Re: [Mesa-dev] [PATCH 2/2] spirv: handle undefined components for OpVectorShuffle

2017-01-30 Thread Jason Ekstrand
On Jan 30, 2017 4:15 AM, "Lionel Landwerlin" wrote: On 27/01/17 09:57, Juan A. Suarez Romero wrote: > On Fri, 2017-01-27 at 09:46 +, Lionel Landwerlin wrote: > >> But what the test does is calling OpSpecConstantOp[2], which is the >>> operation we are patching

Re: [Mesa-dev] [PATCH 2/2] spirv: handle undefined components for OpVectorShuffle

2017-01-30 Thread Lionel Landwerlin
On 27/01/17 09:57, Juan A. Suarez Romero wrote: On Fri, 2017-01-27 at 09:46 +, Lionel Landwerlin wrote: But what the test does is calling OpSpecConstantOp[2], which is the operation we are patching here. And according to the spec, "all Operands must be the s of other constant

Re: [Mesa-dev] [PATCH 2/2] spirv: handle undefined components for OpVectorShuffle

2017-01-27 Thread Juan A. Suarez Romero
On Fri, 2017-01-27 at 09:46 +, Lionel Landwerlin wrote: > > But what the test does is calling OpSpecConstantOp[2], which is the > > operation we are patching here. > > > > And according to the spec, "all Operands must be the s of other > > constant instructions", being constant instructions

Re: [Mesa-dev] [PATCH 2/2] spirv: handle undefined components for OpVectorShuffle

2017-01-27 Thread Lionel Landwerlin
On 27/01/17 08:44, Juan A. Suarez Romero wrote: On Thu, 2017-01-26 at 17:08 +, Lionel Landwerlin wrote: Fixes: dEQP-VK.spirv_assembly.instruction.compute.opspecconstantop.vector_related dEQP-VK.spirv_assembly.instruction.graphics.opspecconstantop.vector_related* Signed-off-by:

Re: [Mesa-dev] [PATCH 2/2] spirv: handle undefined components for OpVectorShuffle

2017-01-27 Thread Juan A. Suarez Romero
On Thu, 2017-01-26 at 17:08 +, Lionel Landwerlin wrote: > Fixes: >dEQP-VK.spirv_assembly.instruction.compute.opspecconstantop.vector_related > > dEQP-VK.spirv_assembly.instruction.graphics.opspecconstantop.vector_related* > > Signed-off-by: Lionel Landwerlin

Re: [Mesa-dev] [PATCH 2/2] spirv: handle undefined components for OpVectorShuffle

2017-01-26 Thread Jason Ekstrand
On Thu, Jan 26, 2017 at 9:08 AM, Lionel Landwerlin < lionel.g.landwer...@intel.com> wrote: > Fixes: >dEQP-VK.spirv_assembly.instruction.compute.opspecconstantop.vector_ > related >dEQP-VK.spirv_assembly.instruction.graphics.opspecconstantop.vector_ > related* > > Signed-off-by: Lionel

[Mesa-dev] [PATCH 2/2] spirv: handle undefined components for OpVectorShuffle

2017-01-26 Thread Lionel Landwerlin
Fixes: dEQP-VK.spirv_assembly.instruction.compute.opspecconstantop.vector_related dEQP-VK.spirv_assembly.instruction.graphics.opspecconstantop.vector_related* Signed-off-by: Lionel Landwerlin --- src/compiler/spirv/spirv_to_nir.c | 52