Re: [Mesa-dev] [PATCH 5/6] glsl/linker: simplify xfb_offset vs xfb_stride overflow check

2019-02-04 Thread Ilia Mirkin
On Mon, Feb 4, 2019 at 7:43 AM Andres Gomez wrote: > > On Fri, 2019-02-01 at 13:17 -0500, Ilia Mirkin wrote: > > On Fri, Feb 1, 2019 at 1:08 PM Andres Gomez wrote: > > > Current implementation uses a complicated calculation which relies in > > > an implicit conversion to check the integral part

Re: [Mesa-dev] [PATCH 5/6] glsl/linker: simplify xfb_offset vs xfb_stride overflow check

2019-02-04 Thread Andres Gomez
On Fri, 2019-02-01 at 13:17 -0500, Ilia Mirkin wrote: > On Fri, Feb 1, 2019 at 1:08 PM Andres Gomez wrote: > > Current implementation uses a complicated calculation which relies in > > an implicit conversion to check the integral part of 2 division > > results. > > > > However, the calculation

Re: [Mesa-dev] [PATCH 5/6] glsl/linker: simplify xfb_offset vs xfb_stride overflow check

2019-02-02 Thread Timothy Arceri
On 3/2/19 7:21 am, Andres Gomez wrote: On Sat, 2019-02-02 at 10:10 +1100, Timothy Arceri wrote: On 2/2/19 5:05 am, Andres Gomez wrote: Current implementation uses a complicated calculation which relies in an implicit conversion to check the integral part of 2 division results. However, the

Re: [Mesa-dev] [PATCH 5/6] glsl/linker: simplify xfb_offset vs xfb_stride overflow check

2019-02-02 Thread Andres Gomez
On Sat, 2019-02-02 at 10:10 +1100, Timothy Arceri wrote: > On 2/2/19 5:05 am, Andres Gomez wrote: > > Current implementation uses a complicated calculation which relies in > > an implicit conversion to check the integral part of 2 division > > results. > > > > However, the calculation actually

Re: [Mesa-dev] [PATCH 5/6] glsl/linker: simplify xfb_offset vs xfb_stride overflow check

2019-02-01 Thread Timothy Arceri
On 2/2/19 5:05 am, Andres Gomez wrote: Current implementation uses a complicated calculation which relies in an implicit conversion to check the integral part of 2 division results. However, the calculation actually checks that the xfb_offset is smaller or a multiplier of the xfb_stride. For

Re: [Mesa-dev] [PATCH 5/6] glsl/linker: simplify xfb_offset vs xfb_stride overflow check

2019-02-01 Thread Ilia Mirkin
On Fri, Feb 1, 2019 at 1:08 PM Andres Gomez wrote: > > Current implementation uses a complicated calculation which relies in > an implicit conversion to check the integral part of 2 division > results. > > However, the calculation actually checks that the xfb_offset is > smaller or a multiplier

[Mesa-dev] [PATCH 5/6] glsl/linker: simplify xfb_offset vs xfb_stride overflow check

2019-02-01 Thread Andres Gomez
Current implementation uses a complicated calculation which relies in an implicit conversion to check the integral part of 2 division results. However, the calculation actually checks that the xfb_offset is smaller or a multiplier of the xfb_stride. For example, while this is expected to fail, it