Re: [Mesa-dev] [PATCH 1/2] softpipe: enable PIPE_QUERY_SO_OVERFLOW_ANY_PREDICATE

2017-08-15 Thread Ilia Mirkin
On Tue, Aug 15, 2017 at 11:27 AM, wrote: > From: Roland Scheidegger > > The driver was supposed to support this since way before the GL spec for it > existed, albeit it was apparently broken, so fix and enable it. > --- > docs/features.txt

[Mesa-dev] [PATCH 2/2] llvmpipe: enable PIPE_CAP_QUERY_SO_OVERFLOW

2017-08-15 Thread sroland
From: Roland Scheidegger The driver supported this since way before the GL spec for it existed. Just need to support both the per-stream and for all streams variants (which are identical due to only supporting 1 stream). Passes piglit

[Mesa-dev] [PATCH 1/2] softpipe: enable PIPE_CAP_QUERY_SO_OVERFLOW

2017-08-15 Thread sroland
From: Roland Scheidegger The driver was supposed to support this since way before the GL spec for it existed, albeit it was apparently broken, so fix and enable it. --- docs/features.txt| 2 +- src/gallium/drivers/softpipe/sp_query.c | 7 ++-

[Mesa-dev] [PATCH] glsl/ast: update rhs in addition to the var's constant_value

2017-08-15 Thread Ilia Mirkin
We continue in the code to do some more things with the rhs, including setting a constant initializer. If the type is wrong, this causes some confusion down the line, leading to assertions. This makes sure that the rhs processing continues to flow as-if the type was correct to start with (even

[Mesa-dev] [PATCH 2/2] radv: Implement bc optimize.

2017-08-15 Thread Bas Nieuwenhuizen
Seems like we actually enabled it already, but did not implement the shader part. With this patch we do. --- src/amd/common/ac_nir_to_llvm.c | 30 ++ src/amd/common/ac_nir_to_llvm.h | 1 + src/amd/vulkan/radv_pipeline.c | 3 +++ 3 files changed, 34 insertions(+)

Re: [Mesa-dev] [PATCH] mesa: framebuffer refcounting with atomic ops

2017-08-15 Thread Marek Olšák
I take back my Rb. If *ptr == fb, it will crash. Also, it's safer to first increment the fb counter and then decrement the *ptr counter. Basically, copy what pipe_reference_described does. Marek On Tue, Aug 15, 2017 at 3:04 PM, Marek Olšák wrote: > Reviewed-by: Marek Olšák

Re: [Mesa-dev] [PATCH 1/2] softpipe: enable PIPE_QUERY_SO_OVERFLOW_ANY_PREDICATE

2017-08-15 Thread Roland Scheidegger
Am 15.08.2017 um 17:32 schrieb Ilia Mirkin: > On Tue, Aug 15, 2017 at 11:27 AM, wrote: >> From: Roland Scheidegger >> >> The driver was supposed to support this since way before the GL spec for it >> existed, albeit it was apparently broken, so fix and

Re: [Mesa-dev] [PATCH] i965: make sure check_and_emit_atom gets inlined

2017-08-15 Thread Scott D Phillips
Tapani Pälli writes: > Improves performance of 3DMark "Ice Storm Unlimited" benchmark > by 1-2% on Apollolake (on Android-IA using clang 3.8.256229). > > Change is based on the performance profiling work and results > by Aravindan Muthukumar and Yogesh Marathe. > >

[Mesa-dev] [PATCH 2/9] loader_dri3/glx/egl: Optionally use a blit context for blitting operations

2017-08-15 Thread Thomas Hellstrom
The code was relying on us always having a current context for client local image blit operations. Otherwise the blit would be skipped. However, glxSwapBuffers, for example, doesn't require a current context and that was a common problem in the dri1 era. It seems the problem has resurfaced with

Re: [Mesa-dev] [PATCH v2 1/1] clover: Wait for requested operation if blocking flag is set

2017-08-15 Thread Francisco Jerez
Jan Vesely writes: > On Sat, 2017-08-12 at 20:14 -0700, Francisco Jerez wrote: >> Jan Vesely writes: >> >> > On Sat, 2017-08-05 at 12:34 -0700, Francisco Jerez wrote: >> > > Francisco Jerez writes: >> > > >> > > > Jan

[Mesa-dev] [Bug 102237] Request for a new account

2017-08-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102237 Boyuan Zhang changed: What|Removed |Added Attachment #133531|0 |1 is

[Mesa-dev] [PATCH 09/20] st/va: add picture parameter handling for mjpeg

2017-08-15 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/state_trackers/va/picture_mjpeg.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/picture_mjpeg.c b/src/gallium/state_trackers/va/picture_mjpeg.c index

[Mesa-dev] [PATCH 17/20] radeon/uvd: add yuyv format support for target buffer

2017-08-15 Thread Leo Liu
YUYV is a packed YUV format, and there is no chorma plane Signed-off-by: Leo Liu --- src/gallium/drivers/radeon/radeon_uvd.c | 8 ++-- src/gallium/drivers/radeonsi/si_uvd.c | 2 +- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git

[Mesa-dev] [PATCH 19/20] st/va: relocate surface with yuyv stream

2017-08-15 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/state_trackers/va/picture.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/src/gallium/state_trackers/va/picture.c b/src/gallium/state_trackers/va/picture.c index a13c1ecbb2..50f280ab58 100644 ---

[Mesa-dev] [PATCH 20/20] st/va: add mjpeg for config

2017-08-15 Thread Leo Liu
To enable mjpeg hw decode Signed-off-by: Leo Liu --- src/gallium/state_trackers/va/config.c | 2 +- src/gallium/state_trackers/va/va_private.h | 4 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/config.c

[Mesa-dev] [PATCH 16/20] st/va: relocate surface when stack field false

2017-08-15 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/state_trackers/va/picture.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/gallium/state_trackers/va/picture.c b/src/gallium/state_trackers/va/picture.c index 59594829dd..3af387ea5b 100644 ---

[Mesa-dev] [PATCH 18/20] st/va: detect mjpeg format from bitstream

2017-08-15 Thread Leo Liu
To find if the format is supported yuyv by sampling factor which is embedded from bitstream. So we could use this info for buffer relocation on the correct format. Signed-off-by: Leo Liu --- src/gallium/state_trackers/va/picture.c | 1 +

[Mesa-dev] [PATCH 03/20] radeon/video: add mjpeg support

2017-08-15 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/auxiliary/util/u_video.h | 3 +++ src/gallium/drivers/radeon/radeon_video.c | 2 ++ 2 files changed, 5 insertions(+) diff --git a/src/gallium/auxiliary/util/u_video.h b/src/gallium/auxiliary/util/u_video.h index

[Mesa-dev] [PATCH 00/20] MJPEG decode support through VA-API

2017-08-15 Thread Leo Liu
The series is able to enable mjpeg decode support through vaapi, and that includes for the formats of 420(NV12) and 422(YUYV). Leo Liu (20): vl: add mjpeg profile and format vl: add mjpeg picture description radeon/video: add mjpeg support radeon/uvd: add mjpeg stream type radeon/uvd:

[Mesa-dev] [PATCH 13/20] radeon/uvd: reconstruct mjpeg bitstream

2017-08-15 Thread Leo Liu
The current tier 1 mjpeg firmware only supports at the bitstream level, the later tier 2 support will be at the buffers level with newer hardware. Signed-off-by: Leo Liu --- src/gallium/drivers/radeon/radeon_uvd.c | 136 1 file changed, 136

[Mesa-dev] [PATCH 12/20] st/va: add slice parameter handling for mjpeg

2017-08-15 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/state_trackers/va/picture_mjpeg.c | 24 +++- 1 file changed, 23 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/picture_mjpeg.c b/src/gallium/state_trackers/va/picture_mjpeg.c index

[Mesa-dev] [PATCH 10/20] st/va: add iq matrix handling for mjpeg

2017-08-15 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/state_trackers/va/picture_mjpeg.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/va/picture_mjpeg.c b/src/gallium/state_trackers/va/picture_mjpeg.c index 50f339eebf..09b2efc21b 100644

Re: [Mesa-dev] [PATCH] radv/gfx9: for fast clear use is_linear flag.

2017-08-15 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen On Tue, Aug 15, 2017, at 21:55, Dave Airlie wrote: > From: Dave Airlie > > The legacy test won't work on gfx9. > > Signed-off-by: Dave Airlie > --- > src/amd/vulkan/radv_meta_clear.c | 2 +- > 1

[Mesa-dev] [Bug 102237] Request for a new account

2017-08-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102237 --- Comment #3 from Alex Deucher --- Approved. Boyuan has been doing a lot of the Mesa multimedia development work for our team for a while now. -- You are receiving this mail because: You are the QA Contact for the

[Mesa-dev] [PATCH 4/9] loader_dri3: Honor the request to preserve back buffer content

2017-08-15 Thread Thomas Hellstrom
EGL uses the force_copy parameter to loader_dri3_swap_buffers_msc() to indicate that it wants to preserve back buffer contents across a buffer swap. While the loader then turns off server-side page-flipping there's nothing to guarantee that a new backbuffer isn't chosen when EGL starts to render

[Mesa-dev] [PATCH 7/9] loader_dri3: Eliminate the back-to-fake-front copy

2017-08-15 Thread Thomas Hellstrom
Eliminate the back-to-fake-front copy by exchanging the previous back buffer and the fake front buffer. This is a gain except when we need to preserve the back buffer content but in that case we still typically gain by replacing a server-side blit by a client side non-flushing blit.

[Mesa-dev] [PATCH 9/9] loader_dri3: Make sure we have an updated back v2

2017-08-15 Thread Thomas Hellstrom
With GLX_SWAP_COPY_OML and GLX_SWAP_EXCHANGE_OML it may happen in situations when glXSwapBuffers() is immediately followed by for example another glXSwapBuffers() or glXCopyBuffers() or back buffer age querying, that we haven't yet allocated and initialized a new back buffer because there was no

[Mesa-dev] [PATCH 8/9] loader_dri3: Support GLX_SWAP_EXCHANGE_OML

2017-08-15 Thread Thomas Hellstrom
Add support for the exchange swap method. Since we're now forcing a fake front buffer and we exchange the back and fake front on swaps, we don't need to add much code. Signed-off-by: Thomas Hellstrom Reviewed-by: Michel Dänzer ---

[Mesa-dev] [PATCH 0/9] dri2: Swapbuffer update v3.

2017-08-15 Thread Thomas Hellstrom
Implement back-to-fake-front flips, Fix EGL_BUFFER_PRESERVED path. Implement dri3 support for GLX_SWAP_EXCHANGE_OML and GLX_SWAP_COPY_OML. The back-to-fake-front flips will save a full buffer copy in the case of a fake front being enabled and GLX_SWAP_UNDEFINED_OML. Support for

[Mesa-dev] [PATCH 3/9] loader_dri3: Increase the likelyhood of reusing the current swap buffer

2017-08-15 Thread Thomas Hellstrom
Signed-off-by: Thomas Hellstrom Reviewed-by: Michel Dänzer --- src/loader/loader_dri3_helper.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/loader/loader_dri3_helper.c b/src/loader/loader_dri3_helper.c index 131c9e9..b3f0482 100644

Re: [Mesa-dev] [PATCH v2 1/5] i965/eu: add support for 1-OWord Block Read/Write messages

2017-08-15 Thread Francisco Jerez
Mark Janes writes: > This series resolves > https://bugs.freedesktop.org/show_bug.cgi?id=101985, currently blocking > 17.2 release. > I have doubts this series is ready for production, though I don't think it makes a ton of sense for Gen7 fp64 vec4 spilling to be

[Mesa-dev] [PATCH 04/20] radeon/uvd: add mjpeg stream type

2017-08-15 Thread Leo Liu
Signed-off-by: Leo Liu --- src/gallium/drivers/radeon/radeon_uvd.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeon/radeon_uvd.h b/src/gallium/drivers/radeon/radeon_uvd.h index 0c3797e22c..a927c843da 100644 ---

[Mesa-dev] nouveau hardware decoding and vaDeriveImage

2017-08-15 Thread Philipp Kerling
Hi, I recently noticed that hardware video decoding with the nouveau driver and libva does not play nicely with Wayland and decided to dig a bit. To use libva in conjunction with Wayland in EGL applications, you usually export the surface dmabuf via vaDeriveImage & vaAcquireBufferHandle and then

[Mesa-dev] [PATCH 1/2] nv50/ir: fix srcMask computation for TG4 and TXF

2017-08-15 Thread Ilia Mirkin
This affects which inputs are marked as used. In a situation where only the texture instruction uses an input, it might have been ignored as unused due to input masks. Affects subtests of KHR-GL45.texture_cube_map_array.sampling Signed-off-by: Ilia Mirkin Cc:

[Mesa-dev] [Bug 101766] Assertion `!"invalid type"' failed when constant expression involves literal of different type

2017-08-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=101766 Ilia Mirkin changed: What|Removed |Added Status|NEW |RESOLVED

Re: [Mesa-dev] [PATCH 06/11] loader_dri3: Honour the request to preserve back buffer content

2017-08-15 Thread Michel Dänzer
On 15/08/17 09:45 PM, Thomas Hellstrom wrote: > On 08/15/2017 09:33 AM, Michel Dänzer wrote: >> On 11/08/17 11:14 PM, Thomas Hellstrom wrote: >>> EGL uses the force_copy parameter to loader_dri3_swap_buffers_msc() >>> to indicate >>> that it wants to preserve back buffer contents across a buffer

Re: [Mesa-dev] [PATCH 0/9] dri2: Swapbuffer update v3.

2017-08-15 Thread Michel Dänzer
On 16/08/17 03:31 AM, Thomas Hellstrom wrote: > Implement back-to-fake-front flips, > Fix EGL_BUFFER_PRESERVED path. > Implement dri3 support for GLX_SWAP_EXCHANGE_OML and GLX_SWAP_COPY_OML. > > The back-to-fake-front flips will save a full buffer copy in the case of a > fake front being enabled

Re: [Mesa-dev] [PATCH] configure: Check llvm-config --shared-mode

2017-08-15 Thread Michel Dänzer
On 15/08/17 11:04 PM, Aaron Watry wrote: > On Mon, Aug 14, 2017 at 10:11 PM, Michel Dänzer wrote: >> On 15/08/17 12:00 PM, Aaron Watry wrote: >>> On Mon, Aug 14, 2017 at 7:54 PM, Michel Dänzer wrote: From: Michel Dänzer

Re: [Mesa-dev] nouveau hardware decoding and vaDeriveImage

2017-08-15 Thread Ilia Mirkin
[adding Julien, who did the nouveau va-api integration.] On Tue, Aug 15, 2017 at 9:59 AM, Philipp Kerling wrote: > Hi, > > I recently noticed that hardware video decoding with the nouveau driver > and libva does not play nicely with Wayland and decided to dig a bit. > > To

Re: [Mesa-dev] [PATCH] configure: Check llvm-config --shared-mode

2017-08-15 Thread Aaron Watry
On Tue, Aug 15, 2017 at 7:30 PM, Michel Dänzer wrote: > On 15/08/17 11:04 PM, Aaron Watry wrote: >> On Mon, Aug 14, 2017 at 10:11 PM, Michel Dänzer wrote: >>> On 15/08/17 12:00 PM, Aaron Watry wrote: On Mon, Aug 14, 2017 at 7:54 PM, Michel Dänzer

[Mesa-dev] [PATCH] radeonsi/gfx9: add a temporary workaround for a tessellation driver bug

2017-08-15 Thread Marek Olšák
From: Marek Olšák The workaround will do for now. The root cause is still unknown. This fixes new piglit: 16in-1out Cc: 17.1 17.2 --- src/gallium/drivers/radeonsi/si_state_draw.c | 6 +- 1 file changed, 5 insertions(+), 1

Re: [Mesa-dev] [PATCH] mesa: framebuffer refcounting with atomic ops

2017-08-15 Thread Tapani Pälli
On 08/15/2017 05:14 PM, Timothy Arceri wrote: We seem to revisit this every few months. Please search your email for all the details but the short answer is this makes some race conditions worse. You will need to address and follow the previous suggestions to be able to improve locking here.

Re: [Mesa-dev] [PATCH] mesa: framebuffer refcounting with atomic ops

2017-08-15 Thread Timothy Arceri
On 16/08/17 00:23, Tapani Pälli wrote: On 08/15/2017 05:14 PM, Timothy Arceri wrote: We seem to revisit this every few months. Please search your email for all the details but the short answer is this makes some race conditions worse. You will need to address and follow the previous

Re: [Mesa-dev] [PATCH] radeonsi: disable CE by default

2017-08-15 Thread Dieter Nützel
Hello Marek, FWIW: Tested-by: Dieter... ;-) I saw, you've committed it all the way. But some numbers for RX580 for you. Not only 'very small' amount, here. Xeon X3470, ~3 GHz, 4/8 Cores, 24 GB with R600_DEBUG=ce glmark2 (final result) goes _down_ by ~5,6% single tests in the range of 2 - 8%

Re: [Mesa-dev] Mesa (master): mesa: correctly calculate the storage offset for i915

2017-08-15 Thread Michel Dänzer
On 15/08/17 07:22 AM, Timothy Arceri wrote: > Module: Mesa > Branch: master > Commit: 365d34540f331df57780dddf8da87235be0a6bcb > URL: > http://cgit.freedesktop.org/mesa/mesa/commit/?id=365d34540f331df57780dddf8da87235be0a6bcb > > Author: Timothy Arceri > Date: Tue

Re: [Mesa-dev] [PATCH 06/11] loader_dri3: Honour the request to preserve back buffer content

2017-08-15 Thread Michel Dänzer
On 11/08/17 11:14 PM, Thomas Hellstrom wrote: > EGL uses the force_copy parameter to loader_dri3_swap_buffers_msc() to > indicate > that it wants to preserve back buffer contents across a buffer swap. > > While the loader then turns off server-side page-flipping there's nothing to > guarantee

Re: [Mesa-dev] [PATCH 5/5] radv/gfx9: fix tile swizzle handling for gfx9

2017-08-15 Thread Bas Nieuwenhuizen
Reviewed-by: Bas Nieuwenhuizen for the series. On Tue, Aug 15, 2017, at 07:26, Dave Airlie wrote: > From: David Airlie > > This sets the tile swizzle up properly for gfx9. > > Signed-off-by: Dave Airlie > ---

[Mesa-dev] [PATCH] i965: make sure check_and_emit_atom gets inlined

2017-08-15 Thread Tapani Pälli
Improves performance of 3DMark "Ice Storm Unlimited" benchmark by 1-2% on Apollolake (on Android-IA using clang 3.8.256229). Change is based on the performance profiling work and results by Aravindan Muthukumar and Yogesh Marathe. Signed-off-by: Tapani Pälli ---

Re: [Mesa-dev] [PATCH 02/11] loader/dri3: Make sure we always have a context for image blit operations

2017-08-15 Thread Michel Dänzer
On 11/08/17 11:14 PM, Thomas Hellstrom wrote: > The code was relying on us always having a current context for client local > image blit operations. Otherwise the blit would be skipped. However, > glxSwapBuffers, for example, doesn't require a current context and that was a > common problem in the

Re: [Mesa-dev] Mesa (master): mesa: correctly calculate the storage offset for i915

2017-08-15 Thread Timothy Arceri
On 15/08/17 17:04, Michel Dänzer wrote: On 15/08/17 07:22 AM, Timothy Arceri wrote: Module: Mesa Branch: master Commit: 365d34540f331df57780dddf8da87235be0a6bcb URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=365d34540f331df57780dddf8da87235be0a6bcb Author: Timothy Arceri

Re: [Mesa-dev] [PATCH v2 1/4] st/omx_bellagio: Rename state tracker and option

2017-08-15 Thread Julien Isorce
No objection from me. Please just re-double check it builds properly. Thx! On 14 August 2017 at 09:10, Christian König wrote: > Am 12.08.2017 um 18:07 schrieb Gurkirpal Singh: > >> Changes --enable-omx option to --enable-omx-bellagio >> >> Signed-off-by: Gurkirpal Singh

[Mesa-dev] [PATCH] mesa: framebuffer refcounting with atomic ops

2017-08-15 Thread Tapani Pälli
Signed-off-by: Tapani Pälli --- src/mesa/main/framebuffer.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-) Use atomic ops in same manner as for shader objects, IMO makes code easier to read. diff --git a/src/mesa/main/framebuffer.c

Re: [Mesa-dev] [PATCH] egl: don't NULL deref the .get_capabilities function pointer

2017-08-15 Thread Tapani Pälli
seems rare scenario indeed but there's similar check for image extension caps; Reviewed-by: Tapani Pälli On 08/07/2017 07:23 PM, Emil Velikov wrote: From: Emil Velikov One could easily introduce version 3 of the DRI2fenceExtension,

Re: [Mesa-dev] How to write using EGLImage?

2017-08-15 Thread Julien Isorce
Hi Christian, Thx for the suggestion. Actually I thought about dmabuf (ref project proposal), but not about opening the EGL so using an internal mesa function. Also eglExportDMABUFImageMESA is still tagged 'MESA' (EGL_MESA_image_dma_buf_export). Compared to EGL_*EXT*_image_dma_buf_import . This

[Mesa-dev] [Bug 102232] gallium/svga_msg.c build failure on non-x86 with gcc 7.1

2017-08-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102232 Bug ID: 102232 Summary: gallium/svga_msg.c build failure on non-x86 with gcc 7.1 Product: Mesa Version: 17.2 Hardware: Other OS: All Status:

[Mesa-dev] [PATCH] a2xx: only update rasterizer settings when they're there

2017-08-15 Thread Ilia Mirkin
The rasterizer being empty can happen e.g. during clears Signed-off-by: Ilia Mirkin --- src/gallium/drivers/freedreno/a2xx/fd2_emit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/freedreno/a2xx/fd2_emit.c

[Mesa-dev] [Bug 102232] gallium/svga_msg.c build failure on non-x86 with gcc 7.1

2017-08-15 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=102232 Timo Aaltonen changed: What|Removed |Added Resolution|--- |INVALID

Re: [Mesa-dev] [PATCH 06/11] loader_dri3: Honour the request to preserve back buffer content

2017-08-15 Thread Thomas Hellstrom
On 08/15/2017 09:33 AM, Michel Dänzer wrote: On 11/08/17 11:14 PM, Thomas Hellstrom wrote: EGL uses the force_copy parameter to loader_dri3_swap_buffers_msc() to indicate that it wants to preserve back buffer contents across a buffer swap. While the loader then turns off server-side

Re: [Mesa-dev] [PATCH 02/11] loader/dri3: Make sure we always have a context for image blit operations

2017-08-15 Thread Thomas Hellstrom
Hi, Michel, Thanks for reviewing. On 08/15/2017 08:57 AM, Michel Dänzer wrote: On 11/08/17 11:14 PM, Thomas Hellstrom wrote: The code was relying on us always having a current context for client local image blit operations. Otherwise the blit would be skipped. However, glxSwapBuffers, for

Re: [Mesa-dev] [PATCH] mesa: framebuffer refcounting with atomic ops

2017-08-15 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Aug 15, 2017 at 2:03 PM, Tapani Pälli wrote: > Signed-off-by: Tapani Pälli > --- > src/mesa/main/framebuffer.c | 19 +-- > 1 file changed, 5 insertions(+), 14

Re: [Mesa-dev] [PATCH] mesa: count uniform against storage when its bindless

2017-08-15 Thread Timothy Arceri
On 15/08/17 23:07, Marek Olšák wrote: Reviewed-by: Marek Olšák Marek Pushed, Thanks. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] mesa: framebuffer refcounting with atomic ops

2017-08-15 Thread Timothy Arceri
We seem to revisit this every few months. Please search your email for all the details but the short answer is this makes some race conditions worse. You will need to address and follow the previous suggestions to be able to improve locking here. On 15/08/17 23:04, Marek Olšák wrote:

Re: [Mesa-dev] [PATCH 11/11] loader_dri3: Make sure we have an updated back

2017-08-15 Thread Thomas Hellstrom
On 08/15/2017 09:32 AM, Michel Dänzer wrote: On 11/08/17 11:14 PM, Thomas Hellstrom wrote: With GLX_SWAP_COPY_OML and GLX_SWAP_EXCHANGE_OML it may happen in situations when glXSwapBuffers() is immediately followed by for example another glXSwapBuffers() or glXCopyBuffers() or back buffer age

Re: [Mesa-dev] [PATCH] mesa: count uniform against storage when its bindless

2017-08-15 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Aug 15, 2017 at 12:42 PM, Timothy Arceri wrote: > Gallium drivers use this code path so we need to account for > bindless after all. > > Fixes: 365d34540f33 ("mesa: correctly calculate the storage offset for