Re: [Mutopia-discuss] reviewing pull requests in github

2014-12-05 Thread Federico Bruni
Il giorno ven 5 dic 2014 alle 18:36, Federico Bruni f...@inventati.org ha scritto: Perhaps it's better using 'git format-patch' in case the contributor approves it and what to apply to his branch? I don't know if the patch generated with the command above can be applied with 'git am'. sorry,

Re: [Mutopia-discuss] reviewing pull requests in github

2014-12-04 Thread Glen Larsen
Ah, so right. My apologies for not doing deeper research. I'll take a more complete look later today. On Thu, Dec 4, 2014 at 3:12 AM, Federico Bruni f...@inventati.org wrote: Il giorno gio 4 dic 2014 alle 8:00, Glen Larsen glenl@gmail.com ha scritto: These instructions are modifying an

Re: [Mutopia-discuss] reviewing pull requests in github

2014-12-03 Thread Federico Bruni
Il giorno mer 3 dic 2014 alle 4:24, Javier Ruiz-Alma jav...@ruiz-alma.com ha scritto: Having a link to this guide would've made things easier for the few times I've copy/pasted code to compile some else's pull-requests. This doesn't happen often, though, so maybe you can create a new wiki

Re: [Mutopia-discuss] reviewing pull requests in github

2014-12-03 Thread Federico Bruni
Il giorno mer 3 dic 2014 alle 10:23, Federico Bruni f...@inventati.org ha scritto: I don't think it's possible to submit changes to someone else's open pull request. You can upload the .patch file of your changes in the comments of the pull request, if you want the author of the PR to see your

[Mutopia-discuss] reviewing pull requests in github

2014-12-02 Thread Federico Bruni
Hi all I'm reading this guide: https://help.github.com/articles/checking-out-pull-requests-locally/ I see that I can easily checkout the branch submitted through a pull request with this command: git fetch origin pull/ID/head:BRANCHNAME git checkout BRANCHNAME Now, if the author of the pull

Re: [Mutopia-discuss] reviewing pull requests in github

2014-12-02 Thread Javier Ruiz-Alma
Hi Federico, Having a link to this guide would've made things easier for the few times I've copy/pasted code to compile some else's pull-requests.  This doesn't happen often, though, so maybe you can create a new wiki page for advanced topics.Is it possible to also submit changes to someone