Re: 'embedded people' and the 'embedded world' (was: Re: [RFC patch] driver for the Opencores Ethernet Controller)

2006-12-08 Thread Robert Schwebel
Lennert, On Tue, Dec 05, 2006 at 01:29:36AM +0100, Lennert Buytenhek wrote: BTW (and this is not specifically directed to you.) One cannot say this loud enough. Acked-By: Robert Schwebel [EMAIL PROTECTED] Robert -- Dipl.-Ing. Robert Schwebel | http://www.pengutronix.de Pengutronix - Linux

Re: [RFC patch] driver for the Opencores Ethernet Controller

2006-12-05 Thread Dan Nicolaescu
Stephen Hemminger [EMAIL PROTECTED] writes: Indentation. See Documentation style. What about IRQF_SHARED? Not sure, maybe I should make this another driver parameter. On my platform is not shared... The trouble with devices, is that some poor sop clones the

Re: [RFC patch] driver for the Opencores Ethernet Controller

2006-12-05 Thread Dan Nicolaescu
Lennert Buytenhek [EMAIL PROTECTED] writes: On Mon, Dec 04, 2006 at 10:27:52AM -0800, Dan Nicolaescu wrote: The Opencores Ethernet Controller is Verilog code that can be used to implement an Ethernet device in hardware. It needs to be coupled with a PHY and some buffer

[RFC patch] driver for the Opencores Ethernet Controller

2006-12-04 Thread Dan Nicolaescu
Hi, Here is a driver for the Opencores Ethernet Controller. I started from a 2.4 uClinux driver, ported it to 2.6, made it work, cleaned it up and added the MII interface. The Opencores Ethernet Controller is Verilog code that can be used to implement an Ethernet device in hardware. It needs

Re: [RFC patch] driver for the Opencores Ethernet Controller

2006-12-04 Thread Lennert Buytenhek
On Mon, Dec 04, 2006 at 10:01:01AM -0800, Dan Nicolaescu wrote: The Opencores Ethernet Controller is Verilog code that can be used to implement an Ethernet device in hardware. It needs to be coupled with a PHY and some buffer memory. Because of that devices that implement this controller can

Re: [RFC patch] driver for the Opencores Ethernet Controller

2006-12-04 Thread Dan Nicolaescu
Lennert Buytenhek [EMAIL PROTECTED] writes: On Mon, Dec 04, 2006 at 10:01:01AM -0800, Dan Nicolaescu wrote: The Opencores Ethernet Controller is Verilog code that can be used to implement an Ethernet device in hardware. It needs to be coupled with a PHY and some buffer memory.

Re: [RFC patch] driver for the Opencores Ethernet Controller

2006-12-04 Thread Stephen Hemminger
On Mon, 04 Dec 2006 10:01:01 -0800 Dan Nicolaescu [EMAIL PROTECTED] wrote: Hi, Here is a driver for the Opencores Ethernet Controller. I started from a 2.4 uClinux driver, ported it to 2.6, made it work, cleaned it up and added the MII interface. The Opencores Ethernet Controller is

Re: [RFC patch] driver for the Opencores Ethernet Controller

2006-12-04 Thread Dan Nicolaescu
Stephen Hemminger [EMAIL PROTECTED] writes: On Mon, 04 Dec 2006 10:01:01 -0800 Dan Nicolaescu [EMAIL PROTECTED] wrote: Hi, Here is a driver for the Opencores Ethernet Controller. I started from a 2.4 uClinux driver, ported it to 2.6, made it work, cleaned it up

Re: [RFC patch] driver for the Opencores Ethernet Controller

2006-12-04 Thread Stephen Hemminger
Indentation. See Documentation style. What about IRQF_SHARED? Not sure, maybe I should make this another driver parameter. On my platform is not shared... The trouble with devices, is that some poor sop clones the hardware to another board and your assumption is no longer valid.

Re: [RFC patch] driver for the Opencores Ethernet Controller

2006-12-04 Thread Lennert Buytenhek
On Mon, Dec 04, 2006 at 10:27:52AM -0800, Dan Nicolaescu wrote: The Opencores Ethernet Controller is Verilog code that can be used to implement an Ethernet device in hardware. It needs to be coupled with a PHY and some buffer memory. Because of that devices that implement this

'embedded people' and the 'embedded world' (was: Re: [RFC patch] driver for the Opencores Ethernet Controller)

2006-12-04 Thread Lennert Buytenhek
On Mon, Dec 04, 2006 at 10:27:52AM -0800, Dan Nicolaescu wrote: I didn't know about platform drivers before your mail. I guess I could convert it to that if that is the right thing to do. (It might be an overkill given that the device is kind of simple and embedded people prefer small