Re: Extensible hashing and RCU

2007-03-04 Thread Michael K. Edwards
On 3/3/07, Evgeniy Polyakov [EMAIL PROTECTED] wrote: Btw, you could try to implement something you have written above to show its merits, so that it would not be an empty words :) Before I implement, I design. Before I design, I analyze. Before I analyze, I prototype. Before I prototype, I

Re: [PATCH][BUG][SECURITY] Re: Weird problem with PPPoE on tap interface

2007-03-04 Thread Michal Ostrowski
Sorry for the late reply I've been on the road the past few days. I ACK the patch. I'll need to think about it some more, but we could probably go a step further and eliminate the MAC address from the hash as well. -- Michal Ostrowski [EMAIL PROTECTED] On Sat, 2007-03-03 at 21:08 -0800,

Re: Session ID 0 with PPPoE

2007-03-04 Thread Michal Ostrowski
From the RFC: 5.4 The PPPoE Active Discovery Session-confirmation (PADS) packet When the Access Concentrator receives a PADR packet, it prepares to begin a PPP session. It generates a unique SESSION_ID for the PPPoE session and replies to the Host with a PADS packet. The

Re: Session ID 0 with PPPoE

2007-03-04 Thread Florian Zumbiehl
Hi, From the RFC: 5.4 The PPPoE Active Discovery Session-confirmation (PADS) packet When the Access Concentrator receives a PADR packet, it prepares to begin a PPP session. It generates a unique SESSION_ID for the PPPoE session and replies to the Host with a PADS packet. The

[RFC NET_SCHED 00/03]: ktime + nano-second clock resolution for packet schedulers

2007-03-04 Thread Patrick McHardy
These patches convert the GETTIMEOFDAY packet scheduler clock source to ktime (based on Stephen's patch) and add support for using nano-second clock resolution. I chose a scalar time representation within the packet schedulers instead of ktime_t since it minimizes the ktime_to_ns() calls in most

[RFC TIME 01/03]: Add jiffies_to_nsecs/nsecs_to_jiffies

2007-03-04 Thread Patrick McHardy
[TIME]: Add jiffies_to_nsecs/nsecs_to_jiffies Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit 861b3967e1bb01335e544220df779f91b20a27e7 tree cd877a5091f461008ec708b801a2fa04d3c26004 parent 2ff7354fe888f46f6629b57e463b0a1eb956c02b author Patrick McHardy [EMAIL PROTECTED] Fri, 02 Mar

[RFC NET_SCHED 02/03]: Replace gettimeofday clocksource by ktime

2007-03-04 Thread Patrick McHardy
[NET_SCHED]: Replace gettimeofday clocksource by ktime Using a monotonic clock avoids glitches when NTP adjusts the clock, additionally it will allow us to take advantage of the higher resolution in the future. This patch also gets rid of the non-scalar representation, which allows to clean up a

[RFC NET_SCHED 03/03]: Add support for nano-second clock resolution

2007-03-04 Thread Patrick McHardy
[NET_SCHED]: Add support for nano-second clock resolution Add support to nano-second clock resolution with ktime as clock source. Since the ABI uses clock ticks in some places and all clock sources previously used micro-second resolution, this changes the API. To avoid breakage with old iproute

[RFC IPROUTE 00/08]: Time cleanups + nano-second clock resolution support

2007-03-04 Thread Patrick McHardy
This patchset consists of four parts: - minor TBF time conversion fix - consolidation of time calculations: consolidate commonly used expressions with the goal of making it easier to audit for integer overflows when increasing the internally used clock resolution. - support for detecting

[RFC IPROUTE 01/08]: tbf: fix latency printing

2007-03-04 Thread Patrick McHardy
[IPROUTE]: tbf: fix latency printing The calculated latency is already in usecs, the additional tick2usec conversion breaks the calculation with jiffies or tsc clock source. Example: # tc qdisc add dev dummy0 root tbf latency 20ms burst 10k rate 50mbit # tc qdisc show dev dummy0 qdisc tbf 8002:

[RFC IPROUTE 03/08]: Introduce tc_calc_xmitsize and use where appropriate

2007-03-04 Thread Patrick McHardy
[IPROUTE]: Introduce tc_calc_xmitsize and use where appropriate Add tc_calc_xmitsize() as complement to tc_calc_xmittime(), which calculates the size that can be transmitted at a given rate during a given time. Replace all expressions of the form size = rate*tc_core_tick2usec(time))/100 by

[RFC IPROUTE 04/08]: Introduce TIME_UNITS_PER_SEC to represent internal clock resolution

2007-03-04 Thread Patrick McHardy
[IPROUTE]: Introduce TIME_UNITS_PER_SEC to represent internal clock resolution Introduce TIME_UNITS_PER_SEC and conversion functions between internal resolution and resolution expected by the kernel (currently implemented as NOPs, only needed by HFSC, which currently always uses microseconds).

[RFC IPROUTE 05/08]: Replace usec by time in function names

2007-03-04 Thread Patrick McHardy
[IPROUTE]: Replace usec by time in function names Rename functions containing usec since they don't necessarily return usec units anymore. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit c2cf24282b2a051942b18fbf894a9c1b490d925c tree 128aa960a599aee0725d723b621db651e02ffa74 parent

[RFC IPROUTE 06/08]: Add sprint_ticks() function and use in CBQ

2007-03-04 Thread Patrick McHardy
[IPROUTE]: Add sprint_ticks() function and use in CBQ Add helper function to print ticks to avoid assumptions about clock resolution in CBQ. Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit 5950296ff76ba81593928a2ee89757d69b2acba9 tree aca072937195b2011c9f64a305716ddfc1b40c66 parent

[RFC IPROUTE 08/08]: Increase internal clock resolution to nsec

2007-03-04 Thread Patrick McHardy
[IPROUTE]: Increase internal clock resolution to nsec Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit 8a76c51f61dd3881bba35f8c73aaa92eabaf50da tree d4b252b801a14ee19ed77d4a06daaacd8c17b495 parent 0e0db5d408bdac33eadd9d947c0e6904df26ab8f author Patrick McHardy [EMAIL PROTECTED] Sat,

[RFC IPROUTE 07/08]: Handle different kernel clock resolutions

2007-03-04 Thread Patrick McHardy
[IPROUTE]: Handle different kernel clock resolutions Signed-off-by: Patrick McHardy [EMAIL PROTECTED] --- commit 0e0db5d408bdac33eadd9d947c0e6904df26ab8f tree 950a6f47287bec01e5996bec3f1141b60f3f6f6a parent 5950296ff76ba81593928a2ee89757d69b2acba9 author Patrick McHardy [EMAIL PROTECTED] Sat, 03

Re: Extensible hashing and RCU

2007-03-04 Thread David Miller
From: Michael K. Edwards [EMAIL PROTECTED] Date: Sun, 4 Mar 2007 02:02:36 -0800 On 3/3/07, Evgeniy Polyakov [EMAIL PROTECTED] wrote: Btw, you could try to implement something you have written above to show its merits, so that it would not be an empty words :) Before I implement, I design.

[NET] Fix PCnet32 performance bug on non-coherent architecutres

2007-03-04 Thread Ralf Baechle
The PCnet32 driver always passed the the size of the largest possible packet to the pci_dma_sync_single_for_cpu and pci_dma_sync_single_for_device. This results in a fairly large colateral damage in the caches and makes the flush operation itself much slower. On a system with a 40MHz CPU this

Re: Wifi support for iproute2

2007-03-04 Thread Johannes Berg
On Sun, 2007-03-04 at 02:26 +0100, Stephan Maka wrote: Everyone told me dscape is near, but I hope iwlib will be ported then. Just a few short notes to add to Stephen's reply. dscape (or mac80211 now, it's been renamed) is going to migrate away from wireless extensions, in fact, wext is going

Re: [PATCH][BUG][SECURITY] Re: Weird problem with PPPoE on tap interface

2007-03-04 Thread David Miller
From: Florian Zumbiehl [EMAIL PROTECTED] Date: Sun, 4 Mar 2007 13:09:39 +0100 From: Florian Zumbiehl [EMAIL PROTECTED] Date: Sun, 4 Mar 2007 02:55:16 +0100 Below you find a slightly changed version of the patch I already applied your first patch, so if you have any fixes to

Re: [PATCH] NET : keep sk_backlog near sk_lock

2007-03-04 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Thu, 22 Feb 2007 15:50:15 +0100 sk_backlog is a critical field of struct sock. (known famous words) It is (ab)used in hot paths, in particular in release_sock(), tcp_recvmsg(), tcp_v4_rcv(), sk_receive_skb(). It really makes sense to place it

Re: [PATCH] div64_64 consolidate (rev3)

2007-03-04 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Fri, 2 Mar 2007 17:29:20 -0800 Here is the current version of the 64 bit divide common code. Since it is used by three times by networking code, can we put it net-2.6.22 tree? Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] Applied to

Re: [RFC NET_SCHED 00/03]: ktime + nano-second clock resolution for packet schedulers

2007-03-04 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Sun, 4 Mar 2007 20:05:30 +0100 (MET) These patches convert the GETTIMEOFDAY packet scheduler clock source to ktime (based on Stephen's patch) and add support for using nano-second clock resolution. I chose a scalar time representation within the

Re: Fun splitting reassembled UDP skbuffs

2007-03-04 Thread David Miller
From: David Howells [EMAIL PROTECTED] Date: Sun, 04 Mar 2007 14:53:35 + Is it possible to mix the likes of skb_clone(), pskb_pull() and pskb_trim()? It should work, pskb_pull() and pskb_trim() check for cloning and COW the data area as-needed. I think you just have a refcounting error

Re: [EMAIL PROTECTED]: Mail delivery failed: returning message to sender]

2007-03-04 Thread Michal Ostrowski
In the current code SID 0 indicates that the socket is to be un-bound. Supporting unbinding of the socket was intended to permit the PPPoE session to be reconnected without closing/reopening the socket; which would mean that you'd have to re-bind the PPPoE/PPP channel bindings. Thus it is

Re: Wifi support for iproute2

2007-03-04 Thread Stephan Maka
Stephen Hemminger wrote: Don't waste your time with a tool that uses the exist wext API. But a tool that could use cfg80211 would be useful. After the wireless summit in Jan, I put it on my interesting ideas list. Ok. I would be happy if anyone will notify me when this is available without

[PATCH][UDP]: Fix whitespace cleanup

2007-03-04 Thread Arnaldo Carvalho de Melo
Hi David, Stephen Whitespace cleanups have to pass the compile test too ;-) This is just in net-2.6.22 tho :-) Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] - Arnaldo diff --git a/net/ipv4/udp.c b/net/ipv4/udp.c index 5309dd5..2e9fd1e 100644 --- a/net/ipv4/udp.c +++

Re: [PATCH][UDP]: Fix whitespace cleanup

2007-03-04 Thread Arnaldo Carvalho de Melo
On 3/5/07, Arnaldo Carvalho de Melo [EMAIL PROTECTED] wrote: Hi David, Stephen Whitespace cleanups have to pass the compile test too ;-) This is just in net-2.6.22 tho :-) Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] There is one more problem: - __u16 destp

Re: [PATCH][UDP]: Fix whitespace cleanup

2007-03-04 Thread David Miller
From: Arnaldo Carvalho de Melo [EMAIL PROTECTED] Date: Mon, 5 Mar 2007 00:11:49 -0300 Hi David, Stephen Whitespace cleanups have to pass the compile test too ;-) This is just in net-2.6.22 tho :-) Signed-off-by: Arnaldo Carvalho de Melo [EMAIL PROTECTED] I think I'll just revert

Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-04 Thread Matt Mackall
Recent kernels are having troubles with wireless for me. Two seemingly related problems: a) NetworkManager seems oblivious to the existence of my IPW2200 b) Manual iwconfig waits for 60s and then reports: Error for wireless request Set Encode (8B2A) : SET failed on device eth1 ; Operation

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-04 Thread Johannes Berg
[adding linux-wireless to CC] On Sun, 2007-03-04 at 16:08 -0600, Matt Mackall wrote: Recent kernels are having troubles with wireless for me. Two seemingly related problems: I don't think they are related actually. a) NetworkManager seems oblivious to the existence of my IPW2200 This is due

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-04 Thread Matt Mackall
On Mon, Mar 05, 2007 at 12:39:24AM +0100, Johannes Berg wrote: [adding linux-wireless to CC] On Sun, 2007-03-04 at 16:08 -0600, Matt Mackall wrote: Recent kernels are having troubles with wireless for me. Two seemingly related problems: I don't think they are related actually. a)

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-04 Thread Ian McDonald
On 3/5/07, Matt Mackall [EMAIL PROTECTED] wrote: This is due to the recent sysfs restructuring I think. IIRC the fix is to upgrade hal to a current git version. If that's the cause, the fix is to back out whatever was done to break userspace. Breaking userspace is not ok. Upgrading from 2.6.x

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-04 Thread Andrew Morton
On Sun, 4 Mar 2007 18:25:50 -0600 Matt Mackall [EMAIL PROTECTED] wrote: On Mon, Mar 05, 2007 at 12:39:24AM +0100, Johannes Berg wrote: [adding linux-wireless to CC] On Sun, 2007-03-04 at 16:08 -0600, Matt Mackall wrote: Recent kernels are having troubles with wireless for me. Two

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-04 Thread Adrian Bunk
On Sun, Mar 04, 2007 at 04:45:25PM -0800, Andrew Morton wrote: On Sun, 4 Mar 2007 18:25:50 -0600 Matt Mackall [EMAIL PROTECTED] wrote: On Mon, Mar 05, 2007 at 12:39:24AM +0100, Johannes Berg wrote: [adding linux-wireless to CC] On Sun, 2007-03-04 at 16:08 -0600, Matt Mackall wrote:

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-04 Thread Greg KH
On Sun, Mar 04, 2007 at 04:08:57PM -0600, Matt Mackall wrote: Recent kernels are having troubles with wireless for me. Two seemingly related problems: a) NetworkManager seems oblivious to the existence of my IPW2200 b) Manual iwconfig waits for 60s and then reports: Error for wireless

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-04 Thread Greg KH
On Sun, Mar 04, 2007 at 06:25:50PM -0600, Matt Mackall wrote: On Mon, Mar 05, 2007 at 12:39:24AM +0100, Johannes Berg wrote: [adding linux-wireless to CC] On Sun, 2007-03-04 at 16:08 -0600, Matt Mackall wrote: Recent kernels are having troubles with wireless for me. Two seemingly

[1/6] 2.6.21-rc2: known regressions

2007-03-04 Thread Adrian Bunk
This email lists some known regressions in 2.6.21-rc2 compared to 2.6.20 that are not yet fixed in Linus' tree. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm

[-mm patch] drivers/net/bonding/bond_main.c:make 3 functions static

2007-03-04 Thread Adrian Bunk
This patch makes the following needlessly global functions static: - bond_mode_name() - bond_sethwaddr() - bond_mii_monitor() Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- drivers/net/bonding/bond_main.c |7 --- drivers/net/bonding/bonding.h |3 --- 2 files changed, 4

[2.6 patch] drivers/net/qla3xxx.c: make 2 functions static

2007-03-04 Thread Adrian Bunk
This patch makes two needlessly global functions static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- --- linux-2.6.21-rc2-mm1/drivers/net/qla3xxx.c.old 2007-03-04 21:41:27.0 +0100 +++ linux-2.6.21-rc2-mm1/drivers/net/qla3xxx.c 2007-03-04 21:41:39.0 +0100 @@ -1797,14

[2.6 patch] make drivers/net/s2io.c:vlan_strip_flag static

2007-03-04 Thread Adrian Bunk
This patch makes the needlessly global vlan_strip_flag static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- --- linux-2.6.21-rc2-mm1/drivers/net/s2io.c.old 2007-03-04 21:37:59.0 +0100 +++ linux-2.6.21-rc2-mm1/drivers/net/s2io.c 2007-03-04 21:38:14.0 +0100 @@ -316,7

Re: [1/6] 2.6.21-rc2: known regressions

2007-03-04 Thread Andrew Morton
On Mon, 5 Mar 2007 02:50:31 +0100 Adrian Bunk [EMAIL PROTECTED] wrote: This email lists some known regressions in 2.6.21-rc2 compared to 2.6.20 that are not yet fixed in Linus' tree. We seem to have broken an unusually large amount of stuff this time. partial post-mortem: - The ACPICA merge

Re: [1/6] 2.6.21-rc2: known regressions

2007-03-04 Thread Greg KH
On Mon, Mar 05, 2007 at 02:50:31AM +0100, Adrian Bunk wrote: Subject: kref refcounting breakage References : http://lkml.org/lkml/2007/3/2/67 Submitter : Andrew Morton [EMAIL PROTECTED] Handled-By : Greg KH [EMAIL PROTECTED] Status : unknown I'm working on tracking this down

Re: [1/6] 2.6.21-rc2: known regressions

2007-03-04 Thread Mark Lord
Adrian Bunk wrote: Subject: Bluetooth RFComm locks up the machine (device_move() related) References : http://lkml.org/lkml/2007/3/4/64 Submitter : Mark Lord [EMAIL PROTECTED] Caused-By : Marcel Holtmann [EMAIL PROTECTED] commit c1a3313698895d8ad4760f98642007bf236af2e8

Re: [1/6] 2.6.21-rc2: known regressions

2007-03-04 Thread Greg KH
On Sun, Mar 04, 2007 at 11:01:33PM -0500, Mark Lord wrote: Adrian Bunk wrote: Subject: Bluetooth RFComm locks up the machine (device_move() related) References : http://lkml.org/lkml/2007/3/4/64 Submitter : Mark Lord [EMAIL PROTECTED] Caused-By : Marcel Holtmann [EMAIL PROTECTED]

Re: [PATCH] NET : convert network timestamps to ktime_t

2007-03-04 Thread Eric Dumazet
David Miller a écrit : From: Eric Dumazet [EMAIL PROTECTED] Date: Fri, 02 Mar 2007 23:46:14 +0100 Stephen Hemminger a écrit : You missed a couple of spots. Arg yes... ... - } - skb_get_timestamp(skb, svsk-sk_sk-sk_stamp); + svsk-sk_sk-sk_stamp = (skb-tstamp.tv64 != 0) ?

Re: Extensible hashing and RCU

2007-03-04 Thread Michael K. Edwards
On 3/4/07, David Miller [EMAIL PROTECTED] wrote: From: Michael K. Edwards [EMAIL PROTECTED] Before I implement, I design. Before I design, I analyze. Before I analyze, I prototype. Before I prototype, I gather requirements. How the heck do you ever get to writing ANYTHING if you work that

[PATCH] NET : convert network timestamps to ktime_t

2007-03-04 Thread Eric Dumazet
Hi David Here is the second version of this patch, including missing bits spoted by Stephen. This is against net-2.6.22 Thank you [PATCH] NET : convert network timestamps to ktime_t We currently use a special structure (struct skb_timeval) and plain 'struct timeval' to store packet

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-04 Thread Matt Mackall
On Sun, Mar 04, 2007 at 05:16:25PM -0800, Greg KH wrote: On Sun, Mar 04, 2007 at 04:08:57PM -0600, Matt Mackall wrote: Recent kernels are having troubles with wireless for me. Two seemingly related problems: a) NetworkManager seems oblivious to the existence of my IPW2200 b) Manual

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-04 Thread Greg KH
On Mon, Mar 05, 2007 at 12:42:29AM -0600, Matt Mackall wrote: On Sun, Mar 04, 2007 at 05:16:25PM -0800, Greg KH wrote: On Sun, Mar 04, 2007 at 04:08:57PM -0600, Matt Mackall wrote: Recent kernels are having troubles with wireless for me. Two seemingly related problems: a)

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-04 Thread Matt Mackall
On Sun, Mar 04, 2007 at 11:02:48PM -0800, Greg KH wrote: On Mon, Mar 05, 2007 at 12:42:29AM -0600, Matt Mackall wrote: On Sun, Mar 04, 2007 at 05:16:25PM -0800, Greg KH wrote: On Sun, Mar 04, 2007 at 04:08:57PM -0600, Matt Mackall wrote: Recent kernels are having troubles with wireless