Re: [PATCH] NET : convert network timestamps to ktime_t

2007-03-05 Thread Eric Dumazet
David Miller a écrit : From: Eric Dumazet [EMAIL PROTECTED] Date: Mon, 05 Mar 2007 08:40:03 +0100 Here is the second version of this patch, including missing bits spoted by Stephen. This is against net-2.6.22 Applied, thanks a lot. Note : this patch includes a bug correction in

[PATCH v.2] RTNL and flush_scheduled_work deadlocks

2007-03-05 Thread Jarek Poplawski
On Sun, Feb 18, 2007 at 10:27:19PM -0800, Ben Greear wrote: Jarek Poplawski wrote: On Fri, Feb 16, 2007 at 11:04:02AM -0800, Ben Greear wrote: ... On Thu, 15 Feb 2007 23:40:32 -0800 Ben Greear [EMAIL PROTECTED] wrote: Maybe there should be something like an ASSERT_NOT_RTNL() in the

Re: [PATCH] NET : convert network timestamps to ktime_t

2007-03-05 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Mon, 05 Mar 2007 09:21:30 +0100 I dont know very much this compat stuff, but I found compat_sock_get_timestamp() only called from net/x25/af_x25.c Good point, I thought for some reason that this function was used for all SO_TIMESTAMP handling, but

[PATCH] Ensure IF_READY is unset when link is not ready

2007-03-05 Thread Mitsuru Chinen
Hi there, On linux-2.6.21-rc2 or later, IPv6 link-local address is not assigned to some kind of interfaces during system start-up. (I found this issue occures with e100, e1000 and tg3.) This issue comes from the change that inet6_dev is allocated when NETDEV_REGISTER event occurs. The allocation

linux 2.6 Ipv4 routing enhancement (fwd)

2007-03-05 Thread Richard Kojedzinszky
Dear all, I work for an ISP, and we do not spend money on heavy routers, we use linux to do the routing tasks, even at core level. We use commercial Intel servers to do this job, but when such a router has come to handle ~1GBit/s traffic, and also update the routing table (from BGP), the

Re: Extensible hashing and RCU

2007-03-05 Thread Robert Olsson
Michael K. Edwards writes: This, incidentally, seems very similar to the process that Robert Olsson and Stefan Nilsson have gone through with their trie/hash project. Although I haven't tried it out yet and don't have any basis for an independent opinion, the data and analysis provided

Re: Extensible hashing and RCU

2007-03-05 Thread Evgeniy Polyakov
On Sun, Mar 04, 2007 at 02:02:36AM -0800, Michael K. Edwards ([EMAIL PROTECTED]) wrote: On 3/3/07, Evgeniy Polyakov [EMAIL PROTECTED] wrote: Btw, you could try to implement something you have written above to show its merits, so that it would not be an empty words :) Before I implement, I

[PATCH 0/3] NetXen: Make driver use multiple PCI functions

2007-03-05 Thread Linsys Contractor Mithlesh Thukral
Hi All, I will be sending updates to NetXen: 1G/10G Ethernet driver in subsequent mails. The patches will be with respect to netdev#upstream. My apologies for insufficient explanation of the patches in my last patchset. Regards, Mithlesh Thukral - To unsubscribe from this list: send the line

[PATCH 2/3] NetXen: Removal of redundant function call parameters

2007-03-05 Thread Linsys Contractor Mithlesh Thukral
NetXen: Removal of redundant function call parameters and bug fixes. This patch will remove the redundant paramters which were being passed to many functions since now adapter-portnum can be used. Signed-off-by: Mithlesh Thukral [EMAIL PROTECTED] --- drivers/net/netxen/netxen_nic.h |

[PATCH 3/3] NetXen: Fix ping failure of Jumbo frames on MEZ cards.

2007-03-05 Thread Linsys Contractor Mithlesh Thukral
NetXen: Fix ping failure of Jumbo frames on MEZ cards. Signed-off by: Mithlesh Thukral [EMAIL PROTECTED] --- drivers/net/netxen/netxen_nic_hw.c |7 ++- 1 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/netxen/netxen_nic_hw.c

Re: [PATCH 3/3] NetXen: Make driver use multi PCI functions

2007-03-05 Thread Mithlesh Thukral
On Saturday 03 March 2007 06:35, Jeff Garzik wrote: Linsys Contractor Mithlesh Thukral wrote: NetXen: Make driver use multi PCI functions. Signed-off by: Mithlesh Thukral [EMAIL PROTECTED] --- netxen_nic.h | 126 +--- netxen_nic_ethtool.c | 80 +++

Re: [RFT] sky2 auto negotiation PHY errata

2007-03-05 Thread Rob Sims
On Tue, Feb 20, 2007 at 11:00:53AM -0800, Stephen Hemminger wrote: You need the flow control fix and the tx_timeout fix posted for 2.6.20 (stable) and current git tree. sky2 1.13 has been far better than 1.10; there have been no system hangs or permanent sky2 failures. However, the

[PATCH] twcal_jiffie should be unsigned long, not int

2007-03-05 Thread Eric Dumazet
Hi David While browsing include/net/inet_timewait_sock.h, I found this buggy definition of twcal_jiffie. int twcal_jiffie; I wonder how inet_twdr_twcal_tick() can really works on x86_64 This seems quite an old bug, it was there before introduction of inet_timewait_death_row made by

[PATCH/RFC 00/13] Transparent proxying patches, take two

2007-03-05 Thread KOVACS Krisztian
Hi, These patches are my second try at providing Linux 2.2-like transparent proxying support for Linux 2.6. Major changes since the first version: - iptable_tproxy now does IPv4 fragment reassembly (necessary for processing TCP/UDP header) - The removal of the source address check in

[PATCH/RFC 01/13] Implement local diversion of IPv4 skbs

2007-03-05 Thread KOVACS Krisztian
The input path for non-local bound sockets requires diverting certain packets locally, even if their destination IP address is not considered local. We achieve this by assigning a specially crafted dst entry to these skbs, and optionally also attaching a socket to the skb so that the upper layer

[PATCH/RFC 02/13] Port redirection support for TCP

2007-03-05 Thread KOVACS Krisztian
Current TCP code relies on the local port of the listening socket being the same as the destination address of the incoming connection. Port redirection used by many transparent proxying techniques obviously breaks this, so we have to store the original destination port address. This patch

[PATCH/RFC 03/13] Don't do the TCP socket lookup if we already have one attached

2007-03-05 Thread KOVACS Krisztian
TCP input code path looks up the TCP socket hash tables to find a socket matching the incoming packet. However, as iptable_tproxy does socket lookups early the skb may already have the appropriate reference attached, in that case we steal that reference instead of doing the lookup. Signed-off-by:

[PATCH/RFC 04/13] Don't do the UDP socket lookup if we already have one attached

2007-03-05 Thread KOVACS Krisztian
UDP input code path looks up the UDP socket hash tables to find a socket matching the incoming packet. However, as iptable_tproxy does socket lookups early the skb may already have the appropriate reference attached, in that case we steal that reference instead of doing the lookup. Signed-off-by:

[PATCH/RFC 05/13] Loosen source address check on IPv4 output

2007-03-05 Thread KOVACS Krisztian
ip_route_output() contains a check to make sure that no flows with non-local source IP addresses are routed. This obviously makes using such addresses impossible. This patch introduces a flowi flag which makes omitting this check possible. The new flag provides a way of handling transparent and

[PATCH/RFC 06/13] Implement IP_TRANSPARENT socket option

2007-03-05 Thread KOVACS Krisztian
This patch introduces the IP_TRANSPARENT socket option: enabling that will make the IPv4 routing omit the non-local source address check on output. Setting IP_TRANSPARENT requires NET_ADMIN capability. Signed-off-by: KOVACS Krisztian [EMAIL PROTECTED] --- include/linux/in.h |

[PATCH/RFC 07/13] Conditionally enable transparent flow flag when connecting

2007-03-05 Thread KOVACS Krisztian
Set FLOWI_FLAG_TRANSPARENT in flowi-flags if the socket has the transparent socket option set. This way we selectively enable certain connections with non-local source addresses to be routed. Signed-off-by: KOVACS Krisztian [EMAIL PROTECTED] --- include/net/route.h |4 1 files

[PATCH/RFC 08/13] Handle TCP SYN+ACK/ACK/RST transparency

2007-03-05 Thread KOVACS Krisztian
The TCP stack sends out SYN+ACK/ACK/RST reply packets in response to incoming packets. The non-local source address check on output bites us again, as replies for transparently redirected traffic won't have a chance to leave the node. This patch selectively sets the FLOWI_FLAG_TRANSPARENT flag

[PATCH/RFC 09/13] Create a tproxy flag in struct sk_buff

2007-03-05 Thread KOVACS Krisztian
We would like to be able to match on whether or not a given packet has been diverted by tproxy. To make this possible we need a flag in sk_buff. Signed-off-by: KOVACS Krisztian [EMAIL PROTECTED] --- include/linux/skbuff.h |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git

[PATCH/RFC 10/13] Export UDP socket lookup function

2007-03-05 Thread KOVACS Krisztian
The iptables tproxy code has to be able to do UDP socket hash lookups, so we have to provide an exported lookup function for this purpose. Signed-off-by: KOVACS Krisztian [EMAIL PROTECTED] --- include/net/udp.h |4 net/ipv4/udp.c|8 2 files changed, 12 insertions(+),

[PATCH/RFC 11/13] iptables tproxy table

2007-03-05 Thread KOVACS Krisztian
The iptables tproxy table registers a new hook on PRE_ROUTING and for each incoming TCP/UDP packet performs as follows: 1. Does IPv4 fragment reassembly. We need this to be able to do TCP/UDP header processing. 2. Does a TCP/UDP socket hash lookup to decide whether or not the packet is

[PATCH/RFC 12/13] iptables TPROXY target

2007-03-05 Thread KOVACS Krisztian
The TPROXY target implements redirection of non-local TCP/UDP traffic to local sockets. It is simply a wrapper around functionality exported from iptable_tproxy. Signed-off-by: KOVACS Krisztian [EMAIL PROTECTED] --- include/linux/netfilter_ipv4/ipt_TPROXY.h |9 +++

[PATCH/RFC 13/13] iptables tproxy match

2007-03-05 Thread KOVACS Krisztian
Implements an iptables module which matches packets which have the tproxy flag set, that is, packets diverted in the tproxy table. Signed-off-by: KOVACS Krisztian [EMAIL PROTECTED] --- net/netfilter/Kconfig |9 + net/netfilter/Makefile|1 + net/netfilter/xt_tproxy.c | 77

Re: SWS for rcvbuf MTU

2007-03-05 Thread Alex Sidorenko
On March 3, 2007 06:40:12 pm John Heffner wrote: David Miller wrote: From: John Heffner [EMAIL PROTECTED] Date: Fri, 02 Mar 2007 16:16:39 -0500 Please don't apply the patch I sent. I've been thinking about this a bit harder, and it may not fix this particular problem. (Hard to say

Re: [RFC NET_SCHED 00/03]: ktime + nano-second clock resolution for packet schedulers

2007-03-05 Thread Patrick McHardy
David Miller wrote: Frankly, I think now that we have ktime and all of the proper generic infrastructure to do this stuff properly, I think we should just use ktime for the packet scheduler across the board and just delete all of that old by-hand timekeeping selection crap from pkt_sched.h

Re: [PATCH RFC 17/31] net: Factor out __dev_alloc_name from dev_alloc_name

2007-03-05 Thread Benjamin Thery
Hello Eric, See comments about __dev_alloc_name() below. Regards, Benjamin Eric W. Biederman wrote: From: Eric W. Biederman [EMAIL PROTECTED] - unquoted When forcibly changing the network namespace of a device I need something that can generate a name for the device in the new namespace

Re: [RFC NET_SCHED 00/03]: ktime + nano-second clock resolution for packet schedulers

2007-03-05 Thread Stephen Hemminger
On Mon, 05 Mar 2007 18:42:26 +0100 Patrick McHardy [EMAIL PROTECTED] wrote: David Miller wrote: Frankly, I think now that we have ktime and all of the proper generic infrastructure to do this stuff properly, I think we should just use ktime for the packet scheduler across the board and

Re: [RFC NET_SCHED 00/03]: ktime + nano-second clock resolution for packet schedulers

2007-03-05 Thread Patrick McHardy
Stephen Hemminger wrote: Don't bother changing netem. I have a version that uses hrtimer's and doesn't use PSCHED() clock source anymore. Me too :) I'm going to send it with my other patches soon, if you don't like it we can still drop it. - To unsubscribe from this list: send the line

[PATCH] natsemi: netpoll fixes

2007-03-05 Thread Sergei Shtylyov
Fix two issues in this driver's netpoll path: one usual, with spin_unlock_irq() enabling interrupts which nobody asks it to do (that has been fixed recently in a number of drivers) and one unusual, with poll_controller() method possibly causing loss of interrupts due to the interrupt status

[PATCH/RFC] Use of uninitialized data in udp_recvmsg().

2007-03-05 Thread Jim Chow
After inspection of some networking code, it seems there is a use of uninitialized data in udp_recvmsg(), linux-2.6.20.1/net/ipv4/udp.c:843, while testing msg-msg_flags (see the backtrace below). It looks like sys_recvfrom() is not initializing msg.msg_flags and, along the path given below,

Re: [PATCH] twcal_jiffie should be unsigned long, not int

2007-03-05 Thread David Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Mon, 5 Mar 2007 16:09:21 +0100 While browsing include/net/inet_timewait_sock.h, I found this buggy definition of twcal_jiffie. int twcal_jiffie; I wonder how inet_twdr_twcal_tick() can really works on x86_64 This seems quite an old

skge 0000:01:0a.0: unsupported phy type 0x0

2007-03-05 Thread Chris Stromsoe
I have a bunch of dual-port SK 98xx cards that work with sk98lin but not with skge. After loading skge, I get ACPI: PCI Interrupt :01:0a.0[A] - Link [LNKC] - GSI 10 (level, low) - IRQ 10 skge :01:0a.0: unsupported phy type 0x0 ACPI: PCI interrupt for device :01:0a.0 disabled skge:

Re: [PATCH/RFC] Use of uninitialized data in udp_recvmsg().

2007-03-05 Thread Herbert Xu
Jim Chow [EMAIL PROTECTED] wrote: After inspection of some networking code, it seems there is a use of uninitialized data in udp_recvmsg(), linux-2.6.20.1/net/ipv4/udp.c:843, while testing msg-msg_flags (see the backtrace below). It looks like sys_recvfrom() is not msg_flags is set on return

Re: [PATCH/RFC] Use of uninitialized data in udp_recvmsg().

2007-03-05 Thread Jim Chow
On Tue, 6 Mar 2007, Herbert Xu wrote: msg_flags [...] its initial value is not used. That's not true. Please see my post. Specifically, at linux-2.6.20.1/net/ipv4/udp.c:843, it seems that udp_recvmsg() can randomly ignore whether the HW has computed a checksum and compute it in SW

Re: skge 0000:01:0a.0: unsupported phy type 0x0

2007-03-05 Thread Stephen Hemminger
On Mon, 5 Mar 2007 13:48:29 -0800 (PST) Chris Stromsoe [EMAIL PROTECTED] wrote: I have a bunch of dual-port SK 98xx cards that work with sk98lin but not with skge. After loading skge, I get ACPI: PCI Interrupt :01:0a.0[A] - Link [LNKC] - GSI 10 (level, low) - IRQ 10 skge

Re: skge 0000:01:0a.0: unsupported phy type 0x0

2007-03-05 Thread Chris Stromsoe
On Mon, 5 Mar 2007, Stephen Hemminger wrote: What kernel version. Type 0 is XMAC support, and that was added to a fairly recent kernel (2.6.19?) It was an old kernel. I booted into 2.6.16 instead of 2.6.20. See my follow-up (and ignore the report). -Chris - To unsubscribe from this

Re: [PATCH] natsemi: netpoll fixes

2007-03-05 Thread Mark Brown
On Tue, Mar 06, 2007 at 12:10:08AM +0400, Sergei Shtylyov wrote: #ifdef CONFIG_NET_POLL_CONTROLLER static void natsemi_poll_controller(struct net_device *dev) { + struct netdev_private *np = netdev_priv(dev); + disable_irq(dev-irq); - intr_handler(dev-irq, dev); + +

Re: [PATCH] natsemi: netpoll fixes

2007-03-05 Thread Mark Brown
[Once more with CCs] On Tue, Mar 06, 2007 at 12:10:08AM +0400, Sergei Shtylyov wrote: #ifdef CONFIG_NET_POLL_CONTROLLER static void natsemi_poll_controller(struct net_device *dev) { + struct netdev_private *np = netdev_priv(dev); + disable_irq(dev-irq); -

ignore; Re: skge 0000:01:0a.0: unsupported phy type 0x0

2007-03-05 Thread Chris Stromsoe
Ignore this. I rebooted into the wrong kernel and was testing with 2.6.16 instead of 2.6.20. It works fine with 2.6.20. -Chris On Mon, 5 Mar 2007, Chris Stromsoe wrote: I have a bunch of dual-port SK 98xx cards that work with sk98lin but not with skge. After loading skge, I get ACPI:

Re: [Bugme-new] [Bug 8132] New: pptp server lockup in ppp_asynctty_receive()

2007-03-05 Thread Andrew Morton
On Mon, 5 Mar 2007 14:26:30 -0800 [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=8132 Summary: pptp server lockup in ppp_asynctty_receive() Kernel Version: 2.6.20 Status: NEW Severity: high Owner: [EMAIL PROTECTED]

Re: [PATCH/RFC] Use of uninitialized data in udp_recvmsg().

2007-03-05 Thread Herbert Xu
On Mon, Mar 05, 2007 at 01:01:16PM -0800, Jim Chow wrote: On Tue, 6 Mar 2007, Herbert Xu wrote: msg_flags [...] its initial value is not used. That's not true. Please see my post. Specifically, at linux-2.6.20.1/net/ipv4/udp.c:843, it seems that udp_recvmsg() can randomly ignore

Re: [PATCH/RFC] Use of uninitialized data in udp_recvmsg().

2007-03-05 Thread Herbert Xu
On Tue, Mar 06, 2007 at 10:34:49AM +1100, Herbert Xu wrote: That's not true. Please see my post. Specifically, at linux-2.6.20.1/net/ipv4/udp.c:843, it seems that udp_recvmsg() can randomly ignore whether the HW has computed a checksum and compute it in SW redundantly. Sorry,

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-05 Thread Johannes Berg
On Sun, 2007-03-04 at 17:17 -0800, Greg KH wrote: This is due to the recent sysfs restructuring I think. IIRC the fix is to upgrade hal to a current git version. If that's the cause, the fix is to back out whatever was done to break userspace. Breaking userspace is not ok. Upgrading

Re: [1/6] 2.6.21-rc2: known regressions

2007-03-05 Thread Marcel Holtmann
Hi Greg, Subject: Bluetooth RFComm locks up the machine (device_move() related) References : http://lkml.org/lkml/2007/3/4/64 Submitter : Mark Lord [EMAIL PROTECTED] Caused-By : Marcel Holtmann [EMAIL PROTECTED] commit c1a3313698895d8ad4760f98642007bf236af2e8

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-05 Thread Theodore Tso
On Sun, Mar 04, 2007 at 05:17:29PM -0800, Greg KH wrote: I should not have broken any userspace if CONFIG_SYSFS_DEPRECATED is enabled with that patch. If that is enabled, and that patch still causes problems, please let me know. But we still need to update the help text for

Re: TCP 2MSL on loopback

2007-03-05 Thread Eric Dumazet
On Monday 05 March 2007 12:20, Howard Chu wrote: Why is the Maximum Segment Lifetime a global parameter? Surely the maximum possible lifetime of a particular TCP segment depends on the actual connection. At the very least, it would be useful to be able to set it on a per-interface basis. E.g.,

RE: [PATCH] xfrm_policy delete security check misplaced

2007-03-05 Thread Venkat Yekkirala
@@ -2552,7 +2550,7 @@ static int pfkey_spdget(struct sock *sk, struct sk_buff *skb, struct sadb_msg *h return -EINVAL; xp = xfrm_policy_byid(XFRM_POLICY_TYPE_MAIN, dir, pol-sadb_x_policy_id, - hdr-sadb_msg_type == SADB_X_SPDDELETE2); +

RE: [PATCH] xfrm_policy delete security check misplaced

2007-03-05 Thread Venkat Yekkirala
Also, [Joy cc'd] deletions here needn't be audited? OK, I see the next patch addressed this :) - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-05 Thread Tomasz Torcz
On Mon, Mar 05, 2007 at 01:13:26AM -0600, Matt Mackall wrote: On Sun, Mar 04, 2007 at 11:02:48PM -0800, Greg KH wrote: On Mon, Mar 05, 2007 at 12:42:29AM -0600, Matt Mackall wrote: On Sun, Mar 04, 2007 at 05:16:25PM -0800, Greg KH wrote: On Sun, Mar 04, 2007 at 04:08:57PM -0600, Matt

RE: [PATCH] xfrm_policy delete security check misplaced

2007-03-05 Thread Venkat Yekkirala
Signed-off-by: Eric Paris [EMAIL PROTECTED] Acked-by: Venkat Yekkirala [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH] Add xfrm policy change auditing to pfkey_spdget

2007-03-05 Thread Venkat Yekkirala
pfkey_spdget neither had an LSM security hook nor auditing for the removal of xfrm_policy structs. The security hook was added when it was moved into xfrm_policy_byid instead of the callers to that function by my earlier patch and this patch adds the auditing hooks as well.

RE: [PATCH] xfrm audit hook misplaced in pfkey_delete and xfrm_del_sa

2007-03-05 Thread Venkat Yekkirala
Inside pfkey_delete and xfrm_del_sa the audit hooks were not called if there was any permission/security failures in attempting to do the del operation (such as permission denied from security_xfrm_state_delete). This patch moves the audit hook to the exit path such that all failures (and

RE: [PATCH] xfrm_policy delete security check misplaced

2007-03-05 Thread James Morris
On Mon, 5 Mar 2007, Venkat Yekkirala wrote: Signed-off-by: Eric Paris [EMAIL PROTECTED] Acked-by: Venkat Yekkirala [EMAIL PROTECTED] What about your previous comment: I guess you meant to do this here? else if (err) return err; -- James Morris [EMAIL

RE: [PATCH] xfrm_policy delete security check misplaced

2007-03-05 Thread Venkat Yekkirala
Signed-off-by: Eric Paris [EMAIL PROTECTED] Acked-by: Venkat Yekkirala [EMAIL PROTECTED] What about your previous comment: I guess you meant to do this here? else if (err) return err; I saw that this was taken care of in patch-2 for the delete case, but

Re: [NFS] [PATCH 001 of 3] knfsd: Use recv_msg to get peer address for NFSD instead of code-copying

2007-03-05 Thread Olaf Kirch
On Friday 02 March 2007 05:28, NeilBrown wrote: The sunrpc server code needs to know the source and destination address for UDP packets so it can reply properly. It currently copies code out of the network stack to pick the pieces out of the skb. This is ugly and causes compile problems with

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-05 Thread Greg KH
On Mon, Mar 05, 2007 at 07:59:50AM -0500, Theodore Tso wrote: On Sun, Mar 04, 2007 at 05:17:29PM -0800, Greg KH wrote: I should not have broken any userspace if CONFIG_SYSFS_DEPRECATED is enabled with that patch. If that is enabled, and that patch still causes problems, please let me know.

Re: [NFS] [PATCH 001 of 3] knfsd: Use recv_msg to get peer address for NFSD instead of code-copying

2007-03-05 Thread Olaf Kirch
Hi Neil, here's another minor comment: On Friday 02 March 2007 05:28, NeilBrown wrote: +static inline void svc_udp_get_dest_address(struct svc_rqst *rqstp, + struct cmsghdr *cmh) { switch (rqstp-rq_sock-sk_sk-sk_family) { case AF_INET: {

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-05 Thread Matt Mackall
On Mon, Mar 05, 2007 at 10:58:13AM -0800, Greg KH wrote: Ok, how about the following patch. Is it acceptable to everyone? - If you are using a distro that was released in 2006 or later, - it should be safe to say N here. + If you are using an OpenSuSE, Gentoo, Ubuntu, or

Re: [NFS] [PATCH 001 of 3] knfsd: Use recv_msg to get peer address for NFSD instead of code-copying

2007-03-05 Thread Neil Brown
On Monday March 5, [EMAIL PROTECTED] wrote: Hi Neil, here's another minor comment: On Friday 02 March 2007 05:28, NeilBrown wrote: +static inline void svc_udp_get_dest_address(struct svc_rqst *rqstp, + struct cmsghdr *cmh) { switch

RE: [PATCH] xfrm_policy delete security check misplaced

2007-03-05 Thread Eric Paris
On Mon, 2007-03-05 at 11:39 -0500, James Morris wrote: On Mon, 5 Mar 2007, Venkat Yekkirala wrote: Signed-off-by: Eric Paris [EMAIL PROTECTED] Acked-by: Venkat Yekkirala [EMAIL PROTECTED] What about your previous comment: I guess you meant to do this here? else if

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-05 Thread Matt Mackall
On Mon, Mar 05, 2007 at 04:46:09PM +0100, Tomasz Torcz wrote: That's not the point. The point is that Debian/unstable as of _this morning_ doesn't work. For reference, I'm running both the latest releases of both hal (0.5.8.1-6.1) and network-manager (0.6.4-6). And there are people telling

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-05 Thread Joel Becker
On Mon, Mar 05, 2007 at 04:46:09PM +0100, Tomasz Torcz wrote: On Mon, Mar 05, 2007 at 01:13:26AM -0600, Matt Mackall wrote: That's not the point. The point is that Debian/unstable as of _this morning_ doesn't work. For reference, I'm running both the latest releases of both hal

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-05 Thread Greg KH
On Mon, Mar 05, 2007 at 01:55:30PM -0600, Matt Mackall wrote: On Mon, Mar 05, 2007 at 10:58:13AM -0800, Greg KH wrote: Ok, how about the following patch. Is it acceptable to everyone? - If you are using a distro that was released in 2006 or later, - it should be safe to say N

RE: [PATCH] s2io: add PCI error recovery support

2007-03-05 Thread Ramkrishna Vepa
Comments on this patch - 1. device_close_flag is unused and is not required. +static pci_ers_result_t s2io_io_error_detected(struct pci_dev *pdev, + pci_channel_state_t state) +{ ... + do_s2io_card_down(sp, 0); +

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-05 Thread Jeffrey Hundstad
Greg KH wrote: On Mon, Mar 05, 2007 at 07:59:50AM -0500, Theodore Tso wrote: Ok, how about the following patch. Is it acceptable to everyone? thanks, greg k-h --- init/Kconfig | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) --- gregkh-2.6.orig/init/Kconfig +++

[2.6.21 patch] unconditionally enable SYSFS_DEPRECATED

2007-03-05 Thread Adrian Bunk
On Mon, Mar 05, 2007 at 10:58:13AM -0800, Greg KH wrote: Ok, how about the following patch. Is it acceptable to everyone? thanks, greg k-h --- init/Kconfig | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) --- gregkh-2.6.orig/init/Kconfig +++

Re: [NFS] [PATCH 001 of 3] knfsd: Use recv_msg to get peer address for NFSD instead of code-copying

2007-03-05 Thread Neil Brown
On Monday March 5, [EMAIL PROTECTED] wrote: On Friday 02 March 2007 05:28, NeilBrown wrote: The sunrpc server code needs to know the source and destination address for UDP packets so it can reply properly. It currently copies code out of the network stack to pick the pieces out of the

Re: [RFC] div64_64 support

2007-03-05 Thread Stephen Hemminger
On 03 Mar 2007 03:31:52 +0100 Andi Kleen [EMAIL PROTECTED] wrote: Stephen Hemminger [EMAIL PROTECTED] writes: Here is another way to handle the 64 bit divide case. It allows full 64 bit divide by adding the support routine GCC needs. Not supplying that was intentional by Linus so that

Re: [2.6.21 patch] unconditionally enable SYSFS_DEPRECATED

2007-03-05 Thread Greg KH
On Tue, Mar 06, 2007 at 12:40:52AM +0100, Adrian Bunk wrote: On Mon, Mar 05, 2007 at 10:58:13AM -0800, Greg KH wrote: Ok, how about the following patch. Is it acceptable to everyone? thanks, greg k-h --- init/Kconfig | 13 +++-- 1 file changed, 11

Re: [RFC] div64_64 support

2007-03-05 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Mon, 5 Mar 2007 15:57:14 -0800 I tried the code from Hacker's Delight. It is cool, but performance is CPU (and data) dependent: Average # of usecs per operation: Interesting results. The problem with these algorithms that tradoff one or more

Re: [PATCH/RFC] Use of uninitialized data in udp_recvmsg().

2007-03-05 Thread Jim Chow
On Tue, 6 Mar 2007, Herbert Xu wrote: It's just too error-prone to rely on it to not have MSG_TRUNC set. Agreed. I'm going to clean this up for UDP and improve the UDP-lite checksum handling while I'm at it. Great. It'll be good to get this years-old UDP bug fixed. Thanks, Jim - To

[UDP]: Reread uh pointer after pskb_trim

2007-03-05 Thread Herbert Xu
Hi Dave: [UDP]: Reread uh pointer after pskb_trim The header may have moved when trimming. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmVHI~} [EMAIL PROTECTED] Home Page: http://gondor.apana.org.au/~herbert/ PGP Key:

Re: [UDP]: Reread uh pointer after pskb_trim

2007-03-05 Thread David Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Tue, 6 Mar 2007 12:00:20 +1100 Hi Dave: [UDP]: Reread uh pointer after pskb_trim The header may have moved when trimming. Signed-off-by: Herbert Xu [EMAIL PROTECTED] Good catch, I'll apply this and push to -stable, thanks Herbert. - To

Re: when having to acquire an SA, ipsec drops the packet

2007-03-05 Thread Joy Latten
From: Joy Latten [EMAIL PROTECTED] Date: Mon, 05 Feb 2007 14:53:39 -0600 I can run some tests with this patch and report any results... Please check out the two most recent patches I posted: 1) Updated core patch with ipv6 side added. 2) Fix for thinko noticed by Venkat. I have been testing

[RFC PATCH]: Dynamically sized routing cache hash table.

2007-03-05 Thread David Miller
This is essentially a port of Nick Piggin's dcache hash table patches to the routing cache. It solves the locking issues during table grow/shrink that I couldn't handle properly last time I tried to code up a patch like this. But one of the core issues of this kind of change still remains.

Re: [PATCH] LVS: Send ICMP unreachable responses to end-users when real-servers are removed

2007-03-05 Thread David Miller
From: Horms [EMAIL PROTECTED] Date: Sun, 11 Feb 2007 12:04:43 +0900 this is a small patch by Janusz Krzysztofik to ip_route_output_slow() that allows VIP-less LVS linux director to generate packets originating From VIP if sysctl_ip_nonlocal_bind is set. In a nutshell, the intention is for

Re: [2.6.21 patch] unconditionally enable SYSFS_DEPRECATED

2007-03-05 Thread Adrian Bunk
On Mon, Mar 05, 2007 at 04:07:22PM -0800, Greg KH wrote: On Tue, Mar 06, 2007 at 12:40:52AM +0100, Adrian Bunk wrote: On Mon, Mar 05, 2007 at 10:58:13AM -0800, Greg KH wrote: Ok, how about the following patch. Is it acceptable to everyone? thanks, greg k-h ---

Re: [PATCH] xfrm_policy delete security check misplaced

2007-03-05 Thread James Morris
On Fri, 2 Mar 2007, Eric Paris wrote: Signed-off-by: Eric Paris [EMAIL PROTECTED] Acked-by: James Morris [EMAIL PROTECTED] -- James Morris [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] Add xfrm policy change auditing to pfkey_spdget

2007-03-05 Thread James Morris
On Fri, 2 Mar 2007, Eric Paris wrote: pfkey_spdget neither had an LSM security hook nor auditing for the removal of xfrm_policy structs. The security hook was added when it was moved into xfrm_policy_byid instead of the callers to that function by my earlier patch and this patch adds the

Re: [PATCH] xfrm audit hook misplaced in pfkey_delete and xfrm_del_sa

2007-03-05 Thread James Morris
On Fri, 2 Mar 2007, Eric Paris wrote: Inside pfkey_delete and xfrm_del_sa the audit hooks were not called if there was any permission/security failures in attempting to do the del operation (such as permission denied from security_xfrm_state_delete). This patch moves the audit hook to the

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-05 Thread Greg KH
On Tue, Mar 06, 2007 at 11:24:57AM +1100, Bron Gondwana wrote: On Mon, Mar 05, 2007 at 03:14:25PM -0600, Matt Mackall wrote: On Mon, Mar 05, 2007 at 04:46:09PM +0100, Tomasz Torcz wrote: That's not the point. The point is that Debian/unstable as of _this morning_ doesn't work. For

Re: [2.6.21 patch] unconditionally enable SYSFS_DEPRECATED

2007-03-05 Thread Greg KH
On Tue, Mar 06, 2007 at 01:35:41AM +0100, Adrian Bunk wrote: On Mon, Mar 05, 2007 at 04:07:22PM -0800, Greg KH wrote: On Tue, Mar 06, 2007 at 12:40:52AM +0100, Adrian Bunk wrote: On Mon, Mar 05, 2007 at 10:58:13AM -0800, Greg KH wrote: Ok, how about the following patch. Is it

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-05 Thread Bron Gondwana
On Mon, Mar 05, 2007 at 03:14:25PM -0600, Matt Mackall wrote: On Mon, Mar 05, 2007 at 04:46:09PM +0100, Tomasz Torcz wrote: That's not the point. The point is that Debian/unstable as of _this morning_ doesn't work. For reference, I'm running both the latest releases of both hal

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-05 Thread Theodore Tso
On Mon, Mar 05, 2007 at 04:37:15PM -0800, Greg KH wrote: But I AM TRYING TO MAKE IT COMPATIBLE!!! That's what that config option is there for. If you happen to be running a newer userspace, a different distro than what is in Debian right now, or don't use HAL and Networkmanager, then

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-05 Thread Andrew Morton
On Mon, 5 Mar 2007 19:56:25 -0500 Theodore Tso [EMAIL PROTECTED] wrote: So the question really is are we really done making changes to sysfs, or maybe what we should do is talk about major version numbers to sysfs. Perhaps using a config option wasn't the right way to do this - a kernel boot

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-05 Thread Greg KH
On Mon, Mar 05, 2007 at 07:56:25PM -0500, Theodore Tso wrote: On Mon, Mar 05, 2007 at 04:37:15PM -0800, Greg KH wrote: But I AM TRYING TO MAKE IT COMPATIBLE!!! That's what that config option is there for. If you happen to be running a newer userspace, a different distro than what is in

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-05 Thread Greg KH
On Mon, Mar 05, 2007 at 05:08:49PM -0800, Andrew Morton wrote: On Mon, 5 Mar 2007 19:56:25 -0500 Theodore Tso [EMAIL PROTECTED] wrote: So the question really is are we really done making changes to sysfs, or maybe what we should do is talk about major version numbers to sysfs. Perhaps

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-05 Thread Andrew Morton
On Mon, 5 Mar 2007 17:17:09 -0800 Greg KH [EMAIL PROTECTED] wrote: On Mon, Mar 05, 2007 at 05:08:49PM -0800, Andrew Morton wrote: On Mon, 5 Mar 2007 19:56:25 -0500 Theodore Tso [EMAIL PROTECTED] wrote: So the question really is are we really done making changes to sysfs, or maybe

Re: [2.6.21 patch] unconditionally enable SYSFS_DEPRECATED

2007-03-05 Thread Matt Mackall
On Mon, Mar 05, 2007 at 04:07:22PM -0800, Greg KH wrote: On Tue, Mar 06, 2007 at 12:40:52AM +0100, Adrian Bunk wrote: On Mon, Mar 05, 2007 at 10:58:13AM -0800, Greg KH wrote: Ok, how about the following patch. Is it acceptable to everyone? thanks, greg k-h ---

Re: [2.6.21 patch] unconditionally enable SYSFS_DEPRECATED

2007-03-05 Thread Greg KH
On Mon, Mar 05, 2007 at 07:30:21PM -0600, Matt Mackall wrote: On Mon, Mar 05, 2007 at 04:07:22PM -0800, Greg KH wrote: On Tue, Mar 06, 2007 at 12:40:52AM +0100, Adrian Bunk wrote: On Mon, Mar 05, 2007 at 10:58:13AM -0800, Greg KH wrote: Ok, how about the following patch. Is it

Re: [2.6.21 patch] unconditionally enable SYSFS_DEPRECATED

2007-03-05 Thread Greg KH
On Mon, Mar 05, 2007 at 07:30:21PM -0600, Matt Mackall wrote: On Mon, Mar 05, 2007 at 04:07:22PM -0800, Greg KH wrote: On Tue, Mar 06, 2007 at 12:40:52AM +0100, Adrian Bunk wrote: On Mon, Mar 05, 2007 at 10:58:13AM -0800, Greg KH wrote: Ok, how about the following patch. Is it

Re: Recent wireless breakage (ipw2200, iwconfig, NetworkManager)

2007-03-05 Thread Matthew Garrett
On Mon, Mar 05, 2007 at 02:39:00PM -0800, Greg KH wrote: Ok, I only named HAL as that is what people have told me the problem is. I have been running this change on my boxs, without CONFIG_SYSFS_DEPRECATED since last July or so. But I don't use NetworkManager here for the most part, but I

Re: [2.6.21 patch] unconditionally enable SYSFS_DEPRECATED

2007-03-05 Thread Matt Mackall
On Mon, Mar 05, 2007 at 06:48:50PM -0800, Greg KH wrote: Wait, have confirmed that if you enable this config option, NetworkManager starts back up again and works properly? Yep, probably should have mentioned that. If so, can you disable the option and strace it to see what program is

Re: [2.6.21 patch] unconditionally enable SYSFS_DEPRECATED

2007-03-05 Thread Matt Mackall
On Mon, Mar 05, 2007 at 06:48:50PM -0800, Greg KH wrote: If so, can you disable the option and strace it to see what program is trying to access what? That will put the HAL/NetworkManager/libsysfs/distro script finger pointing to rest pretty quickly :) Ok, I've got straces of both good and

Re: [2.6.21 patch] unconditionally enable SYSFS_DEPRECATED

2007-03-05 Thread Greg KH
On Mon, Mar 05, 2007 at 09:39:47PM -0600, Matt Mackall wrote: On Mon, Mar 05, 2007 at 06:48:50PM -0800, Greg KH wrote: If so, can you disable the option and strace it to see what program is trying to access what? That will put the HAL/NetworkManager/libsysfs/distro script finger pointing

Re: [RFC] Arp announce (for Xen)

2007-03-05 Thread David Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Thu, 1 Mar 2007 17:30:30 -0800 What about implementing the unused arp_announce flag on the inetdevice? Something like the following. Totally untested... Looks like it either was there (and got removed) or was planned but never implemented.

  1   2   >