Re: Crash in ip_rcv while booting related to netconsole

2005-07-05 Thread David S. Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Thu, 30 Jun 2005 12:37:42 +1000 Actually you never applied my patch :) That's right. I was hoping someone would fix the Acenic driver, oh well. Here they are again. This one makes IPv4 ip_rcv registration happen last in af_inet. Applied, thanks

Re: [PATCH] tg3: support for ethtool -C

2005-07-05 Thread David S. Miller
From: Michael Chan [EMAIL PROTECTED] Date: Wed, 29 Jun 2005 14:48:27 -0700 [TG3]: support for ethtool -C Add support for ethtool -C with verification of user parameters. I've added this patch to my tree, thanks Michael. - To unsubscribe from this list: send the line unsubscribe netdev in the

Re: Broken memory allocation in fib_trie

2005-07-05 Thread David S. Miller
From: Robert Olsson [EMAIL PROTECTED] Date: Thu, 30 Jun 2005 11:23:12 +0200 Below a patch to preallocate memory when doing resize of trie (inflate halve) If preallocations fails it just skips the resize of this tnode for this time. The oops we got when killing bgpd (with full routing) is now

Re: [PATCH] shaper: switch to spinlocks

2005-07-05 Thread David S. Miller
From: Christoph Hellwig [EMAIL PROTECTED] Date: Thu, 30 Jun 2005 22:12:51 +0200 you were right and the sleeping locks in shaper were broken. Markus Kanet noticed this and also tested the patch below that switches locking to spinlocks. Signed-off-by: Christoph Hellwig [EMAIL PROTECTED]

Re: [PATCH] [DECNET]: Fix memset overflow on 64bit archs while dumping decnet routing rules

2005-07-05 Thread David S. Miller
Applied, thanks Thomas. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] part 1/3 : hashed spinlocks in net/ipv4/route.c

2005-07-05 Thread David S. Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Wed, 29 Jun 2005 10:30:23 +0200 [NET] hashed spinlocks in net/ipv4/route.c - Locking abstraction - Spinlocks moved out of rt hash table : Less memory (50%) used by rt hash table. it's a win even on UP. - Sizing of spinlocks table depends on

Re: help on tg3 polling extension

2005-07-05 Thread David S. Miller
From: Qinghua(Kevin) Ye [EMAIL PROTECTED] Date: Tue, 5 Jul 2005 16:19:27 -0600 Compared to NAPI, click polling will disable Nic interrupts during its operation, even there is no any packets in the rx buffer. This destroys latency if you only recheck the RX buffer using timer interrupts. Even

Re: [RESEND] [PKT_SCHED]: Blackhole queueing discipline

2005-07-05 Thread David S. Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Wed, 6 Jul 2005 00:13:24 +0200 Useful in combination with classful qdiscs to drop or temporary disable certain flows, e.g. one could block specific ds flows with dsmark. Unlike the noop qdisc it can be controlled by the user and statistic

Re: help on tg3 polling extension

2005-07-06 Thread David S. Miller
From: Qinghua(Kevin) Ye [EMAIL PROTECTED] Date: Wed, 6 Jul 2005 11:36:40 -0600 Compared to NAPI, click polling will disable Nic interrupts during its operation, even there is no any packets in the rx buffer. This destroys latency if you only recheck the RX buffer using timer

Re: help on tg3 polling extension

2005-07-06 Thread David S. Miller
From: Qinghua(Kevin) Ye [EMAIL PROTECTED] Date: Wed, 6 Jul 2005 14:12:29 -0600 Yes, you are right. Click acturally will release the CPU to OS at interval. Other processes will be responded at this interval. It is not Click's right to make this kind of decision, that is what we have the process

Re: [patch 1/1] net: fix sparse warnings

2005-07-07 Thread David S. Miller
From: [EMAIL PROTECTED] Date: Thu, 07 Jul 2005 23:30:26 +0200 From: Victor Fusco [EMAIL PROTECTED] Fix the sparse warning implicit cast to nocast type Signed-off-by: Victor Fusco [EMAIL PROTECTED] Signed-off-by: Domen Puncer [EMAIL PROTECTED] Applied, thanks a lot. - To unsubscribe from

SKB tutorial updated

2005-07-10 Thread David S. Miller
I've updated the SKB tutorial a little bit today, in particular I added coverage of non-linear data areas to the SKB data handling tutorial page at: http://vger.kernel.org/~davem/skb_data.html I'll probably start working on the TCP packet output engine next. - To unsubscribe from this

Re: [PATCH 2/2] net: move config options out to individual protocols

2005-07-12 Thread David S. Miller
From: Sam Ravnborg [EMAIL PROTECTED] Date: Fri, 8 Jul 2005 00:43:18 + Move the protocol specific config options out to the specific protocols. With this change net/Kconfig now starts to become readable and serve as a good basis for further re-structuring. The menu structure is left

Re: ALIGN at crypt/cipher.c

2005-07-15 Thread David S. Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Fri, 15 Jul 2005 12:27:56 +1000 On Thu, Jul 14, 2005 at 02:36:16PM +, Ken-ichirou MATSUZAWA wrote: No, I think I can understand. align should be unsigned long too. After changing align to unsigned long from int, it works fine. Thanks for

Re: [patch 1/1] drivers/net/pcmcia/smc91c92_cs.c : Use of time_after macro

2005-07-15 Thread David S. Miller
From: [EMAIL PROTECTED] Date: Thu, 14 Jul 2005 23:41:51 +0200 Use of the time_after() macro, defined at linux/jiffies.h, which deal with wrapping correctly and are nicer to read. Signed-off-by: Marcelo Feitoza Parisi [EMAIL PROTECTED] Signed-off-by: Domen Puncer [EMAIL PROTECTED] Patch

Re: [patch 1/3] netlink: Fix nocast type warnings

2005-07-18 Thread David S. Miller
From: [EMAIL PROTECTED] Date: Thu, 14 Jul 2005 23:41:58 +0200 From: Victor Fusco [EMAIL PROTECTED] Fix the sparse warning implicit cast to nocast type File/Subsystem:net/netlink/af_netlink.c Signed-off-by: Victor Fusco [EMAIL PROTECTED] Signed-off-by: Domen Puncer [EMAIL PROTECTED]

Re: [PATCH] convert nfmark and conntrack mark to 32bit

2005-07-18 Thread David S. Miller
From: Harald Welte [EMAIL PROTECTED] Date: Sun, 17 Jul 2005 23:42:23 +0200 As discussed at netconf'05, we convert nfmark and conntrack-mark to be 32bits even on 64bit architectures. Signed-off-by: Harald Welte [EMAIL PROTECTED] Applied, thanks Harald. - To unsubscribe from this list: send

Re: [PATCH] reduce netfilte sk_buff enlargement

2005-07-18 Thread David S. Miller
From: Harald Welte [EMAIL PROTECTED] Date: Mon, 18 Jul 2005 00:04:51 +0200 The only real in-tree user of nfcache was IPVS, who only needs a single bit. Unfortunately I couldn't find some other free bit in sk_buff to stuff that bit into, so I introduced a separate field for them. Maybe the

Re: netdev TODO list

2005-07-19 Thread David S. Miller
From: Ben Greear [EMAIL PROTECTED] Date: Tue, 19 Jul 2005 10:58:33 -0700 That way, any out-of-tree code that uses skb-stamp will no longer compile (it is much better to fail at compile time than run time). Sure. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [NET]: Kill skb-tc_classid

2005-07-19 Thread David S. Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Tue, 19 Jul 2005 20:29:30 +0200 Did you also get the patch to kill skb-tc_classid? I can only see the patch to remove the define in your 2.6.14 tree. I just put it into the tree right now, it should show up on kernel.org in about a half hour.

Re: [PATCH 8/8][ATM]: [speedtch] cure atm_printk() macro gcc-2.95 compile error

2005-07-19 Thread David S. Miller
All 8 patches applied, thanks Chas. Chas, please update your address book, [EMAIL PROTECTED] is no longer in service. The current address for the list is netdev@vger.kernel.org Thanks. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [IPV4]: Don't select XFRM for ip_gre

2005-07-19 Thread David S. Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Tue, 19 Jul 2005 20:47:18 +0200 [IPV4]: Don't select XFRM for ip_gre Signed-off-by: Patrick McHardy [EMAIL PROTECTED] Applied to net-2.6, thanks Patrick. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

Re: [PATCH] fib_trie whitespace fixes

2005-07-19 Thread David S. Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Tue, 19 Jul 2005 08:49:17 -0400 Fix up lots of little whitespace indentation stuff in fib_trie. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] Applied to net-2.6, thanks Stephen. - To unsubscribe from this list: send the line unsubscribe

Re: [NET]: Make ipip/ip6_tunnel independant of XFRM

2005-07-19 Thread David S. Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Tue, 19 Jul 2005 21:23:55 +0200 [NET]: Make ipip/ip6_tunnel independant of XFRM Signed-off-by: Patrick McHardy [EMAIL PROTECTED] Looks good, applied to net-2.6, thanks Patrick. - To unsubscribe from this list: send the line unsubscribe netdev in

Re: [2.6 patch] BRIDGE_EBT_ARPREPLY must depend on INET

2005-07-19 Thread David S. Miller
From: Adrian Bunk [EMAIL PROTECTED] Date: Tue, 19 Jul 2005 15:55:29 +0200 BRIDGE_EBT_ARPREPLY=y and INET=n results in the following compile error: Applied, thanks Adrian. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: [2.6 patch] NETCONSOLE must depend on INET

2005-07-19 Thread David S. Miller
From: Adrian Bunk [EMAIL PROTECTED] Date: Tue, 19 Jul 2005 20:29:19 +0200 NETCONSOLE=y and INET=n results in the following compile error: Also applied, thanks Adrian. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH 3/*] re-add NFC_ defines

2005-07-20 Thread David S. Miller
All 3 patches applied, thanks Harald. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] reduce netfilte sk_buff enlargement

2005-07-21 Thread David S. Miller
From: Marcel Holtmann [EMAIL PROTECTED] Date: Thu, 21 Jul 2005 20:20:35 +0200 However after a look trough the Bluetooth core it should be quite easy too move the pkt_type into the control buffer. We already use it for a direction bit. The nasty thing is that I have to modify all the drivers.

Re: [PATCH 1/2][REQSK] Move the syn_table destruction from tcp_listen_stop to reqsk_queue_destroy

2005-07-21 Thread David S. Miller
From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo) Date: Wed, 20 Jul 2005 20:22:28 -0300 + if (lopt-qlen != 0) { + struct request_sock *req; + int i; + + for (i = 0; i lopt-nr_table_entries; i++) + while ((req = lopt-syn_table[i])

Re: [PATCH] reduce netfilte sk_buff enlargement

2005-07-21 Thread David S. Miller
From: Marcel Holtmann [EMAIL PROTECTED] Date: Thu, 21 Jul 2005 23:42:11 +0200 unfortunatly it is not that straight forward as I thought. The attached patch which modifies the Bluetooth core and the hci_usb driver is not working on my machine. Hmmm... I'll see if I can spot anything obvious in

Re: [PATCH] reduce netfilte sk_buff enlargement

2005-07-21 Thread David S. Miller
From: Marcel Holtmann [EMAIL PROTECTED] Date: Thu, 21 Jul 2005 23:42:11 +0200 unfortunatly it is not that straight forward as I thought. The attached patch which modifies the Bluetooth core and the hci_usb driver is not working on my machine. This probably has nothing to do with why the patch

Re: [NET,RFC]: Introduce SO_{SND,RCV}BUFFORCE socket options

2005-07-21 Thread David S. Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Thu, 21 Jul 2005 02:36:13 +0200 ctnetlink needs large socket buffer sizes. To avoid increasing the system wide limit we would like to have something that allows CAP_NET_ADMIN to override these limits. The first idea was to change the

Re: [PATCH] reduce netfilte sk_buff enlargement

2005-07-21 Thread David S. Miller
From: Marcel Holtmann [EMAIL PROTECTED] Date: Fri, 22 Jul 2005 01:49:51 +0200 The pkt_type zero is not a valid one. We only use 1-4 and 0xff. So this can't be the problem. I assume that the cb is not copied from the driver into the core at some point. All clones and copies of SKBs copy of the

[PATCH RFC]: Killing skb-real_dev

2005-07-21 Thread David S. Miller
I studied this and it's merely a matter of parameter passing. Specifically, at ptype-func() time, it is plainly the skb-dev before skb_bond() is applied. So I added a real_dev arg to ptype-func() and converted the tree over to that. Thomas, this kills the TCF_META_ID_REALDEV stuff, so we should

Re: [PATCH] [IPV4] fib_trie cleanups

2005-07-22 Thread David S. Miller
A lot of the spacing and tabbing has been cleaned up by Stephen Hemminger, so you might want to patch against the copy in my 2.6.14 networking it tree at: rsync://rsync.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6.14.git Thanks. - To unsubscribe from this list: send the line

Re: [PATCH RFC]: Killing skb-real_dev

2005-07-22 Thread David S. Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Fri, 22 Jul 2005 17:04:00 +0200 Sure. I was just thinking that maybe we should delay the iproute2 release with the ematch bits until we finished to shrink the skb. Stephen? Hopefully we can weed out the unusable ematch bits before 2.6.13 is released.

Re: [PATCH] ctnetlink

2005-07-22 Thread David S. Miller
From: Harald Welte [EMAIL PROTECTED] Date: Fri, 22 Jul 2005 09:11:30 -0400 This is a patch for your net-2.6.14 tree (incremental to the expect-double-free fix). It adds the ctnetlink code, and all the required core conntrack/nat changes that it needs. Applied and pushed to net-2.6.14 - To

Re: [PATCH RFC]: Killing skb-real_dev

2005-07-22 Thread David S. Miller
From: Stephen Hemminger [EMAIL PROTECTED] Date: Fri, 22 Jul 2005 13:48:42 -0700 I don't see how the ematch iproute2 stuff depends on SKB shrinking. The CVS repository has the latest ematch stuff, just testing and checking before the next drop. We're killing SKB members that the ematch stuff

Re: [PATCH RFC]: Killing skb-real_dev

2005-07-22 Thread David S. Miller
From: YOSHIFUJI Hideaki [EMAIL PROTECTED] Date: Fri, 22 Jul 2005 17:06:38 -0400 (EDT) No, please, please do not break binaries, whenever it is possible. It is definitely much better to have many deaf entries in enums. That is why we are trying to kill the constants before 2.6.13 gets released.

Re: [PATCH RFC]: Killing skb-real_dev

2005-07-22 Thread David S. Miller
tree using net-2.6 as a base. diff-tree 261688d01ec07d3a265b8ace6ec68310fbd96a96 (from d3984a6b6abac6203868f0e9095c0ed9e33ece03) Author: David S. Miller [EMAIL PROTECTED] Date: Fri Jul 22 14:43:52 2005 -0700 [PKT_SCHED]: em_meta: Kill TCF_META_ID_{INDEV,SECURITY,TCVERDICT} More

Re: Patch: reduce skb input dev on 64 bit machines

2005-07-24 Thread David S. Miller
From: Jamal Hadi Salim [EMAIL PROTECTED] Date: Sat, 23 Jul 2005 09:32:07 -0400 This is part of mission skb diet. Against git/davem/2.6.14 that was on vger 30 minutes back: It changes input_dev to be an ifindex so we dont bother holding devices. Would only cut a 4 byte fat on 64 bit

Re: SKB tutorial, Blog, and NET TODO

2005-07-24 Thread David S. Miller
From: Jamal Hadi Salim [EMAIL PROTECTED] Date: Sat, 23 Jul 2005 10:14:52 -0400 Setting the skb-prio to be used by the driver sounds reasonable. Another alternative would be what was already mentioned to change the call to hardware_start_transmit() to take a prio option. The driver should take

Re: SKB tutorial, Blog, and NET TODO

2005-07-24 Thread David S. Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Mon, 25 Jul 2005 03:24:37 +0200 * David S. Miller [EMAIL PROTECTED] 2005-07-24 18:08 The next issue is how to demultiplex from the number of prios we want, to what the hardware actually supports if the latter is smaller. That's what I meant

Re: [PATCH] reduce netfilte sk_buff enlargement

2005-07-24 Thread David S. Miller
From: Marcel Holtmann [EMAIL PROTECTED] Date: Sat, 23 Jul 2005 03:36:20 +0200 If you are serious with the shrinking of the sk_buff, I can send you the final patch along with my pending patches for 2.6.13. Please do. The pkt_type change would get queued for 2.6.14, and please only send real

Re: Patch: reduce skb input dev on 64 bit machines

2005-07-24 Thread David S. Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Sat, 23 Jul 2005 16:29:42 +0200 I think we should head for a 16bit ifindex at some point or is there any reason why 65K interfaces wouldn't be sufficient? I think we are locked into using s32 for this. I can definitely imagine virtual interfaces that

Re: Patch: reduce skb input dev on 64 bit machines

2005-07-25 Thread David S. Miller
From: Jamal Hadi Salim [EMAIL PROTECTED] Date: Mon, 25 Jul 2005 09:50:33 -0400 how about we set it in only ing_filter() if it is zero. i.e, if (!skb-input_dev) skb-input_dev = skb-dev-ifindex; - Ok... how about we take this one step further? The idea being: 1)

Re: Patch: reduce skb input dev on 64 bit machines

2005-07-25 Thread David S. Miller
From: Ben Greear [EMAIL PROTECTED] Date: Sun, 24 Jul 2005 23:25:53 -0700 When these other changes go in, is there any chance that we can get support for more than 256 routing tables? That can help make all of these virtual interfaces more useful for some of us with strange routing fetishes

Re: Patch: reduce skb input dev on 64 bit machines

2005-07-25 Thread David S. Miller
From: Jamal Hadi Salim [EMAIL PROTECTED] Date: Mon, 25 Jul 2005 09:50:33 -0400 if (!skb-input_dev) skb-input_dev = skb-dev-ifindex; - We get rid of the printk and all other places that set input_dev except for mirred. Any new actions can continue to set it if

Re: [2.6 patch] net/ipv4/: possible cleanups

2005-07-25 Thread David S. Miller
From: Adrian Bunk [EMAIL PROTECTED] Date: Sun, 24 Jul 2005 00:05:30 +0200 This patch contains the following possible cleanups: - make needlessly global code static - #if 0 the following unused global function: - xfrm4_state.c: xfrm4_state_fini - remove the following unneeded

Re: Patch: reduce skb input dev on 64 bit machines

2005-07-25 Thread David S. Miller
From: Thomas Graf [EMAIL PROTECTED] Date: Tue, 26 Jul 2005 00:35:05 +0200 We can also use ifindex and hold a reference. We won't access input_dev too often so a __dev_get_by_ifindex() won't be too expensive given the number of interfaces is not too big but that's another issue. Since the

Re: [2.6 patch] fix ip_conntrack_put prototype

2005-07-26 Thread David S. Miller
From: Adrian Bunk [EMAIL PROTECTED] Date: Tue, 26 Jul 2005 16:56:59 +0200 The function is not inline. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] Applied, thanks Adrian. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH] possible overflow of sock-sk_policy

2005-07-26 Thread David S. Miller
From: Herbert Xu [EMAIL PROTECTED] Subject: Re: [PATCH] possible overflow of sock-sk_policy Date: Tue, 26 Jul 2005 13:07:14 +1000 Balazs Scheidler [EMAIL PROTECTED] wrote: While reading through the xfrm code I've found a possible array overflow in struct sock. Thanks for catching this.

Re: [PATCH] rename skb_ip_make_writable() to skb_make_writable()

2005-07-26 Thread David S. Miller
From: Harald Welte [EMAIL PROTECTED] Date: Tue, 26 Jul 2005 17:20:53 +0200 Rename skb_ip_make_writable() to skb_make_writable() since there is nothing IPv4-specific in it. In fact, it was already used by IPv6, too... Upcoming nfnetlink_queue code will use it for any kind of packet.

Re: [PATCH] move ip[6]_queue rerouting up to nf_queue

2005-07-26 Thread David S. Miller
From: Harald Welte [EMAIL PROTECTED] Date: Tue, 26 Jul 2005 18:45:05 +0200 please apply. If you dislike the yet-another-NPROTO nature of it, I'll prepare one with kmalloc-at-startup. Please do, thanks. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message

Re: [PATCH] add netlink module refcounting

2005-07-26 Thread David S. Miller
From: Harald Welte [EMAIL PROTECTED] Date: Sat, 23 Jul 2005 16:15:52 -0400 The attached patch adds support for refcounting of modules implementing netlink protocols. The idea is that you prevent the module from disappearing as long as someone in userspace has still a socket talking to you.

Re: [PATCH] move ip[6]_queue rerouting up to nf_queue

2005-07-26 Thread David S. Miller
From: Harald Welte [EMAIL PROTECTED] Date: Wed, 27 Jul 2005 01:52:23 +0200 I'll also prepare a modified version of the nfnetlink module refcounting patch, but I'm not submitting it until you've applied ll of the other pending netfilter patches since they would conflict (re-attached the other

Re: [PATCH] move ip[6]_queue rerouting up to nf_queue

2005-07-26 Thread David S. Miller
From: Harald Welte [EMAIL PROTECTED] Date: Wed, 27 Jul 2005 01:52:23 +0200 See attached file 12-queue-reroute.patch.2. All patches applied to net-2.6.14, thanks Harald. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [2.6 patch] NETCONSOLE must depend on INET

2005-07-26 Thread David S. Miller
From: Matt Mackall [EMAIL PROTECTED] Date: Tue, 26 Jul 2005 19:36:37 -0700 [sch added to cc: as I think he's the effective pktgen maintainer] No, that would be Robert Olsson. Move in_aton from net/ipv4/utils.c to net/core/utils.c Fair enough. - To unsubscribe from this list: send the line

killing skb-h

2005-07-26 Thread David S. Miller
So people don't think that I'm doing nothing but sleeping today :-) I gave a shot yesterday and today to kill this off, but it really can't be done easily in one fell swoop, and there are real issues to resolve. So I'll work on this in stages. First I'll get rid of the most trivial uses of

Re: 2.6.13-rc3-mm2

2005-07-27 Thread David S. Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Wed, 27 Jul 2005 14:11:51 -0700 Unbalanced netlink_table_ungrab() in the netlink stuff in git-net.patch. Applied to net-2.6.14, thanks Andrew. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH 2.6.13rc3] IPv6: Check interface bindings on IPv6 raw socket reception

2005-07-27 Thread David S. Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Sun, 24 Jul 2005 07:39:12 +0200 [IPV4/6]: Check if packet was actually delivered to a raw socket to decide whether to send an ICMP unreachable Signed-off-by: Patrick McHardy [EMAIL PROTECTED] Applied, thanks Patrick. - To unsubscribe from this

Re: [2.6 patch] NETCONSOLE must depend on INET

2005-07-27 Thread David S. Miller
From: Matt Mackall [EMAIL PROTECTED] Date: Tue, 26 Jul 2005 19:36:37 -0700 # HG changeset patch # User [EMAIL PROTECTED] # Node ID 6cdd6f36d53678a016cfbf5ce667cbd91504d538 # Parent 75716ae25f9d87ee2a5ef7c4df2d8f86e0f3f762 Move in_aton from net/ipv4/utils.c to net/core/utils.c This patch

Re: [PATCH 2.6 1/5] tg3: Add basic register access function pointers

2005-07-27 Thread David S. Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Wed, 27 Jul 2005 23:44:51 -0400 In x86-based CPUs at least (the largest tg3 platform), branch prediction often prefers if (...) direct_func_1() else direct_func_2() to tp-func() Indirect

Re: [PATCH 2.6 1/5] tg3: Add basic register access function pointers

2005-07-27 Thread David S. Miller
From: Michael Chan [EMAIL PROTECTED] Date: Wed, 27 Jul 2005 22:33:32 -0700 But with so many different workaround methods (TG3_FLAG_MBOX_WRITE_REORDER, TG3_FLAG_TXD_MBOX_HWBUG, TG3_FLG2_ICH_WORKAROUND, TG3_FLAG_5701_REG_WRITE_BUG, etc), it's more like: if (...)

Re: [patch 2.6.13-rc3] ethtool: add generic ethtool_op_get_perm_addr routine

2005-07-28 Thread David S. Miller
From: John W. Linville [EMAIL PROTECTED] Date: Thu, 28 Jul 2005 15:47:02 -0400 On Thu, Jul 28, 2005 at 12:38:53PM -0700, David S. Miller wrote: Probably it is better to define the ethtool object returned to the user as some kind of TLV, so the size doesn't matter. Can you point Jon

raw socket ICMP change buggy

2005-07-28 Thread David S. Miller
Patrick, I think some parts of this change: [IPV4/6]: Check if packet was actually delivered to a raw socket to decide whether to send an ICMP unreachable might be buggy and create SKB refcount problems. Andrew Morton was seeing all kinds of weird problems and we narrowed it down to this

Re: [RFC] Zero-copy sniffer. Reincarnation #1. Numbers.

2005-07-29 Thread David S. Miller
From: Evgeniy Polyakov [EMAIL PROTECTED] Date: Fri, 29 Jul 2005 20:55:06 +0400 Unmapping is repeatedly being done in this driver - update_address() and tlb_flush() does the thing. Current code does skb freeing when it's slot needs to be used for the next skb. So this numbers already include

RSS blog feed

2005-07-29 Thread David S. Miller
Many asked for it, so I spent the better part of today putting it together, here it is: http://vger.kernel.org/~davem/cgi-bin/blog.cgi/index.rss to get the normal HTML version the new URL is http://vger.kernel.org/~davem/cgi-bin/blog.cgi/index.html If you try to go to the old URL, it'll just

Re: raw socket ICMP change buggy

2005-07-30 Thread David S. Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Fri, 29 Jul 2005 16:27:02 +0200 I double-checked, but couldn't find any problems in this patch. Do these problems occur with IPv4 or IPv6? False alarm, it turns out it was likely due to some bogus change an x86_64 merge introduced into the -mm

Re: [PATCH] add refcounting and /proc to nfnetlink_queue

2005-07-30 Thread David S. Miller
From: Harald Welte [EMAIL PROTECTED] Date: Sat, 30 Jul 2005 12:32:26 +0200 [NETFILTER] Add refcounting and /proc/net/netfilter interface to nfnetlink_queue Signed-off-by: Harald Welte [EMAIL PROTECTED] Applied, thanks Harald. - To unsubscribe from this list: send the line

Re: [RFC PATCH] convert ebt_ulog to nfnetlink_log

2005-07-30 Thread David S. Miller
From: Harald Welte [EMAIL PROTECTED] Date: Sat, 30 Jul 2005 13:03:53 +0200 attached is a patch that converts ebt_ulog to use the generic logging mechanism (and thus be able to use the nfnetlink_log backend). This patch breaks userspace compatibility, since the netlink message format of

Re: [PATCH 1/3][SOCK] Rename __tcp_v4_rehash to __sk_prot_rehash

2005-07-30 Thread David S. Miller
From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo) Date: Thu, 28 Jul 2005 13:15:23 -0300 Please consider pulling from: rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14-2.git All pulled, three comments: 1) Consider renaming sk_setup_caps() to __sk_setup_caps() since

Re: Resend: [RFC/PATCH] safer ipv4 reassembly

2005-07-31 Thread David S. Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Sun, 31 Jul 2005 17:17:56 +1000 On Sat, Jul 30, 2005 at 11:44:55PM -0700, David S. Miller wrote: I wish I could come up with a sane way to use the inetpeer cache to store this info. Unfortunately we need to key on address _and_ ID. However

Re: [EMAIL PROTECTED]: Re: weird sysctl behaviour]

2005-07-31 Thread David S. Miller
This is way many global+per-device sysctls work in the networking. The global setting is the default unless the per-device value is set, in which case it overrides the global value. Changing the global value does not change the per-device values. - To unsubscribe from this list: send the line

Re: Resend: [RFC/PATCH] safer ipv4 reassembly

2005-07-31 Thread David S. Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Mon, 1 Aug 2005 00:13:59 +1000 Anyway, here is a patch to use inetpeer instead of that icky ipc structure. It sure cuts down the size of the patch :) Yes, that is so much nicer. - To unsubscribe from this list: send the line unsubscribe netdev in the

Re: Resend: [RFC/PATCH] safer ipv4 reassembly

2005-07-31 Thread David S. Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Mon, 1 Aug 2005 08:33:00 +1000 Actually that reminds me, we better add some accounting stuff so that we know that it is being used. I agree. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED]

Re: 2.6.13-rc4 - kernel panic - BUG at net/ipv4/tcp_output.c:918

2005-07-31 Thread David S. Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Mon, 1 Aug 2005 09:03:14 +1000 I suspect that the MSS stored in the skb disagrees with the mss_now. So when tso_fragment chops it up we end up with a TSO count that's greater than what we started with. Oh yes, that would bolix things up. If we get a

Re: [Bugme-new] [Bug 4952] New: IPSec incompabilty. Linux kernel waits to long to start using new SA for outbound traffic.

2005-07-31 Thread David S. Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Mon, 1 Aug 2005 14:30:46 +1000 Well the problem is that the kernel simply doesn't have the information to selectively flush dst's given a new SA. All it can do is flush out all cached dst entries when a new SA is added. Because SA changes are

Re: [PATCH][INET] Move the TCP hashtable functions/structs to inet_hashtables.[ch]

2005-07-31 Thread David S. Miller
From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo) Date: Mon, 1 Aug 2005 02:10:30 -0300 rsync://rsync.kernel.org/pub/scm/linux/kernel/git/acme/net-2.6.14-2.git All pulled, thanks Arnaldo. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [RFC,PATCH] Idea to speedup tcp lookups

2005-08-03 Thread David S. Miller
From: Eric Dumazet [EMAIL PROTECTED] Date: Tue, 02 Aug 2005 23:45:27 +0200 Please move kmem_cache_t *bind_bucket_cachep; in a better place, not just after spinlock_t portalloc_lock; [ Eric, I haven't had time to respond to this thread because I'm in the UK for UKUUG2005 this week, so email

Re: [Bugme-new] [Bug 4952] New: IPSec incompabilty. Linux kernel waits to long to start using new SA for outbound traffic.

2005-08-03 Thread David S. Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Wed, 3 Aug 2005 21:36:59 +1000 On Sun, Jul 31, 2005 at 10:03:05PM -0700, David S. Miller wrote: When an SA changes, we walk that assosciated policies DST list marking them -obsolete Yes this should work but it's missing one important detail

Re: [Bugme-new] [Bug 4952] New: IPSec incompabilty. Linux kernel waits to long to start using new SA for outbound traffic.

2005-08-04 Thread David S. Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Thu, 4 Aug 2005 07:32:15 +1000 On Wed, Aug 03, 2005 at 06:34:38AM -0700, David S. Miller wrote: Therefore, when any SA is added, the assosciated policy is the one for which we flush all matching DST entries. How do you find the associated policy

Re: [PATCH] add new nfnetlink_log subsystem

2005-08-04 Thread David S. Miller
From: Andi Kleen [EMAIL PROTECTED] Subject: Re: [PATCH] add new nfnetlink_log subsystem Date: Thu, 4 Aug 2005 00:19:41 +0200 no, it hasn't. I am travelling and don't have the space for a debian/i386 installation in addition to the debian/x86_64 on this box, sorry :( That sounds risky. I

Re: Super TSO performance drop

2005-08-04 Thread David S. Miller
From: Leonid Grossman [EMAIL PROTECTED] Date: Wed, 3 Aug 2005 21:07:56 -0400 We can either provide a remote to the setup, or test incremental patches if #16 can be broken in smaller pieces. I think it would be more productive for you to work on trying to figure out what about the packet

Re: Super TSO performance drop

2005-08-05 Thread David S. Miller
From: Leonid Grossman [EMAIL PROTECTED] Date: Thu, 4 Aug 2005 16:10:30 -0400 I'm not sure there is anything specific about ntttcp packet patterns, it's a generic tcp benchmark... We did not try iperf or netperf, but typically these programs perform extremely close to ntttcp numbers. I'm not

Re: [TCP]: Fix TSO cwnd caching bug

2005-08-05 Thread David S. Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Fri, 5 Aug 2005 10:57:41 +1000 OK, here is the final version. It depends on the patch that David posted earlier on in this thread. Please let me know if you need a copy of that. [TCP]: Fix TSO cwnd caching bug Good catch Herbert :) - To

Re: oops with 2.6.13-rc5 on webserver with raid

2005-08-05 Thread David S. Miller
From: Andrew Morton [EMAIL PROTECTED] Subject: Fw: oops with 2.6.13-rc5 on webserver with raid Date: Fri, 5 Aug 2005 03:20:41 -0700 Did we fix this today? Yeah, looks like the same exact oops trace. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to

Re: [BUG?]memory leakage in fib_create_info()?

2005-08-05 Thread David S. Miller
From: Yan Zheng [EMAIL PROTECTED] Date: Fri, 05 Aug 2005 22:27:11 +0800 Kernel: linux-2.6.12.3 Keywords: IPv4 Forwarding Information Base Function fib_create_info(in net/ipv4/fib_semantics.c) do not free memory used by old hash table after enlarge fib_info hash table. Is this a bug? give

Re: lockups with netconsole on e1000 on media insertion

2005-08-05 Thread David S. Miller
From: Steven Rostedt [EMAIL PROTECTED] Date: Fri, 05 Aug 2005 10:27:06 -0400 Darn it, since this should really be reported. Yes, the core netpoll should bail out, but it is also a problem with the driver and should be fixed. I don't get how you can even remotely claim this to be a problem

Re: [PATCH] ctnetlink: fix list traversal order

2005-08-05 Thread David S. Miller
From: Harald Welte [EMAIL PROTECTED] Date: Fri, 5 Aug 2005 18:26:50 +0200 [NETFILTER] fix list traversal order in ctnetlink Applied. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] ctnetlink: fix typo in ctnl_exp_cb array

2005-08-05 Thread David S. Miller
From: Harald Welte [EMAIL PROTECTED] Date: Fri, 5 Aug 2005 18:21:42 +0200 [NETFILTER] Fix typo in ctnl_exp_cb array (no bug, just memory waste) Applied. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] ctnetlink: fix conntrack expect refcount leak

2005-08-05 Thread David S. Miller
From: Harald Welte [EMAIL PROTECTED] Date: Fri, 5 Aug 2005 18:28:20 +0200 [NETFILTER] fix conntrack refcount leak in unlink_expect() Applied. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: assertion (cnt = tp-packets_out) failed

2005-08-05 Thread David S. Miller
From: John Bäckstrand [EMAIL PROTECTED] Date: Fri, 05 Aug 2005 17:53:11 +0200 KERNEL: assertion (cnt = tp-packets_out) failed at net/ipv4/tcp_input.c (1476) I suspect this is a side effect of some changes Herbert Xu and myself did to fix some other bugs. Herbert, I think there are serious

Re: critical section violation in tg3.c?

2005-08-06 Thread David S. Miller
Simply do the pci_save_state before the register_netdev() call, no need to mess around with the locking. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: test

2005-08-06 Thread David S. Miller
From: Daniel Phillips [EMAIL PROTECTED] Date: Sat, 6 Aug 2005 04:52:07 +1000 So then there is no choice but to throttle the per-cpu -input_pkt queues. Make the driver support NAPI if you want device fairness. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a

Re: [PATCH 6/6][INET] Generalise tcp_v4_lookup_listener

2005-08-06 Thread David S. Miller
All pulled, as well as your dccp-2.6.14 tree, into net-2.6.14 It should show up on the kernel.org mirrors shortly. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1][INET] Make inet_create try to load protocol modules

2005-08-06 Thread David S. Miller
From: [EMAIL PROTECTED] (Arnaldo Carvalho de Melo) Date: Sat, 6 Aug 2005 10:01:05 -0300 + /* Be more specific, e.g. net-pf-2-132-1 (net-pf-PF_INET-IPPROTO_SCTP-SOCK_STREAM) */ + if (++try_loading_module == 1) +

Re: [PATCH 2.6 6/5] tg3: Fix bug in setting a tg3_flag

2005-08-06 Thread David S. Miller
Michael, I've added all 6 patches to my net-2.6.14 tree. It should show up on the kernel.org GIT mirrors shortly. I decided against sticking this into 2.6.13, as these changes can introduce regressions and the space of users effected by this problem is decidedly small compared to how many could

Re: assertion (cnt = tp-packets_out) failed

2005-08-06 Thread David S. Miller
From: Herbert Xu [EMAIL PROTECTED] Date: Sat, 6 Aug 2005 17:57:17 +1000 Hang on a second, the original poster mentioned rc5. Is this really pristine rc5 with the one netpoll patch? If so then it can't be the patches we're talking about because they only went in days later. This seems to be

Re: [PATCH] Fix erroneous ICMP corruption with iptable_nat and NOTRACK

2005-08-08 Thread David S. Miller
From: Harald Welte [EMAIL PROTECTED] Date: Mon, 8 Aug 2005 11:50:55 +0200 DaveM is probably travelling back from UKUUG at the moment and therefore wasn't able to push this fix to you. I'm actually back and operational as of this morning :-) I'll push this stuff to Linus later today. So

  1   2   3   4   5   6   7   8   9   10   >