the dirty pointer always by 4 is just
not enough, e.g. KGDBoE managed to stuff 20+ extra buffers into the queue) --
place it before the loop and limit the loop to only look through 4 descriptors
at most, so that already overwritten descriptors are just not counted.
Signed-off-by: Sergei Shtylyov
-by: Sergei Shtylyov [EMAIL PROTECTED]
Jeff, do you have any opinion on this patch?
The out-of-sync dirty pointer check is leftover boilerplate, and not
really indicative of anything except for some code to be removed.
As for the other stuff, I would say fix the caller. We don't need to
hack
Hello.
Adrian Bunk wrote:
3x59x-fix-pci-resource-management.patch causes the following compile
error with CONFIG_PCI=n:
-- snip --
...
CC drivers/net/3c59x.o
/home/bunk/linux/kernel-2.6/linux-2.6.20-rc4-mm1/drivers/net/3c59x.c: In
function 'vortex_init_one':
consecutive MAC
addresses to match those that are printed on their stickers.
Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED]
diff --git a/drivers/net/au1000_eth.c b/drivers/net/au1000_eth.c
index 1363083..d5dfc78 100644
--- a/drivers/net/au1000_eth.c
+++ b/drivers/net/au1000_eth.c
@@ -2,7 +2,7
Ensure that 8-bit mode is selected for the on-board Realtek RTL8019AS chip
on Toshiba RBHMA4x00, get rid of the duplicate #ifdef's when setting
ei_status.word16.
The chip's datasheet says that the PSTOP register shouldn't exceed 0x60 in
8-bit mode -- ensure this too.
Signed-off-by: Sergei
Hello, you wrote:
This patch completes the NAPI functionality for SB1250 MAC, including making
NAPI a kernel option that can be turned on or off and adds the sbmac_poll
routine.
Index: linux-2.6.14-cgl/drivers/net/Kconfig
CONFIG_NETPOLL_RX option completely since there is *no* code depending on it.
Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED]
---
drivers/net/Kconfig |5 -
include/linux/netdevice.h |8 +++-
2 files changed, 3 insertions(+), 10 deletions(-)
Index: linux-2.6/include/linux
bypassing TX softirq wakeup and
remove
CONFIG_NETPOLL_RX option completely since there is *no* code depending
on it.
Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED]
ACK but (a) DaveM not me should apply this,
Oops, sorry. But he's only mentioned as IPv4/v6 maintainer. :-)
and (b) I would
always by 4 is just
not enough, e.g. KGDBoE managed to stuff 20+ extra buffers into the queue) --
place it before the loop and limit the loop to only look through 4 descriptors
at most, so that already overwritten descriptors are just not counted.
Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED
Hello.
Amit S. Kale wrote:
This driver's 4-packet deep TX queue is too sensible to the careless
callers ignoring its state (like netpoll in trapped mode), so add queue
full check at the start of the hard_start_xmit() method (only under
#ifndef RTL8139_NDEBUG, otherwise the queue will get stuck
CONFIG_NETPOLL_RX option completely since there is *no* code depending on it.
Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED]
---
I wonder can I expect any motion with this patch (at least denial :-)?
drivers/net/Kconfig |5 -
include/linux/netdevice.h |8 +++-
2 files
Hello.
Matt Mackall wrote:
CONFIG_NETPOLL_TRAP causes the TX queue controls to be completely bypassed in
the netpoll's trapped mode which easily causes overflows in the drivers with
short TX queues (most notably, in 8139too with its 4-deep queue).
Make this option more sensible by only
wakeup.
Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED]
---
Split this part form the initial patch as request by Matt Mackall.
include/linux/netdevice.h |8 +++-
2 files changed, 3 insertions(+), 10 deletions(-)
Index: linux-2.6/include/linux/netdevice.h
Get rid of the CONFIG_NETPOLL_RX option completely since all the dependencies
have been removed long ago...
Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED]
---
See commit e3c265bcf67f21d847e970e71504890f61f37824 in tglx/history.git for the
patch that removed the #ifdef's.
drivers/net/Kconfig
sensible by making it only bypass the TX
softirq wakeup.
Dammit! Finally forgot to add acks earned so far:
Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED]
Acked-by: Jeff Garzik [EMAIL PROTECTED]
Acked-by: Matt Mackall [EMAIL PROTECTED]
---
Split this part form the initial patch as request
On Saturday 28 April 2007 22:48, Sergei Shtylyov wrote:
Get rid of the CONFIG_NETPOLL_RX option completely since all the
dependencies have been removed long ago...
Same here:
Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED]
Acked-by: Jeff Garzik [EMAIL PROTECTED]
Acked-by: Matt Mackall
sensible by making it only
bypass the TX softirq wakeup.
Dammit! Finally forgot to add acks earned so far:
Oh, and there was even another one:
Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED]
Acked-by: Jeff Garzik [EMAIL PROTECTED]
Acked-by: Tom Rini [EMAIL PROTECTED]
Acked
at it, also clarify/cleanup debug messages in gfar_error()...
Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED]
---
The patch survived netperf stressing on MPC8540ADS realtime kernel. :-)
drivers/net/gianfar.c | 85 --
1 files changed, 15
inconsistencies between the two.
So, make the gfar_interrupt() just call gfar_error(), and not acknowledge
the interrupts itself as gfar_{receive/transmit/error}() do it anyway.
While at it, also clarify/cleanup debug messages in gfar_error()...
Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED
at it, also clarify/cleanup debug messages in gfar_error()...
Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED]
---
The patch survived netperf stressing on MPC8540ADS realtime kernel. :-)
Sorry, forgot to remove the obsolete regs argument from gfar_error() call,
call, so the previous version wasn't
Hello, I wrote:
3x59x-fix-pci-resource-management.patch causes the following compile
error with CONFIG_PCI=n:
-- snip --
...
CC drivers/net/3c59x.o
/home/bunk/linux/kernel-2.6/linux-2.6.20-rc4-mm1/drivers/net/3c59x.c:
In function 'vortex_init_one':
Hello.
Sergei Shtylyov wrote:
3x59x-fix-pci-resource-management.patch causes the following compile
error with CONFIG_PCI=n:
-- snip --
...
CC drivers/net/3c59x.o
/home/bunk/linux/kernel-2.6/linux-2.6.20-rc4-mm1/drivers/net/3c59x.c:
In function 'vortex_init_one':
/home/bunk
Hello.
Stephen Hemminger wrote:
This thread came up on kgdb-bugreport mailing list. Could you please suggest
us what's the correct way of fixing this problem?
1. When running a kgdb on RTL8139 ethernet interface: 8139too driver prints
too many Out-of-sync dirty pointer messages on console
Stephen Hemminger wrote:
This thread came up on kgdb-bugreport mailing list. Could you please suggest
us what's the correct way of fixing this problem?
1. When running a kgdb on RTL8139 ethernet interface: 8139too driver prints
too many Out-of-sync dirty pointer messages on console and gdb
Hello, I wrote:
3x59x-fix-pci-resource-management.patch causes the following compile
error with CONFIG_PCI=n:
-- snip --
...
CC drivers/net/3c59x.o
/home/bunk/linux/kernel-2.6/linux-2.6.20-rc4-mm1/drivers/net/3c59x.c:
In function 'vortex_init_one':
komal wrote:
Hi all,
As the discussion was going on about the effects of trapping the
netpoll queue during KGDBoE debugging, I tried avoiding it. So in
eth_pre_exception_handler() I did not set net_poll_trap to 1 and did not
reset it back to 0 in eth_post_exception_handler()
file
register being cleared
by a simple read and the interrpupt handler simply storing it, not accumulating.
Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED]
---
drivers/net/natsemi.c | 24 +++-
1 files changed, 19 insertions(+), 5 deletions(-)
Index: linux-2.6/drivers/net/natsemi.c
Hello.
Greg KH wrote:
3x59x-fix-pci-resource-management.patch causes the following compile
error with CONFIG_PCI=n:
-- snip --
...
CC drivers/net/3c59x.o
/home/bunk/linux/kernel-2.6/linux-2.6.20-rc4-mm1/drivers/net/3c59x.c:
In function 'vortex_init_one':
Hello.
Mark Huth wrote:
#ifdef CONFIG_NET_POLL_CONTROLLER
static void natsemi_poll_controller(struct net_device *dev)
{
+ struct netdev_private *np = netdev_priv(dev);
+
disable_irq(dev-irq);
- intr_handler(dev-irq, dev);
+
+ /*
+ * A real interrupt might have already
.
Oversized packets occur only at high volume? Is it some errata?
Subject: natsemi: Fix NAPI for interrupt sharing
To: Jeff Garzik [EMAIL PROTECTED]
Cc: Sergei Shtylyov [EMAIL PROTECTED], Simon Blake [EMAIL PROTECTED], John
Philips [EMAIL PROTECTED], netdev@vger.kernel.org
The interrupt status
Hello, I wrote:
Subject: natsemi: Fix NAPI for interrupt sharing
To: Jeff Garzik [EMAIL PROTECTED]
Cc: Sergei Shtylyov [EMAIL PROTECTED], Simon Blake
[EMAIL PROTECTED], John Philips [EMAIL PROTECTED],
netdev@vger.kernel.org
The interrupt status register for the natsemi chips is clear
the netpoll hook and
improves the trace for interrupt events.
Thanks to Sergei Shtylyov [EMAIL PROTECTED] for spotting the
issue, Mark Huth [EMAIL PROTECTED] for a simpler method and Simon
Blake [EMAIL PROTECTED] for testing resources.
Signed-Off-By: Mark Brown [EMAIL PROTECTED]
Index: linux
Hello.
Mark Brown wrote:
Moving netdev_rx() would fix that one but there's some others too -
there's one in the timer routine if the chip crashes. In the case you
Erm, sorry, I'm not seeing it -- could you point with finger please?
:-)
In netdev_timer() when the device is using
Hello, I wrote:
This thread came up on kgdb-bugreport mailing list. Could you please
suggest us what's the correct way of fixing this problem?
1. When running a kgdb on RTL8139 ethernet interface: 8139too driver
prints too many Out-of-sync dirty pointer messages on console and
gdb can't
Hello, I wrote:
This thread came up on kgdb-bugreport mailing list. Could you please
suggest us what's the correct way of fixing this problem?
1. When running a kgdb on RTL8139 ethernet interface: 8139too driver
prints too many Out-of-sync dirty pointer messages on console and
gdb can't
Hello.
Deepak Saxena wrote:
NETPOLL support for Sibyte MAC
Index: linux-2.6.18/drivers/net/sb1250-mac.c
===
--- linux-2.6.18.orig/drivers/net/sb1250-mac.c
+++ linux-2.6.18/drivers/net/sb1250-mac.c
@@ -1128,6 +1128,26 @@ static
Hello.
Atsushi Nemoto wrote:
NETPOLL support for Sibyte MAC
Signed-off-by: Manish Lachwani [EMAIL PROTECTED]
Signed-off-by: Deepak Saxena [EMAIL PROTECTED]
If you added NETPOLL support, do not forget to ensure hard_start_xmit
routine callable from interrupt context (or irq disabled).
See
.
As this is the only case of the must_free_region flag being set,
this flag may go away as well...
Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED]
I agree you have identified a bug, but this is not a solution.
The current driver bug is that it calls request_region() potentially
Hello.
Jeff Garzik wrote:
3x59x-fix-pci-resource-management.patch
Now that the fix for CONFIG_PCI=n has been merged, what's left is to test
this on EISA (at least Andrew wanted it :-).
netdev patches which are stuck in limbo land.
? I don't think I've seen these.
You should
Hello.
Andrew Morton wrote:
3x59x-fix-pci-resource-management.patch: you wrote it ;) I have a comment
No, I did, almost a year ago already. :-)
here:
- I don't remember the story with cardbus either. Presumably once upon a
time the cardbus layer was claiming IO regions on behalf
Hello.
Anton Vorontsov wrote:
This patch adds netpoll support for the QE UCC Gigabit Ethernet
driver. The approach is very similar to the gianfar driver.
It's rather contrarywise -- this is standard approach and gianfar with its
3 TSEC IRQs has a quite non-standard poll_controller()
Hello.
On 04/21/2015 08:53 PM, Vitaly E. Lavrov wrote:
tc filter show does not show last U32 filter on 32-bit systems (tested on
x86).
Additional condition: filter does not have action and CONFIG_NET_CLS_ACT=y
Example: tc filter add dev eth0 parent 1:0 protocol ip prio 100 u32 match ip
Hello.
On 4/20/2015 8:57 AM, Baolin Wang wrote:
This patch introduces the 'struct itimerspec64' for 64bit to replace itimerspec,
and also introduces the conversion methods: itimerspec64_to_itimerspec() and
itimerspec_to_itimerspec64(), that makes itimerspec to ready for 2038 year.
To not
Hello.
On 04/25/2015 06:59 PM, Joe Perches wrote:
Remove braces from a few if statements where not required.
trivia:
diff --git a/net/ipv6/netfilter/ip6_tables.c b/net/ipv6/netfilter/ip6_tables.c
[]
@@ -151,9 +151,8 @@ ip6_packet_match(const struct sk_buff *skb,
Hello.
On 4/23/2015 10:17 PM, Murali Karicheri wrote:
Currently when interface type is MAC to Phy, netif_carrier_(on/off)
is called which is not needed as Phy lib already updates the carrier
status to net stack. This is needed only for other interface types
Signed-off-by: Murali Karicheri
On 04/24/2015 12:03 PM, David Laight wrote:
Sent: 22 April 2015 22:39
On 04/22/2015 11:42 PM, David Miller wrote:
Hmm, I've been digging in the net core, and was unable to see where TX
skb's get their NET_IP_ALIGN bytes reserved. Have I missed something?
Probably need to print
On 04/24/2015 06:56 PM, Florian Fainelli wrote:
Some systems using mdio-gpio may use gpio on message based busses, which
require sleeping (e.g. gpio from an I2C I/O expander).
Since this driver does not use IRQ handler, it is safe to use the
_cansleep suffixed gpio accessors.
On 04/24/2015 06:18 PM, Murali Karicheri wrote:
Currently when interface type is MAC to Phy, netif_carrier_(on/off)
is called which is not needed as Phy lib already updates the carrier
status to net stack. This is needed only for other interface types
Signed-off-by: Murali Karicheri
On 04/24/2015 08:36 PM, Florian Fainelli wrote:
Some systems using mdio-gpio may use gpio on message based busses,
which
require sleeping (e.g. gpio from an I2C I/O expander).
Since this driver does not use IRQ handler, it is safe to use the
_cansleep suffixed gpio accessors.
Hello.
On 04/22/2015 11:42 PM, David Miller wrote:
Hmm, I've been digging in the net core, and was unable to see where TX
skb's get their NET_IP_ALIGN bytes reserved. Have I missed something?
Probably need to print out skb's fields...
NET_IP_ALIGN is for receive, not transmit.
On 04/23/2015 01:41 AM, David Miller wrote:
Sigh... I'm seeing no way out of that then, only copying. :-(
What exactly is the device's restriction?
The frame data must be aligned on 32-bit boundary.
Any reasonable modern chip allows one of two things.
Either it allows
On 04/22/2015 11:42 PM, David Miller wrote:
Hmm, I've been digging in the net core, and was unable to see where TX
skb's get their NET_IP_ALIGN bytes reserved. Have I missed something?
Probably need to print out skb's fields...
NET_IP_ALIGN is for receive, not transmit.
But
On 04/23/2015 01:18 AM, David Miller wrote:
Hmm, I've been digging in the net core, and was unable to see where TX
skb's get their NET_IP_ALIGN bytes reserved. Have I missed something?
Probably need to print out skb's fields...
NET_IP_ALIGN is for receive, not transmit.
On 4/23/2015 1:08 PM, Jia-Ju Bai wrote:
I am very sorry to trouble you.
I find that resource management is error-prone when writing Linux drivers,
and
many problems may occur, such as resource leaks.
Meanwhile, I find that many applied patches in the kernel mailing list focus
on releasing
Hello.
On 04/22/2015 06:36 PM, David Miller wrote:
+ if (!ravb_tx_free(ndev, q)) {
+ netif_warn(priv, tx_queued, ndev, TX FD exhausted.\n);
+ netif_stop_queue(ndev);
+ spin_unlock_irqrestore(priv-lock, flags);
+
Hello.
On 04/14/2015 03:49 AM, Lino Sanfilippo wrote:
+struct ravb_desc {
+#ifdef __LITTLE_ENDIAN
+ u32 ds: 12; /* Descriptor size */
+ u32 cc: 12; /* Content control */
+ u32 die: 4; /* Descriptor interrupt enable */
+ /* 0: disable, other:
On 04/23/2015 02:22 AM, Florian Fainelli wrote:
[...]
+if (ecmd-duplex == DUPLEX_FULL)
+priv-duplex = 1;
+else
+priv-duplex = 0;
Why not use what priv-phydev-duplex has cached for you?
Because we compare 'priv-duplex' with 'priv-phydev-duplex' in
Hello.
On 5/1/2015 6:11 AM, Alexei Starovoitov wrote:
improves ingress+u32 performance from 22.4 Mpps to 22.9 Mpps
Signed-off-by: Jamal Hadi Salim j...@mojatatu.com
Signed-off-by: Alexei Starovoitov a...@plumgrid.com
---
The code is from Jamal. I only did testing and benchmarking.
Then
Hello.
On 04/28/2015 04:14 AM, K. Y. Srinivasan wrote:
Commit commit b08cc79155fc26d0d112b1470d1ece5034651a4b eliminated memory
One commit is enough. :-)
And please also specify that commit's summary in parens.
allocation in the packet send path. This commit introduced a bug since it
Hello.
On 04/16/2015 09:38 PM, Vivien Didelot wrote:
Since commit da4759c, sysfs will only use the permissions returned by
Please also specify that commit's summary line in parens.
is_visible, instead of OR'ing them with the default file mode.
This allows us to declare temp1_max with
Hello.
On 4/15/2015 7:51 AM, Jeff Kirsher wrote:
From: Jesse Brandeburg jesse.brandeb...@intel.com
The init_interrupt_scheme function had a possible failure
path to allocate memory that was found by smatch.
This adds the correct handling to the function to abort
probe if the memory
On 06/09/2015 01:19 AM, David Miller wrote:
Furthermore, you should pass the NAPI context into ravb_rx() and use
I guess I should have one NAPI context per RX queue?
Yes.
Thanks, done.
it so that you can invoke napi_gro_receive() on all of the packets and
therefore support GRO.
Hello.
On 06/04/2015 06:12 AM, David Miller wrote:
+ /* Received network control queue */
+ if (ris0 RIS0_FRF1) {
+ ravb_write(ndev, ~RIS0_FRF1, RIS0);
+ /* Timestamp of network control packets that is based
+
Hello.
On 06/05/2015 10:55 PM, Jaeden Amero wrote:
Link failures have been observed when using the KSZ9031 with HP 1810-8G
and HP 1910-8G network switches. Center the FLP timing at 16ms to help
avoid intermittent link failures.
From the KSZ9031RNX and KSZ9031MNX data sheets revision 2.2,
by Mitsuhiro Kimura.
Signed-off-by: Mitsuhiro Kimura mitsuhiro.kimura...@renesas.com
Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com
---
This patch is against David Miller's 'net-next.git' repo.
Changes in version 5:
- switched to calling multiqueue APIs, implementing ndo_select_queue
, so when that
one leaves the operation mode, we have to unregister the PTP clock... :-(
Based on the original patches by Masaru Nagai.
Signed-off-by: Masaru Nagai masaru.nagai...@renesas.com
Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com
---
This patch is against David Miller's
Hello.
It would have been good if you didn't add other errors while fixing. :-)
s/grammer/grammar/ in the subject.
WBR, Sergei
--
To unsubscribe from this list: send the line unsubscribe netdev in
the body of a message to majord...@vger.kernel.org
More majordomo info at
Hello.
On 06/23/2015 09:26 PM, Thomas F Herbert wrote:
Signed-off-by: Thomas F Herbert thomasfherb...@gmail.com
[...]
diff --git a/include/linux/if_vlan.h b/include/linux/if_vlan.h
index 920e445..3713454 100644
--- a/include/linux/if_vlan.h
+++ b/include/linux/if_vlan.h
@@ -627,5 +627,14 @@
Hello.
On 6/18/2015 3:49 AM, Taku Izumi wrote:
This patch adds epstop_task.
This task is used to process other receiver's
cancellation request.
Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com
---
drivers/platform/x86/fjes/fjes_hw.c | 34 ++
Hello.
On 6/18/2015 3:49 AM, Taku Izumi wrote:
This patch adds net_device_ops.ndo_tx_timeout callback.
Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com
---
drivers/platform/x86/fjes/fjes_main.c | 9 +
1 file changed, 9 insertions(+)
diff --git
Hello.
On 6/18/2015 3:49 AM, Taku Izumi wrote:
This patch adds net_device_ops.ndo_get_stats64 callback.
Signed-off-by: Taku Izumi izumi.t...@jp.fujitsu.com
---
drivers/platform/x86/fjes/fjes_main.c | 14 ++
1 file changed, 14 insertions(+)
diff --git
Hello.
On 6/18/2015 12:53 AM, sfel...@gmail.com wrote:
From: Scott Feldman sfel...@gmail.com
Signed-off-by: Scott Feldman sfel...@gmail.com
---
include/linux/netdevice.h |7 +++
net/switchdev/switchdev.c |8 ++--
2 files changed, 9 insertions(+), 6 deletions(-)
diff
Hello.
Here's the set of 3 patches against Marc Kleine-Budde's 'linux-can.git'
repo; they are small fixes for the Renesas R-Car CAN driver.
rcar_can: fix IRQ check
rcar_can: print signed IRQ #
rcar_can: fix typo in error message
WBR, Sergei
--
To unsubscribe from this list: send the line
Hello.
Here's the set of 2 patches against Marc Kleine-Budde's 'linux-can.git'
repo plus 3 fix patches just posted; they are small error message cleanups for
the Renesas R-Car CAN driver.
[1/2] rcar_can: print request_irq() error code
[2/2] rcar_can: unify error messages
WBR, Sergei
--
To
All the error messages in the driver but the ones from devm_clk_get() failures
use similar format. Make those two messages consitent with others.
Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com
---
drivers/net/can/rcar_can.c |5 +++--
1 file changed, 3 insertions(+), 2
request_irq() with a negative IRQ #, and that
function naturally fails with -EINVAL.
Check for the negative error codes instead and propagate them upstream instead
of just returning -ENODEV.
Fixes: fd1159318e55 (can: add Renesas R-Car CAN driver)
Signed-off-by: Sergei Shtylyov sergei.shtyl
Also print the error code when the request_irq() call fails in rcar_can_open(),
rewording the error message...
Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com
---
drivers/net/can/rcar_can.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Index: linux-can/drivers
-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com
---
drivers/net/can/rcar_can.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Index: linux-can/drivers/net/can/rcar_can.c
===
--- linux-can.orig/drivers/net/can
Fix typo in the first error message printed by rcar_can_open().
Based on the original patch by Vladimir Barinov.
Fixes: 862e2b6af941 (can: rcar_can: support all input clocks)
Reported-by: Vladimir Barinov vladimir.bari...@cogentembedded.com
Signed-off-by: Sergei Shtylyov sergei.shtyl
change the message, why don't you make it consistent
(interrupt vs. IRQ)?
I decided to change the message in a follow-up patch (posted afterwards).
Fixes: fd1159318e55 (can: add Renesas R-Car CAN driver)
Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com
[...]
Gr{oetje,eeting
Hello.
On 6/20/2015 7:02 PM, Marc Kleine-Budde wrote:
Printing IRQ # using %x and %u unsigned formats isn't quite correct as
'ndev-irq' is of type *int*, so the %d format needs to be used instead.
While fixing this, beautify the dev_info() message in rcar_can_probe() a bit.
If you
Hello.
On 06/25/2015 03:19 PM, Yuval Mintz wrote:
20g-capable devices are not configured properly for self-test, using
10g as their speed which cause the link indication to remain down and
fail the internal loopback test.
Signed-off-by: Yuval Mintz yuval.mi...@qlogic.com
Signed-off-by:
Hello.
On 06/24/2015 05:32 PM, Dan Carpenter wrote:
We need to unlock before returning here.
Indeed. Sorry about missing that.
Fixes: a0d2f20650e8 ('Renesas Ethernet AVB PTP clock driver')
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
Acked-by: Sergei Shtylyov sergei.shtyl
.
Unfortunately, the clock seems tightly coupled with the AVB-DMAC, so when that
one leaves the operation mode, we have to unregister the PTP clock... :-(
Based on the original patches by Masaru Nagai.
Signed-off-by: Masaru Nagai masaru.nagai...@renesas.com
Signed-off-by: Sergei Shtylyov sergei.shtyl
, so when that
one leaves the operation mode, we have to unregister the PTP clock... :-(
Based on the original patches by Masaru Nagai.
Signed-off-by: Masaru Nagai masaru.nagai...@renesas.com
Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com
---
This patch is against David Miller's
by Mitsuhiro Kimura.
Signed-off-by: Mitsuhiro Kimura mitsuhiro.kimura...@renesas.com
Signed-off-by: Sergei Shtylyov sergei.shtyl...@cogentembedded.com
---
This patch is against David Miller's 'net-next.git' repo.
Changes in version 6:
- switched to also handling the network control RX/TX queues via NAPI
On 6/16/2015 4:47 PM, Jeff Kirsher wrote:
From: Jacob Keller jacob.e.kel...@intel.com
The value will never be negative, and we use the %i print format, use
%i is the same as %d, AFAIR. You need %u for the unsigned variables.
unsigned int for the loop counter. Issue found using
On 6/16/2015 4:47 PM, Jeff Kirsher wrote:
From: Jacob Keller jacob.e.kel...@intel.com
This patch cleans up the use of dma_get_required_mask and uses the
simpler dma_set_mask_and_coherent function instead of doing these as
separate steps.
I removed the dma_get_required_mask call because
Hello.
On 6/16/2015 4:47 PM, Jeff Kirsher wrote:
From: Jacob Keller jacob.e.kel...@intel.com
Fix up error message style to include a colon.
Signed-off-by: Jacob Keller jacob.e.kel...@intel.com
Tested-by: Krishneil Singh krishneil.k.si...@intel.com
Signed-off-by: Jeff Kirsher
Hello.
On 6/15/2015 4:52 PM, Scott Feldman wrote:
From: Scott Feldman sfel...@gmail.com
skb-fwd_mark and dev-fwd_mark are 32-bit and should be unique for device
and maybe even unique for a sub-set of ports within device, so add
switchdev helper function to generate unique marks based on
Hello.
On 06/16/2015 10:10 PM, Julien Grall wrote:
Append 0x to all %x in order to avoid while reading when there is other
decimal value in the log.
Also replace some of the hexadecimal print to decimal to uniformize the
format with netfront.
Signed-off-by: Julien Grall
Hello.
On 06/17/2015 01:09 AM, Joe Perches wrote:
Append 0x to all %x in order to avoid while reading when there is other
decimal value in the log.
[]
@@ -874,7 +874,7 @@ static inline void xenvif_grant_handle_set(struct
xenvif_queue *queue,
if
Hello.
On 6/17/2015 12:07 AM, Willem de Bruijn wrote:
From: Willem de Bruijn will...@google.com
PACKET_FANOUT_LB computes f-rr_cur such that it is modulo
f-num_members. It returns the old value unconditionally, but
f-num_members may have changed since the last store. This can be
fixed with
Hello.
On 06/12/2015 04:30 PM, Pankaj Gupta wrote:
Macvtap should be compatible with tuntap for maximum number
of queues. '1059590254fa9dce9cafc4f07d1103dbec415e76' removes
Please also specify that commit's summary line in parens.
the limitation and increases number of queues in tuntap.
Hello.
On 05/28/2015 06:41 PM, Or Gerlitz wrote:
From: Matan Barak mat...@mellanox.com
When freeing a CQ, we need to make sure there are no
asynchronous events (on the ASYNC EQ) that could
relate to this CQ before freeing it.
This is done by introducing synchronize_irq.
Signed-off-by:
Hello.
On 06/01/2015 07:34 PM, Shawn Bohrer wrote:
From: Shawn Bohrer sboh...@rgmadvisors.com
421b3885bf6d56391297844f43fb7154a6396e12 udp: ipv4: Add udp early
demux introduced a regression that allowed sockets bound to INADDR_ANY
to receive packets from multicast groups that the socket had
Hello.
On 5/28/2015 1:00 PM, Wang Long wrote:
Remove automatic variable 'err' in register_netevent_notifier() and
return the return value of atomic_notifier_chain_register() directly.
s/return value/result/, in order to avoid tautology.
Signed-off-by: Wang Long long.wangl...@huawei.com
Hello.
On 5/28/2015 2:25 PM, Jeff Kirsher wrote:
From: John Fastabend john.r.fastab...@intel.com
The ring_cookie is 64 bits wide which is much larger than can be used
for actual queue index values. So provide some helper routines to
pack a VF index into the cookie. This is useful to steer
Hello.
On 05/29/2015 11:04 PM, Josh Hunt wrote:
I came across this problem while trying to use UDP encapsulation with IPv6. The
change below fixes that, but it was not immediately apparent if there are any
other protocols relying on this broken behavior. FWIW the behavior below now
matches
Hello.
On 08/19/2015 03:59 PM, Emmanuel Grumbach wrote:
This allows to release the backpressure on the socket only
when the last segment is released.
Now the truesize looks like this:
if the truesize of the original skb is 65420, all the
segments will have a truesize of 704 (skb itself) and
1 - 100 of 1308 matches
Mail list logo
