Re: [PATCH] netfilter: ipt_MASQUERADE: NULL check in device_cmp [BUG] panic 2.6.20-rc3 in nf_conntrack

2007-01-08 Thread Jarek Poplawski
On Thu, Jan 04, 2007 at 02:51:55PM +0100, Jarek Poplawski wrote: Hello, Below I attach a patch proposal. It seems I wasted some time... I wonder if there is any reason to forward netfilter bugs to netdev if patches from netfilter aren't cc-d here? It seems netfilter is really independent

Re: [PATCH/RFC 00/10] Transparent proxying patches version 4

2007-01-08 Thread Harald Welte
On Sun, Jan 07, 2007 at 05:11:06PM +0100, Lennert Buytenhek wrote: On Sun, Jan 07, 2007 at 03:11:34PM +0100, Harald Welte wrote: So instead of using NAT to dynamically redirect traffic to local addresses, we now rely on native non-locally-bound sockets and do early socket lookups for

Re: [PATCH][RFC] tcp: fix ambiguity in the `before' relation

2007-01-08 Thread Gerrit Renker
| Since the old definition is not used in the way before(x, y) !before(y, x), but rather in the | fashion before(x, y) or after(y, x), the main advantage of the new definition is that it makes | this type of use a safe case. | | This is not true because | | if (before(x, y)) |

RE: [git patches] net driver fixes

2007-01-08 Thread Li Yang-r58472
Hi Jeff, Could you apply the updates for ucc_geth driver? The patches from Timur that make the driver compile correctly on 2.6.20. [PATCH] Fix phy_read/write redefinition errors in ucc_geth_phy.c [PATCH] Update ucc_geth.c for new workqueue structure The patch from Ahmed that cleans up some

Re: [git patches] net driver fixes

2007-01-08 Thread Jeff Garzik
Li Yang-r58472 wrote: Hi Jeff, Could you apply the updates for ucc_geth driver? The patches from Timur that make the driver compile correctly on 2.6.20. [PATCH] Fix phy_read/write redefinition errors in ucc_geth_phy.c [PATCH] Update ucc_geth.c for new workqueue structure The patch from Ahmed

[git patches] net driver fixes

2007-01-08 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/netdev-2.6.git upstream-linus to receive the following updates: drivers/net/e1000/e1000_main.c |6 drivers/net/ixgb/ixgb.h |1 + drivers/net/ixgb/ixgb_ethtool.c |1 +

Re: [PATCH] INET: fix incorrect inet_sock-is_icsk assignment

2007-01-08 Thread Jarek Poplawski
On 04-01-2007 21:04, Paul Moore wrote: ... +++ net-2.6.20_bugfix_2/net/ipv4/af_inet.c @@ -305,7 +305,7 @@ lookup_protocol: sk-sk_reuse = 1; inet = inet_sk(sk); - inet-is_icsk = INET_PROTOSW_ICSK answer_flags; + inet-is_icsk = (INET_PROTOSW_ICSK answer_flags)

Re: [PATCH] INET: fix incorrect inet_sock-is_icsk assignment

2007-01-08 Thread Paul Moore
On Monday, January 8 2007 8:25 am, Jarek Poplawski wrote: On 04-01-2007 21:04, Paul Moore wrote: +++ net-2.6.20_bugfix_2/net/ipv4/af_inet.c @@ -305,7 +305,7 @@ lookup_protocol: sk-sk_reuse = 1; inet = inet_sk(sk); - inet-is_icsk = INET_PROTOSW_ICSK answer_flags; +

[PATCH]: 8139cp: Don't blindly enable interrupts in cp_start_xmit

2007-01-08 Thread Chris Lalancette
All, Similar to this commit: http://kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=d15e9c4d9a75702b30e00cdf95c71c88e3f3f51e It's not safe in cp_start_xmit to blindly call spin_lock_irq and then spin_unlock_irq, since it may very well be the case that cp_start_xmit

[PATCH 3/5] s390: qeth driver fixes

2007-01-08 Thread Frank Pavlic
[PATCH 3/5] s390: qeth driver fixes From: Frank Blaschka [EMAIL PROTECTED] - qeth device functions were not callable in atomic context due to usage of wait_event_xxx operations in qeth. schedule while atomic message appeared and kernel dumped when removing slave from bond

[PATCH 2/5] s390: qeth driver fixes

2007-01-08 Thread Frank Pavlic
[PATCH 2/5] s390: qeth driver fixes From: Frank Blaschka [EMAIL PROTECTED] - packet socket support is not complete. Recvfrom a packet socket does not fill the sockaddr_ll structure. device function hard_header_parse is not implemented. For layer 2 mode and layer 3 mode with

[PATCH 4/5] s390: iucv Kconfig help description changes

2007-01-08 Thread Frank Pavlic
[PATCH 4/5] s390: iucv Kconfig help description changes From: Ursula Braun [EMAIL PROTECTED] remove text from help description which does not apply anymore for 2.6 kernel series. Signed-off-by: Frank Pavlic [EMAIL PROTECTED] --- drivers/s390/net/Kconfig |5 + 1 files

[PATCH 1/5] s390: qeth driver fixes

2007-01-08 Thread Frank Pavlic
Hi , please apply following 5 patches for s390 network device drivers. Sorry for the fifth patch containing some lines which just remove whitespaces. Another patch will follow in the next couple of days with more whitespace and coding style cleanups in drivers/s390/net. Thank you Frank [PATCH

[PATCH 5/5] s390: qeth driver hardware specs adaptions

2007-01-08 Thread Frank Pavlic
[PATCH 5/5] s390: qeth driver hardware specs adaptions From: Peter Tiedemann [EMAIL PROTECTED] - according to the latest OSA hardware specification incorporate actual IPA command and return codes into qeth. - whitespaces removed from qeth_mpc.h Signed-off-by: Frank Pavlic [EMAIL

Re: BUG: soft lockup detected on CPU#0! (2.6.18.2 plus hacks)

2007-01-08 Thread Ben Greear
Jarek Poplawski wrote: On Fri, Jan 05, 2007 at 12:33:43PM -0800, Ben Greear wrote: ... So, I do believe this was the problem we were hitting, and it seems fixed. Congratulations! But I can see one strange thing in vlan.c: /* Must be invoked with RCU read lock (no preempt) */ static

Question on advanced routing and/or virtual routers.

2007-01-08 Thread Ben Greear
Hello! I am curious if a single machine can be made to look like several routers. Please consider the following configuration: Linux Router-A has 4 ethernet interfaces. PC-A is connected to eth0 and has IP 192.168.0.2. eth0 on Router-A has IP 192.168.0.1/24 eth1 has IP 192.168.1.1/24, and

Re: BUG: soft lockup detected on CPU#0! (2.6.18.2 plus hacks)

2007-01-08 Thread Stephen Hemminger
On Mon, 08 Jan 2007 08:57:10 -0800 Ben Greear [EMAIL PROTECTED] wrote: Jarek Poplawski wrote: On Fri, Jan 05, 2007 at 12:33:43PM -0800, Ben Greear wrote: ... So, I do believe this was the problem we were hitting, and it seems fixed. Congratulations! But I can see one

Re: Question on advanced routing and/or virtual routers.

2007-01-08 Thread Brendan Cully
On Monday, 08 January 2007 at 09:08, Ben Greear wrote: Hello! I am curious if a single machine can be made to look like several routers. Please consider the following configuration: Linux Router-A has 4 ethernet interfaces. PC-A is connected to eth0 and has IP 192.168.0.2. eth0 on

[PATCH 3/3] chelsio: more rx speedup

2007-01-08 Thread Stephen Hemminger
Cleanup receive processing some more: * do the reserve padding of skb during setup * don't pass constants to get_packet * do smart prefetch of skb * make copybreak a module parameter Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/chelsio/sge.c | 87

[PATCH 2/3] chelsio: NAPI speed improvement

2007-01-08 Thread Stephen Hemminger
Speedup and cleanup the receive processing by eliminating the mmio read and a lock round trip. Signed-off-by: Stephen Hemminger [EMAIL PROTECTED] --- drivers/net/chelsio/sge.c | 77 -- 1 file changed, 35 insertions(+), 42 deletions(-) ---

Re: d80211: How does TX flow control work?

2007-01-08 Thread Jan Kiszka
Jan Kiszka wrote: Jan Kiszka wrote: Jiri Benc wrote: On Wed, 03 Jan 2007 19:10:01 +0100, Jan Kiszka wrote: BUG: warning at /usr/src/rt2x00/rt2x00/ieee80211/ieee80211.c:1256/ieee80211_tx() cfa02245 ieee80211_master_start_xmit+0x105/0x430 [80211] c024e35d __ip_ct_refresh_acct+0x4d/0x60

Re: [PATCH/RFC 00/10] Transparent proxying patches version 4

2007-01-08 Thread KOVACS Krisztian
Hi Evgeniy, On Wednesday 03 January 2007 18:23, Evgeniy Polyakov wrote: Out of curiosity, would you use netchannels [1] if the implementation will be much broader? Since what you have created works exactly like netchannels netfilter NAT target (although it does not change ports, but it can

wireless-dev updated (sync w/ 2.6.20-rc3 + lots of new stuff)

2007-01-08 Thread John W. Linville
Lots of wireless-dev activity around the holidays...still catching-up... I got stuff compiling, so I thought I'd push it out. John --- The following changes since commit 3622152cf1ed4613addde30bce9cd9f71d17efa2: John W. Linville (1): Merge branch 'from-linus' are found in the git

[BNX2 1/4]: Don't apply CRC PHY workaround to 5709.

2007-01-08 Thread Michael Chan
[BNX2]: Don't apply CRC PHY workaround to 5709. The workaround is only needed on 5706/5708 and cannot be applied on 5709. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index ada5e9b..8d682fc 100644 --- a/drivers/net/bnx2.c +++

[BNX2 2/4]: Fix 5709 Serdes detection.

2007-01-08 Thread Michael Chan
[BNX2]: Fix 5709 Serdes detection. 5709 has a new register to detect copper/fiber PHYs. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c index 8d682fc..e325f93 100644 --- a/drivers/net/bnx2.c +++ b/drivers/net/bnx2.c @@ -5643,6 +5643,44 @@

[BNX2 3/4]: Fix bug in bnx2_nvram_write().

2007-01-08 Thread Michael Chan
[BNX2]: Fix bug in bnx2_nvram_write(). The bug was a bogus pointer being passed to kfree(). The pointer was incremented in the write loop and then passed to kfree(). The fix is to use align_buf to save the original address. Signed-off-by: Michael Chan [EMAIL PROTECTED] diff --git

[PACKET]: Add optional checksum computation for recvmsg

2007-01-08 Thread Herbert Xu
Hi Dave: [PACKET]: Add optional checksum computation for recvmsg This patch is needed to make ISC's DHCP server (and probably other DHCP servers/clients using AF_PACKET) to be able to serve another client on the same Xen host. The problem is that packets between different domains on the same

[PATCH] ucc_geth: kmalloc casting cleanups

2007-01-08 Thread Li Yang
From: Ahmed S. Darwish [EMAIL PROTECTED] Switch kmalloc to kzalloc and clean some redundant kmalloc casts. Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED] Signed-off-by: Li Yang [EMAIL PROTECTED] --- diff --git a/drivers/net/ucc_geth.c b/drivers/net/ucc_geth.c index 8243150..0f58f5f 100644

Re: [GIT][Netlabel] Pull request

2007-01-08 Thread David Miller
From: James Morris [EMAIL PROTECTED] Date: Mon, 8 Jan 2007 18:24:41 -0500 (EST) The following changes since commit bf81b46482c0fa8ea638e409d39768ea92a6b0f0: Linus Torvalds: Linux 2.6.20-rc4 are found in the git repository at:

Re: [BNX2 1/4]: Don't apply CRC PHY workaround to 5709.

2007-01-08 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Mon, 08 Jan 2007 15:56:21 -0800 [BNX2]: Don't apply CRC PHY workaround to 5709. The workaround is only needed on 5706/5708 and cannot be applied on 5709. Signed-off-by: Michael Chan [EMAIL PROTECTED] Applied. - To unsubscribe from this list:

Re: [BNX2 2/4]: Fix 5709 Serdes detection.

2007-01-08 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Mon, 08 Jan 2007 15:56:31 -0800 [BNX2]: Fix 5709 Serdes detection. 5709 has a new register to detect copper/fiber PHYs. Signed-off-by: Michael Chan [EMAIL PROTECTED] Applied. - To unsubscribe from this list: send the line unsubscribe netdev in

Re: [BNX2 3/4]: Fix bug in bnx2_nvram_write().

2007-01-08 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Mon, 08 Jan 2007 15:56:48 -0800 [BNX2]: Fix bug in bnx2_nvram_write(). The bug was a bogus pointer being passed to kfree(). The pointer was incremented in the write loop and then passed to kfree(). The fix is to use align_buf to save the

Re: [BNX2 4/4]: Update version and reldate.

2007-01-08 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Mon, 08 Jan 2007 16:04:24 -0800 Sorry, the date was wrong on the one sent earlier. [BNX2]: Update version and reldate. Update version to 1.5.3. Signed-off-by: Michael Chan [EMAIL PROTECTED] :-) Applied. - To unsubscribe from this list: send

Re: [TG3]: Add PHY workaround for 5755M.

2007-01-08 Thread David Miller
From: Michael Chan [EMAIL PROTECTED] Date: Mon, 08 Jan 2007 15:58:00 -0800 [TG3]: Add PHY workaround for 5755M. Some PHY trim values need to be fine-tuned on 5755M to be IEEE-compliant. Update version to 3.72. Signed-off-by: Michael Chan [EMAIL PROTECTED] Applied, thanks Michael. - To

Re: [PATCH] forcedeth: sideband management fix

2007-01-08 Thread Jeff Garzik
Ayaz Abdulla wrote: This patch contains a fix that implements proper communication with the sideband management unit. Also, it makes sure that the speed is correctly set for gigabit phys in the case where sideband mgmt unit initialized the phy. Refer to bug #7684 for more details.

Re: [PATCH] ucc_geth: kmalloc casting cleanups

2007-01-08 Thread Jeff Garzik
Li Yang wrote: From: Ahmed S. Darwish [EMAIL PROTECTED] Switch kmalloc to kzalloc and clean some redundant kmalloc casts. Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED] Signed-off-by: Li Yang [EMAIL PROTECTED] --- I should wait for Kumar to resend ucc_geth fixes before applying this,

Re: [PATCH 1/5] s390: qeth driver fixes

2007-01-08 Thread Jeff Garzik
Frank Pavlic wrote: Hi , please apply following 5 patches for s390 network device drivers. Sorry for the fifth patch containing some lines which just remove whitespaces. Another patch will follow in the next couple of days with more whitespace and coding style cleanups in drivers/s390/net.

RE: [PATCH] ucc_geth: kmalloc casting cleanups

2007-01-08 Thread Li Yang-r58472
-Original Message- From: Jeff Garzik [mailto:[EMAIL PROTECTED] Sent: Tuesday, January 09, 2007 3:16 PM To: Li Yang-r58472 Cc: netdev@vger.kernel.org; [EMAIL PROTECTED] Subject: Re: [PATCH] ucc_geth: kmalloc casting cleanups Li Yang wrote: From: Ahmed S. Darwish [EMAIL PROTECTED]

[take31 6/10] kevent: Pipe notifications.

2007-01-08 Thread Evgeniy Polyakov
Pipe notifications. diff --git a/fs/pipe.c b/fs/pipe.c index 68090e8..0c75bf1 100644 --- a/fs/pipe.c +++ b/fs/pipe.c @@ -16,6 +16,7 @@ #include linux/uio.h #include linux/highmem.h #include linux/pagemap.h +#include linux/kevent.h #include asm/uaccess.h #include asm/ioctls.h @@ -313,6

[take31 8/10] kevent: Kevent posix timer notifications.

2007-01-08 Thread Evgeniy Polyakov
Kevent posix timer notifications. Simple extensions to POSIX timers which allows to deliver notification of the timer expiration through kevent queue. Example application posix_timer.c can be found in archive on project homepage. Signed-off-by: Evgeniy Polyakov [EMAIL PROTECTED] diff --git

[take31 5/10] kevent: Timer notifications.

2007-01-08 Thread Evgeniy Polyakov
Timer notifications. Timer notifications can be used for fine grained per-process time management, since interval timers are very inconvenient to use, and they are limited. This subsystem uses high-resolution timers. id.raw[0] is used as number of seconds id.raw[1] is used as number of

[take31 1/10] kevent: Description.

2007-01-08 Thread Evgeniy Polyakov
Description. diff --git a/Documentation/kevent.txt b/Documentation/kevent.txt new file mode 100644 index 000..95cb36e --- /dev/null +++ b/Documentation/kevent.txt @@ -0,0 +1,244 @@ +Description. + +int kevent_init(struct kevent_ring *ring, unsigned int ring_size, + unsigned int

[take31 7/10] kevent: Signal notifications.

2007-01-08 Thread Evgeniy Polyakov
Signal notifications. This type of notifications allows to deliver signals through kevent queue. One can find example application signal.c on project homepage. If KEVENT_SIGNAL_NOMASK bit is set in raw_u64 id then signal will be delivered only through queue, otherwise both delivery types are

[PATCH] X.25 Add missing sock_put in x25_receive_data

2007-01-08 Thread ahendry
__x25_find_socket does a sock_hold. This adds a missing sock_put in x25_receive_data. Signed-off-by: Andrew Hendry [EMAIL PROTECTED] --- linux-2.6.19-vanilla/net/x25/x25_dev.c 2006-12-31 22:31:07.0 +1100 +++ linux-2.6.19/net/x25/x25_dev.c 2007-01-06 16:40:54.0 +1100

Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer

2007-01-08 Thread YOSHIFUJI Hideaki / 吉藤英明
In article [EMAIL PROTECTED] (at Thu, 4 Jan 2007 14:23:30 +0200), Craig Schlenter [EMAIL PROTECTED] says: On Fri, Jan 05, 2007 at 05:45:46AM +0900, Komuro wrote: Hi, I made a patch below. With this patch, the ftp-transfer-stop problem does not happen. Therefore, I think this is not a

RE: [PATCH 2.6.20-rc3] UCC Ether driver: kmalloc casting cleanups

2007-01-08 Thread Li Yang-r58472
-Original Message- From: Ahmed S. Darwish [mailto:[EMAIL PROTECTED] Sent: Saturday, January 06, 2007 9:19 PM To: Li Yang-r58472 Cc: linux-kernel@vger.kernel.org Subject: [PATCH 2.6.20-rc3] UCC Ether driver: kmalloc casting cleanups [Please inform me if you are not the maintaner

[PATCH] Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer

2007-01-08 Thread Craig Schlenter
Hi Dave YOSHIFUJI Hideaki / 吉藤英明 has suggested that I send the patch below to fix the ftp stalls present in the current kernels. All credit goes to Komuro [EMAIL PROTECTED] for tracking this down. The patch is untested but it looks *cough* obviously correct. Signed-off-by: Craig Schlenter

Re: [PATCH] Re: [BUG KERNEL 2.6.20-rc1] ftp: get or put stops during file-transfer

2007-01-08 Thread YOSHIFUJI Hideaki / 吉藤英明
Dave, please apply. Thank you. In article [EMAIL PROTECTED] (at Tue, 9 Jan 2007 07:11:39 +0200), Craig Schlenter [EMAIL PROTECTED] says: All credit goes to Komuro [EMAIL PROTECTED] for tracking this down. The patch is untested but it looks *cough* obviously correct. Signed-off-by: Craig

2.6.20-rc4: known regressions with patches (v2)

2007-01-08 Thread Adrian Bunk
This email lists some known regressions in 2.6.20-rc4 compared to 2.6.19 with patches available. If you find your name in the Cc header, you are either submitter of one of the bugs, maintainer of an affectected subsystem or driver, a patch of you caused a breakage or I'm considering you in any