Re: [PATCH] net, swap: Remove a warning and clarify why sk_mem_reclaim is required when deactivating swap

/ . Don't email: a href=mailto:d...@kvack.org; em...@kvack.org /a -- Leon Romanovsky | Independent Linux Consultant www.leon.nu | l...@leon.nu -- To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v9 08/22] IB/hns: Add icm support

On Wed, Jun 01, 2016 at 11:37:50PM +0800, Lijun Ou wrote: > This patch mainly added icm support for RoCE. It initializes icm > which managers the relative memory blocks for RoCE. The data > structures of RoCE will be located in it. For example, CQ table, > QP table and MTPT table so on. I wonder

Re: [PATCH v9 05/22] IB/hns: Add initial profile resource

On Wed, Jun 01, 2016 at 11:37:47PM +0800, Lijun Ou wrote: > This patch mainly configured some profile resoure. For example, > vendor_id, hardware version, and some data structure sizes so on. > > Signed-off-by: Wei Hu > Signed-off-by: Nenglong Zhao

Re: [PATCH v9 09/22] IB/hns: Add hca support

On Wed, Jun 01, 2016 at 11:37:51PM +0800, Lijun Ou wrote: > This patch mainly setup hca for RoCE. It will do a series of > initial works, as follows: > 1. init uar table, allocate uar resource > 2. init pd table > 3. init cq table > 4. init mr table > 5. init qp table > >

Re: [PATCH v8 10/22] IB/hns: Add process flow to init RoCE engine

On Wed, May 25, 2016 at 11:05:13PM +0800, Lijun Ou wrote: > This patch mainly initialized the RoCE engine. It is absolutely > necessary to run RoCE. It mainly includes that configure DMAE > user, initialize doorbell and raq operations, enable port. > > Signed-off-by: Wei Hu

Re: [GIT PULL] Please Pull Mellanox Shared Code

On Mon, Jun 13, 2016 at 03:03:01PM +0300, Leon Romanovsky wrote: > Hi Doug and David, > > This is Mellanox mlx5_core shared code for both net-next and RDMA > trees for 4.8 kernel cycle. > > This mlx5_ifc update introduces following ConnectX-4 features.

[for-next 0/1] [pull request] Mellanox ConnectX-4 Shared Code

Hi Doug and Dave, This is Mellanox mlx5_core shared code for both net-next and RDMA trees for 4.8 kernel cycle. This mlx5_ifc update introduces following ConnectX-4 features. * netdev part: - MLX5_CQ_PERIOD_NUM_MODES for adaptive moderation support - QoS rate limiting - SQ context rate

Re: [GIT PULL] Please Pull Mellanox Shared Code

On Tue, Jun 14, 2016 at 02:12:49AM -0400, David Miller wrote: > > A bare pull request does not work. > > You must post the actual patches so that they can be reviewed > properly. Sorry, It was first time attempt to get the sense for the proper procedure. I will send the patch as a reply to

[PATCH for-next 1/1] {net,IB}/mlx5: mlx5_ifc updates

upport IB. Signed-off-by: Saeed Mahameed <sae...@mellanox.com> Signed-off-by: Leon Romanovsky <leo...@mellanox.com> Signed-off-by: Leon Romanovsky <l...@kernel.org> --- include/linux/mlx5/mlx5_ifc.h | 275 -- 1 file changed, 263 insertions(+

[for-next 0/1] [pull request] Mellanox ConnectX-4 Shared Code

Hi Doug and Dave, This is Mellanox mlx5_core shared code for both net-next and RDMA trees for 4.8 kernel cycle. This mlx5_ifc update introduces following ConnectX-4 features. * netdev part: - MLX5_CQ_PERIOD_NUM_MODES for adaptive moderation support - QoS rate limiting - SQ context rate

Re: [PATCH v9 11/22] IB/hns: Add IB device registration

On Sun, Jun 12, 2016 at 05:41:06PM +0800, Wei Hu (Xavier) wrote: > > > On 2016/6/9 14:26, Leon Romanovsky wrote: > >On Wed, Jun 01, 2016 at 11:37:53PM +0800, Lijun Ou wrote: > >>This patch registered IB device when loaded, and unregistered > >>IB device when rem

Re: [PATCH 1/3] infiniband: rxe: avoid 64-bit division

On Mon, Jun 13, 2016 at 02:54:53PM +0200, Arnd Bergmann wrote: > The rxe driver fails to build on 32-bit because of a 64-bit division: > > In function `rxe_qp_from_attr': > :(.text+0x53158): undefined reference to `__aeabi_uldivmod' > > We can easily avoid this division by converting the

Re: [GIT PULL] Please Pull Mellanox Shared Code

On Tue, Jun 14, 2016 at 01:16:50PM -0400, Doug Ledford wrote: > On 6/14/2016 3:02 AM, David Miller wrote: > > > > Please, just stop right now. > > > > We're not asking for the a huge patch covering the entire pull > > request. > > > > We're asking for you to post a patch series, one per commit,

[GIT PULL] Please Pull Mellanox Shared Code

Hi Doug and David, This is Mellanox mlx5_core shared code for both net-next and RDMA trees for 4.8 kernel cycle. This mlx5_ifc update introduces following ConnectX-4 features. * netdev part: - MLX5_CQ_PERIOD_NUM_MODES for adaptive moderation support - QoS rate limiting - SQ context rate

Re: [PATCH v9 11/22] IB/hns: Add IB device registration

On Wed, Jun 01, 2016 at 11:37:53PM +0800, Lijun Ou wrote: > This patch registered IB device when loaded, and unregistered > IB device when removed. > > Signed-off-by: Wei Hu > Signed-off-by: Nenglong Zhao > Signed-off-by: Lijun Ou

Re: [PATCH v9 03/22] IB/hns: Add initial main frame driver and get cfg info

On Wed, Jun 01, 2016 at 11:37:45PM +0800, Lijun Ou wrote: > This patch mainly added the initial bare main driver. It > could get the relative configure information of net node. > > Signed-off-by: Wei Hu > Signed-off-by: Nenglong Zhao >

Re: [PATCH v10 06/22] IB/hns: Add initial cmd operation

On Tue, Jun 21, 2016 at 06:50:51PM +0800, Wei Hu (Xavier) wrote: > > > On 2016/6/20 21:33, Leon Romanovsky wrote: > >On Thu, Jun 16, 2016 at 10:35:14PM +0800, Lijun Ou wrote: > >>This patch added the operation for cmd, and added some functions > >>for initializin

Re: [PATCH v10 08/22] IB/hns: Add icm support

On Tue, Jun 21, 2016 at 12:37:39PM +0800, Wei Hu (Xavier) wrote: > > > On 2016/6/20 21:04, Leon Romanovsky wrote: > >On Mon, Jun 20, 2016 at 05:48:15PM +0800, Wei Hu (Xavier) wrote: > >> > >>On 2016/6/20 17:27, Leon Romanovsky wrote: > >>>On Mon, Jun

Re: [PATCH v10 06/22] IB/hns: Add initial cmd operation

On Tue, Jun 21, 2016 at 09:01:57PM +0800, Wei Hu (Xavier) wrote: > > > On 2016/6/21 19:28, Leon Romanovsky wrote: > >On Tue, Jun 21, 2016 at 06:50:51PM +0800, Wei Hu (Xavier) wrote: > >> > >>On 2016/6/20 21:33, Leon Romanovsky wrote: > >>>On Thu, Jun

Re: [PATCH v10 08/22] IB/hns: Add icm support

On Thu, Jun 16, 2016 at 10:35:16PM +0800, Lijun Ou wrote: > This patch mainly added icm support for RoCE. It initializes icm > which managers the relative memory blocks for RoCE. The data > structures of RoCE will be located in it. For example, CQ table, > QP table and MTPT table so on. > >

Re: [PATCH v10 08/22] IB/hns: Add icm support

On Mon, Jun 20, 2016 at 12:37:40PM +0800, Wei Hu (Xavier) wrote: > > > On 2016/6/17 17:58, Leon Romanovsky wrote: > >On Thu, Jun 16, 2016 at 10:35:16PM +0800, Lijun Ou wrote: > >>This patch mainly added icm support for RoCE. It initializes icm > >>which ma

Re: [PATCH] mellanox: mlx5: Use logging functions to reduce text ~10k/5%

ges now do not include line #, > but do include the function offset. > > Signed-off-by: Joe Perches <j...@perches.com> As far as I see all these functions are used in error paths, so no implication on performance is expected. And I'm fine with function offsets. Saeed, What do you thi

Re: [PATCH] mellanox: mlx5: Use logging functions to reduce text ~10k/5%

On Thu, Jun 23, 2016 at 08:27:01AM +0300, Leon Romanovsky wrote: > On Wed, Jun 22, 2016 at 11:23:59AM -0700, Joe Perches wrote: > > The logging macros create a bit of duplicated code/text. > > > > Use specialized functions to reduce the duplication. > > > > (def

Re: [PATCH v10 06/22] IB/hns: Add initial cmd operation

On Thu, Jun 16, 2016 at 10:35:14PM +0800, Lijun Ou wrote: > This patch added the operation for cmd, and added some functions > for initializing eq table and selecting cmd mode. > > Signed-off-by: Wei Hu > Signed-off-by: Nenglong Zhao >

Re: [PATCH v10 08/22] IB/hns: Add icm support

On Mon, Jun 20, 2016 at 05:48:15PM +0800, Wei Hu (Xavier) wrote: > > > On 2016/6/20 17:27, Leon Romanovsky wrote: > >On Mon, Jun 20, 2016 at 03:49:24PM +0800, Wei Hu (Xavier) wrote: > >> > >>On 2016/6/20 14:06, Leon Romanovsky wrote: > >>>On Mon, Jun

Re: [PATCH v10 08/22] IB/hns: Add icm support

On Mon, Jun 20, 2016 at 03:49:24PM +0800, Wei Hu (Xavier) wrote: > > > On 2016/6/20 14:06, Leon Romanovsky wrote: > >On Mon, Jun 20, 2016 at 12:37:40PM +0800, Wei Hu (Xavier) wrote: > >> > >>On 2016/6/17 17:58, Leon Romanovsky wrote: > >>>On Thu, Jun

Re: [PATCH v10 01/22] net: hns: Add reset function support for RoCE driver

> --- > PATCH v9/v8/v7: > - No change over PATCH v6 > > PATCH v6: > This fixes the comments given by Leon Romanovsky over the PATCH v5: > Link: https://lkml.org/lkml/2016/5/3/733 > > PATCH v5/v4/v3: > - No change over PATCH v2 > > PATCH v2: > This fixes the comment

Re: [PATCH v10 03/22] IB/hns: Add initial main frame driver and get cfg info

@hisilicon.com> > Signed-off-by: Lijun Ou <ouli...@huawei.com> > --- > PATCH v9: > This fixes comments given by Leon Romanovsky over the PATCH v8: > Link: https://lkml.org/lkml/2016/6/9/56 > > PATCH v8/v7/v6: > - No change over the PATCH v5 > > PATCH v5:

Re: [PATCH v10 05/22] IB/hns: Add initial profile resource

@hisilicon.com> > Signed-off-by: Lijun Ou <ouli...@huawei.com> > --- > PATCH v9: > This fixes the comments given by Leon Romanovsky over the PATCH v8: > Link: https://lkml.org/lkml/2016/6/9/65 > > PATCH v8/v7/v6: > - No change over the PATCH v5 >

Re: [PATCH v10 09/22] IB/hns: Add hca support

5. init qp table > > Signed-off-by: Wei Hu <xavier.hu...@huawei.com> > Signed-off-by: Nenglong Zhao <zhaonengl...@hisilicon.com> > Signed-off-by: Lijun Ou <ouli...@huawei.com> > --- > PATCH v9: > This fixes the comments given by Leon Romanovsky over the PATCH v8

Re: [PATCH v10 04/22] IB/hns: Add RoCE engine reset function

@hisilicon.com> > Signed-off-by: Lijun Ou <ouli...@huawei.com> > --- > PATCH v9/v8: > - No change over the PATCH v7 > > PATCH v7: > This fixes the comments given by Leon Romanovsky over the PATCH v6: > Link: https://lkml.org/lkml/2016/5/3/733 > > PATCH v6:

Re: [PATCH v10 07/22] IB/hns: Add event queue support

On Thu, Jun 16, 2016 at 10:35:15PM +0800, Lijun Ou wrote: > This patch added event queue support for RoCE driver. It is used > for RoCE interrupt. RoCE includes 32 synchronous event irqs, 1 > asynchronous event irq and 1 common overflow irq. > > Signed-off-by: Wei Hu >

Re: [PATCH v10 00/22] Add HiSilicon RoCE driver

On Thu, Jun 16, 2016 at 10:35:08PM +0800, Lijun Ou wrote: > The HiSilicon Network Substem is a long term evolution IP which is > supposed to be used in HiSilicon ICT SoCs. HNS (HiSilicon Network > Sybsystem) also has a hardware support of performing RDMA with > RoCEE. > The driver for HiSilicon

Re: [PATCH 1/2] mlx5: only register devlink when ethernet is available

On Fri, Jun 17, 2016 at 05:02:33PM +0200, Arnd Bergmann wrote: > On Friday, June 17, 2016 5:50:14 PM CEST Saeed Mahameed wrote: > > On Wed, Jun 15, 2016 at 11:50 PM, Arnd Bergmann wrote: > > > On Wednesday, June 15, 2016 7:04:54 PM CEST Saeed Mahameed wrote: > > > Ok, I see. It

Re: [PATCH v10 04/22] IB/hns: Add RoCE engine reset function

On Tue, Jun 28, 2016 at 02:31:41PM +0800, Wei Hu (Xavier) wrote: > > > On 2016/6/27 16:31, oulijun wrote: > >Hi, Leon > >在 2016/6/27 16:01, Leon Romanovsky 写道: > >>On Sat, Jun 25, 2016 at 06:25:37PM +0800, Wei Hu (Xavier) wrote: > >>> > >>>O

Re: [PATCH v10 03/22] IB/hns: Add initial main frame driver and get cfg info

On Sat, Jun 25, 2016 at 06:29:31PM +0800, Wei Hu (Xavier) wrote: > > > On 2016/6/24 19:48, Leon Romanovsky wrote: > >On Thu, Jun 16, 2016 at 10:35:11PM +0800, Lijun Ou wrote: > >>This patch mainly added the initial bare main driver. It > >>could get the relative

Re: [PATCH 2/3] net: hns: add Hisilicon RoCE support

On Mon, Mar 14, 2016 at 09:12:28AM +0800, Yankejian (Hackim Yim) wrote: > > > On 2016/3/12 18:43, Leon Romanovsky wrote: > > On Fri, Mar 11, 2016 at 06:37:10PM +0800, Lijun Ou wrote: > >> It added hns_dsaf_roce_reset routine for roce driver. > >> RoCE is a

Re: [PATCH 1/5] mlx4: add missing braces in verify_qp_parameters

m the > start, as the update_gid() function in the same patch correctly does. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> > Fixes: 54679e148287 ("mlx4: Implement QP paravirtualization and maintain > phys_pkey_cache for smp_snoop") Thanks, looks good. Reviewed-

Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support

On Fri, Mar 11, 2016 at 06:37:09PM +0800, Lijun Ou wrote: > The driver for Hisilicon RoCE is a platform driver. > The driver will support mulitple versions of hardware. Currently only "v1" > for hip06 SOC is supported. > The driver includes two parts: common driver and hardware-specific >

Re: [PATCH 2/3] net: hns: add Hisilicon RoCE support

On Fri, Mar 11, 2016 at 06:37:10PM +0800, Lijun Ou wrote: > It added hns_dsaf_roce_reset routine for roce driver. > RoCE is a feature of hns. > In hip06 SOC, in roce reset process, it's needed to configure > dsaf channel reset,port and sl map info. > > Signed-off-by: Lijun Ou

Re: [PATCH 0/3] infiniband: IB/hns: Hisilicon RoCE support

On Fri, Mar 11, 2016 at 06:37:08PM +0800, Lijun Ou wrote: 1) It is redundant to write "infiniband" and "IB" in one title to mention relevant subsystem, since it is the same. Please take a look on the other submissions here on the list and use similar construction. 2) Please use version number

Re: [RESEND PATCH V4 2/3] IB/hns: Add HiSilicon RoCE driver support

On Tue, Apr 05, 2016 at 03:32:53PM +0800, oulijun wrote: > >> .../infiniband/hw/hisilicon/hns/hns_roce_v1_hw.c | 2832 > >> > >> .../infiniband/hw/hisilicon/hns/hns_roce_v1_hw.h | 985 +++ > > ^^ > > Do you support v1 of

Re: [PATCH for-next 2/2] net/mlx5: Update mlx5_ifc hardware features

On Tue, Apr 12, 2016 at 12:37:34AM +0300, Or Gerlitz wrote: > On Tue, Apr 12, 2016 at 12:24 AM, Saeed Mahameed > wrote: > > On Tue, Apr 12, 2016 at 12:17 AM, Or Gerlitz wrote: > > >> feature --> features > > > Correct, will fix. > > >>> * Add

Re: [PATCH for-next 2/2] net/mlx5: Update mlx5_ifc hardware features

On Tue, Apr 12, 2016 at 08:36:21AM +0300, Or Gerlitz wrote: > Conflicts happens @ all times, life. > ... > > I understand your desire to get it down to zero, but it's not gonna > work, pick another target. Maybe you are right and the time will show, but now we (Saeed, Matan and me) are trying

Re: [PATCH v3 2/3] IB/hns: Add HiSilicon RoCE driver support

On Sat, Mar 19, 2016 at 06:50:57PM +0800, Lijun Ou wrote: > The driver for HiSilicon RoCE is a platform driver. > The driver will support multiple versions of hardware. Currently only "v1" > for hip06 SoC is supported. > The driver includes two parts: common driver and hardware-specific >

Re: [PATCH 1/3] infiniband: IB/hns: add Hisilicon RoCE support

On Wed, Mar 16, 2016 at 11:36:38AM +0100, Jiri Pirko wrote: > >so, I continue to have it. > > I will continue to bash on your odd codingstyle. Please fix it! Jiri, Checkpatch errors is an easiest issue with this patch. It is full of functions without use, unconnected macros and if you replace

Re: call attention to review

On Thu, Mar 24, 2016 at 01:50:30PM +0800, oulijun wrote: > Hi, >I am Lijun Ou. I have sent the PATCH v4 of HiSilicon RoCE driver at March > 22, 2016. > if you are convenient, please help to review. Welcome to give your reviewing. Hi Lijun, Please read whole document which describes how to

Re: [PATCH 0/4] infiniband: hns: Hisilicon RoCE support

On Fri, Mar 04, 2016 at 04:41:13PM +0800, Wei Hu(Xavier) wrote: > The Hisilicon Network Substem(hns) is a long term evolution IP which is > supposed to be used in Hisilicon ICT SoC. RoCE is a feature of hns. > The driver for Hisilicon RoCE engine is a platform driver. > The driver will support

Re: [PATCH 4/4] infiniband: hns: add Hisilicon RoCE support(Kconfig)

On Fri, Mar 04, 2016 at 04:41:17PM +0800, Wei Hu(Xavier) wrote: > This submit add Kconfig. It needs be part of previous patch. > > Signed-off-by: Wei Hu(Xavier) > Signed-off-by: oulijun ^^^.. -- Is this first name or second

Re: [PATCH 1/4] net: hns: add Hisilicon RoCE support(the dependent routine)

Please rewrite your title to be without (...). On Fri, Mar 04, 2016 at 04:41:14PM +0800, Wei Hu(Xavier) wrote: > It added hns_dsaf_roce_reset routine for roce driver. > RoCE is a feature of hns. > In hip06 SOC, in roce reset process, it's needed to configure > dsaf channel reset,port and sl map

Re: [PULL REQUEST] Please pull rdma.git

On Thu, Mar 31, 2016 at 10:18:47PM -0400, David Miller wrote: > From: Leon Romanovsky <l...@leon.nu> > Date: Fri, 1 Apr 2016 02:38:28 +0300 > > > On Wed, Mar 23, 2016 at 09:37:54AM -0400, Doug Ledford wrote: > >> On 03/23/2016 06:57 AM, Leon Romanovsky wrote: > &

Re: [PULL REQUEST] Please pull rdma.git

On Wed, Mar 23, 2016 at 09:37:54AM -0400, Doug Ledford wrote: > On 03/23/2016 06:57 AM, Leon Romanovsky wrote: > > On Sat, Mar 19, 2016 at 02:37:08PM -0700, Linus Torvalds wrote: > >> So the *best* situation would be: > >> > >> - your two groups talk it

Re: [RESEND PATCH V4 2/3] IB/hns: Add HiSilicon RoCE driver support

On Fri, Apr 01, 2016 at 05:21:31PM +0800, Lijun Ou wrote: > The driver for HiSilicon RoCE is a platform driver. > The driver will support multiple versions of hardware. Currently only "v1" > for hip06 SoC is supported. > The driver includes two parts: common driver and hardware-specific >

Re: [PATCH] RDS: sync congestion map updating

o be sent to Dave and applied by him. Is it right? ➜ linus-tree git:(master) ./scripts/get_maintainer.pl -f net/rds/cong.c Santosh Shilimkar <santosh.shilim...@oracle.com> (supporter:RDS - RELIABLE DATAGRAM SOCKETS) "David S. Miller" <da...@davemloft.net> (maintainer:NETWORKING [GENERAL]) netdev@vger.kernel.org (open list:RDS - RELIABLE DATAGRAM SOCKETS) linux-r...@vger.kernel.org (open list:RDS - RELIABLE DATAGRAM SOCKETS) rds-de...@oss.oracle.com (moderated list:RDS - RELIABLE DATAGRAM SOCKETS) linux-ker...@vger.kernel.org (open list) > > Signed-off-by: Wengang Wang <wen.gang.w...@oracle.com> > Signed-off-by: Santosh Shilimkar <santosh.shilim...@oracle.com> Reviewed-by: Leon Romanovsky <l...@leon.nu>

Re: [PATCH net] net/mlx4: Avoid wrong virtual mappings

On Mon, Apr 25, 2016 at 04:34:47PM +0300, Haggai Abramovsky wrote: > -int mlx4_buf_alloc(struct mlx4_dev *dev, int size, int max_direct, > -struct mlx4_buf *buf, gfp_t gfp) > +static int mlx4_buf_direct_alloc(struct mlx4_dev *dev, int size, > + struct

[no subject]

, Doug Ledford Bcc: Subject: Re: [PATCH net] RDMA/nes: don't leak skb if carrier down Reply-To: l...@kernel.org In-Reply-To: <1461529139-28582-1-git-send-email...@strlen.de> On Sun, Apr 24, 2016 at 10:18:59PM +0200, Florian Westphal wrote: >

Re: [PATCH v5 09/21] IB/hns: Add hca support

On Tue, Apr 26, 2016 at 02:34:44PM +0800, oulijun wrote: > On 2016/4/24 15:54, Leon Romanovsky wrote: > > On Sat, Apr 23, 2016 at 06:26:47PM +0800, Lijun Ou wrote: > >> This patch mainly setup hca for RoCE. it will do a series of > >> initial works as follows: &

Re: [PATCH v5 09/21] IB/hns: Add hca support

On Sat, Apr 23, 2016 at 06:26:47PM +0800, Lijun Ou wrote: > This patch mainly setup hca for RoCE. it will do a series of > initial works as follows: > 1. init uar table, allocate uar resource > 2. init pd table > 3. init cq table > 4. init mr table > 5. init qp table

Re: [PATCH v5 00/21] Add HiSilicon RoCE driver

On Sat, Apr 23, 2016 at 06:26:38PM +0800, Lijun Ou wrote: > The HiSilicon Network Substem is a long term evolution IP which is > supposed to be used in HiSilicon ICT SoCs. HNS (HiSilicon Network > Sybsystem) also has a hardware support of performing RDMA with > RoCEE. > The driver for HiSilicon

Re: [PATCH v6 00/21] Add HiSilicon RoCE driver

On Thu, Apr 28, 2016 at 08:09:35PM +0800, Lijun Ou wrote: > The HiSilicon Network Substem is a long term evolution IP which is > supposed to be used in HiSilicon ICT SoCs. HNS (HiSilicon Network > Sybsystem) also has a hardware support of performing RDMA with > RoCEE. > The driver for HiSilicon

Re: [PATCH] i40e: constify i40e_client_ops structure

On Sun, May 01, 2016 at 02:07:23PM +0200, Julia Lawall wrote: > The i40e_client_ops structure is never modified, so declare it as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall <julia.law...@lip6.fr> > Thanks Julia, Reviewed-

Re: [PATCH] Add support for configuring Infiniband GUIDs

On Fri, May 06, 2016 at 10:43:25AM -0500, Eli Cohen wrote: > Add two NLA's that allow configuration of Infiniband node or port GUIDs > by referencing the IPoIB net device set over then physical function. The > format to be used is as follows: > > ip link set dev ib0 vf 0 node_guid

Re: [PATCH v2] net/mlx5_core/health: Remove deprecated create_singlethread_workqueue

ng tasks while disconnecting the driver. > > Signed-off-by: Bhaktipriya Shridhar <bhaktipriy...@gmail.com> > --- > Changes in v2: > -Updated commit description as per the feedback received. > > drivers/net/ethernet/mellanox/mlx5/core/health.c | 7 ++- > 1

Re: [PATCH V2] Add flow control to the portmapper

On Thu, Jul 21, 2016 at 12:42:42PM -0500, Steve Wise wrote: > > > > On Wed, Jul 20, 2016 at 09:47:50PM -0500, Shiraz Saleem wrote: > > > On Tue, Jul 19, 2016 at 08:32:53PM +0300, Leon Romanovsky wrote: > > > > On Tue, Jul 19, 2016 at 09:50:24AM -0500, Shiraz Salee

Re: [PATCH V2] Add flow control to the portmapper

On Fri, Jul 22, 2016 at 10:26:01AM -0500, Shiraz Saleem wrote: > On Thu, Jul 21, 2016 at 08:29:42PM +0300, Leon Romanovsky wrote: > > On Wed, Jul 20, 2016 at 09:47:50PM -0500, Shiraz Saleem wrote: > > > On Tue, Jul 19, 2016 at 08:32:53PM +0300, Leon Romanovsky wrote: > >

Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Tue, Jul 19, 2016 at 10:49:57AM -0700, Joe Perches wrote: > On Tue, 2016-07-19 at 20:26 +0300, Leon Romanovsky wrote: > > On Tue, Jul 19, 2016 at 02:09:25PM +0300, Netanel Belgazal wrote: > > > This is the debugging message interface. > > > https://www.kernel.org/d

Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue

On Thu, Jul 28, 2016 at 01:49:49PM +0530, Bhaktipriya Shridhar wrote: > A dedicated workqueue has been used since the work items are being used > on a memory reclaim path. WQ_MEM_RECLAIM has been set to guarantee forward > progress under memory pressure. > > The workqueue has a single work item.

Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue

On Fri, Jul 29, 2016 at 08:22:37AM -0400, Tejun Heo wrote: > Hello, > > On Thu, Jul 28, 2016 at 12:37:35PM +0300, Leon Romanovsky wrote: > > Did you test this patch? Did you notice the memory reclaim path nature > > of this work? > > The conversion uses WQ_MEM_RECLAIM

Re: [patch v2] net/mlx5: missing error code in esw_create_offloads_fdb_table()

On Wed, Jul 13, 2016 at 02:48:44PM +0300, Dan Carpenter wrote: > We accidentally return success when we had intended to return an error > code. > > Fixes: 69697b6e2086 ('net/mlx5: E-Switch, Add support for the sriov offloads > mode') > Signed-off-by: Dan Carpenter >

Re: [PATCH v11 00/22] Add HiSilicon RoCE driver

On Thu, Jul 14, 2016 at 11:43:59AM +0800, oulijun wrote: > 在 2016/7/2 17:39, Lijun Ou 写道: > > > Hi, Doug & Sean Hefty & Hal Rosenstock > "Hello, I understand that maintainer is dealing with lots of patches not just > mine. Also, I could not see any further review comments from the community. >

Re: [PATCH v11 21/22] IB/hns: Kconfig and Makefile for RoCE module

16/3/22/609 > > PATCH V3: > This fixes the comments given by Leon Romanovsky over the PATCH v2: > Link: https://lkml.org/lkml/2016/3/20/5 > > PATCH v2: > This fixes the comments given by Leon Romanovsky over the PATCH v1: > Link: https://lkml.org/lkml/2016/3/6/94 > Fixes the

Re: [patch v2] net/mlx5: missing error code in esw_create_offloads_fdb_table()

On Wed, Jul 13, 2016 at 11:54:54AM -0600, Jason Gunthorpe wrote: > On Wed, Jul 13, 2016 at 02:48:44PM +0300, Dan Carpenter wrote: > > We accidentally return success when we had intended to return an error > > code. > > > > Fixes: 69697b6e2086 ('net/mlx5: E-Switch, Add support for the sriov > >

Re: [PATCH] net/mlx5_core/health: Remove deprecated create_singlethread_workqueue

On Sat, Jul 16, 2016 at 01:29:20PM +0530, Bhaktipriya Shridhar wrote: > The workqueue health->wq was used as per device private health thread. > This was done so that system error handling could be processed > concurrently. Not exactly, AFAIK it was intended to perform delayed work and not

Re: [PATCH V2] Add flow control to the portmapper

On Mon, Jul 18, 2016 at 02:23:30PM -0500, Shiraz Saleem wrote: > From: Mustafa Ismail > > During connection establishment with a large number of connections, > it is possible that the connection requests might fail. Adding flow > control prevents this failure. Change

Re: [PATCH -next] net/mlx5: Use PTR_ERR_OR_ZERO() to simplify the code

;yongjun_...@trendmicro.com.cn> Thanks, Acked-by: Leon Romanovsky <leo...@mellanox.com> signature.asc Description: Digital signature

Re: [PATCH V2] Add flow control to the portmapper

On Tue, Jul 19, 2016 at 09:50:24AM -0500, Shiraz Saleem wrote: > On Tue, Jul 19, 2016 at 08:40:06AM +0300, Leon Romanovsky wrote: > > > > You are the one user of this new inline function. > > Why don't you directly call to netlink_unicast() in your ibnl_unicast() > >

Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Tue, Jul 19, 2016 at 02:09:25PM +0300, Netanel Belgazal wrote: > > > On 07/15/2016 08:00 AM, Leon Romanovsky wrote: > > On Thu, Jul 14, 2016 at 09:46:14AM +0300, Netanel Belgazal wrote: > >> This is a driver for the ENA family of networking devices. > >> >

Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Fri, Jul 15, 2016 at 08:17:59AM -0700, Benjamin Poirier wrote: > On 2016/07/15 08:00, Leon Romanovsky wrote: > > On Thu, Jul 14, 2016 at 09:46:14AM +0300, Netanel Belgazal wrote: > > > This is a driver for the ENA family of networking devices. > > > > > > S

Re: [patch] net/mlx5: missing error code in esw_create_offloads_fdb_table()

On Wed, Jul 13, 2016 at 02:40:26PM +0300, Or Gerlitz wrote: > On 7/13/2016 2:19 PM, Matan Barak wrote: > >I'm not sure EINVAL is the right error here though. > >Maybe -ENOTSUPP is a bit more appropriate here. > > I agree, Dan, can you please change to be along Matan's suggestion? Or, Dan already

Re: [patch] net/mlx5: missing error code in esw_create_offloads_fdb_table()

.carpen...@oracle.com> Thanks Dan, Reviewed-by: Leon Romanovsky <leo...@mellanox.com> signature.asc Description: Digital signature

Re: [PATCH net-next V3] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

On Thu, Jul 14, 2016 at 09:46:14AM +0300, Netanel Belgazal wrote: > This is a driver for the ENA family of networking devices. > > Signed-off-by: Netanel Belgazal > --- > > Notes: ... > - Increase driver version to 1.0.2 ... > +static void

Re: [PATCH v10 04/22] IB/hns: Add RoCE engine reset function

On Sat, Jun 25, 2016 at 06:25:37PM +0800, Wei Hu (Xavier) wrote: > > > On 2016/6/24 22:59, Leon Romanovsky wrote: > >On Thu, Jun 16, 2016 at 10:35:12PM +0800, Lijun Ou wrote: > >>This patch mainly added reset flow of RoCE engine in RoCE > >>driver. It is necessar

Re: [PATCH] net/mlx5_core/pagealloc: Remove deprecated create_singlethread_workqueue

On Mon, Aug 01, 2016 at 11:11:19AM -0400, Tejun Heo wrote: > > Right now, I'm feeling that I'm participating in soapie where one sends > > patch for every line, waits and sends the same patch for another file. > > It is worth to send one patch set and let us to test it all in once. > > Yeah, I

Re: [PATCH V2] Add flow control to the portmapper

On Wed, Jul 20, 2016 at 09:47:50PM -0500, Shiraz Saleem wrote: > On Tue, Jul 19, 2016 at 08:32:53PM +0300, Leon Romanovsky wrote: > > On Tue, Jul 19, 2016 at 09:50:24AM -0500, Shiraz Saleem wrote: > > > On Tue, Jul 19, 2016 at 08:40:06AM +0300, Leon Romanovsky wrote: &g

Re: [PATCH v11 00/22] Add HiSilicon RoCE driver

On Sat, Jul 02, 2016 at 05:39:02PM +0800, Lijun Ou wrote: This v11 > 28 files changed, 10626 insertions(+), 1 deletion(-) First version > 27 files changed, 11670 insertions(+), 11 deletions(-) 1K LOC less, we are moving in right direction. signature.asc Description: Digital signature

Re: [PATCH] net/mlx4: Fix some indent inconsistancy

witch' block. > > Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr> Thanks Reviewed-by: Leon Romanovsky <leo...@mellanox.com> signature.asc Description: Digital signature

Re: [PATCH v10 07/22] IB/hns: Add event queue support

On Wed, Jun 29, 2016 at 04:53:39PM +0800, oulijun wrote: > >> + > >> + for (i = 0; i < npages; ++i) > >> + if (eq->buf_list[i].buf) > > > > Is it possible situation to have eq->buf_list[i].buf == NULL at the > > middle of iteration? > > > We have analysized it according to your

Re: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

On Tue, Feb 07, 2017 at 12:22:59PM -0800, Vishwanathapura, Niranjana wrote: > ChangeLog: > = > v2 => v3: > a) Introduce and adopt generic RDMA netdev interface including, > - having bottom hfi1 driver directly interfacing with netstack. > - optimizing interface between hfi_vnic

Re: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

On Tue, Feb 07, 2017 at 01:43:03PM -0800, Vishwanathapura, Niranjana wrote: > On Tue, Feb 07, 2017 at 01:00:05PM -0800, Hefty, Sean wrote: > > > I didn't read patches yet, and prefer to ask it in advance. Does this > > > new ULP work with all > > > drivers/infiniband/hw/* devices as it is expected

Re: [RFC v3 00/11] HFI Virtual Network Interface Controller (VNIC)

On Tue, Feb 07, 2017 at 09:00:05PM +, Hefty, Sean wrote: > > I didn't read patches yet, and prefer to ask it in advance. Does this > > new ULP work with all > > drivers/infiniband/hw/* devices as it is expected from ULP? > > Like the way ipoib or srp work with all hw devices? What is the real

Re: [RFC v3 02/11] IB/hfi-vnic: Virtual Network Interface Controller (VNIC) interface

On Tue, Feb 07, 2017 at 02:19:01PM -0700, Jason Gunthorpe wrote: > On Tue, Feb 07, 2017 at 12:23:01PM -0800, Vishwanathapura, Niranjana wrote: > > Add rdma netdev interface to ib device structure allowing rdma netdev > > devices to be allocated by ib clients. > > Define HFI VNIC interface between

Re: [PATCH] net/mlx4: use rb_entry()

On Sun, Jan 22, 2017 at 10:42:25PM +0800, Geliang Tang wrote: > On Sun, Jan 22, 2017 at 09:48:39AM +0200, Leon Romanovsky wrote: > > On Fri, Jan 20, 2017 at 10:36:57PM +0800, Geliang Tang wrote: > > > To make the code clearer, use rb_entry() instead of container_of() to >

Re: [PATCH for-next V2 00/11] Mellanox mlx5 core and ODP updates 2017-01-01

On Tue, Jan 24, 2017 at 02:39:59PM -0500, Doug Ledford wrote: > On Tue, 2017-01-03 at 09:23 +0200, Leon Romanovsky wrote: > > On Tue, Jan 03, 2017 at 01:30:16AM +0200, Saeed Mahameed wrote: > > > > > > On Mon, Jan 2, 2017 at 10:53 PM, David Miller <da

Re: [PATCH for bnxt_re V4 15/21] RDMA/bnxt_re: Support post_recv

On Wed, Dec 21, 2016 at 03:42:04AM -0800, Selvin Xavier wrote: > Enables the fastpath verb ib_post_recv. > > v3: Fixes sparse warnings > > Signed-off-by: Eddie Wai > Signed-off-by: Devesh Sharma > Signed-off-by: Somnath Kotur

Re: [PATCH for bnxt_re V4 20/21] RDMA/bnxt_re: Add QP event handling

On Wed, Dec 21, 2016 at 03:42:09AM -0800, Selvin Xavier wrote: > Implements callback handler for processing Async events related to a QP. > This patch also implements the control path command completion handling. > > v3: Removes unwanted braces > > Signed-off-by: Eddie Wai

Re: [PATCH for bnxt_re V4 17/21] RDMA/bnxt_re: Handling dispatching of events to IB stack

On Wed, Dec 21, 2016 at 03:42:06AM -0800, Selvin Xavier wrote: > This patch implements events dispatching to the IB stack > based on NETDEV events received. > > v2: Removed cleanup of the resources during driver unload since > we are calling unregister_netdevice_notifier first in the exit. > >

Re: [PATCH 5/9] treewide: use kv[mz]alloc* rather than opencoded variants

r.kernel.org > Acked-by: Andreas Dilger <andreas.dil...@intel.com> # Lustre > Reviewed-by: Boris Ostrovsky <boris.ostrov...@oracle.com> # Xen bits > Acked-by: Christian Borntraeger <borntrae...@de.ibm.com> # KVM/s390 > Acked-by: Dan Williams <dan.j.willi...@intel.com&

Re: [PATCH] net/mlx4: use rb_entry()

On Fri, Jan 20, 2017 at 10:36:57PM +0800, Geliang Tang wrote: > To make the code clearer, use rb_entry() instead of container_of() to > deal with rbtree. > > Signed-off-by: Geliang Tang > --- > drivers/net/ethernet/mellanox/mlx4/resource_tracker.c | 8 > 1 file

Re: [PATCH V5 for-next 21/21] RDMA/bnxt_re: Add bnxt_re driver build support

ude/uapi/rdma/bnxt_re-abi.h > + Please take a look on the note which I gave to Faisal a long time ago [1]. Our experience shows that the more people you add here, the less chances to be CCed on the relevant patches. It is definitely up to you. Thanks, Reviewed-by: Leon Romanovsky <leo...@mellanox.com> [1] https://www.spinics.net/lists/linux-rdma/msg41457.html signature.asc Description: PGP signature

Re: [PATCH V5 for-next 16/21] RDMA/bnxt_re: Support poll_cq verb

On Fri, Feb 10, 2017 at 03:19:48AM -0800, Selvin Xavier wrote: > Enables the fastpath ib_poll_cq verb. > > v2: Fixed sparse warnings > v3: Fixes endianness related warnings reported by sparse. Also, fixes > smatch and checkpatch warnings > v5: Uses ETH_P_IBOE macro for RoCE ethertype > >

  1   2   3   4   5   6   7   8   9   10   >