[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-08-20 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16585561#comment-16585561 ] Mathieu Lirzin commented on OFBIZ-10438: Hello [~deepak.nigam], I am looking at the bug you have

[jira] [Commented] (OFBIZ-10515) Impersonation of userLogin feature

2018-08-11 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577330#comment-16577330 ] Mathieu Lirzin commented on OFBIZ-10515: Indeed, I have been confused by the fact that applying

[jira] [Commented] (OFBIZ-10514) Refactoring ContactMechWorker.get[Entity]ContactMechValueMaps

2018-08-11 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577323#comment-16577323 ] Mathieu Lirzin commented on OFBIZ-10514: Hello [~soledad], The performance difference is

[jira] [Comment Edited] (OFBIZ-10515) Impersonation of userLogin feature

2018-08-11 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577253#comment-16577253 ] Mathieu Lirzin edited comment on OFBIZ-10515 at 8/11/18 5:33 PM: - Hello

[jira] [Commented] (OFBIZ-10515) Impersonation of userLogin feature

2018-08-11 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577253#comment-16577253 ] Mathieu Lirzin commented on OFBIZ-10515: Hello [~gil portenseigne], Nice work, this is working

[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-08-09 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16574379#comment-16574379 ] Mathieu Lirzin commented on OFBIZ-10438: Hello [~taher], Makes sense, please go ahead. :) >

[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-08-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10438: --- Attachment: (was: OFBIZ-10438_0003-Handle-multiple-request-methods.patch) > Add method

[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-08-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10438: --- Attachment: OFBIZ-10438_0003-Handle-multiple-request-methods.patch > Add method attribute

[jira] [Commented] (OFBIZ-10485) Refactor MapContext

2018-08-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16573257#comment-16573257 ] Mathieu Lirzin commented on OFBIZ-10485: Thanks [~jacques.le.roux] for spotting that > Refactor

[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-08-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572985#comment-16572985 ] Mathieu Lirzin commented on OFBIZ-10438: I don't mind if you go with this strategy, however it

[jira] [Comment Edited] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-08-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552431#comment-16552431 ] Mathieu Lirzin edited comment on OFBIZ-10438 at 8/8/18 9:47 AM: Seems

[jira] [Comment Edited] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-08-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572942#comment-16572942 ] Mathieu Lirzin edited comment on OFBIZ-10438 at 8/8/18 9:43 AM: {quote}

[jira] [Comment Edited] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-08-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572935#comment-16572935 ] Mathieu Lirzin edited comment on OFBIZ-10438 at 8/8/18 9:41 AM: Since

[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-08-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572942#comment-16572942 ] Mathieu Lirzin commented on OFBIZ-10438: {quote} Can I bother you to refresh my memory? What are

[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-08-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16572935#comment-16572935 ] Mathieu Lirzin commented on OFBIZ-10438: Since OFBIZ-10485 is closed, I have updated the

[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-08-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10438: --- Attachment: (was: OFBIZ-10438_0003-Handle-multiple-request-methods.patch) > Add method

[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-08-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10438: --- Attachment: (was: OFBIZ-10438_0002-Parse-controller-config-in-one-place.patch) > Add

[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-08-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10438: --- Attachment: OFBIZ-10438_0001-Add-optional-method-attribute-in-request.patch

[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-08-08 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10438: --- Attachment: (was: OFBIZ-10438_0001-Add-optional-method-attribute-in-request.patch) >

[jira] [Commented] (OFBIZ-10450) Extract verification of certificates in ‘RequestHandler’

2018-08-07 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16571291#comment-16571291 ] Mathieu Lirzin commented on OFBIZ-10450: Just for information, the extracted

[jira] [Closed] (OFBIZ-10485) Refactor MapContext

2018-08-07 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin closed OFBIZ-10485. -- > Refactor MapContext > --- > > Key: OFBIZ-10485 >

[jira] [Commented] (OFBIZ-10485) Refactor MapContext

2018-08-05 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569420#comment-16569420 ] Mathieu Lirzin commented on OFBIZ-10485: done in

[jira] [Updated] (OFBIZ-10485) Refactor MapContext

2018-08-05 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10485: --- Attachment: OFBIZ-10485_0009-0013_Continue-refactoring-the-MapContext-class.patch >

[jira] [Updated] (OFBIZ-10485) Refactor MapContext

2018-08-05 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10485: --- Attachment: OFBIZ-10485_0009-0012_Continue-refactoring-the-MapContext-class.patch >

[jira] [Updated] (OFBIZ-10485) Refactor MapContext

2018-08-05 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10485: --- Attachment: (was:

[jira] [Commented] (OFBIZ-10505) Use the stream API in FormRenderer

2018-08-05 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569413#comment-16569413 ] Mathieu Lirzin commented on OFBIZ-10505: Thanks [~gil portenseigne] > Use the stream API in

[jira] [Commented] (OFBIZ-10485) Refactor MapContext

2018-08-04 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16569306#comment-16569306 ] Mathieu Lirzin commented on OFBIZ-10485: {quote}I'm not sure replacing {{stackList}} with maps

[jira] [Commented] (OFBIZ-10450) Extract verification of certificates in ‘RequestHandler’

2018-08-03 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568436#comment-16568436 ] Mathieu Lirzin commented on OFBIZ-10450: a gentle ping. :-) > Extract verification of

[jira] [Updated] (OFBIZ-10505) Use the stream API in FormRenderer

2018-08-03 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10505: --- Description: I am refactoring the {{FormRenderer}} class to make it more declarative. Here

[jira] [Commented] (OFBIZ-10505) Use the stream API in FormRenderer

2018-08-03 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568424#comment-16568424 ] Mathieu Lirzin commented on OFBIZ-10505: The patches are meant to be applied in order > Use the

[jira] [Updated] (OFBIZ-10505) Use the stream API in FormRenderer

2018-08-03 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10505: --- Attachment: OFBIZ-10505_0001-Add-filteringDuplicateNames.patch

[jira] [Comment Edited] (OFBIZ-10504) Remove all unnecessary boxing and unboxing in Java classes

2018-08-03 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16568157#comment-16568157 ] Mathieu Lirzin edited comment on OFBIZ-10504 at 8/3/18 12:34 PM: -

[jira] [Commented] (OFBIZ-10503) Inline ‘getFieldListsByPosition’ method

2018-08-03 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16567926#comment-16567926 ] Mathieu Lirzin commented on OFBIZ-10503: Thanks [~gil portenseigne] > Inline

[jira] [Comment Edited] (OFBIZ-10503) Inline ‘getFieldListsByPosition’ method

2018-08-02 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566693#comment-16566693 ] Mathieu Lirzin edited comment on OFBIZ-10503 at 8/2/18 12:27 PM: -

[jira] [Commented] (OFBIZ-10503) Inline ‘getFieldListsByPosition’ method

2018-08-02 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16566693#comment-16566693 ] Mathieu Lirzin commented on OFBIZ-10503: Indeed, there is no order guarantee with basic

[jira] [Updated] (OFBIZ-10503) Inline ‘getFieldListsByPosition’ method

2018-08-02 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10503: --- Attachment: OFBIZ_10503_Refactor-getFieldListsByPosition.patch > Inline

[jira] [Updated] (OFBIZ-10503) Inline ‘getFieldListsByPosition’ method

2018-08-02 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10503: --- Attachment: (was: OFBIZ-10503_Inline-getFieldListsByPosition.patch) > Inline

[jira] [Commented] (OFBIZ-10502) Factorize and Refactor filtering of duplicated ‘use-when’ fields in ‘FormRenderer’

2018-08-01 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565975#comment-16565975 ] Mathieu Lirzin commented on OFBIZ-10502: Thanks [~gil portenseigne] for your prompt review. >

[jira] [Updated] (OFBIZ-10503) Inline ‘getFieldListsByPosition’ method

2018-08-01 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10503: --- Attachment: OFBIZ-10503_Inline-getFieldListsByPosition.patch > Inline

[jira] [Updated] (OFBIZ-10503) Inline ‘getFieldListsByPosition’ method

2018-08-01 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10503: --- Attachment: (was: OFBIZ-10503_Inline-getFieldListsByPosition.patch) > Inline

[jira] [Updated] (OFBIZ-10503) Inline ‘getFieldListsByPosition’ method

2018-08-01 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10503: --- Attachment: OFBIZ-10503_Inline-getFieldListsByPosition.patch > Inline

[jira] [Created] (OFBIZ-10503) Inline ‘getFieldListsByPosition’ method

2018-08-01 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10503: -- Summary: Inline ‘getFieldListsByPosition’ method Key: OFBIZ-10503 URL: https://issues.apache.org/jira/browse/OFBIZ-10503 Project: OFBiz Issue Type:

[jira] [Updated] (OFBIZ-10503) Inline ‘getFieldListsByPosition’ method

2018-08-01 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10503?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10503: --- Description: {{FormRenderer::getFieldListsByPosition}} is trivial to implement with a

[jira] [Updated] (OFBIZ-10502) Factorize and Refactor filtering of duplicated ‘use-when’ fields in ‘FormRenderer’

2018-08-01 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10502: --- Attachment: (was: OFBIZ-10502_0002-Add-test-for-extracted-method.patch) > Factorize and

[jira] [Updated] (OFBIZ-10502) Factorize and Refactor filtering of duplicated ‘use-when’ fields in ‘FormRenderer’

2018-08-01 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10502: --- Attachment: (was: OFBIZ-10502_0003-Refactor.patch) > Factorize and Refactor filtering

[jira] [Updated] (OFBIZ-10502) Factorize and Refactor filtering of duplicated ‘use-when’ fields in ‘FormRenderer’

2018-08-01 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10502: --- Attachment: OFBIZ-10502_0001-Factorize-filtering-of-duplicated-use-when-fields.patch

[jira] [Updated] (OFBIZ-10502) Factorize and Refactor filtering of duplicated ‘use-when’ fields in ‘FormRenderer’

2018-08-01 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10502: --- Attachment: (was:

[jira] [Created] (OFBIZ-10502) Factorize and Refactor filtering of duplicated ‘use-when’ fields in ‘FormRenderer’

2018-08-01 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10502: -- Summary: Factorize and Refactor filtering of duplicated ‘use-when’ fields in ‘FormRenderer’ Key: OFBIZ-10502 URL: https://issues.apache.org/jira/browse/OFBIZ-10502

[jira] [Commented] (OFBIZ-10485) Refactor MapContext

2018-07-26 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558129#comment-16558129 ] Mathieu Lirzin commented on OFBIZ-10485: Thank you Taher, feel free to apply those patches the

[jira] [Assigned] (OFBIZ-10411) XML schemas should use predefined boolean type

2018-07-25 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin reassigned OFBIZ-10411: -- Assignee: (was: Mathieu Lirzin) > XML schemas should use predefined boolean type

[jira] [Comment Edited] (OFBIZ-10485) Refactor MapContext

2018-07-25 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555718#comment-16555718 ] Mathieu Lirzin edited comment on OFBIZ-10485 at 7/25/18 2:00 PM: - Thanks

[jira] [Comment Edited] (OFBIZ-10485) Refactor MapContext

2018-07-25 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555718#comment-16555718 ] Mathieu Lirzin edited comment on OFBIZ-10485 at 7/25/18 2:13 PM: - Thanks

[jira] [Commented] (OFBIZ-10485) Refactor MapContext

2018-07-25 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16555718#comment-16555718 ] Mathieu Lirzin commented on OFBIZ-10485: Thanks Taher for applying the first two patches. The

[jira] [Commented] (OFBIZ-10485) Refactor MapContext

2018-07-24 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554337#comment-16554337 ] Mathieu Lirzin commented on OFBIZ-10485: With the removal of dead code in the super class, then

[jira] [Updated] (OFBIZ-10485) Refactor MapContext

2018-07-24 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10485: --- Description: Following conversation

[jira] [Commented] (OFBIZ-10485) Refactor MapContext

2018-07-24 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16554025#comment-16554025 ] Mathieu Lirzin commented on OFBIZ-10485: [~taher]: Where are you in the review process? Have you

[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-07-23 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16552431#comment-16552431 ] Mathieu Lirzin commented on OFBIZ-10438: Seems reasonable. I will rebase the patches after

[jira] [Comment Edited] (OFBIZ-10485) Refactor MapContext

2018-07-18 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547927#comment-16547927 ] Mathieu Lirzin edited comment on OFBIZ-10485 at 7/18/18 2:54 PM: - Hello

[jira] [Commented] (OFBIZ-10485) Refactor MapContext

2018-07-18 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16547927#comment-16547927 ] Mathieu Lirzin commented on OFBIZ-10485: Hello Taher, I have used my IDE to check for

[jira] [Updated] (OFBIZ-10488) Replace Callable objects with lambda expressions

2018-07-18 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10488?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10488: --- Attachment: OFBIZ-10488_Replace-Callable-objects-with-lambda-expressions.patch > Replace

[jira] [Created] (OFBIZ-10488) Replace Callable objects with lambda expressions

2018-07-18 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10488: -- Summary: Replace Callable objects with lambda expressions Key: OFBIZ-10488 URL: https://issues.apache.org/jira/browse/OFBIZ-10488 Project: OFBiz Issue

[jira] [Updated] (OFBIZ-10485) Refactor MapContext

2018-07-18 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10485: --- Attachment: OFBIZ-10485_0006-Rewrite-MapContext-keySet.patch

[jira] [Updated] (OFBIZ-10485) Refactor MapContext

2018-07-17 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10485: --- Attachment: (was: OFBIZ-10485_0011-Inline-MapContext-getMapContext.patch) > Refactor

[jira] [Updated] (OFBIZ-10485) Refactor MapContext

2018-07-17 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10485: --- Attachment: (was: OFBIZ-10485_0010-Rewrite-MapContext.containsValue.patch) > Refactor

[jira] [Updated] (OFBIZ-10485) Refactor MapContext

2018-07-17 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10485: --- Attachment: (was: OFBIZ-10485_0013-Rework-comments.patch) > Refactor MapContext >

[jira] [Updated] (OFBIZ-10485) Refactor MapContext

2018-07-17 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10485: --- Attachment: (was: OFBIZ-10485_0014-Add-collectBackwards-private-method.patch) >

[jira] [Updated] (OFBIZ-10485) Refactor MapContext

2018-07-17 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10485: --- Attachment: (was: OFBIZ-10485_0012-Rename-stackList-to-maps.patch) > Refactor

[jira] [Updated] (OFBIZ-10485) Refactor MapContext

2018-07-17 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10485: --- Attachment: (was: OFBIZ-10485_0009-Rewrite-MapContext-entrySet.patch) > Refactor

[jira] [Updated] (OFBIZ-10485) Refactor MapContext

2018-07-17 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10485: --- Attachment: (was: OFBIZ-10485_0008-Remove-MapContext.ListSet-class.patch) > Refactor

[jira] [Updated] (OFBIZ-10485) Refactor MapContext

2018-07-17 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10485: --- Attachment: (was: OFBIZ-10485_0006-Rewrite-MapContext-keySet.patch) > Refactor

[jira] [Updated] (OFBIZ-10485) Refactor MapContext

2018-07-17 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10485: --- Attachment: (was: OFBIZ-10485_0007-Rewrite-MapContext-values.patch) > Refactor

[jira] [Updated] (OFBIZ-10485) Refactor MapContext

2018-07-17 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10485: --- Attachment: OFBIZ-10485_0001-Remove-MapContext-dead-code.patch

[jira] [Created] (OFBIZ-10485) Refactor MapContext

2018-07-17 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10485: -- Summary: Refactor MapContext Key: OFBIZ-10485 URL: https://issues.apache.org/jira/browse/OFBIZ-10485 Project: OFBiz Issue Type: Improvement

[jira] [Commented] (OFBIZ-10450) Extract verification of certificates in ‘RequestHandler’

2018-07-13 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16542832#comment-16542832 ] Mathieu Lirzin commented on OFBIZ-10450: I have updated

[jira] [Updated] (OFBIZ-10450) Extract verification of certificates in ‘RequestHandler’

2018-07-13 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10450: --- Attachment: OFBIZ-10450_Extract-verification-of-certificates-in-RequestHandl.patch >

[jira] [Updated] (OFBIZ-10450) Extract verification of certificates in ‘RequestHandler’

2018-07-13 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10450: --- Attachment: (was:

[jira] [Updated] (OFBIZ-10474) Remove duplicated code when running login/logout events

2018-07-13 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10474?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10474: --- Attachment: OFBIZ-10474-duplicated-code-when-running-events.patch > Remove duplicated code

[jira] [Created] (OFBIZ-10474) Remove duplicated code when running login/logout events

2018-07-13 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10474: -- Summary: Remove duplicated code when running login/logout events Key: OFBIZ-10474 URL: https://issues.apache.org/jira/browse/OFBIZ-10474 Project: OFBiz

[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-07-12 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16541575#comment-16541575 ] Mathieu Lirzin commented on OFBIZ-10438: I have updated the

[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-07-12 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10438: --- Attachment: OFBIZ-10438_0003-Handle-multiple-request-methods.patch > Add method attribute

[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-07-12 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10438: --- Attachment: (was: OFBIZ-10438_0003-Handle-multiple-request-methods.patch) > Add method

[jira] [Commented] (OFBIZ-10460) setLocaleFromBrowser requires authentification

2018-07-11 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16539769#comment-16539769 ] Mathieu Lirzin commented on OFBIZ-10460: I would recommend adding a "XXX" comment directly in

[jira] [Commented] (OFBIZ-10458) GetLocaleList call can provide duplicate results

2018-07-06 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16535417#comment-16535417 ] Mathieu Lirzin commented on OFBIZ-10458: Thanks [~gil portenseigne] for commiting those patches

[jira] [Comment Edited] (OFBIZ-10458) GetLocaleList call can provide duplicate results

2018-07-06 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16535417#comment-16535417 ] Mathieu Lirzin edited comment on OFBIZ-10458 at 7/6/18 10:15 PM: - Thanks

[jira] [Commented] (OFBIZ-10458) GetLocaleList call can provide duplicate results

2018-07-06 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16535389#comment-16535389 ] Mathieu Lirzin commented on OFBIZ-10458: You are correct about the fact that we can rely on

[jira] [Commented] (OFBIZ-10458) GetLocaleList call can provide duplicate results

2018-07-06 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16535113#comment-16535113 ] Mathieu Lirzin commented on OFBIZ-10458: {quote}This started already 3.5 years ago:

[jira] [Updated] (OFBIZ-10458) GetLocaleList call can provide duplicate results

2018-07-06 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10458: --- Description: This is not a huge issue but I detected an issue with the {{GetLocaleList}}

[jira] [Updated] (OFBIZ-10460) setLocaleFromBrowser requires authentification

2018-07-05 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10460?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10460: --- Fix Version/s: (was: Upcoming Branch) > setLocaleFromBrowser requires authentification

[jira] [Created] (OFBIZ-10460) setLocaleFromBrowser requires authentification

2018-07-05 Thread Mathieu Lirzin (JIRA)
Mathieu Lirzin created OFBIZ-10460: -- Summary: setLocaleFromBrowser requires authentification Key: OFBIZ-10460 URL: https://issues.apache.org/jira/browse/OFBIZ-10460 Project: OFBiz Issue

[jira] [Updated] (OFBIZ-10458) GetLocaleList call can provide duplicate results

2018-07-05 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10458: --- Summary: GetLocaleList call can provide duplicate results (was: GetLocaleList call can

[jira] [Updated] (OFBIZ-10458) GetLocaleList call can result in duplicate results

2018-07-05 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10458: --- Attachment: OFBIZ-10458_0001-Add-failing-tests.patch

[jira] [Updated] (OFBIZ-10458) GetLocaleList call can result in duplicate results

2018-07-05 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10458: --- Attachment: (was: OFBIZ-10458_0002-Fix-duplicates-bug.patch) > GetLocaleList call can

[jira] [Updated] (OFBIZ-10458) GetLocaleList call can result in duplicate results

2018-07-05 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10458: --- Attachment: (was: OFBIZ-10458_0003-Refactor.patch) > GetLocaleList call can result in

[jira] [Updated] (OFBIZ-10458) GetLocaleList call can result in duplicate results

2018-07-05 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10458: --- Attachment: OFBIZ-10458_0001-Add-failing-tests.patch

[jira] [Commented] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-07-04 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532372#comment-16532372 ] Mathieu Lirzin commented on OFBIZ-10438: Following revert of the commit in order to discuss the

[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-07-04 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10438: --- Attachment: OFBIZ-10438_0001-Add-optional-method-attribute-in-request.patch

[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-07-04 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10438: --- Attachment: (was:

[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-07-04 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10438: --- Attachment: (was: OFBIZ-10438_0005-Improved-Parse-controller-config-in-one-place.patch)

[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-07-04 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10438: --- Attachment: (was: OFBIZ-10438_0001-Improved-Add-ControlServlet-service-method.patch) >

[jira] [Updated] (OFBIZ-10438) Add method attribute to request-map to controll a uri can be called GET or POST only

2018-07-04 Thread Mathieu Lirzin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-10438?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mathieu Lirzin updated OFBIZ-10438: --- Attachment: (was: OFBIZ-10438_0004-Improved-Add-RequestHandler-resolveURI-method.patch)

<    4   5   6   7   8   9   10   >