[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748410#comment-17748410
]
Deepak Dixit commented on OFBIZ-12813:
--
Hi [~jleroux], [~wpaetzold]
ofbiz-plugins still have the
mbrohl closed pull request #642: Improved: Persist OrderItemAttribute of
ShoppingCartItem (OFBIZ-12828)
URL: https://github.com/apache/ofbiz-framework/pull/642
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/OFBIZ-12836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748298#comment-17748298
]
Jacques Le Roux commented on OFBIZ-12836:
-
Beware that as noted Wiebke in OFBIZ-12813
bq.
[
https://issues.apache.org/jira/browse/OFBIZ-12828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748297#comment-17748297
]
Jacques Le Roux commented on OFBIZ-12828:
-
OK, as soon as a groovy file is modifed, and
[
https://issues.apache.org/jira/browse/OFBIZ-12828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748295#comment-17748295
]
Jacques Le Roux commented on OFBIZ-12828:
-
It should even be backported to 18.12. We are not yet
[
https://issues.apache.org/jira/browse/OFBIZ-12828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748252#comment-17748252
]
Michael Brohl commented on OFBIZ-12828:
---
You are right, this should normally be backported to
[
https://issues.apache.org/jira/browse/OFBIZ-12828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748246#comment-17748246
]
Jacques Le Roux commented on OFBIZ-12828:
-
Hi Michael,
If it's a bug why not backporting?
>
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748238#comment-17748238
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12174?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl closed OFBIZ-12174.
-
Fix Version/s: Upcoming Branch
Resolution: Implemented
Thanks [~sberg] and [~cshan] !
>
[
https://issues.apache.org/jira/browse/OFBIZ-12174?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748229#comment-17748229
]
ASF subversion and git services commented on OFBIZ-12174:
-
Commit
mbrohl merged PR #664:
URL: https://github.com/apache/ofbiz-framework/pull/664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/OFBIZ-9403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl closed OFBIZ-9403.
Fix Version/s: Upcoming Branch
Resolution: Implemented
Thanks [~mbecker] and [~cshan] !
>
[
https://issues.apache.org/jira/browse/OFBIZ-9403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748226#comment-17748226
]
ASF subversion and git services commented on OFBIZ-9403:
Commit
mbrohl merged PR #663:
URL: https://github.com/apache/ofbiz-framework/pull/663
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/OFBIZ-12802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl reassigned OFBIZ-12802:
-
Assignee: Michael Brohl
> Extending calculateProductPrice (custom) Service and
mbrohl commented on PR #655:
URL: https://github.com/apache/ofbiz-framework/pull/655#issuecomment-1653894859
Looks good to me. Any objections to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/OFBIZ-12802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748225#comment-17748225
]
Michael Brohl commented on OFBIZ-12802:
---
Looks good to me. Any objections to merge?
> Extending
mbrohl commented on PR #660:
URL: https://github.com/apache/ofbiz-framework/pull/660#issuecomment-1653892055
Closed in favor of #664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
mbrohl closed pull request #660: Fixed: Convert InventoryServices.xml mini lang
to groovy (OFBIZ-12174)
URL: https://github.com/apache/ofbiz-framework/pull/660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/OFBIZ-12828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl closed OFBIZ-12828.
-
Fix Version/s: Upcoming Branch
Resolution: Fixed
Thanks [~pzoschke] and [~sberg] for
[
https://issues.apache.org/jira/browse/OFBIZ-12828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748220#comment-17748220
]
ASF subversion and git services commented on OFBIZ-12828:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl reassigned OFBIZ-12828:
-
Assignee: Michael Brohl (was: Pascal Zoschke)
> Persist OrderItemAttributes of
mbrohl merged PR #662:
URL: https://github.com/apache/ofbiz-framework/pull/662
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
sonarcloud[bot] commented on PR #663:
URL: https://github.com/apache/ofbiz-framework/pull/663#issuecomment-1653843442
Kudos, SonarCloud Quality Gate passed! [
Thanks: SebastianEcomify
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/OFBIZ-9403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748182#comment-17748182
]
Chenghu Shan commented on OFBIZ-9403:
-
[~mbrohl] I created a new pull request. The method getMimeType
sonarcloud[bot] commented on PR #662:
URL: https://github.com/apache/ofbiz-framework/pull/662#issuecomment-1653740981
Kudos, SonarCloud Quality Gate passed! [ (OFBIZ-9403)
URL: https://github.com/apache/ofbiz-framework/pull/644
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
[
https://issues.apache.org/jira/browse/OFBIZ-9403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chenghu Shan reassigned OFBIZ-9403:
---
Assignee: Chenghu Shan (was: Michael Brohl)
> DataResourceWorker: New method
cshan-ecomify opened a new pull request, #663:
URL: https://github.com/apache/ofbiz-framework/pull/663
Improved: Refactored DataResourceWorker getMimeType (OFBIZ-9403)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
SebastianEcomify closed pull request #661: Improved: Persist OrderItemAttribute
of ShoppingCartItem (OFBIZ-12828)
URL: https://github.com/apache/ofbiz-framework/pull/661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
SebastianEcomify opened a new pull request, #662:
URL: https://github.com/apache/ofbiz-framework/pull/662
Fixed: Persist OrderItemAttribute of ShoppingCartItem (OFBIZ-12828)
Fix introduced so that OrderItemAttributes are persisted inside
ShoppingCartItemAttributes from now on.
[
https://issues.apache.org/jira/browse/OFBIZ-12828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748169#comment-17748169
]
Michael Brohl commented on OFBIZ-12828:
---
I think this should be classified as a bug because data
[
https://issues.apache.org/jira/browse/OFBIZ-12828?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl updated OFBIZ-12828:
--
Component/s: order
Issue Type: Bug (was: Improvement)
> Persist OrderItemAttributes of
[
https://issues.apache.org/jira/browse/OFBIZ-12828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748166#comment-17748166
]
Sebastian Berg commented on OFBIZ-12828:
Hi,
I provided a new PR to account for the moved
sonarcloud[bot] commented on PR #660:
URL: https://github.com/apache/ofbiz-framework/pull/660#issuecomment-1653625836
Kudos, SonarCloud Quality Gate passed! [
Improvement introduced so that OrderItemAttributes are persisted inside
ShoppingCartItemAttributes from
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wiebke Paetzold closed OFBIZ-12813.
---
Fix Version/s: Upcoming Branch
Resolution: Fixed
> Refactor groovy folder structure
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748162#comment-17748162
]
Wiebke Paetzold commented on OFBIZ-12813:
-
Thanks [~jleroux] and [~deepak] for reviewing :)
>
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748146#comment-17748146
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748150#comment-17748150
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748145#comment-17748145
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748144#comment-17748144
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748148#comment-17748148
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748149#comment-17748149
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748147#comment-17748147
]
ASF subversion and git services commented on OFBIZ-12813:
-
Commit
wpaetzold merged PR #653:
URL: https://github.com/apache/ofbiz-framework/pull/653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mbrohl commented on PR #660:
URL: https://github.com/apache/ofbiz-framework/pull/660#issuecomment-1653574583
Should be applied after https://github.com/apache/ofbiz-framework/pull/653
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
SebastianEcomify opened a new pull request, #660:
URL: https://github.com/apache/ofbiz-framework/pull/660
Fixed: Convert InventoryServices.xml mini lang to groovy (OFBIZ-12174)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
[
https://issues.apache.org/jira/browse/OFBIZ-11434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748132#comment-17748132
]
Michael Brohl commented on OFBIZ-11434:
---
Thanks, [~jleroux] !
> Forum Articles do not respond to
[
https://issues.apache.org/jira/browse/OFBIZ-11434?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-11434.
---
Fix Version/s: 22.01.01
18.12.09
(was: Upcoming
[
https://issues.apache.org/jira/browse/OFBIZ-11434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748124#comment-17748124
]
ASF subversion and git services commented on OFBIZ-11434:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-11434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748123#comment-17748123
]
ASF subversion and git services commented on OFBIZ-11434:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-11434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748127#comment-17748127
]
ASF subversion and git services commented on OFBIZ-11434:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-11434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748128#comment-17748128
]
ASF subversion and git services commented on OFBIZ-11434:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-11434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748125#comment-17748125
]
ASF subversion and git services commented on OFBIZ-11434:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-11434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748126#comment-17748126
]
ASF subversion and git services commented on OFBIZ-11434:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-9403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748111#comment-17748111
]
Michael Brohl commented on OFBIZ-9403:
--
[~cshan] I think we should take the defaultMimeType from
mbrohl commented on PR #644:
URL: https://github.com/apache/ofbiz-framework/pull/644#issuecomment-1653453910
@cshan-ecomify I think we should take the defaultMimeType from
applications/content/config/content.properties instead of a hard coded one, can
you please change it accordingly?
--
[
https://issues.apache.org/jira/browse/OFBIZ-11434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748110#comment-17748110
]
Jacques Le Roux commented on OFBIZ-11434:
-
Hi Michael,
We need 1st to backport, at least to
[
https://issues.apache.org/jira/browse/OFBIZ-11434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748106#comment-17748106
]
Michael Brohl commented on OFBIZ-11434:
---
[~jleroux] shouldn't this be closed already?
> Forum
mbrohl commented on code in PR #592:
URL: https://github.com/apache/ofbiz-framework/pull/592#discussion_r1276148465
##
applications/party/groovyScripts/party/PartyServices.groovy:
##
@@ -427,13 +427,49 @@ def createPartyRelationship() {
partyIdTo:
[
https://issues.apache.org/jira/browse/OFBIZ-12830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl reassigned OFBIZ-12830:
-
Assignee: Michael Brohl (was: Chenghu Shan)
> Reduction of recurring INFO logs
>
[
https://issues.apache.org/jira/browse/OFBIZ-12830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl reassigned OFBIZ-12830:
-
Assignee: (was: Michael Brohl)
> Reduction of recurring INFO logs
>
[
https://issues.apache.org/jira/browse/OFBIZ-12842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748102#comment-17748102
]
ASF subversion and git services commented on OFBIZ-12842:
-
Commit
[
https://issues.apache.org/jira/browse/OFBIZ-12842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl closed OFBIZ-12842.
-
Fix Version/s: Upcoming Branch
Resolution: Implemented
Thanks [~cshan]
>
[
https://issues.apache.org/jira/browse/OFBIZ-12841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl closed OFBIZ-12841.
-
Fix Version/s: Upcoming Branch
Resolution: Fixed
Thanks [~cshan]
>
mbrohl merged PR #659:
URL: https://github.com/apache/ofbiz-framework/pull/659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/OFBIZ-12842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl reassigned OFBIZ-12842:
-
Assignee: Michael Brohl (was: Chenghu Shan)
> UtilHttp.getPathInfoOnlyParameterMap
[
https://issues.apache.org/jira/browse/OFBIZ-12841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl reassigned OFBIZ-12841:
-
Assignee: Michael Brohl
> GenericDelegator.findList should return unmodifiable list
mbrohl merged PR #658:
URL: https://github.com/apache/ofbiz-framework/pull/658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/OFBIZ-12829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17748096#comment-17748096
]
Michael Brohl commented on OFBIZ-12829:
---
Looks good to me, any objections to merge?
>
mbrohl commented on PR #643:
URL: https://github.com/apache/ofbiz-framework/pull/643#issuecomment-1653419334
Looks good to me, any objections to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/OFBIZ-12829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl reassigned OFBIZ-12829:
-
Assignee: Michael Brohl (was: Chenghu Shan)
> Improvements for ContentWorker methods
sonarcloud[bot] commented on PR #659:
URL: https://github.com/apache/ofbiz-framework/pull/659#issuecomment-1653373001
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
[
https://issues.apache.org/jira/browse/OFBIZ-12840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl closed OFBIZ-12840.
-
Fix Version/s: Upcoming Branch
Resolution: Implemented
Thanks [~cshan]
> Missing
mbrohl merged PR #657:
URL: https://github.com/apache/ofbiz-framework/pull/657
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mbrohl closed pull request #652: Improved: Refactoring groovy folder structure
and package declaration (OFBIZ-12813)
URL: https://github.com/apache/ofbiz-framework/pull/652
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
Chenghu Shan created OFBIZ-12842:
Summary: UtilHttp.getPathInfoOnlyParameterMap should be public
Key: OFBIZ-12842
URL: https://issues.apache.org/jira/browse/OFBIZ-12842
Project: OFBiz
Issue
[
https://issues.apache.org/jira/browse/OFBIZ-12840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Brohl reassigned OFBIZ-12840:
-
Assignee: Michael Brohl (was: Chenghu Shan)
> Missing Getter in ShoppingCart and
[
https://issues.apache.org/jira/browse/OFBIZ-12841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747890#comment-17747890
]
Chenghu Shan commented on OFBIZ-12841:
--
Pullrequest:
sonarcloud[bot] commented on PR #657:
URL: https://github.com/apache/ofbiz-framework/pull/657#issuecomment-1653289977
Kudos, SonarCloud Quality Gate passed! [
--
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747887#comment-17747887
]
Jacques Le Roux commented on OFBIZ-12813:
-
Hi Wiebke,
I have a question : why order/return was
Chenghu Shan created OFBIZ-12841:
Summary: GenericDelegator.findList should return unmodifiable list
when using cache
Key: OFBIZ-12841
URL: https://issues.apache.org/jira/browse/OFBIZ-12841
Project:
cshan-ecomify opened a new pull request, #657:
URL: https://github.com/apache/ofbiz-framework/pull/657
Improved: Added missing getter/setter in Shoppingcart.java and
ConfigXMLReader.java (OFBIZ-12840)
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747871#comment-17747871
]
Jacques Le Roux edited comment on OFBIZ-12813 at 7/27/23 9:15 AM:
--
Hi
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747871#comment-17747871
]
Jacques Le Roux commented on OFBIZ-12813:
-
Hi Wiebke,
Don't worry I don't need help on Eclipse.
[
https://issues.apache.org/jira/browse/OFBIZ-12813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17747843#comment-17747843
]
Wiebke Paetzold commented on OFBIZ-12813:
-
Hi [~jleroux] ,
unfortunately I can not help you
[
https://issues.apache.org/jira/browse/OFBIZ-12802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrian Wolf updated OFBIZ-12802:
Description:
Background is the communication of an individually (informally) calculated
discount
1 - 100 of 102 matches
Mail list logo
