[Nutch-dev] [jira] Closed: (NUTCH-406) Metadata tries to write null values

2006-11-23 Thread Chris A. Mattmann (JIRA)
[ http://issues.apache.org/jira/browse/NUTCH-406?page=all ] Chris A. Mattmann closed NUTCH-406. --- Patch applied to trunk: http://svn.apache.org/viewvc?view=revrevision=478619 Metadata tries to write null values ---

Re: [Nutch-dev] [jira] Closed: (NUTCH-406) Metadata tries to write null values

2006-11-23 Thread Sami Siren
Couple of points: 1. You used tabs 2. You left some unneccessary comments on source, bug history is allready in jira and commit logs 3. Why not addition to testcase? 4. Issue could have been iterated in jira a bit further so all these could have been catched before a commit. -- Sami Siren

Re: [Nutch-dev] [jira] Closed: (NUTCH-406) Metadata tries to write null values

2006-11-23 Thread Chris Mattmann
Hi Sami, On 11/23/06 9:45 AM, Sami Siren [EMAIL PROTECTED] wrote: Couple of points: 1. You used tabs I just installed a new version of Eclipse, and forgot to change the default preference for using tabs versus just whitespaces. I've went ahead and changed this in my Eclipse and will commit

Re: [Nutch-dev] [jira] Closed: (NUTCH-406) Metadata tries to write null values

2006-11-23 Thread Sami Siren
Chris Mattmann wrote: 2. You left some unneccessary comments on source, bug history is allready in jira and commit logs I would disagree with this statement: no comment is unnecessary. What if the users don't look into JIRA, or don't scan through the commit logs? The change that we just