Re: [OPEN-ILS-DEV] Putting the community's QA money where our dev mouth is

2013-11-05 Thread Mike Rylander
Dan, You're right, and I was personally remiss in leaving out a pgTAP test for my recent repairs to authority overlay generation in an attempt to avoid delaying 2.5 even a little bit. I've pushed 120e24dd6d26f2460d209421bbbc9a1777f4fb52 in order to remedy that. (Of course, if I got anything

Re: [OPEN-ILS-DEV] Putting the community's QA money where our dev mouth is

2013-11-05 Thread Jason Etheridge
On Tue, Nov 5, 2013 at 11:53 AM, Kathy Lussier kluss...@masslnc.org wrote: I'm guessing this message was sent mostly to get developer feedback on including unit tests. However, since there has been no developer feedback and since this e-mail raised a lot of questions for me, I'll jump in with

Re: [OPEN-ILS-DEV] Putting the community's QA money where our dev mouth is

2013-11-05 Thread Kathy Lussier
Thank you Jason! Your explanations were very helpful. Kathy Kathy Lussier Project Coordinator Massachusetts Library Network Cooperative (508) 343-0128 kluss...@masslnc.org Twitter: http://www.twitter.com/kmlussier On 11/5/2013 12:59 PM, Jason Etheridge wrote: On Tue, Nov 5, 2013 at 11:53 AM,

Re: [OPEN-ILS-DEV] Putting the community's QA money where our dev mouth is

2013-11-05 Thread Mike Rylander
CORRECTION: the commit hash is 3e7f6f1503938e3e5a1cfe3bd90eaa8f021a0d48 ... I failed to fetch before attempting to pick. Sorry! --miker On Tue, Nov 5, 2013 at 12:41 PM, Mike Rylander mrylan...@gmail.com wrote: Dan, You're right, and I was personally remiss in leaving out a pgTAP test for my

Re: [OPEN-ILS-DEV] Putting the community's QA money where our dev mouth is

2013-11-05 Thread Dan Scott
On Tue, Nov 5, 2013 at 1:41 PM, Mike Rylander mrylan...@gmail.com wrote: CORRECTION: the commit hash is 3e7f6f1503938e3e5a1cfe3bd90eaa8f021a0d48 ... I failed to fetch before attempting to pick. Sorry! Hey Mike: It looks like that test assumes that the concerto sample records have been loaded,

Re: [OPEN-ILS-DEV] Putting the community's QA money where our dev mouth is

2013-11-05 Thread Mike Rylander
Dan, I understand the process of building mock environments, but thanks. It's my understanding that concerto is intended to be a valid test environment, so I decided to go with that. Is that not the case? As I mentioned in IRC, changing my most recent test to create a mock env would be fine,

Re: [OPEN-ILS-DEV] Putting the community's QA money where our dev mouth is

2013-11-05 Thread Dan Scott
On Tue, Nov 5, 2013 at 2:38 PM, Mike Rylander mrylan...@gmail.com wrote: Dan, I understand the process of building mock environments, but thanks. You're welcome. I'm sure that many other people reading this thread, now and in the future, might not, so hopefully my response will be helpful to

Re: [OPEN-ILS-DEV] Putting the community's QA money where our dev mouth is

2013-11-05 Thread Jason Etheridge
Building a test that relies on Concerto also means that once you log into the system and make any changes that affect the database, you can no longer depend on the results of tests run against that database. You need a full stop, database rebuild, start of the system to get a valid set of

[OPEN-ILS-DEV] Putting the community's QA money where our dev mouth is

2013-11-01 Thread Dan Scott
In the QA report for which several members of the community generously paid $30,000, the Moving Forward section at http://nox.esilibrary.com/~jason/qareport/qa.html#_moving_forward states: We recommend that the development community start including integration tests with their changes to the

Re: [OPEN-ILS-DEV] Putting the community's QA money where our dev mouth is

2013-11-01 Thread Tim Spindler
+1 Tim Spindler C/W MARS On Fri, Nov 1, 2013 at 5:01 PM, Dan Scott d...@coffeecode.net wrote: In the QA report for which several members of the community generously paid $30,000, the Moving Forward section at