Re: RFR: 8196065: ListChangeListener getRemoved() returns items that were not removed. [v3]

2021-04-29 Thread Ambarish Rapte
On Mon, 26 Apr 2021 18:58:02 GMT, mstr2 wrote: >> The documentation for `ObservableListBase.nextRemove` states that a single >> change always refers to the current state of the list, which likely means >> that multiple disjoint removed ranges need to be applied in order, otherwise >> the

Re: RFR: 8264449: Enable reproducible builds with SOURCE_DATE_EPOCH [v4]

2021-04-29 Thread John Neffenger
> This pull request allows for reproducible builds of JavaFX on Linux, macOS, > and Windows by defining the `SOURCE_DATE_EPOCH` environment variable. For > example, the following commands create a reproducible build: > > > $ export SOURCE_DATE_EPOCH=$(git log -1 --pretty=%ct) > $ bash gradlew

Re: RFR: 8238650: Allow to override buildDate with SOURCE_DATE_EPOCH [v2]

2021-04-29 Thread John Neffenger
> This is a continuation of the [pull request][1] started by @bmwiedemann in > January 2020. After this change is integrated, I can follow up immediately > with additional pull requests that get us much closer to providing fully > reproducible builds. > > Motivation > > The only

Re: RFR: 8264010: Add Gradle dependency verification [v5]

2021-04-29 Thread John Neffenger
> This pull request adds dependency verification to the Gradle builds of JavaFX > on Linux, macOS, and Windows. It is the third of three changes that close the > gaps in the JavaFX build security: > > * [JDK-8262236][1]: Configure Gradle checksum verification > * [JDK-8263204][2]: Add Gradle

Re: RFR: 8137323: Incorrect parsing of mnemonic in controls text

2021-04-29 Thread Kevin Rushforth
On Fri, 2 Apr 2021 19:47:30 GMT, mstr2 wrote: > This PR fixes incorrect parsing of mnemonic symbols in the following cases: > 1. an escaped double underscore incorrectly shows up as a double underscore > in displayed text > 2. an extended mnemonic incorrectly removes a part of adjacent text >

Re: RFR: 8264010: Add Gradle dependency verification [v4]

2021-04-29 Thread Kevin Rushforth
On Sat, 17 Apr 2021 23:17:04 GMT, John Neffenger wrote: >> This pull request adds dependency verification to the Gradle builds of >> JavaFX on Linux, macOS, and Windows. It is the third of three changes that >> close the gaps in the JavaFX build security: >> >> * [JDK-8262236][1]: Configure

Re: RFR: 8264010: Add Gradle dependency verification [v4]

2021-04-29 Thread John Neffenger
On Tue, 27 Apr 2021 21:19:26 GMT, Kevin Rushforth wrote: > Here are the two additional internal downloads for the new versions of the > gcc-10.3 and vs2019-16.9.3 download Thanks, Kevin. I'll assume those replace the older versions shown in the excerpt below, and I'll remove them. Let me know

Re: RFR: 8265399: Update to Visual Studio 2019 version 16.9.3 [v2]

2021-04-29 Thread Ambarish Rapte
On Thu, 29 Apr 2021 13:17:07 GMT, Kevin Rushforth wrote: >> This patch updates the compiler to Visual Studio 2019 version 16.9.3 on >> Windows, in order to match JDK 17 -- see >> [JDK-8265371](https://bugs.openjdk.java.net/browse/JDK-8265371). >> >> I ran a full build and test, including

Re: Support :focus-visible CSS pseudoclass

2021-04-29 Thread Tom Schindl
Ok did not know that so then yes following the CSS-Spec naming make sense. Tom Am 28.04.21 um 17:24 schrieb Michael Strauß: It's certainly true that all JavaFX themes show a focus indicator for all controls, but that's not universally so. For example, Microsoft's Fluent theme doesn't show any

Re: RFR: 8265399: Update to Visual Studio 2019 version 16.9.3 [v2]

2021-04-29 Thread Kevin Rushforth
> This patch updates the compiler to Visual Studio 2019 version 16.9.3 on > Windows, in order to match JDK 17 -- see > [JDK-8265371](https://bugs.openjdk.java.net/browse/JDK-8265371). > > I ran a full build and test, including media and WebKit. > > NOTE: I also have PR #481 out for review to

Re: RFR: 8265400: Update to gcc 10.3 on Linux

2021-04-29 Thread Kevin Rushforth
On Thu, 29 Apr 2021 12:59:01 GMT, Johan Vos wrote: > the entry says "gcc10.3.0-OL6.4+1.0" but I tested using the gcc10.3.0 on > Ubuntu (18.04) Yeah, the "OL6.4" part is just the name of the devkit (generated for the JDK builds), since that was their baseline. You can see it in the JDK 17

Integrated: 8265400: Update to gcc 10.3 on Linux

2021-04-29 Thread Kevin Rushforth
On Tue, 27 Apr 2021 21:30:25 GMT, Kevin Rushforth wrote: > This patch updates the compiler to gcc 10.3 on Linux, in order to match JDK > 17 -- see [JDK-8265373](https://bugs.openjdk.java.net/browse/JDK-8265373). > > I ran a full build and test, including media and WebKit. This pull request

Re: RFR: 8265400: Update to gcc 10.3 on Linux

2021-04-29 Thread Johan Vos
On Tue, 27 Apr 2021 21:30:25 GMT, Kevin Rushforth wrote: > This patch updates the compiler to gcc 10.3 on Linux, in order to match JDK > 17 -- see [JDK-8265373](https://bugs.openjdk.java.net/browse/JDK-8265373). > > I ran a full build and test, including media and WebKit. Marked as reviewed

Re: RFR: 8137323: Incorrect parsing of mnemonic in controls text

2021-04-29 Thread Ajit Ghaisas
On Fri, 2 Apr 2021 19:47:30 GMT, mstr2 wrote: > This PR fixes incorrect parsing of mnemonic symbols in the following cases: > 1. an escaped double underscore incorrectly shows up as a double underscore > in displayed text > 2. an extended mnemonic incorrectly removes a part of adjacent text >

[jfx11u] Integrated: 8265703: Change JavaFX release version in jfx11u to 11.0.12

2021-04-29 Thread Johan Vos
On Thu, 29 Apr 2021 07:05:07 GMT, Johan Vos wrote: > Increase security release number for JavaFX 11 to 11.0.12 > Fix for JDK-8265703 This pull request has now been integrated. Changeset: debbd07d Author:Johan Vos URL:

Re: [jfx11u] RFR: 8265703: Change JavaFX release version in jfx11u to 11.0.12

2021-04-29 Thread Kevin Rushforth
On Thu, 29 Apr 2021 07:05:07 GMT, Johan Vos wrote: > Increase security release number for JavaFX 11 to 11.0.12 > Fix for JDK-8265703 Marked as reviewed by kcr (Lead). - PR: https://git.openjdk.java.net/jfx11u/pull/1

Integrated: 8265206: Tree-/TableCell: editing state not updated on cell re-use

2021-04-29 Thread Jeanette Winzenburg
On Wed, 21 Apr 2021 11:29:38 GMT, Jeanette Winzenburg wrote: > Issue is missing update of Tree-/TableCell's editiable state when changing > its index from editingIndex to -1. > > Seems to be a left-over from fixing cell's editing update - done in >

Re: RFR: 8231601: Update CONTRIBUTING.md to clarify process for contributing features plus Skara changes [v3]

2021-04-29 Thread Marius Hanl
On Fri, 18 Sep 2020 18:57:16 GMT, Kevin Rushforth wrote: >> This PR updates the `CONTRIBUTING.md` guide to address the following: >> >> 1. Clarify the process for adding new features / API changes, specifically >> that they must be discussed on the mailing list as the first step. >> 2. Add a

Re: RFR: 8196065: ListChangeListener getRemoved() returns items that were not removed. [v3]

2021-04-29 Thread Ambarish Rapte
On Mon, 26 Apr 2021 18:58:02 GMT, mstr2 wrote: >> The documentation for `ObservableListBase.nextRemove` states that a single >> change always refers to the current state of the list, which likely means >> that multiple disjoint removed ranges need to be applied in order, otherwise >> the

[jfx11u] RFR: 8265703: Change JavaFX release version in jfx11u to 11.0.12

2021-04-29 Thread Johan Vos
Increase security release number for JavaFX 11 to 11.0.12 Fix for JDK-8265703 - Commit messages: - Increase security release number for JavaFX 11 to 11.0.12 Changes: https://git.openjdk.java.net/jfx11u/pull/1/files Webrev: https://webrevs.openjdk.java.net/?repo=jfx11u=1=00

Re: RFR: 8265206: Tree-/TableCell: editing state not updated on cell re-use [v2]

2021-04-29 Thread Johan Vos
On Fri, 23 Apr 2021 15:31:52 GMT, Jeanette Winzenburg wrote: >> Issue is missing update of Tree-/TableCell's editiable state when changing >> its index from editingIndex to -1. >> >> Seems to be a left-over from fixing cell's editing update - done in >>