Re: RFR: 8263761: Update boot JDK to 16.0.1

2021-05-19 Thread Ambarish Rapte
On Wed, 19 May 2021 17:28:34 GMT, Kevin Rushforth wrote: > This PR updates the boot JDK for JavaFX builds to use JDK 16.0.1. The minimum > version of the JDK remains unchanged at JDK 11. Linux build failure is not related to this change, failed test: test.javafx.css.HonorDeveloperSettingsTest

Re: .classpath files for Eclipse

2021-05-19 Thread Nir Lisker
The Eclipse files are due an update. There were previous reports on issues on Linux too (probably the ones you mentioned). We were hoping to be able to remove them with Gradle generating them during the build, but last time it was checked it couldn't. Don't know if Gradle 7 changed anything. I

Re: RFR: 8267418: IntelliJ build and test of JavaFX does not work

2021-05-19 Thread Kevin Rushforth
On Wed, 19 May 2021 16:12:45 GMT, Marius Hanl wrote: > Question: I was wondering, should I create a ticket for this as well? All fixes need a bug ID in JBS. For this one, it seemed easier for me to just file it directly, so I did:

RFR: 8267418: IntelliJ build and test of JavaFX does not work

2021-05-19 Thread Marius Hanl
Question: I was wondering, should I create a ticket for this as well? Given the fact that I don't have an https://bugs.openjdk.java.net account, I need to use the official bug reporting tool, which looked a bit overkill to me since someone needs to check my created ticket, while this PR is only

Support loading images from inline data-URIs

2021-05-19 Thread Michael Strauß
I would like to propose adding support for loading images from inline data-URIs, as commonly supported by web browsers. This is a low-impact addition to the image loading infrastructure as seen in this draft PR: https://github.com/openjdk/jfx/pull/508 As a follow-on feature, I'd also like to

Re: Minimum JDK policy for OpenJFX

2021-05-19 Thread Ty Young
If you want to learn more about Panama you can read the JEP page: https://openjdk.java.net/jeps/412 You can also join the panama-dev list and ask questions: https://mail.openjdk.java.net/mailman/listinfo/panama-dev Biggest things for JavaFX that I can think of is jextract, a tool for

Re: [External] : Re: Dependencies on java.desktop

2021-05-19 Thread Philip Race
Did someone mention my name ? Implementing FX printing on top of 2D printing was always a pragmatic way of delivering in FX 8. Never something that was done because we wanted to for any reason. A new native implementation will still cost the same amount of work that we put off in JDK 8. So

Re: [External] : Re: Dependencies on java.desktop

2021-05-19 Thread Kevin Rushforth
That's an interesting idea, although splitting it up to the degree you listed below would be unwieldy at best and likely unworkable (due to split package issues and interdependencies). It also would be wrong to create any implementation modules unless they are 100% hidden from the application

Re: RFR: 8263761: Update boot JDK to 16.0.1

2021-05-19 Thread Kevin Rushforth
On Wed, 19 May 2021 17:28:34 GMT, Kevin Rushforth wrote: > This PR updates the boot JDK for JavaFX builds to use JDK 16.0.1. The minimum > version of the JDK remains unchanged at JDK 11. It looks like we are still seeing occasional failures in `HonorDeveloperSettingsTest` on Linux. I filed

RFR: 8263761: Update boot JDK to 16.0.1

2021-05-19 Thread Kevin Rushforth
This PR updates the boot JDK for JavaFX builds to use JDK 16.0.1. The minimum version of the JDK remains unchanged at JDK 11. - Commit messages: - 8263761: Update boot JDK to 16.0.1 Changes: https://git.openjdk.java.net/jfx/pull/507/files Webrev:

Re: [External] : Re: Dependencies on java.desktop

2021-05-19 Thread Tom Schindl
Hi, Well I looked a bit closer now and the situation and you are right. I think need to do that one by one. I think getting rid of HostServices::showDocument is quite easy as the code in Java-AWT is just 1 JNI-Method so copying that to OpenJFX should be fairly easy. Now on the printing

Integrated: 8263760: Update gradle to version 7.0.1

2021-05-19 Thread Kevin Rushforth
On Wed, 12 May 2021 14:54:09 GMT, Kevin Rushforth wrote: > This PR fixes the gradle deprecation warnings described in > [JDK-8240336](https://bugs.openjdk.java.net/browse/JDK-8240336) and updates > the JavaFX build to use gradle 7.0.1 as described in >

Re: RFR: 8263760: Update gradle to version 7.0.1 [v2]

2021-05-19 Thread Ambarish Rapte
On Thu, 13 May 2021 21:55:59 GMT, Kevin Rushforth wrote: >> This PR fixes the gradle deprecation warnings described in >> [JDK-8240336](https://bugs.openjdk.java.net/browse/JDK-8240336) and updates >> the JavaFX build to use gradle 7.0.1 as described in >>

Re: [External] : Re: Minimum JDK policy for OpenJFX

2021-05-19 Thread Kevin Rushforth
These are all excellent points. I would add that while a new language feature would be the biggest reason to update, there could be new JDK API that we would want to use as an argument type or return type in a new FX API. I'm not aware of any in the JDK 12-16 range (at least not ones that

.classpath files for Eclipse

2021-05-19 Thread Tom Schindl
Hi Nir/Jeannette, As you are both using Eclipse for development I'd like to get your take on the following things. Dealing with OS specific The graphics module has to have different source folders depending on the OS you are developing on: * Windows:

Re: [External] : Re: Minimum JDK policy for OpenJFX

2021-05-19 Thread Johan Vos
Hi, This is an important and good discussion, and I've read a number of valid points. To reiterate what I've always stated: * we don't want to increase the base (JDK) version just for the sake of increasing * we don't want to lose significant benefits (or developer productivity) by sticking with

Re: RFR: 8267392: ENTER key press on editable TableView throws NPE

2021-05-19 Thread Kevin Rushforth
On Wed, 19 May 2021 14:06:21 GMT, Marius Hanl wrote: > > sounds like a duplicate of > > [JDK-8089652](https://bugs.openjdk.java.net/browse/JDK-8089652) - faintly > > remember that it's a dark pit: there are issues in selection/focus model > > implementations, see f.i. > >

Re: RFR: 8267392: ENTER key press on editable TableView throws NPE [v2]

2021-05-19 Thread Marius Hanl
On Wed, 19 May 2021 12:15:55 GMT, Kevin Rushforth wrote: >> Marius Hanl has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Addressed review comment (changed from NP to NPE) > >

Re: RFR: 8267392: ENTER key press on editable TableView throws NPE [v2]

2021-05-19 Thread Marius Hanl
> ~~Note: I reported the bug already, waiting for approval. Internal tracking > id: 9070318. I will update the title as soon as the ticket is created.~~ > EDIT: Changed the title. :) > > This PR is fixing a NP, which is thrown when you press ENTER on an editbale > table, after it is initially

Re: RFR: 8267392: ENTER key press on editable TableView throws NPE

2021-05-19 Thread Marius Hanl
On Wed, 19 May 2021 11:03:52 GMT, Jeanette Winzenburg wrote: > > > sounds like a duplicate of > [JDK-8089652](https://bugs.openjdk.java.net/browse/JDK-8089652) - faintly > remember that it's a dark pit: there are issues in selection/focus model > implementations, see f.i. >

Re: RFR: 8267392: ENTER key press on editable TableView throws NPE

2021-05-19 Thread Jeanette Winzenburg
On Wed, 19 May 2021 00:48:18 GMT, Marius Hanl wrote: > **Note: I reported the bug already, waiting for approval. Internal tracking > id: 9070318. I will update the title as soon as the ticket is created.** > > This PR is fixing a NP, which is thrown when you press ENTER on an editbale >

Re: RFR: 8267392: ENTER key press on editable TableView throws NPE

2021-05-19 Thread Kevin Rushforth
On Wed, 19 May 2021 00:48:18 GMT, Marius Hanl wrote: > **Note: I reported the bug already, waiting for approval. Internal tracking > id: 9070318. I will update the title as soon as the ticket is created.** > > This PR is fixing a NP, which is thrown when you press ENTER on an editbale >

RFR: 8267392: ENTER key press on editable TableView throws NPE

2021-05-19 Thread Marius Hanl
**Note: I reported the bug already, waiting for approval. Internal tracking id: 9070318. I will update the title as soon as the ticket is created.** This PR is fixing a NP, which is thrown when you press ENTER on an editbale table, after it is initially shown. When pressing ENTER,

Re: [External] : Re: Minimum JDK policy for OpenJFX

2021-05-19 Thread Kevin Rushforth
I missed seeing this reply yesterday. We can't bump the minimum to JDK 17 until at least JavaFX 18 without changing our policy that JavaFX N is able to build and run with JDK N-1. If we were to change that we would also need to delay our release to be after JDK 17 date (currently JavaFX N is

Re: Minimum JDK policy for OpenJFX

2021-05-19 Thread Kevin Rushforth
No. I've already done a full build and test using JDK 16 (and a full build using JDK 17 ea for that matter). -- Kevin On 5/18/2021 5:46 PM, Eric Bresie wrote: Are there any deprecated or removed (1) (2) dependencies that could cause problems? (1)

Re: Build error with gradle (command line)

2021-05-19 Thread Jeanette Winzenburg
Zitat von Nir Lisker : I'm getting this error in Eclipse when it tries to load the tasks, but in the command line I can build and test. I already refreshed the dependencies and cleaned the cache. Did you solve this in Eclipse? I'm not using gradle inside Eclipse: its build remained

[jfx11u] Integrated: 8266554: Change default macOS min version for aarch64 to 11.0

2021-05-19 Thread Johan Vos
On Tue, 18 May 2021 20:05:03 GMT, Johan Vos wrote: > Require at least MacOSX 11.0 to build on mac-AArch64. > Don't increase minimum SDK version when building on x86-64 (contrary to > JDK-8265031) This pull request has now been integrated. Changeset: 8805e436 Author:Johan Vos URL: