Re: Proposal for Enhancement to PixelBuffer/WritableImage to support pixelScale

2021-12-02 Thread Tom Schindl
ok answering my own question it is quite simple using setFitWidth/setFitHeight already today. ImageView renderingView renderingView.setFitWidth(width / scaleFactor); renderingView.setFitHeight(height / scaleFactor); I already tested that before sending out this mail but unfortunately it

Re: RFR: 8276313: ScrollPane scroll delta incorrectly depends on content height [v3]

2021-12-02 Thread Michael Strauß
> This PR fixes an issue where the scroll delta of ScrollPane incorrectly > depends on the size of its content. > This leads to extremely slow scrolling when the content is only slightly > larger than the ScrollPane. Michael Strauß has updated the pull request incrementally with one additional

Re: RFR: 8276313: ScrollPane scroll delta incorrectly depends on content height [v2]

2021-12-02 Thread Michael Strauß
On Thu, 2 Dec 2021 21:51:59 GMT, Kevin Rushforth wrote: >> Michael Strauß has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Handle division by zero > > modules/javafx.controls/src/main/java/javafx/scene/control/skin/ScrollPaneSkin.java >

Re: RFR: 8276170: Create Sources when publishing to Maven

2021-12-02 Thread Kevin Rushforth
On Fri, 29 Oct 2021 12:36:13 GMT, eduardsdv wrote: > Create sources.jars and attach they to the publish task, so that they can be > uploaded to the (e.g. maven) repository automatically. As discussed in the bug report, it isn't at all clear that we should do this. @johanvos can make the call

Re: RFR: 8276167: fixing VirtualFlow.scrollToTop(int)

2021-12-02 Thread Dalibor Topic
On Fri, 29 Oct 2021 12:19:40 GMT, eduardsdv wrote: > Fix VirtualFlow.scrollToTop(int) doesn't scroll to the top of the last > element but to the bottom of the last element. Hi, please send me an e-Mail at dalibor.to...@oracle.com and I can help with the verification process. -

RFR: 8276167: fixing VirtualFlow.scrollToTop(int)

2021-12-02 Thread eduardsdv
Fix VirtualFlow.scrollToTop(int) doesn't scroll to the top of the last element but to the bottom of the last element. - Commit messages: - JDK-8276167: fixing VirtualFlow.scrollToTop(int) Changes: https://git.openjdk.java.net/jfx/pull/656/files Webrev:

Re: RFR: 8276170: Create Sources when publishing to Maven

2021-12-02 Thread Florian Kirmaier
On Fri, 29 Oct 2021 12:36:13 GMT, eduardsdv wrote: > Create sources.jars and attach they to the publish task, so that they can be > uploaded to the (e.g. maven) repository automatically. I wonder how the sources for the official maven release are generated?

RFR: 8276170: Create Sources when publishing to Maven

2021-12-02 Thread eduardsdv
Create sources.jars and attach they to the publish task, so that they can be uploaded to the (e.g. maven) repository automatically. - Commit messages: - 8276170: Remove trailing whitespaces - JDK-8276170: Create Sources when publishing to Maven Changes:

Integrated: 8272118: ListViewSkin et al: must not cancel edit on scrolling

2021-12-02 Thread Jeanette Winzenburg
On Thu, 25 Nov 2021 15:46:01 GMT, Jeanette Winzenburg wrote: > Issue was that mouse pressed on the scrollbars of all virtualized controls > cancelled the edit. That's inconsistent with other scroll triggers > (mouseWheel, programmatic). Fixed by removing the cancel. > > Added tests that

Re: RFR: 8272118: ListViewSkin et al: must not cancel edit on scrolling

2021-12-02 Thread Jeanette Winzenburg
On Thu, 2 Dec 2021 00:18:37 GMT, Kevin Rushforth wrote: >> Issue was that mouse pressed on the scrollbars of all virtualized controls >> cancelled the edit. That's inconsistent with other scroll triggers >> (mouseWheel, programmatic). Fixed by removing the cancel. >> >> Added tests that

Proposal for Enhancement to PixelBuffer/WritableImage to support pixelScale

2021-12-02 Thread Tom Schindl
Hi, I'm try to get a HiDPI-Image produced by an external application into JavaFX using WritableImage. In the end the situation is comparable to what you get today when loading an image from an URL (eg sam...@2.png) where JavaFX sets the appropriate image pixelScale on "com.sun.prism.Image".