Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v4]

2021-12-16 Thread Kevin Rushforth
On Thu, 16 Dec 2021 21:08:49 GMT, Martin Fox wrote: > I can't build this branch anymore, something related to compiling > CCTaskGroovy. I think I need to merge or rebase to the latest version of > master. Which is preferred, merge or rebase? Merge, please. - PR:

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v4]

2021-12-16 Thread Martin Fox
On Thu, 25 Mar 2021 17:41:40 GMT, Martin Fox wrote: >> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as >> expected by more accurately mapping from a Mac key code to a Java key code >> based on the user’s active keyboard layout (the existing code assumes a US >> QWERTY

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v4]

2021-11-22 Thread Martin Fox
On Thu, 25 Mar 2021 17:41:40 GMT, Martin Fox wrote: >> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as >> expected by more accurately mapping from a Mac key code to a Java key code >> based on the user’s active keyboard layout (the existing code assumes a US >> QWERTY

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v4]

2021-11-17 Thread Kevin Rushforth
On Thu, 25 Mar 2021 17:41:40 GMT, Martin Fox wrote: >> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as >> expected by more accurately mapping from a Mac key code to a Java key code >> based on the user’s active keyboard layout (the existing code assumes a US >> QWERTY

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v4]

2021-11-17 Thread Christian Heilmann
On Wed, 6 Oct 2021 20:18:33 GMT, Martin Fox wrote: >> @beldenfox Can you somehow add the test you talked about in a previous >> comment? It always helps to have a test that fails before and succeeds after. >> Let me know if you need help with this? > > @johanvos I've attached my test app to

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v4]

2021-10-06 Thread Martin Fox
On Wed, 6 Oct 2021 19:42:41 GMT, Johan Vos wrote: >> @tomsontom I've added the Swing-style code as WIP PR #519. There are >> comments in the PR that probably should be in the code but I wanted to >> reduce the code diffs. >> >> PR #519 (and Swing) tend to get codes for punctuation keys wrong

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v4]

2021-10-06 Thread Johan Vos
On Tue, 25 May 2021 18:29:45 GMT, Martin Fox wrote: >> @beldenfox I did not say that the swing version is the way to go and in the >> end its @kevinrushforth call what route should be taken - I just wanted to >> show what my initial change would have been without saying it is better than >>

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v4]

2021-05-25 Thread Martin Fox
On Tue, 25 May 2021 10:40:50 GMT, Tom Schindl wrote: >> Is there some reason you would prefer a Swing-style implementation over the >> approach I submitted in this PR? The Swing code breaks down if an >> accelerator calls for the Option modifier alone or in addition to Command. >> I'm still

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v4]

2021-05-25 Thread Tom Schindl
On Mon, 24 May 2021 15:25:22 GMT, Martin Fox wrote: >> Martin Fox has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed whitespace error. > > Is there some reason you would prefer a Swing-style implementation over the > approach I

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v4]

2021-05-24 Thread Martin Fox
On Thu, 25 Mar 2021 17:41:40 GMT, Martin Fox wrote: >> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as >> expected by more accurately mapping from a Mac key code to a Java key code >> based on the user’s active keyboard layout (the existing code assumes a US >> QWERTY

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v4]

2021-05-21 Thread Tom Schindl
On Thu, 25 Mar 2021 17:41:40 GMT, Martin Fox wrote: >> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as >> expected by more accurately mapping from a Mac key code to a Java key code >> based on the user’s active keyboard layout (the existing code assumes a US >> QWERTY

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v4]

2021-05-20 Thread Martin Fox
On Thu, 25 Mar 2021 17:41:40 GMT, Martin Fox wrote: >> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as >> expected by more accurately mapping from a Mac key code to a Java key code >> based on the user’s active keyboard layout (the existing code assumes a US >> QWERTY

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v4]

2021-04-12 Thread Martin Fox
On Thu, 25 Mar 2021 17:41:40 GMT, Martin Fox wrote: >> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as >> expected by more accurately mapping from a Mac key code to a Java key code >> based on the user’s active keyboard layout (the existing code assumes a US >> QWERTY

Re: RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v4]

2021-03-25 Thread Martin Fox
> This PR adds code to ensure that KeyCodeCombinations match KeyEvents as > expected by more accurately mapping from a Mac key code to a Java key code > based on the user’s active keyboard layout (the existing code assumes a US > QWERTY layout). The new code first identifies a set of Mac keys