RE: [openssl.org #3320] Invalid large memory access in openssl due to a bug on the client side

2014-05-12 Thread Ajit Menon via RT
I think this is the right change. However, I see that there is another len-tot in the following conditional block #if !defined(OPENSSL_NO_MULTIBLOCK) EVP_CIPH_FLAG_TLS1_1_MULTIBLOCK This is within the same function. I wonder whether that line is also prone to the same issue and need the same

[openssl.org #3320] Invalid large memory access in openssl due to a bug on the client side

2014-05-12 Thread Matt Caswell via RT
On 12 May 2014 11:36, Ajit Menon via RT r...@openssl.org wrote: I think this is the right change. However, I see that there is another len-tot in the following conditional block #if !defined(OPENSSL_NO_MULTIBLOCK) EVP_CIPH_FLAG_TLS1_1_MULTIBLOCK This is within the same function. I wonder

RE: [openssl.org #3320] Invalid large memory access in openssl due to a bug on the client side

2014-05-12 Thread Ajit Menon
I think this is the right change. However, I see that there is another len-tot in the following conditional block #if !defined(OPENSSL_NO_MULTIBLOCK) EVP_CIPH_FLAG_TLS1_1_MULTIBLOCK This is within the same function. I wonder whether that line is also prone to the same issue and need the same

Re: [openssl.org #3320] Invalid large memory access in openssl due to a bug on the client side

2014-04-26 Thread Kurt Roeckx via RT
Libressl has a patch for this at: http://anoncvs.estpak.ee/cgi-bin/cgit/openbsd-src/commit/lib/libssl?id=cb8b51bf2f6517fe96ab0d20c4d9bba2eef1b67c I believe that patch is not really the correct fix. My understanding is that tot is what is already written, and that len is until where we want to

Re: [openssl.org #3320] Invalid large memory access in openssl due to a bug on the client side

2014-04-26 Thread Tim Hudson
On 26/04/2014 11:04 PM, Kurt Roeckx via RT wrote: Libressl has a patch for this at: http://anoncvs.estpak.ee/cgi-bin/cgit/openbsd-src/commit/lib/libssl?id=cb8b51bf2f6517fe96ab0d20c4d9bba2eef1b67c I believe that patch is not really the correct fix. My understanding is that tot is what is

Re: [openssl.org #3320] Invalid large memory access in openssl due to a bug on the client side

2014-04-26 Thread Tim Hudson via RT
On 26/04/2014 11:04 PM, Kurt Roeckx via RT wrote: Libressl has a patch for this at: http://anoncvs.estpak.ee/cgi-bin/cgit/openbsd-src/commit/lib/libssl?id=cb8b51bf2f6517fe96ab0d20c4d9bba2eef1b67c I believe that patch is not really the correct fix. My understanding is that tot is what is

RE: [openssl.org #3320] Invalid large memory access in openssl due to a bug on the client side

2014-04-26 Thread Salz, Rich
If the API requires the same buffer and count, then perhaps the SSL structure should hold those values, and require the user to send NULL/0 in subsequent calls? Or assert(). It's a programming error that requires source changes to fix. -- Principal Security Engineer Akamai Technologies,

RE: [openssl.org #3320] Invalid large memory access in openssl due to a bug on the client side

2014-04-26 Thread Salz, Rich via RT
If the API requires the same buffer and count, then perhaps the SSL structure should hold those values, and require the user to send NULL/0 in subsequent calls? Or assert(). It's a programming error that requires source changes to fix. -- Principal Security Engineer Akamai Technologies,

[openssl.org #3320] Invalid large memory access in openssl due to a bug on the client side

2014-04-21 Thread Ajit Menon via RT
Hi, This happens in the 0.9.8 branch for sure (event in the latest y version). Not sure if it is there in 1.x versions. The problem is with code in s3_pkt.c: the ssl3_write_bytes() function. Within this function, there is a line, n=(len-tot). Here if 'len' is less than 'tot' then the result is a