Hi,
On Tue, Dec 06, 2022 at 04:54:38PM +0100, Gert Doering wrote:
> I have not server-tested this, as it "should not" make a difference,
> and Arne did test this on s390. The full server tests will run
> tonight, though.
I *should* have, as that would have caught the fact that this patch
breaks
Acked-by: Gert Doering
Stared-at-code, ran unit tests beforehand on FreeBSD/amd64 and
AIX/PowerPC, verified that it *failed* on PowerPC. Ran unit tests
again with the patch, and both FreeBSD/amd64 and AIX/PowerPC succeeded
now, so endianness is taken into account now.
I have not server-tested
We accidentially checked the adress family size instead of the address
family.
For unit test checks we need to consider endianess to ensure the hmac
for the adress is always the same. The real code does not care about
endian since it only needs it to be same on the same architecture.
Converting
Modify the Win32-PE search path to find dependencies
in shared object origin location.
Needs https://github.com/OpenSC/pkcs11-helper/pull/59 to work.
Would be nice if this could still be included for v2.6,
an additional pkcs11-helper patch may be added to preempt the PR.
Am 06.12.22 um 17:19 schrieb Gert Doering:
Hi,
On Tue, Dec 06, 2022 at 04:54:38PM +0100, Gert Doering wrote:
I have not server-tested this, as it "should not" make a difference,
and Arne did test this on s390. The full server tests will run
tonight, though.
I *should* have, as that would
in case of absolute library path, search origin for dependencies
---
src/openvpn/pkcs11.c | 16 ++--
1 file changed, 14 insertions(+), 2 deletions(-)
needs https://github.com/OpenSC/pkcs11-helper/pull/59
diff --git a/src/openvpn/pkcs11.c b/src/openvpn/pkcs11.c
index
split provider creation, property modifications and initialization.
new interface available since pkcs11-helper v1.28
---
src/openvpn/pkcs11.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/src/openvpn/pkcs11.c b/src/openvpn/pkcs11.c
index
---
src/openvpn/pkcs11.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/src/openvpn/pkcs11.c b/src/openvpn/pkcs11.c
index 507af17c..b6ceb582 100644
--- a/src/openvpn/pkcs11.c
+++ b/src/openvpn/pkcs11.c
@@ -853,17 +853,7 @@ show_pkcs11_ids(
goto cleanup;
Hi,
bad news...
On Thu, Dec 01, 2022 at 12:01:28PM +0100, Arne Schwabe wrote:
> diff --git a/src/openvpn/forward.c b/src/openvpn/forward.c
> index 1b418b1bc..958bf0b56 100644
> --- a/src/openvpn/forward.c
> +++ b/src/openvpn/forward.c
> @@ -1174,9 +1174,22 @@ process_incoming_dco(struct context
