Re: [Openvpn-devel] [PATCH] cleanup: Remove faulty env processing functions

On 25/02/17 16:28, Илья Шипицин wrote: > > but for "[src/openvpn/error.c:824]: (error) Null pointer dereference", > I'm afraid we should guard it with "#if 0", otherwise static analyzer > will continue complain No. That function in error.c:824, crash(), which is only enabled with ENABLE_DEBUG is

[Openvpn-devel] [PATCH] travis-ci: add "make distcheck" to test scenario, V2

in rare cases openvpn is built from tarball, it happens during "installer build" process. "make distcheck" helps to prevent problems during such builds. V2: limit "make distcheck" to one build configuration Signed-off-by: Ilya Shipitsin --- .travis.yml | 3 ++- 1 file

Re: [Openvpn-devel] [PATCH] travis-ci: add "make distcheck" to test scenario

2017-02-25 21:10 GMT+05:00 Steffan Karger : > Hi, > > On 23-02-17 19:22, Ilya Shipitsin wrote: > > in rare cases openvpn is built from tarball, it happens during > "installer build" > > process. "make distcheck" helps to prevent problems during such builds. > > > >

Re: [Openvpn-devel] [PATCH] travis-ci: add "make distcheck" to test scenario

Hi, On 23-02-17 19:22, Ilya Shipitsin wrote: > in rare cases openvpn is built from tarball, it happens during "installer > build" > process. "make distcheck" helps to prevent problems during such builds. > > Signed-off-by: Ilya Shipitsin > --- > .travis.yml | 1 + > 1

Re: [Openvpn-devel] Should we use mbedTLS certificate profiles?

On 25-02-17 07:04, James Yonan wrote: > On 24/02/2017 16:10, Steffan Karger wrote: >> On 24-02-17 22:28, James Yonan wrote: >>> On 24/02/2017 02:40, Steffan Karger wrote: On 23-02-17 22:41, James Yonan wrote: > On 23/02/2017 01:22, Steffan Karger wrote: >> On 22-02-17 19:48, James

Re: [Openvpn-devel] [PATCH] cleanup: Remove faulty env processing functions

2017-02-25 19:36 GMT+05:00 Antonio Quartulli : > On Sat, Feb 25, 2017 at 06:45:36PM +0500, Илья Шипицин wrote: > > 2017-02-25 16:49 GMT+05:00 David Sommerseth < > > open...@sf.lists.topphemmelig.net>: > > > > > On 25/02/17 10:42, Илья Шипицин wrote: > > > > there are two another

Re: [Openvpn-devel] [PATCH] cleanup: Remove faulty env processing functions

On Sat, Feb 25, 2017 at 06:45:36PM +0500, Илья Шипицин wrote: > 2017-02-25 16:49 GMT+05:00 David Sommerseth < > open...@sf.lists.topphemmelig.net>: > > > On 25/02/17 10:42, Илья Шипицин wrote: > > > there are two another unused functions in misc.c > > > > > > [src/openvpn/misc.c:661]: (style) The

Re: [Openvpn-devel] [PATCH] cleanup: Remove faulty env processing functions

2017-02-25 16:49 GMT+05:00 David Sommerseth < open...@sf.lists.topphemmelig.net>: > On 25/02/17 10:42, Илья Шипицин wrote: > > there are two another unused functions in misc.c > > > > [src/openvpn/misc.c:661]: (style) The function 'env_set_print' is never > > used. > > This one is useful for

Re: [Openvpn-devel] [PATCH] Ignore auth-nocache for auth-user-pass if auth-token is pushed

On 25/02/17 10:19, Gert Doering wrote: > Hi, > > On Sat, Feb 25, 2017 at 08:40:14AM +0800, Antonio Quartulli wrote: >> When the auth-token option is pushed from the server to the client, >> the latter has to ignore the auth-nocache directive (if specified). >> >> The password will now be

Re: [Openvpn-devel] [PATCH] cleanup: Remove faulty env processing functions

On 25/02/17 10:42, Илья Шипицин wrote: > there are two another unused functions in misc.c > > [src/openvpn/misc.c:661]: (style) The function 'env_set_print' is never > used. This one is useful for debugging purposes, so I let this one stay. I did consider an #if 0 around it, to make it more

Re: [Openvpn-devel] [PATCH] cleanup: Remove faulty env processing functions

there are two another unused functions in misc.c [src/openvpn/misc.c:661]: (style) The function 'env_set_print' is never used. [src/openvpn/misc.c:895]: (style) The function 'setenv_int_i' is never used. 2017-02-25 7:02 GMT+05:00 David Sommerseth : > The

Re: [Openvpn-devel] [PATCH] travis-ci: add "make distcheck" to test scenario

ack ? nack ? 2017-02-23 23:22 GMT+05:00 Ilya Shipitsin : > in rare cases openvpn is built from tarball, it happens during "installer > build" > process. "make distcheck" helps to prevent problems during such builds. > > Signed-off-by: Ilya Shipitsin >

Re: [Openvpn-devel] [PATCH] Ignore auth-nocache for auth-user-pass if auth-token is pushed

Hi, On Sat, Feb 25, 2017 at 08:40:14AM +0800, Antonio Quartulli wrote: > When the auth-token option is pushed from the server to the client, > the latter has to ignore the auth-nocache directive (if specified). > > The password will now be substituted by the unique token, therefore > it can't be