FWIW, clang-formating is a requirement before creating pull requests for
the Vulkan repos at https://github.com/KhronosGroup
-- mew
On Sun, Apr 14, 2019 at 9:52 AM Robert Osfield
wrote:
> Hi Chris, Michael et. al,
>
> On Sun, 14 Apr 2019 at 15:50, michael kapelko wrote:
> > I would guess it
Hi all,
kornerr wrote:
> Hi, Chris.
>
> I would guess it might be not exactly appropriate to update
> OpenSceneGraph sources just to have the order in spaces and tabs.
> However, I think VulkanSceneGraph would definitely benefit
> EditorConfig rules. So once VSG has its place at GitHub, I would
Hi Chris, Michael et. al,
On Sun, 14 Apr 2019 at 15:50, michael kapelko wrote:
> I would guess it might be not exactly appropriate to update
> OpenSceneGraph sources just to have the order in spaces and tabs.
> However, I think VulkanSceneGraph would definitely benefit
> EditorConfig rules. So
Hi, Chris.
I would guess it might be not exactly appropriate to update
OpenSceneGraph sources just to have the order in spaces and tabs.
However, I think VulkanSceneGraph would definitely benefit
EditorConfig rules. So once VSG has its place at GitHub, I would
recommend re-raising this issue and
Hi,
Here's a list by file extension of which indentation styles are used.
Annoyingly, a lot of the file extensions that always have tabs somewhere often
have spaces, too, so it's not quite as simple as declaring all .java files use
tabs (although I'm assuming they all used tabs when they were
kornerr wrote:
> Hi, Chris,
>
> just create EditorConfig and share it. Those who are interested will
> follow you.Don't wait for us to want your thing. Just do the thing,
> show it and explain its benefits.
> You're not alone, we're here, but you lead EditorConfig initiative, not us.
>
>
Hi, Chris,
just create EditorConfig and share it. Those who are interested will
follow you.Don't wait for us to want your thing. Just do the thing,
show it and explain its benefits.
You're not alone, we're here, but you lead EditorConfig initiative, not us.
Regards
On Tue, 2 Apr 2019 at 09:55,
Hi Chris,
On Mon, 1 Apr 2019 at 22:17, Chris Djali wrote:
> It's been a couple of weeks, and I've not had any response about any official
> policy on indentation in the case of existing files that already break the
> global rule. Should I just go for the stance of "it's supposed to be spaces
Hi,
It's been a couple of weeks, and I've not had any response about any official
policy on indentation in the case of existing files that already break the
global rule. Should I just go for the stance of "it's supposed to be spaces for
everything except for files that are already entirely
I just grepped the repo for tabs just in case, and found that that's not
entirely accurate. There are a few files where tabs have snuck into otherwise
space-indented files (which is fine - adding an editorconfig file won't meddle
with existing stuff until someone edits that line), but it looks
Hi Chris,
The OSG codebase uses four spaces for tabs.
I don't have any strong opinions on adding EditorConfig file.
Cheers,
Robert.
___
osg-users mailing list
osg-users@lists.openscenegraph.org
I'm fine making the pull request. I'd just like confirmation of exactly what
the whitespace conventions are - I wouldn't want to set it to use four spaces
for indentation for everything and then find out later that the CMake files use
tabs or anything like that.
The main rules are listed here:
Hi.
We're waiting for your pull request ;)
On Thu, 14 Mar 2019 at 03:01, Chris Djali wrote:
>
> Hi,
>
> I just noticed (when looking at a local modification and realising my IDE had
> added tabs to a file using spaces) that the OSG repo doesn't contain an
> EditorConfig file. This is
Hi,
I just noticed (when looking at a local modification and realising my IDE had
added tabs to a file using spaces) that the OSG repo doesn't contain an
EditorConfig file. This is basically a file that instructs IDEs and editors of
a project's whitespace style, overriding the user's settings
14 matches
Mail list logo
