Re: Permute underscore separated components of columns before fuzzy matching

2024-03-03 Thread Andrey M. Borodin
> On 23 Jan 2024, at 09:42, Arne Roland wrote: > > <0001-fuzzy_underscore_permutation_v5.patch> Mikhail, there’s a new patch version. May I ask you to review it? Best regards, Andrey Borodin.

Re: Permute underscore separated components of columns before fuzzy matching

2024-01-22 Thread Arne Roland
Thank you! I wasn't aware of the filter per person. It was quite simple integrate a web scraper into my custom push system. Regarding the patch: I ran the 2.1.1 version of pg_bsd_indent now. I hope that suffices. I removed the matrix declaration to make it C90 complaint. I attached the

Re: Permute underscore separated components of columns before fuzzy matching

2024-01-22 Thread Tom Lane
Arne Roland writes: > Thank you for bringing that to my attention. Is there a way to subscribe > to cf-bot failures? I don't know of any push notification support in cfbot, but you can bookmark the page with your own active patches, and check it periodically:

Re: Permute underscore separated components of columns before fuzzy matching

2024-01-22 Thread Arne Roland
Thank you for bringing that to my attention. Is there a way to subscribe to cf-bot failures? Apparently I confused myself with my naming. I attached a patch that fixes the bug (at least at my cassert test-world run). Regards Arne On 2024-01-22 06:38, Peter Smith wrote: 2024-01 Commitfest.

Re: Permute underscore separated components of columns before fuzzy matching

2024-01-21 Thread Peter Smith
2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems like there were CFbot test failures last time it was run [2]. Please have a look and post an updated version if necessary. == [1] https://commitfest.postgresql.org/46/4282/ [2]

Re: Permute underscore separated components of columns before fuzzy matching

2023-12-31 Thread Arne Roland
Hi! Mikhail Gribkov writes: > > Honestly I'm not entirely sure fixing only two switched words is worth the > > effort, but the declared goal is clearly achieved. > > > > I think the patch is good to go, although you need to fix code formatting. > > > I took a brief look at this.  I concur

Re: Permute underscore separated components of columns before fuzzy matching

2023-11-17 Thread Tom Lane
Mikhail Gribkov writes: > Honestly I'm not entirely sure fixing only two switched words is worth the > effort, but the declared goal is clearly achieved. > I think the patch is good to go, although you need to fix code formatting. I took a brief look at this. I concur that we shouldn't need to

Re: Permute underscore separated components of columns before fuzzy matching

2023-07-24 Thread Mikhail Gribkov
4-71-12 Telegram: @youzhick On Mon, Jul 17, 2023 at 1:42 AM Arne Roland wrote: > Hello Mikhail, > > I'm sorry. Please try attached patch instead. > > Thank you for having a look! > > Regards > Arne > > ---------- > *From:* Mikhail Gribkov >

Re: Permute underscore separated components of columns before fuzzy matching

2023-07-16 Thread Arne Roland
Hello Mikhail, I'm sorry. Please try attached patch instead. Thank you for having a look! Regards Arne From: Mikhail Gribkov Sent: Thursday, July 6, 2023 13:31 To: Arne Roland Cc: Pg Hackers Subject: Re: Permute underscore separated components of columns

Re: Permute underscore separated components of columns before fuzzy matching

2023-07-06 Thread Mikhail Gribkov
The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: tested, failed Documentation:tested, failed Hello Arne, The goal of supporting words-switching hints

Re: Permute underscore separated components of columns before fuzzy matching

2023-07-06 Thread Mikhail Gribkov
Hello Arne, The goal of supporting words-switching hints sounds interesting and I've tried to apply your patch. The patch was applied smoothly to the latest master and check-world reported no problems. Although I had problems after trying to test the new functionality. I tried to simply mix

Permute underscore separated components of columns before fuzzy matching

2023-01-06 Thread Arne Roland
Hello, we have the great fuzzy string match, that comes up with suggestions in the case of a typo of a column name. Since underscores are the de facto standard of separating words, it would also make sense to also generate suggestions, if the order of words gets mixed up. Example: If the user