Re: Track in pg_replication_slots the reason why slots conflict?

2023-12-31 Thread shveta malik
On Mon, Jan 1, 2024 at 9:14 AM shveta malik wrote: > > On Fri, Dec 29, 2023 at 3:35 PM Michael Paquier wrote: > > > > On Fri, Dec 29, 2023 at 09:20:52AM +0530, Amit Kapila wrote: > > > Does anyone have a preference for a column name? The options on the > > > table are conflict_cause,

Re: Autonomous transactions 2023, WIP

2023-12-31 Thread Pavel Stehule
Hi ne 31. 12. 2023 v 15:15 odesílatel Ivan Kush napsal: > > On 24.12.2023 15:38, Pavel Stehule wrote: > > Can you show some benchmarks? I don't like this system too much but > > maybe it can work enough. > > > > Still I am interested in possible use cases. If it should be used only > > for

Re: Next step towards 64bit XIDs: Switch to FullTransactionId for PGPROC->xid and XLogRecord->xl_xid

2023-12-31 Thread Maxim Orlov
On Fri, 29 Dec 2023 at 16:36, Matthias van de Meent < boekewurm+postg...@gmail.com> wrote: > > I don't think this is an actionable change, as this wastes 4 more bytes > (or 8 with alignment) in nearly all WAL records that don't use the > HEAP/HEAP2/XLOG rmgrs, which would then be up to 10 (if not

Re: Build versionless .so for Android

2023-12-31 Thread Matthias Kuhn
Thanks for all the comments and help. I have added the patch to the January CF. It looks like meson does not currently support building for android, the following output is what I get (but I have actually no experience with meson): meson.build:320:2: ERROR: Problem encountered: unknown host

Re: Commitfest manager January 2024

2023-12-31 Thread Shubham Khanna
On Sat, Dec 23, 2023 at 8:53 AM vignesh C wrote: > > Hi, > > I didn't see anyone volunteering for the January Commitfest, so I'll > volunteer to be CF manager for January 2024 Commitfest. I can assist with the January 2024 Commitfest. Thanks and Regards, Shubham Khanna.

Re: Track in pg_replication_slots the reason why slots conflict?

2023-12-31 Thread shveta malik
On Fri, Dec 29, 2023 at 3:35 PM Michael Paquier wrote: > > On Fri, Dec 29, 2023 at 09:20:52AM +0530, Amit Kapila wrote: > > Does anyone have a preference for a column name? The options on the > > table are conflict_cause, conflicting_cause, conflict_reason. Any > > others? I was checking docs for

Re: Commitfest manager January 2024

2023-12-31 Thread vignesh C
On Sun, 24 Dec 2023 at 18:40, vignesh C wrote: > > On Sun, 24 Dec 2023 at 07:16, Michael Paquier wrote: > > > > On Sat, Dec 23, 2023 at 08:52:38AM +0530, vignesh C wrote: > > > I didn't see anyone volunteering for the January Commitfest, so I'll > > > volunteer to be CF manager for January 2024

Re: Add support for __attribute__((returns_nonnull))

2023-12-31 Thread John Naylor
On Thu, Dec 28, 2023 at 1:20 AM Tristan Partin wrote: > I recently wound up in a situation where I was checking for NULL return > values of a function that couldn't ever return NULL because the > inability to allocate memory was always elog(ERROR)ed (aborted). It sounds like you have a ready

Re: Commitfest 2024-01 starting in 3 days!

2023-12-31 Thread vignesh C
On Sun, 31 Dec 2023 at 06:19, Michael Paquier wrote: > > On Fri, Dec 29, 2023 at 02:41:55PM +0530, vignesh C wrote: > > Commitfest 2024-01 is starting in 3 days! > > Please register the patches which have not yet registered. Also if > > someone has some pending patch that is not yet submitted,

Re: SET ROLE x NO RESET

2023-12-31 Thread Joe Conway
On 12/30/23 17:19, Michał Kłeczek wrote: On 30 Dec 2023, at 17:16, Eric Hanson wrote: What do you think of adding a NO RESET option to the SET ROLE command? What I proposed some time ago is SET ROLE … GUARDED BY ‘password’, so that you could later: RESET ROLE WITH ‘password' I like that

Re: Build versionless .so for Android

2023-12-31 Thread Joe Conway
On 12/31/23 01:24, Michael Paquier wrote: On Sun, Dec 31, 2023 at 06:08:04AM +0100, Matthias Kuhn wrote: I was wondering if there are a) any comments on the approach and if I should be handed in for a commitfest (currently waiting for the cooldown period after account activation, I am not sure

Re: [17] CREATE SUBSCRIPTION ... SERVER

2023-12-31 Thread Jeff Davis
On Fri, 2023-12-29 at 15:22 -0800, Jeff Davis wrote: > On Tue, 2023-09-05 at 12:08 -0700, Jeff Davis wrote: > > OK, so we could have a built-in FDW called pg_connection that would > > do > > the right kinds of validation; and then also allow other FDWs but > > the > > subscription would have to do

Re: pg_stat_statements: more test coverage

2023-12-31 Thread Tom Lane
Peter Eisentraut writes: > It looks like the failing configurations are exactly all the big-endian > ones: s390x, sparc, powerpc. So it's possible that this is actually a > bug? But unless someone can reproduce this locally and debug it, we > should probably revert this for now. The reason

Re: Streaming I/O, vectored I/O (WIP)

2023-12-31 Thread Melanie Plageman
I've written a new version of the vacuum streaming read user on top of the rebased patch set [1]. It differs substantially from Andres' and includes several refactoring patches that can apply on top of master. As such, I've proposed those in a separate thread [2]. I noticed mac and windows fail to

Confine vacuum skip logic to lazy_scan_skip

2023-12-31 Thread Melanie Plageman
Hi, I've written a patch set for vacuum to use the streaming read interface proposed in [1]. Making lazy_scan_heap() async-friendly required a bit of refactoring of lazy_scan_heap() and lazy_scan_skip(). I needed to confine all of the skipping logic -- previously spread across lazy_scan_heap()

Re: Permute underscore separated components of columns before fuzzy matching

2023-12-31 Thread Arne Roland
Hi! Mikhail Gribkov writes: > > Honestly I'm not entirely sure fixing only two switched words is worth the > > effort, but the declared goal is clearly achieved. > > > > I think the patch is good to go, although you need to fix code formatting. > > > I took a brief look at this.  I concur

Re: pg_stat_statements: more test coverage

2023-12-31 Thread Tom Lane
Peter Eisentraut writes: > It looks like the failing configurations are exactly all the big-endian > ones: s390x, sparc, powerpc. So it's possible that this is actually a > bug? But unless someone can reproduce this locally and debug it, we > should probably revert this for now. I see it

Re: Fixing backslash dot for COPY FROM...CSV

2023-12-31 Thread Daniel Verite
Hi, The CI patch tester fails on this patch, because it has a label at the end of a C block, which I'm learning is a C23 feature that happens to be supported by gcc 11 [1], but is not portable. PFA an update fixing this, plus removing an obsolete chunk in the COPY documentation that v2 left

Re: Password leakage avoidance

2023-12-31 Thread Jonathan S. Katz
On 12/31/23 9:50 AM, Magnus Hagander wrote: On Wed, Dec 27, 2023 at 10:31 PM Jonathan S. Katz wrote: On 12/24/23 12:15 PM, Tom Lane wrote: Maybe we need a PQcreaterole that provide the mechanism to set passwords safely. It'd likely need to take all the options need for creating a role, but

Re: Password leakage avoidance

2023-12-31 Thread Magnus Hagander
On Wed, Dec 27, 2023 at 10:31 PM Jonathan S. Katz wrote: > > On 12/24/23 12:15 PM, Tom Lane wrote: > > >> Maybe we need a PQcreaterole that provide the mechanism to set passwords > >> safely. It'd likely need to take all the options need for creating a > >> role, but that would at least give the

Re: Remove useless GROUP BY columns considering unique index

2023-12-31 Thread jian he
On Fri, Dec 29, 2023 at 11:05 PM Zhang Mingli wrote: > > Hi, > > This idea first came from remove_useless_groupby_columns does not need to > record constraint dependencie[0] which points out that > unique index whose columns all have NOT NULL constraints could also take the > work with primary

Re: Autonomous transactions 2023, WIP

2023-12-31 Thread Ivan Kush
On 24.12.2023 15:38, Pavel Stehule wrote: Can you show some benchmarks? I don't like this system too much but maybe it can work enough. Still I am interested in possible use cases. If it should be used only for logging, then we can implement something less generic, but surely with better

Network failure may prevent promotion

2023-12-31 Thread Kyotaro Horiguchi
(Apology for resubmitting due to poor subject of the previous mail) --- Hello. We've noticed that when walreceiver is waiting for a connection to complete, standby does not immediately respond to promotion requests. In PG14, upon receiving a promotion request, walreceiver terminates instantly,

libpqsrv_connect_params should call ProcessWalRcvInterrupts

2023-12-31 Thread Kyotaro Horiguchi
Hello. We've noticed that when walreceiver is waiting for a connection to complete, standby does not immediately respond to promotion requests. In PG14, upon receiving a promotion request, walreceiver terminates instantly, but in PG16, it waits for connection timeout. This behavior is attributed

Re: pg_stat_statements: more test coverage

2023-12-31 Thread Peter Eisentraut
On 31.12.23 10:26, Julien Rouhaud wrote: On Sun, Dec 31, 2023 at 2:28 PM Michael Paquier wrote: On Sat, Dec 30, 2023 at 08:39:47PM +0100, Peter Eisentraut wrote: Ok, I have committed these two patches. Please note that the buildfarm has turned red, as in:

Re: Things I don't like about \du's "Attributes" column

2023-12-31 Thread Pavel Luzanov
On 30.12.2023 17:33, Isaac Morland wrote: Would it make sense to make the column non-nullable and always set it to infinity when there is no expiry? A password is not required for roles. In many cases, external authentication is used in ph_hba.conf. I think it would be strange to have

Re: A typo in a messsage?

2023-12-31 Thread Kyotaro Horiguchi
At Wed, 27 Dec 2023 13:34:50 +0700, John Naylor wrote in > > Shouldn't the "is" following "LSN" be "in"? > > Pushed. At Wed, 27 Dec 2023 13:35:24 +0700, John Naylor wrote in >> I think "crc" should be in all uppercase in general and a brief >> grep'ing told me that it is almost always or

Re: pg_basebackup has an accidentaly separated help message

2023-12-31 Thread Kyotaro Horiguchi
At Tue, 26 Dec 2023 19:04:53 +0900, Michael Paquier wrote in > On Mon, Dec 25, 2023 at 05:07:28PM +0900, Kyotaro Horiguchi wrote: > > Yes. So, it turns out that they're found after they have been > > committed. > > No problem. I've just applied what you had. I hope this makes your > life a

Re: pg_stat_statements: more test coverage

2023-12-31 Thread Julien Rouhaud
On Sun, Dec 31, 2023 at 2:28 PM Michael Paquier wrote: > > On Sat, Dec 30, 2023 at 08:39:47PM +0100, Peter Eisentraut wrote: > > Ok, I have committed these two patches. > > Please note that the buildfarm has turned red, as in: >