Re: Improve eviction algorithm in ReorderBuffer

Hi, On Wed, Jan 31, 2024 at 5:32 PM vignesh C wrote: > > On Tue, 30 Jan 2024 at 13:37, Masahiko Sawada wrote: > > > > On Fri, Jan 26, 2024 at 5:36 PM Masahiko Sawada > > wrote: > > > > > > On Wed, Dec 20, 2023 at 12:11 PM Amit Kapila > > > wrote: > > > > > > > > On Wed, Dec 20, 2023 at 6:49 

Re: Commitfest 2024-01 is now closed

On Fri, Feb 2, 2024 at 2:41 PM Michael Paquier wrote: > On Fri, Feb 02, 2024 at 11:56:36AM +0530, Amit Kapila wrote: > > On Fri, Feb 2, 2024 at 10:58 AM Tom Lane wrote: > >> Thanks for all the work you did running it! CFM is typically a > >> thankless exercise in being a nag, but I thought you

Re: Make COPY format extendable: Extract COPY TO format implementations

Hi, In "Re: Make COPY format extendable: Extract COPY TO format implementations" on Fri, 2 Feb 2024 15:27:15 +0800, Junwang Zhao wrote: > I agree CopyToRoutine should be placed into CopyToStateData, but > why set it after ProcessCopyOptions, the implementation of > CopyToGetRoutine

Re: An improvement on parallel DISTINCT

On Fri, Feb 2, 2024 at 11:26 AM David Rowley wrote: > In light of this, do you still think it's worthwhile making this change? > > For me, I think all it's going to result in is extra planner work > without any performance gains. Hmm, with the query below, I can see that the new plan is

Re: Make COPY format extendable: Extract COPY TO format implementations

Hi, In "Re: Make COPY format extendable: Extract COPY TO format implementations" on Fri, 2 Feb 2024 15:21:31 +0900, Michael Paquier wrote: > I have done a review of v10, see v11 attached which is still WIP, with > the patches for COPY TO and COPY FROM merged together. Note that I'm >

Re: Make COPY format extendable: Extract COPY TO format implementations

On Fri, Feb 2, 2024 at 2:21 PM Michael Paquier wrote: > > On Fri, Feb 02, 2024 at 09:40:56AM +0900, Sutou Kouhei wrote: > > Thanks. It'll help us. > > I have done a review of v10, see v11 attached which is still WIP, with > the patches for COPY TO and COPY FROM merged together. Note that I'm >

Re: Is this a problem in GenericXLogFinish()?

On Fri, Dec 01, 2023 at 03:27:33PM +0530, Amit Kapila wrote: > Pushed! Amit, this has been applied as of 861f86beea1c, and I got pinged about the fact this triggers inconsistencies because we always set the LSN of the write buffer (wbuf in _hash_freeovflpage) but XLogRegisterBuffer() would *not*

Re: Small fix on COPY ON_ERROR document

On Fri, 02 Feb 2024 11:29:41 +0900 torikoshia wrote: > On 2024-02-01 15:16, Yugo NAGATA wrote: > > On Mon, 29 Jan 2024 15:47:25 +0900 > > Yugo NAGATA wrote: > > > >> On Sun, 28 Jan 2024 19:14:58 -0700 > >> "David G. Johnston" wrote: > >> > >> > > Also, I think "invalid input syntax" is a bit

Re: Synchronizing slots from primary to standby

On Thu, Feb 1, 2024 at 5:29 PM shveta malik wrote: > > On Thu, Feb 1, 2024 at 2:35 PM Amit Kapila wrote: > > > > Agreed, and I am fine with merging 0001, 0002, and 0004 as suggested > > by you though I have a few minor comments on 0002 and 0004. I was > > thinking about what will be a logical

Re: Synchronizing slots from primary to standby

Here are some review comments for v750002. (this is a WIP but this is what I found so far...) == doc/src/sgml/protocol.sgml 1. > > 2. ALTER_REPLICATION_SLOT slot_name ( option [, ...] ) # > > > > > > - If true, the slot is enabled to be synced to the standbys. > > +

Re: Commitfest 2024-01 is now closed

On Fri, Feb 2, 2024 at 2:19 PM vignesh C wrote: > > Hi, > > Thanks a lot to all the members who participated in the commitfest. > > Here are the final numbers at the end of the commitfest: > status | w1 | w2 | w3 | w4| End >

Re: Avoid unncessary always true test (src/backend/storage/buffer/bufmgr.c)

On Fri, Feb 02, 2024 at 12:04:39AM +0530, vignesh C wrote: > The patch which you submitted has been awaiting your attention for > quite some time now. As such, we have moved it to "Returned with > Feedback" and removed it from the reviewing queue. Depending on > timing, this may be reversible.

Re: Improve eviction algorithm in ReorderBuffer

On Wed, Jan 31, 2024 at 2:18 PM Hayato Kuroda (Fujitsu) wrote: > > Dear Sawada-san, > > I have started to read your patches. Here are my initial comments. > At least, all subscription tests were passed on my env. Thank you for the review comments! > > A comment for 0001: > > 01. > ``` > +static

Re: Commitfest 2024-01 is now closed

On Fri, Feb 02, 2024 at 11:56:36AM +0530, Amit Kapila wrote: > On Fri, Feb 2, 2024 at 10:58 AM Tom Lane wrote: >> Thanks for all the work you did running it! CFM is typically a >> thankless exercise in being a nag, but I thought you put in more >> than the usual amount of effort to keep things

Re: Synchronizing slots from primary to standby

On Fri, Feb 2, 2024 at 1:58 PM Amit Kapila wrote: > > On Fri, Feb 2, 2024 at 6:46 AM Masahiko Sawada wrote: > > > > On Thu, Feb 1, 2024 at 12:51 PM Amit Kapila wrote: > > > > > > > > > > BTW I've tested the following switch/fail-back scenario but it seems > > > > not to work fine. Am I missing

Re: Commitfest 2024-01 is now closed

On Fri, Feb 2, 2024 at 10:58 AM Tom Lane wrote: > > vignesh C writes: > > Thanks a lot to all the members who participated in the commitfest. > > Thanks for all the work you did running it! CFM is typically a > thankless exercise in being a nag, but I thought you put in more > than the usual

Re: Make COPY format extendable: Extract COPY TO format implementations

On Fri, Feb 02, 2024 at 09:40:56AM +0900, Sutou Kouhei wrote: > Thanks. It'll help us. I have done a review of v10, see v11 attached which is still WIP, with the patches for COPY TO and COPY FROM merged together. Note that I'm thinking to merge them into a single commit. @@ -74,11 +75,11 @@

Re: Synchronizing slots from primary to standby

On Fri, Feb 2, 2024 at 9:50 AM Peter Smith wrote: > > Here are some review comments for v750001. > > ~~~ > > 2. > This patch also implements a new API libpqrcv_get_dbname_from_conninfo() > to extract database name from the given connection-info > > ~ > > /extract database name/the extract

Re: Add new COPY option REJECT_LIMIT

On 2024-01-27 00:20, David G. Johnston wrote: Thanks for your comments! On Fri, Jan 26, 2024 at 2:49 AM torikoshia wrote: Hi, 9e2d870 enabled the COPY command to skip soft error, and I think we can add another option which specifies the maximum tolerable number of soft errors. I remember

Re: SLRU optimization - configurable buffer pool and partitioning the SLRU lock

On Thu, Feb 1, 2024 at 4:34 PM Dilip Kumar wrote: > > On Thu, Feb 1, 2024 at 4:12 PM Dilip Kumar wrote: > > > > On Thu, Feb 1, 2024 at 3:44 PM Alvaro Herrera > > wrote: > > > Okay. > > > > > > While I have your attention -- if you could give a look to the 0001 > > > patch I posted, I would

Re: Synchronizing slots from primary to standby

Hi, On Thu, Feb 01, 2024 at 05:29:15PM +0530, shveta malik wrote: > Attached v75 patch-set. Changes are: > > 1) Re-arranged the patches: > 1.1) 'libpqrc' related changes (from v74-001 and v74-004) are > separated out in v75-001 as those are independent changes. > 1.2) 'Add logical slot sync

Re: Race condition in FetchTableStates() breaks synchronization of subscription tables

Hello Vignesh and Hou-san, 01.02.2024 07:59, vignesh C wrote: Here is an updated patch which changes the boolean variable to a tri-state enum and set stable state to valid only if no invalidations have been occurred while the list is being prepared. While testing the v3 patch, I observed

Re: SQL:2011 application time

On Mon, Jan 29, 2024 at 8:00 AM jian he wrote: > > I fixed your tests, some of your tests can be simplified, (mainly > primary key constraint is unnecessary for the failed tests) > also your foreign key patch test table, temporal_rng is created at > line 141, and we use it at around line 320. >

Re: More new SQL/JSON item methods

On Thu, Feb 1, 2024 at 11:25 AM Kyotaro Horiguchi wrote: > At Thu, 1 Feb 2024 09:22:22 +0530, Jeevan Chalke < > jeevan.cha...@enterprisedb.com> wrote in > > On Thu, Feb 1, 2024 at 7:24 AM Kyotaro Horiguchi < > horikyota@gmail.com> > > wrote: > > > > > At Thu, 01 Feb 2024 10:49:57 +0900

Re: Commitfest 2024-01 is now closed

vignesh C writes: > Thanks a lot to all the members who participated in the commitfest. Thanks for all the work you did running it! CFM is typically a thankless exercise in being a nag, but I thought you put in more than the usual amount of effort to keep things moving.

Re: Synchronizing slots from primary to standby

Hi, On Thu, Feb 01, 2024 at 04:12:43PM +0530, Amit Kapila wrote: > On Thu, Jan 25, 2024 at 11:26 AM Bertrand Drouvot > wrote: > > > > On Wed, Jan 24, 2024 at 04:09:15PM +0530, shveta malik wrote: > > > On Wed, Jan 24, 2024 at 2:38 PM Bertrand Drouvot > > > wrote: > > > > > > > > I also see

Commitfest 2024-01 is now closed

Hi, Thanks a lot to all the members who participated in the commitfest. Here are the final numbers at the end of the commitfest: status | w1 | w2 | w3 | w4| End ++--++-+-- Needs review:

Re: Improve eviction algorithm in ReorderBuffer

On Fri, Jan 26, 2024 at 2:07 PM Masahiko Sawada wrote: > > On Wed, Dec 20, 2023 at 12:11 PM Amit Kapila wrote: > > > > On Wed, Dec 20, 2023 at 6:49 AM Masahiko Sawada > > wrote: > > > > > > On Tue, Dec 19, 2023 at 8:02 PM Amit Kapila > > > wrote: > > > > > > > > On Tue, Dec 19, 2023 at 8:31 

Re: Synchronizing slots from primary to standby

On Fri, Feb 2, 2024 at 6:46 AM Masahiko Sawada wrote: > > On Thu, Feb 1, 2024 at 12:51 PM Amit Kapila wrote: > > > > > > > BTW I've tested the following switch/fail-back scenario but it seems > > > not to work fine. Am I missing something? > > > > > > Setup: > > > node1 is the primary, node2 is

Re: POC: GROUP BY optimization

On 2/2/2024 11:06, Richard Guo wrote: On Fri, Feb 2, 2024 at 11:32 AM Richard Guo > wrote: On Fri, Feb 2, 2024 at 10:02 AM Tom Lane mailto:t...@sss.pgh.pa.us>> wrote: One of the test cases added by this commit has not been very stable in the

Re: Synchronizing slots from primary to standby

Here are some review comments for v750001. == Commit message 1. This patch provides support for non-replication connection in libpqrcv_connect(). ~ 1a. /connection/connections/ ~ 1b. Maybe there needs to be a few more sentences just to describe what you mean by "non-replication

Re: POC: GROUP BY optimization

On Fri, Feb 2, 2024 at 11:32 AM Richard Guo wrote: > On Fri, Feb 2, 2024 at 10:02 AM Tom Lane wrote: > >> One of the test cases added by this commit has not been very >> stable in the buildfarm. Latest example is here: >> >> >>

Re: POC: GROUP BY optimization

On 2/2/2024 09:02, Tom Lane wrote: Alexander Korotkov writes: I'm going to push this if there are no objections. One of the test cases added by this commit has not been very stable in the buildfarm. Latest example is here:

Re: POC: GROUP BY optimization

On Fri, Feb 2, 2024 at 10:02 AM Tom Lane wrote: > Alexander Korotkov writes: > > I'm going to push this if there are no objections. > > One of the test cases added by this commit has not been very > stable in the buildfarm. Latest example is here: > > >

Re: An improvement on parallel DISTINCT

On Wed, 27 Dec 2023 at 00:23, Richard Guo wrote: > -- on master > EXPLAIN (costs off) > SELECT DISTINCT four FROM tenk1; > QUERY PLAN > > Unique >-> Sort > Sort Key: four > -> Gather >

Re: Small fix on COPY ON_ERROR document

On 2024-02-01 15:16, Yugo NAGATA wrote: On Mon, 29 Jan 2024 15:47:25 +0900 Yugo NAGATA wrote: On Sun, 28 Jan 2024 19:14:58 -0700 "David G. Johnston" wrote: > > Also, I think "invalid input syntax" is a bit ambiguous. For example, > > COPY FROM raises an error when the number of input column

Re: Oversight in reparameterize_path_by_child leading to executor crash

On Fri, Feb 2, 2024 at 1:45 AM Tom Lane wrote: > I pushed v12 (with some cosmetic adjustments) into the back branches, > since we're getting close to the February release freeze. We still > need to deal with the larger fix for HEAD. Please re-post that > one so that the cfbot knows which is

Re: set_cheapest without checking pathlist

On Thu, Feb 1, 2024 at 1:36 AM Richard Guo wrote: > > > On Thu, Feb 1, 2024 at 11:37 AM David Rowley wrote: >> >> On Thu, 1 Feb 2024 at 16:29, Richard Guo wrote: >> > On Thu, Feb 1, 2024 at 10:04 AM James Coleman wrote: >> >> I don't see any inherent reason why we must always assume that >> >>

Re: speed up a logical replica setup

On Thu, Feb 1, 2024, at 9:47 AM, Hayato Kuroda (Fujitsu) wrote: > I made fix patches to solve reported issues by Fabrízio. > > * v13-0001: Same as v11-0001 made by Euler. > * v13-0002: Fixes ERRORs while dropping replication slots [1]. >If you want to see codes which we get agreement,

Re: POC: GROUP BY optimization

Alexander Korotkov writes: > I'm going to push this if there are no objections. One of the test cases added by this commit has not been very stable in the buildfarm. Latest example is here: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=prion=2024-02-01%2021%3A28%3A04 and I've seen

Re: Synchronizing slots from primary to standby

On Thu, Feb 1, 2024 at 12:51 PM Amit Kapila wrote: > > On Wed, Jan 31, 2024 at 9:20 PM Masahiko Sawada wrote: > > > > On Wed, Jan 31, 2024 at 7:42 PM Amit Kapila wrote: > > > > > > > > > Considering my previous where we don't want to restart for a required > > > parameter change, isn't it

Re: Make COPY format extendable: Extract COPY TO format implementations

On Fri, Feb 02, 2024 at 06:51:02AM +0900, Michael Paquier wrote: > I am going to try to plug in some rusage() calls in the backend for > the COPY paths. I hope that gives more precision about the backend > activity. I'll post that with more numbers. And here they are with log_statement_stats

Re: set_cheapest without checking pathlist

On Thu, Feb 1, 2024 at 5:03 PM David Rowley wrote: > On Thu, 1 Feb 2024 at 19:36, Richard Guo wrote: > > maybe we can add an Assert or a comment clarifying that the pathlist of > > partially_grouped_rel cannot be empty here. > > There'd be no need to Assert that as set_cheapest() will raise an

Re: Fix log_line_prefix to display the transaction id (%x) for statements not in a transaction block

A little tweak to the code. GetTopTransactionIdIfAny() != InvalidTransactionId changed to TransactionIdIsValid(GetTopTransactionIdIfAny() On 2024/1/12 08:51, jian he wrote: Hi ... with patch: src3=# explain(analyze, costs off) select 1 from pg_sleep(10); 2024-01-12 08:43:14.750 CST [5739]

Re: Make COPY format extendable: Extract COPY TO format implementations

Hi, In "Re: Make COPY format extendable: Extract COPY TO format implementations" on Fri, 2 Feb 2024 06:51:02 +0900, Michael Paquier wrote: > On Fri, Feb 02, 2024 at 12:19:51AM +0900, Sutou Kouhei wrote: >> Here are some numbers on my local machine (Note that my >> local machine isn't

Re: Where can I find the doxyfile?

Here is the updated patch. It should fix the meson issue when no doxygen is present. doxygen-v3.patch Description: doxygen-v3.patch

Checking MINIMUM_VERSION_FOR_WAL_SUMMARIES

Hi hackers, during reading the source code of new incremental backup functionality I noticed that the following condition can by unintentional: /* * For newer server versions, likewise create pg_wal/summaries */ if (PQserverVersion(conn) < MINIMUM_VERSION_FOR_WAL_SUMMARIES)

[Doc] Improve hostssl related descriptions and option presentation

Motivated by a recent complaint [1] I found the hostssl related material in our docs quite verbose and even repetitive. Some of that is normal since we have both an overview/walk-through section as well as a reference section. But the overview in particular was self-repetitive. Here is a first

Re: Adding comments to help understand psql hidden queries

On Thu, Feb 1, 2024 at 4:34 PM Greg Sabino Mullane wrote: > > The use of the --echo-hidden flag in psql is used to show people the way psql > performs its magic for its backslash commands. None of them has more magic > than "\d relation", but it suffers from needing a lot of separate queries to

Re: Call pqPipelineFlush from PQsendFlushRequest

On Thu, 1 Feb 2024 at 21:00, Tom Lane wrote: >Note that the request is not itself flushed to the server > automatically; >use PQflush if necessary. > > Doesn't that require some rewording? I agree that the current wording is slightly incorrect, but I think I prefer we keep it

Re: Make COPY format extendable: Extract COPY TO format implementations

On Fri, Feb 02, 2024 at 12:19:51AM +0900, Sutou Kouhei wrote: > Here are some numbers on my local machine (Note that my > local machine isn't suitable for benchmark as I said > before. Each number is median of "\watch 15" results): >> > I'll measure again on my local machine later. I'll stop >

Re: ALTER TABLE SET ACCESS METHOD on partitioned tables

On Thu, Feb 01, 2024 at 04:50:49PM +0100, Alvaro Herrera wrote: > I think this works similarly but not identically to tablespace defaults, > and the difference could be confusing. You seem to have made it so that > the partitioned table _always_ have a table AM, so the partitions can > always

Fwd: Re: [HACKERS] make async slave to wait for lsn to be replayed

Updated, rebased, fixed Ci and added documentation. We left two different solutions. Help me please to choose the best. 1) Classic (wait_classic_v6.patch) https://www.postgresql.org/message-id/3cc883048264c2e9af022033925ff8db%40postgrespro.ru == advantages: multiple wait events, separate

Re: [PATCH] LockAcquireExtended improvement

On Thu, Feb 1, 2024 at 2:16 AM Jingxian Li wrote: > According to what you said, I resubmitted a patch which splits the ProcSleep > logic into two parts, the former is responsible for inserting self to > WaitQueue, > the latter is responsible for deadlock detection and processing, and the > former

Re: Collation version tracking for macOS

On Sun, Jan 21, 2024 at 1:58 PM Jeff Davis wrote: > I rendered the docs I wrote as an HTML page and attached it to this > thread, to make it easier for others to read and comment. It's > basically a tool for experts who are willing to devote effort to > managing their collations and ICU

Re: 003_extrafiles.pl test fails on Windows with the newer Perl versions

On 2024-02-01 Th 12:32, Tom Lane wrote: Seems like the back branches are still not quite there: I'm seeing Name "PostgreSQL::Test::Utils::windows_os" used only once: possible typo at t/003_extrafiles.pl line 74. in v12 and v13, while it's Name "PostgreSQL::Test::Utils::windows_os" used

Re: Flushing large data immediately in pqcomm

On Thu, Feb 1, 2024 at 10:52 AM Robert Haas wrote: > On Wed, Jan 31, 2024 at 10:24 PM Andres Freund wrote: > > While not perfect - e.g. because networks might use jumbo packets / large > > MTUs > > and we don't know how many outstanding bytes there are locally, I think a > > decent heuristic

Re: Call pqPipelineFlush from PQsendFlushRequest

Alvaro Herrera writes: > On 2023-Nov-07, Michael Paquier wrote: >> Indeed, it looks a bit strange that there is no flush if the buffer >> threshold is reached once the message is sent, so your suggestion >> sounds right. Alvaro? > Pushed, thanks. I observe that this patch did not touch

Re: Add connection active, idle time to pg_stat_activity

Hi again, > It looks like we can check increments in all fields playing with transactions in tests. I've added such tests. Regards, Sergey From 66ac1efe5424aa1385744a60047ffd44d42dd244 Mon Sep 17 00:00:00 2001 From: Sergey Dudoladov Date: Thu, 1 Feb 2024 16:11:36 +0100 Subject: [PATCH] Add

Re: Reducing connection overhead in pg_upgrade compat check phase

On Sat, 27 Jan 2024 at 09:10, vignesh C wrote: > > On Fri, 27 Oct 2023 at 18:50, Daniel Gustafsson wrote: > > > > Attached is a v10 rebase of this patch which had undergone significant > > bitrot > > due to recent changes in the pg_upgrade check phase. This brings in the > > changes into the

Re: PATCH: Using BRIN indexes for sorted output

On Sun, 21 Jan 2024 at 07:32, vignesh C wrote: > > On Wed, 2 Aug 2023 at 21:34, Tomas Vondra > wrote: > > > > > > > > On 8/2/23 17:25, Sergey Dudoladov wrote: > > > Hello, > > > > > >> Parallel version is not supported, but I think it should be possible. > > > > > > @Tomas are you working on

Re: Reduce timing overhead of EXPLAIN ANALYZE using rdtsc?

On Sat, 20 Jan 2024 at 09:03, vignesh C wrote: > > On Mon, 20 Feb 2023 at 16:06, David Geier wrote: > > > > Hi! > > > > On 2/14/23 13:48, David Geier wrote: > > > > > > It still fails. > > > > > > I'll get Cirrus-CI working on my own Github fork so I can make sure it > > > really compiles on all

Re: Avoid unncessary always true test (src/backend/storage/buffer/bufmgr.c)

On Mon, 4 Sept 2023 at 21:40, Peter Eisentraut wrote: > > On 30.06.23 20:48, Karina Litskevich wrote: > > So as for me calling LockRelationForExtension() and > > UnlockRelationForExtension() > > without testing eb.rel first looks more like a bug here. However, they > > are never > > actually

Re: Add system identifier to backup manifest

On Thu, Feb 1, 2024 at 2:18 AM Amul Sul wrote: > I intended to minimize the out param of parse_manifest_file(), which currently > returns manifest_files_hash and manifest_wal_range, and I need two more -- > manifest versions and the system identifier. Sure, but you could do context.ht =

Re: pgbench - adding pl/pgsql versions of tests

On Fri, 18 Aug 2023 at 23:04, Hannu Krosing wrote: > > I will address the comments here over this coming weekend. The patch which you submitted has been awaiting your attention for quite some time now. As such, we have moved it to "Returned with Feedback" and removed it from the reviewing

Re: Where can I find the doxyfile?

On Thu, 18 Jan 2024 at 06:39, vignesh C wrote: > > On Tue, 7 Nov 2023 at 12:23, John Morris wrote: > > > > Another update, this time with an abbreviated Doxyfile. Rather than > > including the full Doxyfile, this updated version only includes modified > > settings. It is more compact and more

Re: Should the archiver process always make sure that the timeline history files exist in the archive?

On Thu, 11 Jan 2024 at 20:38, vignesh C wrote: > > On Tue, 29 Aug 2023 at 06:29, Jimmy Yih wrote: > > > > Thanks for the insightful response! I have attached an updated patch > > that moves the proposed logic to the end of StartupXLOG where it seems > > more correct to do this. It also helps

Re: Issue in postgres_fdw causing unnecessary wait for cancel request reply

On Thu, 11 Jan 2024 at 20:00, vignesh C wrote: > > On Thu, 13 Apr 2023 at 23:34, Fujii Masao wrote: > > > > > > > > On 2023/04/13 11:00, Kyotaro Horiguchi wrote: > > > Agreed, it seems to be a leftover when we moved to parse_int_param() > > > in that area. > > > > It looks like there was an

Re: Assertion failure in SnapBuildInitialSnapshot()

On Thu, 11 Jan 2024 at 19:55, vignesh C wrote: > > On Thu, 9 Feb 2023 at 12:02, Masahiko Sawada wrote: > > > > On Wed, Feb 8, 2023 at 1:13 PM Amit Kapila wrote: > > > > > > On Wed, Feb 8, 2023 at 1:19 AM Andres Freund wrote: > > > > > > > > On 2023-02-01 11:23:57 +0530, Amit Kapila wrote: > >

Re: odd buildfarm failure - "pg_ctl: control file appears to be corrupt"

On Thu, 11 Jan 2024 at 19:50, vignesh C wrote: > > On Tue, 17 Oct 2023 at 04:18, Thomas Munro wrote: > > > > I pushed the retry-loop-in-frontend-executables patch and the > > missing-locking-in-SQL-functions patch yesterday. That leaves the > > backup ones, which I've rebased and attached, no

Re: [PATCH] Support % wildcard in extension upgrade filenames

On Thu, Feb 01, 2024 at 04:31:26PM +0530, vignesh C wrote: > > With no update to the thread and the tests still failing I'm marking > this as returned with feedback. Please feel free to resubmit to the > next CF when there is a new version of the patch. Ok, no problem. Thank you. --strk;

Re: Allow parallel plan for referential integrity checks?

On Sun, 21 Jan 2024 at 07:56, vignesh C wrote: > > On Fri, 18 Aug 2023 at 16:29, Juan José Santamaría Flecha > wrote: > > > > > > On Thu, Aug 17, 2023 at 3:51 PM Frédéric Yhuel > > wrote: > >> > >> On 8/17/23 14:00, Frédéric Yhuel wrote: > >> > On 8/17/23 09:32, Frédéric Yhuel wrote: > >> >>

Re: Oversight in reparameterize_path_by_child leading to executor crash

Richard Guo writes: > How about the attached v12 patch? But I'm a little concerned about > omitting PVC_RECURSE_AGGREGATES and PVC_RECURSE_WINDOWFUNCS in this > case. Is it possible that aggregates or window functions appear in the > tablesample expression? No, they can't appear there; it'd

Re: Asynchronous execution support for Custom Scan

On Sun, 14 Jan 2024 at 11:21, vignesh C wrote: > > On Fri, 2 Dec 2022 at 05:05, Kohei KaiGai wrote: > > > > > > IIUC, we already can use ctid in the where clause on the latest > > > > PostgreSQL, can't we? > > > > > > Oh, sorry, I missed the TidRangeScan. My apologies for the noise. > > > > > I

Re: Add connection active, idle time to pg_stat_activity

Hi all, @Andrei Zubkov I've modify the patch to address most of your comments. > I have a thought about other possible improvements fitting to this patch. > I think pg_stat_session view is able to add one more dimension of monitoring - a dimension of sessions I would like to remind here about

Re: 003_extrafiles.pl test fails on Windows with the newer Perl versions

Seems like the back branches are still not quite there: I'm seeing Name "PostgreSQL::Test::Utils::windows_os" used only once: possible typo at t/003_extrafiles.pl line 74. in v12 and v13, while it's Name "PostgreSQL::Test::Utils::windows_os" used only once: possible typo at

Re: GenBKI emits useless open;close for catalogs without rows

On Wed, 8 Nov 2023 at 12:50, Peter Eisentraut wrote: > > On 08.11.23 08:16, Peter Eisentraut wrote: > > On 19.09.23 20:05, Heikki Linnakangas wrote: > >> One thing caught my eye though: We currently have an "open" command > >> after every "create". Except for bootstrap relations; creating a > >>

Re: Using AF_UNIX sockets always for tests on Windows

On Sun, 21 Jan 2024 at 18:01, vignesh C wrote: > > On Wed, 22 Mar 2023 at 09:59, Thomas Munro wrote: > > > > Thanks Tom, Andres, Juan José, Andrew for your feedback. I agree that > > it's a better "OS harmonisation" outcome if we can choose both ways on > > both OSes. I will leave the 0003

Re: Unified File API

On Sat, 6 Jan 2024 at 22:58, vignesh C wrote: > > On Thu, 29 Jun 2023 at 13:20, John Morris wrote: > > > > Background > > > > == > > > > PostgreSQL has an amazing variety of routines for accessing files. Consider > > just the “open file” routines. > >PathNameOpenFile,

Re: Move bki file pre-processing from initdb to bootstrap

On Sat, 11 Nov 2023 at 00:03, Krishnakumar R wrote: > > Thank you for review, Peter. > > Makes sense on the split part. Was starting to think in same lines, at the > end of last iteration. Will come back shortly. > > On Fri, Nov 10, 2023 at 12:48 AM Peter Eisentraut > wrote: >> >> On 17.10.23

Re: Forbid the use of invalidated physical slots in streaming replication.

On Mon, 8 Jan 2024 at 10:25, vignesh C wrote: > > On Fri, 8 Dec 2023 at 19:15, Ashutosh Bapat > wrote: > > > > > > > pg_replication_slot could be set back to null. > > > > > > > > In this case, since the basebackup was taken after the slot was > > > > invalidated, it > > > > does not require

Re: Revisiting {CREATE INDEX, REINDEX} CONCURRENTLY improvements

> > > I just realised there is one issue with this design: We can't cheaply > > > reset the snapshot during the second table scan: > > > It is critically important that the second scan of R/CIC uses an index > > > contents summary (made with index_bulk_delete) that was created while > > > the

Re: Flushing large data immediately in pqcomm

On Wed, Jan 31, 2024 at 10:24 PM Andres Freund wrote: > While not perfect - e.g. because networks might use jumbo packets / large MTUs > and we don't know how many outstanding bytes there are locally, I think a > decent heuristic could be to always try to send at least one packet worth of > data

Re: ALTER TABLE SET ACCESS METHOD on partitioned tables

> @@ -947,20 +947,22 @@ DefineRelation(CreateStmt *stmt, char relkind, Oid > ownerId, >* a type of relation that needs one, use the default. >*/ > if (stmt->accessMethod != NULL) > + accessMethodId = get_table_am_oid(stmt->accessMethod, false); > + else if

Re: Skip collecting decoded changes of already-aborted transactions

On Tue, 3 Oct 2023 at 15:54, vignesh C wrote: > > On Mon, 3 Jul 2023 at 07:16, Masahiko Sawada wrote: > > > > On Fri, Jun 23, 2023 at 12:39 PM Dilip Kumar wrote: > > > > > > On Fri, Jun 9, 2023 at 10:47 AM Masahiko Sawada > > > wrote: > > > > > > > > Hi, > > > > > > > > In logical decoding,

Re: Volatile write caches on macOS and Windows, redux

On Mon, 22 Jan 2024 at 07:46, Peter Smith wrote: > > 2024-01 Commitfest. > > Hi, this patch was marked in CF as "Needs Review" [1], but there has > been no activity on this thread for 6+ months. > > Is anything else planned, or can you post something to elicit more > interest in the patch?

Re: Request for comment on setting binary format output per session

On Sat, 27 Jan 2024 at 07:45, vignesh C wrote: > > On Mon, 31 Jul 2023 at 21:58, Dave Cramer wrote: > > > > > > Dave Cramer > > > > > > On Mon, 10 Jul 2023 at 03:56, Daniel Gustafsson wrote: > >> > >> > On 25 Apr 2023, at 16:47, Dave Cramer wrote: > >> > >> > Patch attached with comments

Re: Possibility to disable `ALTER SYSTEM`

On Thu, Feb 1, 2024 at 7:33 AM Bruce Momjian wrote: > On Tue, Jan 30, 2024 at 04:25:12PM -0500, Robert Haas wrote: > > I don't think we should pretend like one of the two paragraphs above > > is valid and the other is hot garbage. That's not solving anything. We > > can't resolve the tension

Re: Collation version tracking for macOS

On Mon, 22 Jan 2024 at 00:28, Jeff Davis wrote: > > On Sat, 2024-01-20 at 07:40 +0530, vignesh C wrote: > > This thread has been idle for a year now, It has stalled after a lot > > of discussion. > > @Jeff Davis: Do you want to try to restart the discussion by posting > > an updated version and

Re: Make COPY format extendable: Extract COPY TO format implementations

Hi, Thanks for preparing benchmark. In "Re: Make COPY format extendable: Extract COPY TO format implementations" on Thu, 1 Feb 2024 12:49:59 +0900, Michael Paquier wrote: > On Thu, Feb 01, 2024 at 10:57:58AM +0900, Michael Paquier wrote: >> And here are the results I get for text and

Re: Moving forward with TDE [PATCH v3]

On Mon, 22 Jan 2024 at 11:47, Peter Smith wrote: > > 2024-01 Commitfest. > > Hi, This patch has a CF status of "Needs Review" [1], but it seems > there were CFbot test failures last time it was run [2]. Please have a > look and post an updated version if necessary. The patch which you submitted

Re: [PATCH] ltree hash functions

On Wed, 6 Dec 2023 at 04:08, Tommy Pavlicek wrote: > > Thanks. > > I've attached the latest version that updates the naming in line with > the convention. > > On Mon, Dec 4, 2023 at 12:46 AM jian he wrote: > > > > On Fri, Dec 1, 2023 at 8:44 AM Tommy Pavlicek wrote: > > > > > > > > > Patch

Re: Refactoring backend fork+exec code

On 30/01/2024 02:08, Heikki Linnakangas wrote: On 29/01/2024 17:54, reid.thomp...@crunchydata.com wrote: On Thu, 2024-01-25 at 01:51 +0200, Heikki Linnakangas wrote: And here we go. BackendID is now a 1-based index directly into the PGPROC array. Would it be worthwhile to also note in this

Re: Possibility to disable `ALTER SYSTEM`

On Tue, Jan 30, 2024 at 04:25:12PM -0500, Robert Haas wrote: > I don't think we should pretend like one of the two paragraphs above > is valid and the other is hot garbage. That's not solving anything. We > can't resolve the tension between those two things in either direction > by somebody

Re: Fix bugs not to discard statistics when changing stats_fetch_consistency

On 2024-02-01 17:33, Michael Paquier wrote: On Thu, Jan 11, 2024 at 06:18:38PM +0900, Shinya Kato wrote: Hi, hackers (Sorry for the delay, this thread was on my TODO list for some time.) There is below description in docs for stats_fetch_consistency. "Changing this parameter in a transaction

Re: Synchronizing slots from primary to standby

On Wed, Jan 31, 2024 at 2:02 PM Masahiko Sawada wrote: > > --- > +static char * > +wait_for_valid_params_and_get_dbname(void) > +{ > + char *dbname; > + int rc; > + > + /* Sanity check. */ > + Assert(enable_syncslot); > + > + for (;;) > + { > + if

Re: Synchronizing slots from primary to standby

On Thu, Feb 1, 2024 at 11:21 AM Peter Smith wrote: > > Here are some review comments for v740001. Thanks Peter for the feedback. > == > src/sgml/logicaldecoding.sgml > > 1. > + > +Replication Slot Synchronization > + > + A logical replication slot on the primary can be

Re: Synchronizing slots from primary to standby

On Wed, Jan 31, 2024 at 10:40 AM Peter Smith wrote: > > On Wed, Jan 31, 2024 at 2:18 PM Amit Kapila wrote: > > > > > > > > I think is correct to say all those *other* properties (create_slot, > > > enabled, copy_data) are forced to false because those otherwise have > > > default true values. >

Re: When extended query protocol ends?

>> Hello Dave, >> >> > Tatsuo Ishii writes: >> >> Below is outputs from "pgproto" command coming with Pgpool-II. >> >> (Lines starting "FE" represents a message from frontend to backend. >> >> Lines starting "BE" represents a message from backend to frontend.) >> > >> >> FE=> Parse(stmt="",

Re: [PoC/RFC] Multiple passwords, interval expirations

On Sat, 27 Jan 2024 at 07:18, vignesh C wrote: > > On Tue, 10 Oct 2023 at 16:37, Gurjeet Singh wrote: > > > > > On Mon, Oct 9, 2023 at 2:31 AM Gurjeet Singh wrote: > > > > > > > > Next steps: > > > > - Break the patch into a series of smaller patches. > > > > - Add TAP tests (test the ability

  1   2   >