Re: Doc limitation update proposal: include out-of-line OID usage per TOAST-ed columns

2024-04-03 Thread Jakub Wartak
Hi Andrey, On Thu, Mar 28, 2024 at 1:09 PM Andrey M. Borodin wrote: > > > > > On 8 Aug 2023, at 12:31, John Naylor wrote: > > > > > > Also the shared counter is the cause of the slowdown, but not the > > > > reason for the numeric limit. > > > > > > Isn't it both? typedef Oid is unsigned int =

Re: Doc limitation update proposal: include out-of-line OID usage per TOAST-ed columns

2024-03-28 Thread Andrey M. Borodin
> On 8 Aug 2023, at 12:31, John Naylor wrote: > > > > Also the shared counter is the cause of the slowdown, but not the reason > > > for the numeric limit. > > > > Isn't it both? typedef Oid is unsigned int = 2^32, and according to > > GetNewOidWithIndex() logic if we exhaust the whole OID

Re: Doc limitation update proposal: include out-of-line OID usage per TOAST-ed columns

2023-08-22 Thread John Naylor
On Mon, Aug 21, 2023 at 1:33 PM Gurjeet Singh wrote: > > Please see attached the proposed patch, which attempts to make that > language newcomer-friendly. The patch adds one link for TOAST, and > replaces Postgres-specific terms with generic ones. This is off-topic for this thread (which has a

Re: Doc limitation update proposal: include out-of-line OID usage per TOAST-ed columns

2023-08-21 Thread Gurjeet Singh
On Wed, Apr 26, 2023 at 4:48 AM David Rowley wrote: > > On Sun, 23 Apr 2023, 3:42 am Gurjeet Singh, wrote: >> >> I anticipate that edits to Appendix K Postgres Limits will prompt >> improving the note in there about the maximum column limit, That note >> is too wordy, and sometimes confusing,

Re: Doc limitation update proposal: include out-of-line OID usage per TOAST-ed columns

2023-08-08 Thread John Naylor
On Wed, Jul 5, 2023 at 9:45 PM Jakub Wartak wrote: > [v3] --- a/doc/src/sgml/limits.sgml +++ b/doc/src/sgml/limits.sgml @@ -10,6 +10,7 @@ hard limits are reached. + @@ -92,11 +93,25 @@ can be increased by recompiling PostgreSQL - -partition keys -32 -can

Re: Doc limitation update proposal: include out-of-line OID usage per TOAST-ed columns

2023-07-05 Thread Jakub Wartak
On Tue, Jun 13, 2023 at 10:20 AM John Naylor wrote: Hi John, v3 is attached for review. > > > >- > >+ see note below on TOAST > > Maybe: > "further limited by the number of TOAST-ed values; see note below" Fixed. > > I've wrongly put it, I've meant that pg_largeobject also

Re: Doc limitation update proposal: include out-of-line OID usage per TOAST-ed columns

2023-06-13 Thread John Naylor
On Thu, Apr 27, 2023 at 7:36 PM Jakub Wartak wrote: > > Spurious whitespace. > > Hopefully fixed, I've tried to align with the other entries tags. Hope springs eternal. ;-) --- a/doc/src/sgml/limits.sgml +++ b/doc/src/sgml/limits.sgml @@ -10,6 +10,7 @@ hard limits are reached. + @@

Re: Doc limitation update proposal: include out-of-line OID usage per TOAST-ed columns

2023-04-27 Thread Jakub Wartak
Hi John, Thanks for your review. Here's v2 attached. > -partition keys > -32 > -can be increased by recompiling > PostgreSQL > + partition keys > + 32 > + can be increased by recompiling > PostgreSQL > > Spurious whitespace. Hopefully fixed, I've tried to align with

Re: Doc limitation update proposal: include out-of-line OID usage per TOAST-ed columns

2023-04-26 Thread John Naylor
On Wed, Apr 26, 2023 at 5:18 PM Jakub Wartak wrote: > OK, so here is the documentation patch proposal. I've also added two > rows touching the subject of pg_largeobjects, as it is also related to > the OIDs topic. -partition keys -32 -can be increased by recompiling PostgreSQL +

Re: Doc limitation update proposal: include out-of-line OID usage per TOAST-ed columns

2023-04-26 Thread David Rowley
On Sun, 23 Apr 2023, 3:42 am Gurjeet Singh, wrote: > I anticipate that edits to Appendix K Postgres Limits will prompt > improving the note in there about the maximum column limit, That note > is too wordy, and sometimes confusing, especially for the audience > that it's written for: newcomers

Re: Doc limitation update proposal: include out-of-line OID usage per TOAST-ed columns

2023-04-26 Thread Jakub Wartak
Hi, >> These 2 discussions show that it's a painful experience to run into >> this problem, and that the hackers have ideas on how to fix it, but >> those fixes haven't materialized for years. So I would say that, yes, >> this info belongs in the hard-limits section, because who knows how >> long

Re: Doc limitation update proposal: include out-of-line OID usage per TOAST-ed columns

2023-04-24 Thread Nikita Malakhov
Hi, This is a production case for large databases with high update rates, but is mistaken with reaching table size limit, although size limit is processed correctly. The note on TOAST limitation does not mention that TOAST values are not actually updated on UPDATE operation - old value is marked

Re: Doc limitation update proposal: include out-of-line OID usage per TOAST-ed columns

2023-04-22 Thread Gurjeet Singh
On Fri, Apr 21, 2023 at 12:14 AM Nikita Malakhov wrote: > This limitation applies not only to wide tables - it also applies to tables > where TOASTed values > are updated very often. You would soon be out of available TOAST value ID > because in case of > high frequency updates autovacuum

Re: Doc limitation update proposal: include out-of-line OID usage per TOAST-ed columns

2023-04-21 Thread Nikita Malakhov
Hi! This limitation applies not only to wide tables - it also applies to tables where TOASTed values are updated very often. You would soon be out of available TOAST value ID because in case of high frequency updates autovacuum cleanup rate won't keep up with the updates. It is discussed in [1].

Doc limitation update proposal: include out-of-line OID usage per TOAST-ed columns

2023-04-21 Thread Jakub Wartak
Hi -hackers, I would like to ask if it wouldn't be good idea to copy the https://wiki.postgresql.org/wiki/TOAST#Total_table_size_limit discussion (out-of-line OID usage per TOAST-ed columns / potential limitation) to the official "Appendix K. PostgreSQL Limits" with also little bonus mentioning