Re: [HACKERS] Parallel Hash take II

Hi Andres and Peter, Please see below for inline responses to your feedback. New patch attached. On Wed, Nov 8, 2017 at 10:01 AM, Andres Freund wrote: > +set min_parallel_table_scan_size = 0; > +set parallel_setup_cost = 0; > +-- Make a simple relation with well distributed

Re: [HACKERS] LDAPS

On Sat, Nov 4, 2017 at 2:05 AM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > I've only tested the attached lightly on FreeBSD + OpenLDAP and > don't know if it'll work elsewhere. While rebasing this on top of a nearby changes, I looked into how portable it is. The prev

Re: [HACKERS] A GUC to prevent leader processes from running subplans?

On Sun, Nov 12, 2017 at 8:51 PM, Amit Kapila <amit.kapil...@gmail.com> wrote: > On Sun, Nov 12, 2017 at 9:18 AM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> How about parallel_leader_participation = on|off? The attached >> version has it that

Re: [HACKERS] A GUC to prevent leader processes from running subplans?

On Sat, Oct 21, 2017 at 8:09 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Tue, Oct 17, 2017 at 7:27 AM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> While testing parallelism work I've wanted to be able to prevent >> gather nodes from running

Re: [HACKERS] LDAP URI decoding bugs

On Sat, Nov 11, 2017 at 8:37 AM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 11/6/17 23:30, Michael Paquier wrote: >> On Fri, Nov 3, 2017 at 12:57 PM, Thomas Munro >> <thomas.mu...@enterprisedb.com> wrote: >>> 1. If you set up a pg_hba.

Re: [HACKERS] Planning counters in pg_stat_statements

On Tue, Nov 7, 2017 at 6:39 PM, Tsunakawa, Takayuki <tsunakawa.ta...@jp.fujitsu.com> wrote: > From: pgsql-hackers-ow...@postgresql.org >> [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Thomas Munro >> I have often wanted $SUBJECT and was happy to find that Fujii-san

Re: [HACKERS] Pg V10: Patch for bug in bonjour support

On Thu, Nov 9, 2017 at 6:27 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Thomas Munro <thomas.mu...@enterprisedb.com> writes: >> On Thu, Nov 9, 2017 at 5:03 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: >>> Is the AC_SEARCH_LIBS configure call needed to make P

Re: [HACKERS] Pg V10: Patch for bug in bonjour support

e native API it's shouting about. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] UPDATE of partition key

On Wed, Nov 8, 2017 at 5:57 PM, Amit Khandekar <amitdkhan...@gmail.com> wrote: > On 8 November 2017 at 07:55, Thomas Munro <thomas.mu...@enterprisedb.com> > wrote: >> On Tue, Nov 7, 2017 at 8:03 AM, Robert Haas <robertmh...@gmail.com> wrote: >>> The c

Re: [HACKERS] Pg V10: Patch for bug in bonjour support

quot;DNSServiceRegister() failed: error code -65537", which might just mean it wants to talk to some daemon I'm not running. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Pg V10: Patch for bug in bonjour support

SockFD, [], [AC_MSG_ERROR([library > 'dns_sd' is required for Bonjour])]) > > fi Hi Luke, It lives in libSystem.dylib (implicitly linked) on macOS, so that would break the build there. We'd need something a bit more conditional, but I don't know what. -- Thomas Munro http://www.enterprise

Re: [HACKERS] UPDATE of partition key

will > include these changes (also for list_parted) in the upcoming v23 > patch. That looks good. Thanks. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] UPDATE of partition key

On Tue, Nov 7, 2017 at 8:03 AM, Robert Haas <robertmh...@gmail.com> wrote: > The changes to trigger.c still make me super-nervous. Hey THOMAS > MUNRO, any chance you could review that part? Looking, but here's one silly thing that jumped out at me while getting started with this patc

[HACKERS] OpenTemporaryFile() vs resowner.c

ResourceOwnerEnlargeXXX() interface is to be able to put it before resource acquisition. The existing OpenTemporaryFile() coding has the same mistake. Please see attached. [1] https://www.postgresql.org/message-id/20171107210155.kuksdd324kgz5oev%40alap3.anarazel.de -- Thomas Munro http

Re: [HACKERS] Parallel Hash take II

act. Do you see a bug? None of this has any impact on whether files are leaked: either SharedFileSet removes the files, or you crash (or take a filesystem snapshot, etc) and RemovePgTempFiles() mops them up at the next clean startup. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Parallel Hash take II

in fact this change is probably not needed for my patch set (theory not tested). I will put it in a separate patch as requested by Andres, because it's generally a good idea anyway for the reasons that Robert explained (ie you probably always want to clean up memory last, since it might contain the meta-data/locks/control objects/whatever you'll need to clean up anything else). -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] Planning counters in pg_stat_statements

x_%3DDO-Gu-MfPW3VQ4qC7TfVdH2zHmvZfrGv6fQ3D-Tw%40mail.gmail.com -- Thomas Munro http://www.enterprisedb.com pg-stat-statements-planning-v1.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mail

Re: [HACKERS] Statement-level rollback

h to apply on top of yours to fix that and some small copy/paste errors, if I understood correctly. -- Thomas Munro http://www.enterprisedb.com docs-suggestion.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Flexible configuration for full-text search

of the patch the binary upgrade test in src/bin/pg_dump/t/002_pg_dump.pl fails for me: # Failed test 'binary_upgrade: dumps ALTER TEXT SEARCH CONFIGURATION dump_test.alt_ts_conf1 ...' # at t/002_pg_dump.pl line 6715. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers

Re: [HACKERS] [PATCH] Add ALWAYS DEFERRED option for constraints

home/nico/ws/postgres/src/test/regress/data/constro.data'; -COPY COPY_TBL FROM '@abs_srcdir@/data/constrf.data'; +COPY COPY_TBL FROM '/home/nico/ws/postgres/src/test/regress/data/constrf.data'; -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsq

Re: [HACKERS] [PATCH] Overestimated filter cost and its mitigation

d this project on). + /* Make a temporary clause list for selectivity calcuation */ s/calcuation/calculation/ -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Secondary index access optimizations

ition-wise join stuff), as far as I can tell in a good way. Can you please double check those changes and post an updated patch? -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgres

Re: [HACKERS] Restricting maximum keep segments by repslots

n't expect your new columns. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] LDAPS

On Sat, Nov 4, 2017 at 2:05 AM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > That > said, I've only tested the attached lightly on FreeBSD + OpenLDAP and > don't know if it'll work elsewhere. Oops, that version's TAP test was a little too dependent on my system's ldap.con

[HACKERS] LDAPS

elsewhere. Thoughts? -- Thomas Munro http://www.enterprisedb.com ldaps-v1.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] LDAP URI decoding bugs

to macros.) Please see attached. -- Thomas Munro http://www.enterprisedb.com ldap-fixes.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation)

On Fri, Nov 3, 2017 at 2:24 PM, Peter Geoghegan <p...@bowt.ie> wrote: > Thomas Munro <thomas.mu...@enterprisedb.com> wrote: >> That way you don't have to opt in to BufFile's >> double buffering and segmentation schemes just to get shared file >> clean-up, if for

Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation)

On Wed, Nov 1, 2017 at 2:11 PM, Peter Geoghegan <p...@bowt.ie> wrote: > On Tue, Oct 31, 2017 at 5:07 PM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> Another complaint is that perhaps fd.c >> knows too much about buffile.c's business. For example, >

Re: [HACKERS] Parallel Hash take II

On Mon, Oct 30, 2017 at 1:49 PM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > A couple of stupid things outstanding: > > 1. EXPLAIN ANALYZE for Parallel Hash "actual" shows the complete row > count, which is interesting to know (or not? maybe I sho

[HACKERS] ucs_wcwidth vintage

different frozen versions of the Unicode standard in the source tree, and that might affect some proper languages. 樂 [1] http://www.cl.cam.ac.uk/~mgk25/ucs/wcwidth.c -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes

Re: [HACKERS] Parallel tuplesort (for parallel B-Tree index creation)

In the newest version I changed that flexible array to tablespaces[8], because 8 should be enough tablespaces for anyone (TM). I don't really believe anyone uses temp_tablespaces for IO load balancing anymore and I hate code like the above. So I think Rushabh should now remove the above-quot

Re: [HACKERS] Parallel Hash take II

On Tue, Aug 1, 2017 at 9:28 AM, Andres Freund <and...@anarazel.de> wrote: > On 2017-07-26 20:12:56 +1200, Thomas Munro wrote: >> I'll report on performance separately. > > Looking forward to that ;) Here are some experimental results from a Xeon E5-2695 v3 with a ton of R

Re: [HACKERS] Parallel Hash take II

t the costing shows the partial row estimate used for costing purposes. 2. The BufFileSet's temporary directory gets created even if you don't need it for batches. Duh. 3. I don't have a good query rescan regression query yet. I wish I could write my own query plans to test the executor. -- Thomas Munro http

Re: [HACKERS] Causal reads take II

On Sun, Oct 1, 2017 at 10:03 AM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: >> I tried few more times, and I've got it two times from four attempts on a >> fresh >> installation (when all instances were on the same machine). But anyway I'll >> try >> to

Re: [HACKERS] Continuous integration on Windows?

ht find this: this plaintext-password-in-script-files stuff is intended for use on self-destructing isolated build bot images only and should never be done on a computer you care about.) Hooray! Now I can go and figure out why my Parallel Hash regression test is failing with file permissions problems

Re: [HACKERS] Parallel Hash take II

On Tue, Oct 24, 2017 at 10:10 PM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > Here is an updated patch set that does that ^. It's a bit hard to understand what's going on with the v21 patch set I posted yesterday because EXPLAIN ANALYZE doesn't tell you anything interesti

Re: [HACKERS] Parallel Hash take II

On Tue, Sep 19, 2017 at 8:06 AM, Robert Haas <robertmh...@gmail.com> wrote: > On Thu, Sep 14, 2017 at 10:01 AM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> 3. Gather Merge and Parallel Hash Join may have a deadlock problem. > > [...] > > Thomas

Re: [HACKERS] Block level parallel vacuum WIP

h. > > Did you ever find out what the cause of this problem was? I wonder if it might have been the same issue that commit 19de0ab23ccba12567c18640f00b49f01471018d fixed a week or so later. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] A GUC to prevent leader processes from running subplans?

tter ideas? -- Thomas Munro http://www.enterprisedb.com 0001-Add-a-GUC-to-control-whether-Gather-runs-subplans.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

[HACKERS] EXPLAIN (ANALYZE, BUFFERS) reports bogus temporary buffer reads

reports that we read 30 more blocks than we wrote (2 per batch after the first, as expected): Buffers: shared hit=434 read=16234, temp read=5532 written=5502 With the attached patch: Buffers: shared hit=547 read=16121, temp read=5502 written=5502 -- Thomas Munro http://www.enterprisedb.com

Re: [HACKERS] oversight in EphemeralNamedRelation support

o that too (unless of course it shows up in a future standard), just pointing it out as a curiosity. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Continuous integration on Windows?

On Sat, Oct 14, 2017 at 11:27 AM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > On Sat, Oct 14, 2017 at 7:47 AM, legrand legrand > <legrand_legr...@hotmail.com> wrote: >> Is it stored somewhere to permit to users like me >> that want to test pg 10 on wind

Re: [HACKERS] Continuous integration on Windows?

ies without disturbing anyone else. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Continuous integration on Windows?

to teach it to dump out resulting regression.diffs files and backtraces from core files (as the Travis CI version accessible from that page does). -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to you

Re: [HACKERS] Log LDAP "diagnostic messages"?

On Fri, Oct 13, 2017 at 3:59 PM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 9/24/17 07:00, Thomas Munro wrote: >> Fair point. In that case there are a few others we should consider >> moving down too for consistency, like in the attached. > >&g

Re: [HACKERS] oversight in EphemeralNamedRelation support

On Fri, Oct 13, 2017 at 12:46 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Thomas Munro <thomas.mu...@enterprisedb.com> writes: >> On Fri, Oct 13, 2017 at 10:01 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >>> The CTE was simply not part of the available names

Re: [HACKERS] oversight in EphemeralNamedRelation support

On Fri, Oct 13, 2017 at 10:01 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Thomas Munro <thomas.mu...@enterprisedb.com> writes: >> Before that, CTE used as modify targets produced a different error message: > >> postgres=# WITH d AS (SELECT 42) INSERT INTO d VALUES (1)

Re: [HACKERS] Continuous integration on Windows?

of the format-patch-and-post process. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] oversight in EphemeralNamedRelation support

On Fri, Oct 13, 2017 at 8:50 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Julien Rouhaud <rjuju...@gmail.com> writes: >> On Mon, Oct 9, 2017 at 10:43 PM, Thomas Munro >> <thomas.mu...@enterprisedb.com> wrote: >>> I suppose we

[HACKERS] Continuous integration on Windows?

). I wonder... has anyone here with Microsoft know-how ever tried to produce an appveyor.yml file that would do a MSVC build and check-world? -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription

Re: [HACKERS] oversight in EphemeralNamedRelation support

> relation. I agree. > PFA a simple patch to fix this issue, with updated regression test. Thanks! I suppose we could consider moving the schemaname check into getRTEForSpecialRelationType(), since otherwise both callers need to do that (and as you discovered, one forgot). -- Thomas Munro http://w

Re: [HACKERS] Parallel Hash take II

temporary files over the available temporary tablespaces, but it's a terrible API, since you have to promise to use the same stripe number when opening the same name later... Maybe I should use a hash of the name for that instead. Thoughts? -- Thomas Munro http://www.enterprisedb.com 0006-Remove-BufFil

Re: [HACKERS] [sqlsmith] stuck spinlock in pg_stat_get_wal_receiver after OOM

atches anyway, but it may be a better abstraction. On the other hand I'm not sure how waits on a ConditionVariable would be multiplexed with IO (a distinct wait event, or leaky abstraction where the caller relies on the fact that it's built on MyProc->latch, something else?). -- Thomas Munro http:

Re: [HACKERS] [sqlsmith] stuck spinlock in pg_stat_get_wal_receiver after OOM

pstrdup()? The buffers could be statically sized with NAMEDATALEN and MAXCONNINFO. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Causal reads take II

> segment 00010020, offset 10092544 Hi Dmitry, Thanks for testing. Yeah, it looks like the patch may be corrupting the WAL stream in some case that I didn't hit in my own testing procedure. I will try to reproduce these failures. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] A design for amcheck heapam verification

ng, rather than 'init'. 'init' has connotations of being the second phase in an allocate-and-init pattern for me. Then bloom_filt_make() would be trivially implemented on top of bloom_estimate() and bloom_init(), and bloom_init() could be used directly in DSM, DSA, traditional shmem without having t

Re: [HACKERS] Server crash due to SIGBUS(Bus Error) when trying to access the memory created using dsm_create().

On Tue, Sep 26, 2017 at 10:12 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Thomas Munro <thomas.mu...@enterprisedb.com> writes: >> I think the problem here is that posix_fallocate() doesn't set errno. > > Huh. So the fact that it worked for me is likely because glibc

Re: [HACKERS] Server crash due to SIGBUS(Bus Error) when trying to access the memory created using dsm_create().

On Tue, Sep 26, 2017 at 9:57 AM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: >> On Tue, Sep 26, 2017 at 9:13 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >>> Pushed with that change; we'll soon see what the buildfarm thinks. > > Hmm. One failu

Re: [HACKERS] Server crash due to SIGBUS(Bus Error) when trying to access the memory created using dsm_create().

.10.0-229.11.1.el7.x86_64 -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Server crash due to SIGBUS(Bus Error) when trying to access the memory created using dsm_create().

d POSIX itself *does* > list EINTR, so I'm hesitant to muck with that. Ah, it all makes sense now that I see the fallback strategy section of the posix_fallocate() man page. I was unaware that there were kernel releases that had the syscall but lacked support in tmpfs. Thanks for te

Re: [HACKERS] Server crash due to SIGBUS(Bus Error) when trying to access the memory created using dsm_create().

vide a fallback for posix_fallocate() but let ENOTSUPP escape from fallocate(). -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] SERIALIZABLE with parallel query

s way your test case behaves the same as non-parallel mode. > I will continue my review on the latest patch and share any updates. Thanks! -- Thomas Munro http://www.enterprisedb.com ssi-parallel-v8.patch Description: Binary data -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Parallel Hash take II

ing of the > topic is very deliberate and high level, which suggests that ours > should be, too. Very interesting and certainly relevant (the parts I've read so far), though we don't have multiple consumers. Multiplexing one thread so that it is both a consumer and a producer is an

Re: [HACKERS] Server crash due to SIGBUS(Bus Error) when trying to access the memory created using dsm_create().

On Thu, Aug 17, 2017 at 11:39 AM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > On Thu, Jun 29, 2017 at 12:24 PM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> fallocate-v5.patch > > Added to commitfest so we don't lose track of this. Rebase

Re: [HACKERS] Log LDAP "diagnostic messages"?

ll addition to your TAP test which exercises the non-NULL code path because slapd rejects TLS by default with a diagnostic message. I'm not sure if this is worth adding, since it doesn't actually verify that the code path is reached (though you can see that it is from the logs). -- Thomas M

Re: [HACKERS] Re: [COMMITTERS] pgsql: Make new crash restart test a bit more robust.

control but we can't see its output, maybe due to -Otarget, before the whole job is nuked by Travis for not making progress). -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] SERIALIZABLE with parallel query

r sees r2[X=0,Y=0] (we scanned the whole table, as if we read all objects, in this case X and Y, even though we only asked to read X). Then the SSI algorithm is able to detect a "dangerous structure" at w2[Y=10], instead of later at commit time. So I don't think this indicates a problem

Re: [HACKERS] Error: dsa_area could not attach to a segment that has been freed

be a better abstraction of reliable scoped cleanup waiting to be discovered (as I think Craig was also getting at). -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Error: dsa_area could not attach to a segment that has been freed

ulti-allocation operations if that turned out to be necessary. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Error: dsa_area could not attach to a segment that has been freed

ryContext); area = dsa_attach(...); MemoryContextSwitchTo(old_context); You'll need to #include "utils/memutils.h". -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] src/test/subscription/t/002_types.pl hanging on particular environment

On Mon, Sep 18, 2017 at 10:18 PM, Andres Freund <and...@anarazel.de> wrote: > On 2017-09-18 21:57:04 +1200, Thomas Munro wrote: >> WARNING: terminating connection because of crash of another server >> process >> DETAIL: The postmaster has commanded this ser

Re: [HACKERS] why not parallel seq scan for slow functions

l-cfbot/postgresql/builds/277376953 . -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Block level parallel vacuum WIP

D test rules... FAILED Down at the bottom of the build log in the regression diffs file you can see: ! ERROR: cache lookup failed for relation 32893 https://travis-ci.org/postgresql-cfbot/postgresql/builds/277165907 -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers

Re: [HACKERS] SERIALIZABLE with parallel query

On Fri, Sep 1, 2017 at 5:11 PM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > On Wed, Jun 28, 2017 at 11:21 AM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> [ssi-parallel-v5.patch] > > Rebased. Rebased again. -- Thomas Munro http://www.ente

[HACKERS] src/test/subscription/t/002_types.pl hanging on particular environment

it's really just an immediate shutdown. There is no core file, so I don't believe anything actually crashed. Here's a version that's the same except it doesn't have --enable-coverage. It passes: https://travis-ci.org/macdice/postgres/jobs/276771654 Any ideas? -- Thomas Munro http://www.

Re: [HACKERS] valgrind vs. shared typmod registry

On Mon, Sep 18, 2017 at 5:39 PM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > Here is a patch to fix that. Here's a better one (same code, corrected commit message). -- Thomas Munro http://www.enterprisedb.com 0001-Fix-uninitialized-variable-in-dshash.c.patch Description: Bi

Re: [HACKERS] valgrind vs. shared typmod registry

On Sun, Sep 17, 2017 at 8:49 AM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > On Sun, Sep 17, 2017 at 7:42 AM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> On Sun, Sep 17, 2017 at 12:30 AM, Tomas Vondra >> <tomas.von...@2ndquadrant.com&g

Re: [HACKERS] Automatic testing of patches in commit fest

On Mon, Sep 18, 2017 at 2:39 PM, Andres Freund <and...@anarazel.de> wrote: > E.g. very little of the new stuff in > https://codecov.io/gh/postgresql-cfbot/postgresql/commit/ceaa3dbece3c9b98abcaa28009320fde45a83f88 > is exercised. Hoist by my own petard. -- Th

Re: [HACKERS] Automatic testing of patches in commit fest

stuff, valgrind, Coverity, more compilers, ... but I'm not sure what things really make sense. I may be placing undue importance on things that I personally screwed up recently :-D -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org

Re: [HACKERS] Improving DISTINCT with LooseScan node

p scan', suggesting that we should consider 'hop'... (weak humour, 'a hop, skip and a jump' being an English idiom meaning a short distance)). -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] valgrind vs. shared typmod registry

On Sun, Sep 17, 2017 at 7:42 AM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > On Sun, Sep 17, 2017 at 12:30 AM, Tomas Vondra > <tomas.von...@2ndquadrant.com> wrote: >> I've been running some regression tests under valgrind, and it seems >> sele

Re: [HACKERS] valgrind vs. shared typmod registry

about hashtable->size_log2 > being not being initialized in ensure_valid_bucket_pointers. Thanks. Will investigate. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgres

Re: [HACKERS] Partition-wise join for join between (declaratively) partitioned tables

those question, but keep getting distracted by other things catching on fire... -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Log LDAP "diagnostic messages"?

ide line length rules, but I also see no reason to continue > doing it.) Done for all lines I touched in the patch. Thanks for the review! -- Thomas Munro http://www.enterprisedb.com 0001-Improve-LDAP-cleanup-code-in-error-paths.patch Description: Binary data 0002-Log-diagnostic-mes

Re: [HACKERS] POC: Sharing record typmods between backends

On Fri, Sep 15, 2017 at 3:03 PM, Andres Freund <and...@anarazel.de> wrote: > On 2017-09-04 18:14:39 +1200, Thomas Munro wrote: >> Thanks for the review and commits so far. Here's a rebased, debugged >> and pgindented version of the remaining patches. > > I've pushed th

Re: [HACKERS] Patches that don't apply or don't compile: 2017-09-12

es CF via an HTTPS endpoint so that the CF app finishes up with the information in its database. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Parallel Hash take II

On Thu, Sep 14, 2017 at 11:57 AM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > On Thu, Sep 14, 2017 at 12:51 AM, Prabhat Sahu > <prabhat.s...@enterprisedb.com> wrote: >> Setting with lower "shared_buffers" and "work_mem" as below, query ge

Re: [HACKERS] Parallel Hash take II

e means that it sometimes thinks the shared skew hash table is present and tries to probe it after batch 1. I have a fix for that and I will post a new patch set just as soon as I have a good regression test figured out. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing li

Re: [HACKERS] <> join selectivity estimate question

On Wed, Sep 6, 2017 at 11:14 PM, Ashutosh Bapat <ashutosh.ba...@enterprisedb.com> wrote: > On Fri, Jul 21, 2017 at 4:10 AM, Thomas Munro > <thomas.mu...@enterprisedb.com> wrote: >> That just leaves the question of whether we should try to handle the >> empty RHS an

Re: [HACKERS] proposal: psql: check env variable PSQL_PAGER

uch I've started setting PSQL_PAGER="~/bin/pspg -s0" to try your new column-aware pager from https://github.com/okbob/pspg for my regular work. Wow! It could use some warning clean-up but it's a clever idea and so far it works really well. Thanks for making this. -- Thomas Munro ht

Re: [HACKERS] Getting error message with latest PG source on Windows.

On Wed, Sep 13, 2017 at 9:11 PM, Thomas Munro <thomas.mu...@enterprisedb.com> wrote: > On Wed, Sep 13, 2017 at 8:58 PM, Ashutosh Sharma <ashu.coe...@gmail.com> > wrote: >> I am getting the following error message when trying to build latest >> PG source on Wind

Re: [HACKERS] Getting error message with latest PG source on Windows.

because it does not (and can not) correspond to any attribute in use. It seems like we need to do that. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] WAL logging problem in 9.4.3?

of HEAP_INSERT_SKIP_WAL but hasn't removed that reference to it. I'm not sure what happened. Is it possible that your patch was not created by diffing against master? -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Log LDAP "diagnostic messages"?

Protocol error >>> DETAIL: LDAP diagnostics: unsupported extended operation. >>> >> +1, pretty neat. Here is a new version adopting Alvaro's wording. I'll set this back to "Needs review" status. -- Thomas Munro http://www.enterprisedb.com ldap-diagn

Re: [HACKERS] [PATCH v1] Add and report the new "in_hot_standby" GUC pseudo-variable.

ng to do no > database roundtrips. Hi Elvis, FYI the recovery test 001_stream_rep.pl fails with this patch applied. You can see that if you configure with --enable-tap-tests, build and then cd into src/test/recovery and "make check". -- Thomas Munro http://www.enterprisedb.com

Re: [HACKERS] More flexible LDAP auth search filters?

On Wed, Sep 13, 2017 at 1:55 AM, Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > On 9/11/17 23:58, Thomas Munro wrote: >> Sounds good. Here it is with $username. It's nice not to have to >> escape any characters in URLs. I suppose more keywords could be

Re: [HACKERS] Automatic testing of patches in commit fest

autious and over time we can revise it.) -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Automatic testing of patches in commit fest

legitimate complaint. The rejected hunk is trying to replace this line: ! return exec_simple_check_node((Node *) ((ArrayCoerceExpr *) node)->arg); But you removed exec_simple_check_node in 00418c61244138bd8ac2de58076a1d0dd4f539f3, so this 02 patch needs to be rebased. > Also, at this point th

Re: [HACKERS] Patches that don't apply or don't compile: 2017-09-12

quot; badge take you there directly... Eventually I'll also teach it how to dump a backtrace out of gdb the tests leave a smouldering core. -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers

Re: [HACKERS] Automatic testing of patches in commit fest

that's cfbot's fault, but if we were to nail down the acceptable formats then it'd become your fault if it didn't understand your patch :-D -- Thomas Munro http://www.enterprisedb.com -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: htt

  1   2   3   4   5   6   7   8   9   >