Re: [HACKERS] libpq object hooks (libpq events)

2008-09-03 Thread Andrew Chernow
Alvaro Herrera wrote: There's one thing that seems a bit baroque, which is the PG_COPYRES_USE_ATTRS stuff in PQcopyResult. I think that flag introduces different enough behavior that it should be a routine of its own, say PQcopyResultAttrs. That way you would leave out the two extra params in

Re: [HACKERS] libpq object hooks (libpq events)

2008-09-03 Thread Alvaro Herrera
Andrew Chernow escribió: Alvaro Herrera wrote: (I also removed PQresultAlloc.) Nooo ... removing PQresultAlloc breaks libpqtypes! It also removes some of the use cases provided by PQsetvalue, which allows one to add to a result (in our case from scratch). I don't really see the

Re: [HACKERS] libpq object hooks (libpq events)

2008-09-03 Thread Andrew Chernow
Alvaro Herrera wrote: Andrew Chernow escribió: Alvaro Herrera wrote: (I also removed PQresultAlloc.) Nooo ... removing PQresultAlloc breaks libpqtypes! It also removes some of the use cases provided by PQsetvalue, which allows one to add to a result (in our case from scratch). I

Re: [HACKERS] libpq object hooks (libpq events)

2008-09-02 Thread Alvaro Herrera
Andrew Chernow escribió: Attached is the latest patch. It has addressed the requested changes found here: http://archives.postgresql.org/pgsql-patches/2008-05/msg00389.php Its a tarball because there are two new files, libpq-events.c and libpq-events.h. The patch is in the tarball as

Re: [HACKERS] libpq object hooks (libpq events)

2008-09-02 Thread Andrew Chernow
Alvaro Herrera wrote: Andrew Chernow escribió: Attached is the latest patch. It has addressed the requested changes found here: http://archives.postgresql.org/pgsql-patches/2008-05/msg00389.php Its a tarball because there are two new files, libpq-events.c and libpq-events.h. The patch is