Re: [PHP] How to get a code review?

2008-04-03 Thread Daniel Brown
On Thu, Apr 3, 2008 at 12:09 PM, David Jourard [EMAIL PROTECTED] wrote: Hi, I'm a perl programmer and I've written a registration/login program in Perl. I've just finished writing a small program in php to check the login cookie created by my perl program for any php html page. Can

Re: [PHP] How to get a code review?

2008-04-03 Thread Robert Cummings
On Thu, 2008-04-03 at 12:09 -0400, David Jourard wrote: Hi, I'm a perl programmer and I've written a registration/login program in Perl. I've just finished writing a small program in php to check the login cookie created by my perl program for any php html page. Can anyone direct me

Re: [PHP] How to get a code review?

2008-04-03 Thread Nathan Nobbe
On Thu, Apr 3, 2008 at 10:09 AM, David Jourard [EMAIL PROTECTED] wrote: Can anyone direct me to a list or forum where one can get a code review of the php by other experienced php programmers. how much code is there ? -nathan

RE: [PHP] How to get a code review?

2008-04-03 Thread admin
You can simply check the session or cookie if(!session_is_registered(user)) { echo I cant see the session_register user; }else{ echo I see the session $user; } User is an example of a session_register(user); the user variable has been set in the

Re: [PHP] How to get a code review?

2008-04-03 Thread David Jourard
Nathan Nobbe wrote: how much code is there ? -nathan 200 lines Robert Cummings You could provide links to the source code and post the links here. Pastebin is often used... http://www.pastebin.com Thanks http://pastebin.com/m6c8cb17c Daniel Brown wrote: By code review, what exactly

Re: [PHP] How to get a code review?

2008-04-03 Thread Nathan Nobbe
On Thu, Apr 3, 2008 at 10:41 AM, David Jourard [EMAIL PROTECTED] wrote: Nathan Nobbe wrote: how much code is there ? 200 lines i think ur safe posting that on the list directly. sometimes people post several thousand lines and those sort of things are overlooked. I work alone and this

Re: [PHP] How to get a code review?

2008-04-03 Thread David Jourard
Nathan Nobbe wrote: On Thu, Apr 3, 2008 at 10:09 AM, David Jourard [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: Can anyone direct me to a list or forum where one can get a code review of the php by other experienced php programmers. how much code is there ? -nathan I

Re: [PHP] How to get a code review?

2008-04-03 Thread Nathan Nobbe
On Thu, Apr 3, 2008 at 11:29 AM, David Jourard [EMAIL PROTECTED] wrote: I posted it at http://pastebin.com/m6c8cb17c for the variable names, you might consider camelCase or underscores to enhance readbility, for example $htmlpathcomponents would become $htmlPathComponents (my preference)

Re: [PHP] How to get a code review?

2008-04-03 Thread Ryan Panning
Robert Cummings wrote: You could provide links to the source code and post the links here. Pastebin is often used... http://www.pastebin.com Cheers, Rob. Another good option is PHP Builder, they have a forum setup specifically for code reviewing. They have a large user base too.

Re: [PHP] How to get a code review?

2008-04-03 Thread Shawn McKenzie
Nathan Nobbe wrote: On Thu, Apr 3, 2008 at 10:41 AM, David Jourard [EMAIL PROTECTED] wrote: Nathan Nobbe wrote: how much code is there ? 200 lines i think ur safe posting that on the list directly. sometimes people post several thousand lines and those sort of things are