D17249: Preserve screen colour doesn't work as expected

jsalatas created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jsalatas requested review of this revision. REVISION SUMMARY If you are using a custom icc profile, this should be restored during day time. see also

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

ngraham updated this revision to Diff 46523. ngraham added a comment. Remove now-unnecessary import REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16031?vs=46522=46523 BRANCH arcpatch-D16031_1 REVISION DETAIL

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

ngraham updated this revision to Diff 46522. ngraham added a comment. - Use consistent shadows for `ActionButton` labels - Don't unnecessarily increase `ActionButton` label size - Don't unnecessarily add outlines around `ActionButton` labels (left over from earlier experiment) REPOSITORY

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

ngraham updated this revision to Diff 46519. ngraham added a comment. Calculate footer background bar height correctly REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16031?vs=46518=46519 BRANCH arcpatch-D16031_1 REVISION DETAIL

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

ngraham updated this revision to Diff 46518. ngraham added a comment. Don't hardcode colors REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16031?vs=46477=46518 BRANCH arcpatch-D16031_1 REVISION DETAIL https://phabricator.kde.org/D16031

D17233: Delay finishing download when state changes to "interrupted"

fvogt added a comment. It might work as well to just ignore the "interrupted" `state` completely and only react when `error` becomes set. The docs say that error is undefined if no error occured (It's actually `null` here, so it's already a doc violation...), so if it's set that's a

D17192: use a Kirigami Heading for perfect consistency

ngraham added a comment. It isn't a title, though. At best, the text in question is a list item, not a title. I kinda like the fact that the whole item is a button. It even looks button-like. Makes for a nice easy click/touch target, and you know exactly where going back will take you.

D16901: [Folder View] implement a minimum width for icon view to ensure that labels are never rendered useless

This revision was automatically updated to reflect the committed changes. Closed by commit R119:0b654afd8884: [Folder View] implement a minimum width for icon view to ensure that labels are… (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D17203: [Task Manager] Move apps to activities from the context menu

thsurrel abandoned this revision. thsurrel added a comment. I use it differently then ! :) REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17203 To: thsurrel, #plasma, hein Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D17203: [Task Manager] Move apps to activities from the context menu

hein added a comment. Well, the entire point of activities existing is that they go beyond the limitations of desktops - you can add a window to 2 out of 5 activities, not just one or all. If it's the same, we don't need both. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D17212: Port to QQC2 and FormLayout

mart added a comment. In D17212#368135 , @abetts wrote: > In D17212#368048 , @mart wrote: > > > F6446445: Screenshot_20181129_143041.png > > > Wait!

D17203: [Task Manager] Move apps to activities from the context menu

thsurrel added a comment. Yes, indeed. But it is just a proposal. This patch mimics what is done for desktops: you can move a window to a desktop or to all of them. You lose the ability to add a window to an activity, but do we have a strong use case for that ? I personally always want to

D17211: Port applet/containment configs to qqc2

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c2640f83f107: Port applet/containment configs to qqc2 (authored by mart). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17211?vs=46481=46483 REVISION

D17211: Port applet/containment configs to qqc2

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1 shipit! REPOSITORY R119 Plasma Desktop BRANCH phab/qqc2 REVISION DETAIL https://phabricator.kde.org/D17211 To: mart, #plasma, #vdg, broulik, ngraham Cc: abetts, ngraham, apol,

D17203: [Task Manager] Move apps to activities from the context menu

hein added a comment. Does this mean you can't use the menu to add the window to multiple activities anymore? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17203 To: thsurrel, #plasma, hein Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D17192: use a Kirigami Heading for perfect consistency

abetts added a comment. In D17192#368170 , @mart wrote: > well, to me part of the problem is that a title became a back button... even tough smaller target to hit, i would have preferred to have a toolbutton followed by a proper title that is

D17192: use a Kirigami Heading for perfect consistency

mart added a comment. well, to me part of the problem is that a title became a back button... even tough smaller target to hit, i would have preferred to have a toolbutton followed by a proper title that is just a title REPOSITORY R124 System Settings REVISION DETAIL

D17212: Port to QQC2 and FormLayout

ngraham added a comment. That's true, in this case where not one of the items has a left label, we generally like to use left labels as pseudo section headers, like in Dolphin's settings window. REPOSITORY R120 Plasma Workspace BRANCH phab/qqc2 REVISION DETAIL

D17211: Port applet/containment configs to qqc2

mart updated this revision to Diff 46481. mart added a comment. - show the label again, but shorter REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17211?vs=46398=46481 BRANCH phab/qqc2 REVISION DETAIL https://phabricator.kde.org/D17211

D17211: Port applet/containment configs to qqc2

abetts added a comment. In D17211#368161 , @ngraham wrote: > Thanks, the combobox open-on-click feature works perfectly! > > I still don't agree with making the wallpaper plugin GHNS button icons-only. That makes it inconsistent with all

D17211: Port applet/containment configs to qqc2

ngraham added a comment. Thanks, the combobox open-on-click feature works perfectly! I still don't agree with making the wallpaper plugin GHNS button icons-only. That makes it inconsistent with all others in every other KCM and I took great pain recently to make them all consistent. Can

D17211: Port applet/containment configs to qqc2

abetts added a comment. +1 on visuals REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17211 To: mart, #plasma, #vdg, broulik, ngraham Cc: abetts, ngraham, apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, mart

D17177: Drop tab-based UI for the about page

This revision was automatically updated to reflect the committed changes. Closed by commit R134:50c69c2c069f: Drop tab-based UI for the about page (authored by apol). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17177?vs=46479=46480

D17177: Drop tab-based UI for the about page

apol updated this revision to Diff 46479. apol added a comment. Adopt the AboutPage upstream in Kirigami REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17177?vs=46390=46479 BRANCH master REVISION DETAIL

D17212: Port to QQC2 and FormLayout

abetts added a comment. In D17212#368048 , @mart wrote: > F6446445: Screenshot_20181129_143041.png Wait! Isn't the header labels supposed to be on the right? They are also supposed to be aligned to

D17216: Move the about page from Discover to Kirigami

apol closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D17216 To: apol, #kirigami, mart, broulik Cc: leinir, nicolasfella, plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17212: Port to QQC2 and FormLayout

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Lovely :) REPOSITORY R120 Plasma Workspace BRANCH phab/qqc2 REVISION DETAIL https://phabricator.kde.org/D17212 To: mart, #plasma, #vdg, ngraham Cc: ngraham, abetts, plasma-devel,

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

ngraham updated this revision to Diff 46477. ngraham added a comment. Rebase on master and fix merge conflicts REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16031?vs=46475=46477 BRANCH arcpatch-D16031_1 REVISION DETAIL

D17216: Move the about page from Discover to Kirigami

apol updated this revision to Diff 46476. apol added a comment. gravatar-- REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17216?vs=46417=46476 BRANCH master REVISION DETAIL https://phabricator.kde.org/D17216 AFFECTED FILES kirigami.qrc

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

ngraham updated this revision to Diff 46475. ngraham added a comment. Remove changes that were made in D16879 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16031?vs=44876=46475 BRANCH arcpatch-D16031

D17233: Delay finishing download when state changes to "interrupted"

broulik updated this revision to Diff 46474. broulik added a comment. - Set no error explicitly when completing, just in case REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17233?vs=46459=46474 REVISION DETAIL

D9388: Fix queued connection error

davidedmundson added a comment. @iromanov ping, this is accepted, can you push it REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D9388 To: iromanov, graesslin, mart Cc: davidedmundson, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D16879: [Login and Lock screens] Improve UI elements' contrast a bit

This revision was automatically updated to reflect the committed changes. Closed by commit R120:d9532e80da6d: [Login and Lock screens] Improve UI elements contrast a bit (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D7780: Make Kickoff expose items to accessibility

davidedmundson added a comment. This got stuck because of some big kicker rewrite that happened in the meantime (and there's still some more on phab). I'll abandon this then re-upload in smaller bite size chunks REPOSITORY R119 Plasma Desktop BRANCH backup REVISION DETAIL

D9271: Fixed memory leak in new_argv

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Many changes remaining - especially in joystick, I'm pretty sure that'll crash. Marking as request changes REPOSITORY R119 Plasma Desktop REVISION DETAIL

D8695: Fix ampersand characters not showing in tab titles

davidedmundson commandeered this revision. davidedmundson added a reviewer: corentinr. davidedmundson added a comment. This appears to be merged. I'm going to close it. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D8695 To: davidedmundson, corentinr Cc:

D17212: Port to QQC2 and FormLayout

mart updated this revision to Diff 46465. mart added a comment. - center the layout REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17212?vs=46396=46465 BRANCH phab/qqc2 REVISION DETAIL https://phabricator.kde.org/D17212 AFFECTED FILES

D17212: Port to QQC2 and FormLayout

mart added a comment. F6446445: Screenshot_20181129_143041.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D17212 To: mart, #plasma, #vdg Cc: ngraham, abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D17211: Port applet/containment configs to qqc2

mart added a comment. the shrinking of the wallpaper combobox will be done in a separate commit REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17211 To: mart, #plasma, #vdg, broulik, ngraham Cc: ngraham, apol, plasma-devel, ragreen, Pitel, ZrenBot,

D17211: Port applet/containment configs to qqc2

mart added a comment. In D17211#367974 , @mart wrote: > ah, that needs a fix in qqc2-desktop-style.. i can hack the open on down, tough for combox and menus in particular, is not possible at all the pattern press, open the subpopup, move the

D17216: Move the about page from Discover to Kirigami

broulik added inline comments. INLINE COMMENTS > leinir wrote in AboutPage.qml:102 > It seems to me that this is not really a privacy issue - it's the developer > emails being leaked here, and those are made all manner of public already. If > it were the end user's gravatar we fetched like

D17216: Move the about page from Discover to Kirigami

leinir added inline comments. INLINE COMMENTS > apol wrote in AboutPage.qml:102 > I do agree it can read a bit weird. > It's generally done on public emails though, I'm not sure why it's bad. > > If we feel better about it, I can drop it and we port it to something else > we're happy with some

D17233: Delay finishing download when state changes to "interrupted"

broulik updated this revision to Diff 46459. broulik added a comment. - Update comment, originally had `singleShot(0` but that wasn't enough REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17233?vs=46458=46459 REVISION DETAIL

D17233: Delay finishing download when state changes to "interrupted"

broulik created this revision. broulik added reviewers: Plasma, davidedmundson, fvogt. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY In Chrome we get state change to "interrupted" and the error in unison

D17213: Add support for settings portal

jgrulich added inline comments. INLINE COMMENTS > jgrulich wrote in khintssettings.cpp:442 > Ok, I'll look into that. It looks it's not that simple, this change would require other additions in order to support KConfig overload. I would leave it as it is for now. REPOSITORY R135 Integration

D17211: Port applet/containment configs to qqc2

mart added a comment. In D17211#367573 , @ngraham wrote: > The Layout and Wallpaper Type comboboxes should open on press, not on click-and-release. ah, that needs a fix in qqc2-desktop-style.. i can hack the open on down, tough for

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. In D16988#367971 , @filipf wrote: > In D16988#367970 , @rooty wrote: > > > Suffice it to say, you can't use any of the other patches (except the font size / label change)

D16988: [Kickoff] Make the visible search field unfocused by default

filipf added a comment. In D16988#367970 , @rooty wrote: > Suffice it to say, you can't use any of the other patches (except the font size / label change) without this one. Separating this doesn't make sense either because there's no

D16988: [Kickoff] Make the visible search field unfocused by default

rooty added a comment. In D16988#366146 , @ngraham wrote: > D17020 , D17022 , and D17023 still include duplicated changes from this

D17213: Add support for settings portal

jgrulich updated this revision to Diff 46457. jgrulich marked 2 inline comments as done. jgrulich added a comment. Minor fixes REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17213?vs=46399=46457 BRANCH

D17213: Add support for settings portal

jgrulich marked 5 inline comments as done. jgrulich added inline comments. INLINE COMMENTS > broulik wrote in khintssettings.cpp:66 > I thought Qt could de-serialize built-in types on its own? Nope, I think it can't. You already told me this before, but from my experience I always had to do it

D17213: Add support for settings portal

broulik added a comment. Good stuff! INLINE COMMENTS > kfontsettingsdata.cpp:81 > > -const KConfigGroup configGroup(mKdeGlobals, fontData.ConfigGroupKey); > -QString fontInfo = configGroup.readEntry(fontData.ConfigKey, > QString()); > +QString fontInfo = >

D17207: Use KPasswordLineEdit

This revision was automatically updated to reflect the committed changes. Closed by commit R121:a13b84e326e1: Use KPasswordLineEdit (authored by broulik). REPOSITORY R121 Policykit (Polkit) KDE Agent CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17207?vs=46378=46456 REVISION DETAIL