KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.11 - Build # 131 - Failure!

2018-12-17 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.11/131/ Project: kf5-qt5 SUSEQt5.11 Date of build: Tue, 18 Dec 2018 07:55:15 + Build duration: 3 min 14 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.11 - Build # 140 - Fixed!

2018-12-17 Thread CI System
BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.11/140/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Tue, 18 Dec 2018 07:54:27 + Build duration: 3 min 25 sec and counting

D15599: Port the "Switch Desktop" containment action to libtaskmanager

2018-12-17 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R120:6e41b8d98e06: Port the Switch Desktop containment action to libtaskmanager (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D15642: Port "Switch Window" containment action to updated libtaskmanager API and away from KWindowSystem

2018-12-17 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R120:c64fc46955f2: Port Switch Window containment action to updated libtaskmanager API and away… (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.11 - Build # 130 - Still Failing!

2018-12-17 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.11/130/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Tue, 18 Dec 2018 07:53:10 + Build duration: 1 min 17 sec and counting CONSOLE OUTPUT

D13748: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support

2018-12-17 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R119:c92b97fe9390: Adjust Pager to libtaskmanager API changes for Wayland virtual desktop support (authored by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13748?vs=38112=47753#toc

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.11 - Build # 129 - Failure!

2018-12-17 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.11/129/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Tue, 18 Dec 2018 07:48:52 + Build duration: 1 min 16 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.11 - Build # 139 - Failure!

2018-12-17 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.11/139/ Project: kf5-qt5 FreeBSDQt5.11 Date of build: Tue, 18 Dec 2018 07:47:22 + Build duration: 1 min 17 sec and counting CONSOLE OUTPUT

D13746: Adjust Task Manager to libtaskmanager API changes for Wayland virtual desktop support

2018-12-17 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R119:b0d6eab4a698: Adjust Task Manager to libtaskmanager API changes for Wayland virtual desktop… (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D13745: Implement support for virtual desktops on Wayland

2018-12-17 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R120:52d760c57c24: Implement support for virtual desktops on Wayland (authored by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13745?vs=43317=47751#toc REPOSITORY R120 Plasma Workspace

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

2018-12-17 Thread Eike Hein
This revision was automatically updated to reflect the committed changes. Closed by commit R108:cee5ea7819b2: [kcmkwin/desktop] KCM using new virtual desktops DBus interface (authored by hein). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14542?vs=47749=47750

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

2018-12-17 Thread Eike Hein
hein updated this revision to Diff 47749. hein added a comment. - Add missing upper bound to the Rows spinbox (cf. 06a9a2a468df ). - Change 'msec' to 'ms'. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

2018-12-17 Thread Eike Hein
hein added inline comments. INLINE COMMENTS > davidedmundson wrote in kcm_kwin_virtualdesktops.desktop:6 > please make sure the docs people know about this Told Luigi about it weeks ago, no worries :) > yurchor wrote in main.qml:222 > Can this be just "ms"-symbol as in Wikipedia for

Re: Quiet Mode signal

2018-12-17 Thread David Edmundson
Not at the moment. It's something that's come up before as a "this would be nice to have" repeatedly but hasn't gone anywhere...yet. It sort of falls into the category of the screensaver/power inhibitions which is an absolute mess of at least 4 duplicate and competing specs. It would be nice to

Quiet Mode signal

2018-12-17 Thread David Faure
Hi everyone, Is there some work going on in order to implement a desktop-wide signal that would automatically disable reminders during a presentation ? Calligra Stage, LibreOffice Impress and other presentation software could emit a dbus signal (or via plasma, not sure what the best

D17642: remove binding loop in KickoffItem

2018-12-17 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY For non-wrapped text, implicitHeight will be the height of the

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

2018-12-17 Thread Yuri Chornoivan
yurchor added inline comments. INLINE COMMENTS > main.qml:222 > + > +textFromValue: function(value, locale) { return i18n("%1 > msec", value)} > + Can this be just "ms"-symbol as in Wikipedia for milliseconds to avoid confusion with plural forms? Thanks. REPOSITORY R108

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

2018-12-17 Thread David Edmundson
davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kcm_kwin_virtualdesktops.desktop:6 > X-KDE-ServiceTypes=KCModule > -X-DocPath=kcontrol/desktop/index.html > -Icon=preferences-desktop > -Exec=kcmshell5

D17592: Introduce a DelegateRecycler attached object

2018-12-17 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 47719. apol added a comment. Use QML so the property emits updates upon change REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17592?vs=47602=47719 BRANCH arcpatch-D17592 REVISION DETAIL

D17487: Check if the form has changed, and only reconnect if it has

2018-12-17 Thread Jan Grulich
jgrulich added a comment. After a discussion with Openconnect main developer, we have come up with a fix in Openconnect itself and a workaround on plasma-nm side. Basically it's based on your previous patch where you just check the protocol to see if it's Juniper or not and if it's Juniper,

D14542: [kcmkwin/desktop] KCM using new virtual desktops DBus interface

2018-12-17 Thread Vlad Zagorodniy
zzag accepted this revision. zzag added a comment. Please wait for David's review. :-) REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D14542 To: hein, mart, davidedmundson, ltoscano, zzag, ngraham Cc: ngraham, davidedmundson, broulik, plasma-devel, kwin, GB_2,

D17591: Make AbstractCard.background react to AbstractCard.highlighted

2018-12-17 Thread Aleix Pol Gonzalez
apol closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D17591 To: apol, #kirigami, mart Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17583: Simplify code in MnemonicAttached

2018-12-17 Thread Aleix Pol Gonzalez
apol closed this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D17583 To: apol, #kirigami, mart Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D17533: Make the button's purpose more clear

2018-12-17 Thread Andras Mantia
amantia updated this revision to Diff 47714. amantia added a comment. Use title case REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17533?vs=47712=47714 BRANCH accesbility_dialog_improvement REVISION DETAIL https://phabricator.kde.org/D17533

D17533: Make the button's purpose more clear

2018-12-17 Thread Pino Toscano
pino added a comment. Regarding the use of bold: please note that using bold in some languages (usually eastern ones) either is not possible, or it does not make sense. So please do not solely rely on it to convey anything. INLINE COMMENTS > kaccess.cpp:671 > dialog = new

D17533: Make the button's purpose more clear

2018-12-17 Thread Andras Mantia
amantia added a comment. I perfectly agree with Frederik. There is room for improvement, but my intention was not to completely change it, just to make it slightly more clear what this is about. The rest can be fixed in a separate commit, if anyone is interested to do it. :) INLINE

D17533: Make the button's purpose more clear

2018-12-17 Thread Andras Mantia
amantia updated this revision to Diff 47712. amantia added a comment. Change the individual texts REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17533?vs=47661=47712 BRANCH accesbility_dialog_improvement REVISION DETAIL

D17592: Introduce a DelegateRecycler attached object

2018-12-17 Thread Marco Martin
mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. recycler should have a notify signal, because it's going to change all the time. the delegaterecycler instances are created/destroyed all the time like normal listview delegates,

D17533: Make the button's purpose more clear

2018-12-17 Thread Frederik Gladhorn
gladhorn added a comment. I also find the text rather confusing (thank you for working on this!). What is AccessX? And why should I care as a user? I need the feature... On the other hand, this patch is simple, self-contained, and in my opinion a clear improvement, so I'd vote for

D17561: Fix memory leak in notifications applet if only tracking jobs

2018-12-17 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. One could probably have cached the contents in a variable and then `delete`'d them right away without doing it before every `return` REPOSITORY R120 Plasma Workspace BRANCH master