Re: Thunderbolt KCM

First, is this something you Plasma folks would like to have in regular > Plasma > releases, or should I just make it an extragear project? If you think it > makes > sense to include it in Plasma, should it go to plasma-workspace, or should > it > be a standalone thing, like plasma-nm? It does

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

rooty added a comment. i think this is fine because the parent already behaves this way so REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D18797 To: ngraham, #vdg Cc: rooty, ndavis, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D18802: Fix pragma once problem with process class

patrickelectric created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. patrickelectric requested review of this revision. REVISION SUMMARY Signed-off-by: Patrick José Pereira REPOSITORY R871 DrKonqi BRANCH fix_pragma REVISION DETAIL

D18801: CMakeLists: Fix bgd.h include path on windows

patrickelectric updated this revision to Diff 51067. patrickelectric added a comment. Fix commit message REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18801?vs=51066=51067 BRANCH fix_bfd REVISION DETAIL https://phabricator.kde.org/D18801 AFFECTED

D18801: CMakeLists: Fix bgd.h include path on windows

patrickelectric created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. patrickelectric requested review of this revision. REVISION SUMMARY Signed-off-by: Patrick José Pereira REPOSITORY R871 DrKonqi BRANCH fix_bfd REVISION DETAIL

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

ndavis added a comment. The idea would be that 16 and 22px are for monochrome and 24px and above could be for color. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D18797 To: ngraham, #vdg Cc: ndavis, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen,

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

ngraham added a comment. That's rather a can of worms, since the 22px size is used all over the place. If we added a 24px size in addition (rather than replacing the 22px size), it would be weird; why have both 22 and 24px sizes. But if we replaced 22px entirely, a lot of things that are

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

ndavis added a comment. In D18797#406754 , @ngraham wrote: > Next question: KInfoCenter's version of this tooltip currently hardcodes 32x32 for the size of the parent icon above it rather than using the `KIconLoader::Dialog` size (which

D18800: Use colorful icon in KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R128:a7141be3091f: Use colorful icon in KCM (authored by ngraham). REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18800?vs=51063=51064 REVISION DETAIL

D18800: Use colorful icon in KCM

ngraham created this revision. ngraham added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Use a nice new colorful icon. Master only since this icon is provided by a symlink created in

Thunderbolt KCM

Hi all, last year I got a new Dell laptop at work with a docking station connected via the Thunderbolt thingy and I found out that there's a DBus daemon for Linux that allows users to authorize TB devices...long story short I somehow happened to have created a KCM to manage TB devices and a

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

ngraham added a comment. Next question: KInfoCenter's version of this tooltip currently hardcodes 32x32 for the size of the parent icon above it rather than using the `KIconLoader::Dialog` size (which defaults to 32x32).. Should we do that here too so that there's never a case where the

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

ngraham added a comment. In D18797#406733 , @ndavis wrote: > I thought we primarily used 22px and not 24px? While it does make the icons look more consistent as long as there are no monochrome 24px versions (there are some) should there be an

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

ndavis added a comment. In D18797#406739 , @ngraham wrote: > In D18797#406733 , @ndavis wrote: > > > I thought we primarily used 22px and not 24px? While it does make the icons look more consistent

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

ngraham updated this revision to Diff 51060. ngraham added a comment. Add a comment REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18797?vs=51058=51060 BRANCH Plasma/5.12 REVISION DETAIL https://phabricator.kde.org/D18797 AFFECTED FILES

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

ndavis added a comment. I thought we primarily used 22px and not 24px? While it does make the icons look more consistent as long as there are no monochrome 24px versions (there are some) should there be an exception to the norm? If so, we would have to remove all 24px monochrome icons. That

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

ngraham added a comment. Because the default MainToolbar size is 22x22, at which size we have various monochrome versions of color icons. So for example it would display the ugly 22px monochrome version of the Fonts icon, which did not change its color due to a bug in the way this tooltip

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

davidedmundson added a comment. Even if it did load MainToolbar icon size, why does that make them invisible as per the bug report? REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D18797 To: ngraham, #vdg Cc: davidedmundson, plasma-devel, jraleigh, GB_2,

D18797: [Tooltips] Use 24px size for children to improve display, just like KInfoCenter

ngraham created this revision. ngraham added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Adopt the same code that KInfoCenter uses for this tooltip and hardcode a 24px icon size for

D18341: Support icons from local files in buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R858:3ce69e6d6357: Support icons from local files in buttons (authored by nicolasfella). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D18796: [PassiveNotification] Don't start timer until window has focus

ngraham created this revision. ngraham added reviewers: Kirigami, mart, broulik, apol. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY WIth this patch, the `PassiveNotification`'s timer only starts when its

Re: Reverted "[Activities KCM] vertically center the buttons"

git branch --contains 9cdfe25910cbbfbef09364ce3adba5 Plasma/5.12 Plasma/5.14 Plasma/5.15 * master git branch --contains ccc6e24f9aab3da40f0ff2ba7b505022b485ed0e (your revert) master Can you double check everything's ok everywhere. David

Reverted "[Activities KCM] vertically center the buttons"

Hi all, Just to notify you that I've reverted commit 9cdfe25910cbbfbef09364ce3adba53bcc292853 because it broke the layout (see [1]) of the items in the Activities KCM. Cheers, Ivan [1] https://ibin.co/4W7JHc5mZ64Q.jpg -- dr Ivan Čukić KDE, ivan.cu...@kde.org, https://cukic.co/ gpg key

D18785: Use different Font Management KCM "All Fonts" icon

ngraham added a comment. The name makes me think this is not really semantically correct. Maybe we could make a symlink just called `font` or something that points to this icon? Also this icon only has a 24px version so it would look blurry at the more common 16px and 24px sizes, as in

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

This revision was automatically updated to reflect the committed changes. Closed by commit R116:bc4d82c15657: plasma-nm Connection Icon not showing correct icon when using a bridge (authored by jgrulich). REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE

D18766: Don't show tooltip when search field has text and set a timeout period

apol added a comment. In D18766#406485 , @shubham wrote: > @apol about the timeout? yes REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18766 To: shubham, apol, ngraham Cc: ngraham, broulik,

D18717: improvements for global shortcuts

This revision was automatically updated to reflect the committed changes. Closed by commit R878:fede9feb2dd0: improvements for global shortcuts (authored by trmdi, committed by mvourlakos). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE

D18779: Better window title display

broulik closed this revision. broulik added a comment. https://cgit.kde.org/libksysguard.git/commit/?id=87c2028856a1b924cdf86b5b258b642394dd7b13 REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D18779 To: broulik, #plasma, #vdg, tcanabrava Cc: abetts,

D18716: Add a SearchField component

mart added a comment. In D18716#404852 , @ognarb wrote: > Interesting, but I have some question before I start implementing. > > - Do you have an example for a left action? right now only web browsers url bars come to mind, so perhaps

D18779: Better window title display

abetts added a comment. Love it! REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D18779 To: broulik, #plasma, #vdg, tcanabrava Cc: abetts, rooty, mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas,

D18779: Better window title display

rooty added a comment. +1 REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D18779 To: broulik, #plasma, #vdg, tcanabrava Cc: rooty, mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D18767: [KEditFileType] Make heading with mime type selectable

This revision was automatically updated to reflect the committed changes. Closed by commit R126:9282d20d1b15: [KEditFileType] Make heading with mime type selectable (authored by broulik). REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE

D18767: [KEditFileType] Make heading with mime type selectable

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Yes please. Really all the labels in this dialog should have that flag. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D18767 To: broulik, #plasma,

D18767: [KEditFileType] Make heading with mime type selectable

rooty added a comment. sounds good to me REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D18767 To: broulik, #plasma, #vdg Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18689: plasma-nm Connection Icon not showing correct icon when using a bridge

rthomas added a comment. Hey Jan, please make this commit on my behalf as I don't have commit access right now and I'm not planning to apply for it any time soon. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18689 To: rthomas, jgrulich,

D18766: Don't show tooltip when search field has text and set a timeout period

shubham added a comment. @apol about the timeout? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18766 To: shubham, apol, ngraham Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D18766: Don't show tooltip when search field has text and set a timeout period

apol requested changes to this revision. apol added a comment. Nate is right. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18766 To: shubham, apol, ngraham Cc: ngraham, broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D18785: Use different Font Management KCM "All Fonts" icon

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Needed for D18702 . F6591513: New Font Management All Fonts

D14364: Test configId in TestSerializer

zzag added a comment. Any updates? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14364 To: gladhorn, #plasma, romangg Cc: zzag, romangg, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D17706: Fix lock screen focus

andreyby added a comment. When we use the X11BypassWindowManagerHint flag with a call to the showFullScreen() function on the x11 platform, requestActivate does not make the desired window active. For correct work, on x11 we have to call the show() function. But when the focus is set on a

D18751: [kcms/cursortheme] Correctly load m_originalPreferredSize

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3ae6a0eeb478: [kcms/cursortheme] Correctly load m_originalPreferredSize (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D18777: [kcms/mouse] Load current server settings in kcminit

This revision was automatically updated to reflect the committed changes. Closed by commit R119:e8de7085371f: [kcms/mouse] Load current server settings in kcminit (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

filipf added a comment. Can you confirm this @jriddell? Also, how strong of a document is an email confirmation to rooty or me, shouldn't it be something more formal? REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabricator.kde.org/D18078 To: filipf, #plasma, #vdg, ngraham

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

rooty added a comment. In D18078#406392 , @filipf wrote: > What is the final verdict reached in the mailing list discussion? We need to ask Unsplash and/or the photographers to release their work into the public domain or if it already

D18078: [plasma-workspace-wallpapers] Improve wallpaper selection

filipf added a comment. What is the final verdict reached in the mailing list discussion? REPOSITORY R131 Plasma Wallpapers REVISION DETAIL https://phabricator.kde.org/D18078 To: filipf, #plasma, #vdg, ngraham Cc: jriddell, lydia, davidedmundson, abetts, mart, rooty, plasma-devel,

Re: Monday meeting minutes for 2019-02-04 (week 6)

On Mon, Feb 4, 2019 at 2:25 PM Eike Hein wrote: > > > Of special note: We decided on doing another 5.14.x release to round up > Folder View and Discover fixes, to aid Debian Stable which will ship > 5.14.x. This will happen pending th completion of some Discover work for > the branch. on my side:

Re: Plasma and Qt5.12

On Tue, Feb 5, 2019 at 12:47 PM David Edmundson wrote: > > We've agreed that we want Plasma5.16 to depend on Qt5.12. > > Are there any objections to switching master to depend on this? none on my side, go go go :) -- Marco Martin

D18779: Better window title display

mart added a comment. +1 REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D18779 To: broulik, #plasma, #vdg Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D18779: Better window title display

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Replace HTML list by simple unicode bullets, avoids awkward indentation. Also, when there's