D19325: [sddm-theme/lock screen] WIP, Tighten clock shadows

rooty added a comment. In D19325#419745 , @rooty wrote: > Render shadows before labels Is "visible:" enough here or do I need layer.enabled too? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19325

D19325: [sddm-theme/lock screen] WIP, Tighten clock shadows

rooty updated this revision to Diff 52580. rooty added a comment. Render shadows before labels REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19325?vs=52578=52580 BRANCH tighten-clock-shadow (branched from master) REVISION DETAIL

D19325: [sddm-theme/lock screen] WIP, Tighten clock shadows

rooty added a comment. @ngraham there's actually another problem here, but one that's more readily seen in UserDelegate.qml The shadow is rendered **after** the label - which results in the label being darker than it should be (the shadows should go under the label not on top). This is

D19325: [sddm-theme/lock screen] WIP, Tighten clock shadows

rooty updated this revision to Diff 52578. rooty added a comment. Remove unnecessary (pasted) lines of code REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19325?vs=52577=52578 BRANCH tighten-clock-shadow (branched from master) REVISION DETAIL

D19325: [sddm-theme/lock screen] WIP, Tighten Clock shadows

rooty created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. rooty requested review of this revision. REVISION SUMMARY This patch tightens the shadows around the clock in the Breeze SDDM theme and lock screen so as to prevent the appearance of a diffuse

D19214: [sddm-theme] Replace login button label with icon

rooty added a comment. In D19214#419682 , @ngraham wrote: > OK, so let's pretend the password field height bug doesn't exist since it's gotta be solved elsewhere. Haha sure thing :D I mean I was meaning to wait until it was resolved

D18939: Add search/filter bar

ngraham added a comment. Thanks again for the contribution, @tuxxi! If you'd like to submit more patches to clean up the codebase a bit and add unit tests, nobody's gonna complain. :-) REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D18939 To: tuxxi, ngraham,

D18939: Add search/filter bar

This revision was automatically updated to reflect the committed changes. Closed by commit R103:3f6c86e1f26d: Add search/filter bar (authored by tuxxi, committed by ngraham). REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18939?vs=52129=52573 REVISION

D19295: [batterymonitor] Port Battery and Brightness settings to QQC2 and Kirigami

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4c691ce09f18: [batterymonitor] Port Battery and Brightness settings to QQC2 and Kirigami (authored by rooty). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19295: [batterymonitor] Port Battery and Brightness settings to QQC2 and Kirigami

rooty added a comment. In D19295#419562 , @ngraham wrote: > Hah! Doesn't get much simpler than this. ikr :D REPOSITORY R120 Plasma Workspace BRANCH battery-config-kirigami (branched from master) REVISION DETAIL

D19214: [sddm-theme] Replace login button label with icon

ngraham added a comment. OK, so let's pretend the password field height bug doesn't exist since it's gotta be solved elsewhere. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19214 To: rooty, #vdg, #plasma Cc: ngraham, filipf, plasma-devel, jraleigh,

D19077: Redesign the theme preview window

rooty added a comment. P.S. I moved the background button to the bottom, F6635412: image.png and I removed the vertical spacer so the label below the picture would never get cut off again (that glitch was fairly annoying and unpredictable...)

D19011: Thunderbolt KCM and KDED module

ngraham added inline comments. INLINE COMMENTS > DeviceView.qml:133 > +id: storeBtn > +text: i18n("Set as Trusted") > +visible: device && device.status == > Bolt.Bolt.Status.Authorized && device.stored == false "Trust this Device"? >

D19011: Thunderbolt KCM and KDED module

dvratil updated this revision to Diff 52568. dvratil added a comment. - Wording: replaced Stored with Trusted - Layout: centered all controls on device view page REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19011?vs=52255=52568 BRANCH

D19077: Redesign the theme preview window

rooty added a comment. Maybe we should switch tack - the other KCMs just state "Icon theme by Author" or "Cursor theme by Author" in their tooltips. We could just do that here. "Theme by Author" The license and email/web addresses of the author don't seem to be crucial information and

D19077: Redesign the theme preview window

ngraham added a comment. +1 REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL https://phabricator.kde.org/D19077 To: filipf, #plasma, #vdg, ngraham Cc: GB_2, mmustac, davidedmundson, abetts, rooty, plasma-devel, jraleigh, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D19280: [TaskManager] Modernize and reorganize configuration settings

filipf updated this revision to Diff 52565. filipf added a comment. I forgot to hide the grouping and sorting options when using Icons-only REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19280?vs=52518=52565 BRANCH master REVISION DETAIL

D19077: Redesign the theme preview window

ngraham added inline comments. INLINE COMMENTS > filipf wrote in main.qml:81 > > you'll need to handle that in the code > > How to do this? Sometimes some information really is missing so it could be > an issue. Then you'll need to have separate strings based on what could be missing. For

D19321: Fix a right to left issue

ognarb created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REPOSITORY R169 Kirigami BRANCH rtl REVISION DETAIL https://phabricator.kde.org/D19321 AFFECTED FILES src/controls/ActionTextField.qml To:

D19077: Redesign the theme preview window

filipf added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:81 > This is a word puzzle and will lead to bad translations because translators > won't be able to figure out what `", by "` refers to. The string should be > like this instead: > > `i18n("%1, by %2 (%3)", description,

D18934: WIP: [Notifications] Remove close button border by porting to IconItem

filipf added a comment. Update: I managed to get RoundButton working. While it does only have a minimal frame, unfortunately (with non-Breeze themes I believe) the button seemed to be suffering from odd coloring issues such as randomly taking on highlight color (even when the notifications

D19295: [batterymonitor] Port Battery and Brightness settings to QQC2 and Kirigami

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Hah! Doesn't get much simpler than this. REPOSITORY R120 Plasma Workspace BRANCH battery-config-kirigami (branched from master) REVISION DETAIL https://phabricator.kde.org/D19295

D19315: Use ActionTextField to implement the searchField

ognarb created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REVISION SUMMARY Need Kirigami latest version (master) and D19314 **Warning:** Remove the opacity change

D19314: Fix bug (check null didn't work)

ognarb created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REVISION SUMMARY Found a bug when adding this component to system settings, != null didn't work TEST PLAN Tested with applications already using

D19305: Use a better icon for the generic PackageKit source

Codezela added a comment. can we remove word sources and put the default source name instead REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D19305 To: ngraham, apol, #discover_software_store Cc: Codezela, plasma-devel, jraleigh, GB_2, ragreen,

D19312: Add tooltip for quick search

simgunz created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. simgunz requested review of this revision. REPOSITORY R111 KSysguard Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D19312 AFFECTED FILES

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre added a comment. In D18809#419441 , @davidedmundson wrote: > I have a sequence that breaks. > > Add /opt/kde5/share/wallpapers > Add /opt/kde5/share/wallpapers/Cascade > > (weirdly this last one now lists every size

D19305: Use a better icon for the generic PackageKit source

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R134:ae18ea936184: Provide a better package icon (authored by apol). REPOSITORY R134 Discover Software Store CHANGES

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidedmundson added a comment. I have a sequence that breaks. Add /opt/kde5/share/wallpapers Add /opt/kde5/share/wallpapers/Cascade (weirdly this last one now lists every size separately!) Remove the latter, nothing updates REPOSITORY R120 Plasma Workspace REVISION DETAIL

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

mart added a comment. applied the patch locally, and to me removing a folder immediately removes its images from the right thumbnail view REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18809 To: davidre, #vdg, ngraham, davidedmundson Cc: mart, alexde,

D19309: Improve Unity Indicator

trmdi created this revision. trmdi added a reviewer: Latte Dock. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. trmdi requested review of this revision. REVISION SUMMARY - Fix the bug "UnityRect is smaller than the icon in some cases", caused by `anchors.margin: 4`

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. It's a bit wasteful as we ultimately end up scanning all the wallpaper directories once in the main view then again when we have the config view open. But we

D19305: Use a better icon for the generic PackageKit source

ngraham added a comment. I've also requested a new icon for Flatpak Packages from VDG: https://bugs.kde.org/show_bug.cgi?id=404810 Then we can replace the ugly one that's currently in use there. REPOSITORY R134 Discover Software Store REVISION DETAIL

D19306: send a signal over dbus when the wrong password is provided

mart added a comment. F6634894: Screenshot_20190225_170638.png REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D19306 To: mart, #plasma, jgrulich Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel,

D19306: send a signal over dbus when the wrong password is provided

mart created this revision. mart added reviewers: Plasma, jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. mart requested review of this revision. REVISION SUMMARY On Plasma Mobile we can't actually show a qwidgets

D19305: Use a better icon for the generic PackageKit source

ngraham created this revision. ngraham added reviewers: apol, Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. TEST PLAN F6634891: package-x-generic.png REPOSITORY

D19301: Use Kirigami.ActionTextField for the SearchField

This revision was automatically updated to reflect the committed changes. Closed by commit R134:0bb9bd345f0a: Use Kirigami.ActionTextField for the SearchField (authored by ognarb). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D19300: Improve ToolTip in the ActionTextField component

This revision was automatically updated to reflect the committed changes. Closed by commit R169:e0503e1794b5: Improve ToolTip in the ActionTextField component (authored by ognarb). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19300?vs=52528=52536 REVISION

D15907: Compare float values in DecorationButton contains check

romangg abandoned this revision. romangg added a comment. No, it wouldn't. But you know what, fix your faulty patches yourselves. I have enough time wasted on this super-small issue. Get your priorities straight! REPOSITORY R129 Window Decoration Library REVISION DETAIL

D19301: Use Kirigami.ActionTextField for the SearchField

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks! Next can you do System Settings? https://cgit.kde.org/systemsettings.git/tree/sidebar/package/contents/ui/CategoriesPage.qml#n53 Looks like that one has some RTL handling

D15907: Compare float values in DecorationButton contains check

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. > You could have added some more rows for that to your autotest proposal to do this as well. As can you. It's your patch. Zzag already did 90% of the cleanup.

D19300: Improve ToolTip in the ActionTextField component

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D19300 To: ognarb, #kirigami, ngraham Cc: ngraham, plasma-devel, domson, dkardarakos,

D19301: Use Kirigami.ActionTextField for the SearchField

ognarb updated this revision to Diff 52533. ognarb marked 2 inline comments as done. ognarb added a comment. Improve code REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19301?vs=52529=52533 BRANCH master REVISION DETAIL

D19301: Use Kirigami.ActionTextField for the SearchField

apol added inline comments. INLINE COMMENTS > SearchField.qml:34 > +visible: root.text != "" > +onTriggered: clearText() > +} `searchField.clearText()` REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D19301 To: ognarb,

D19301: Use Kirigami.ActionTextField for the SearchField

apol added inline comments. INLINE COMMENTS > SearchField.qml:33 > +iconName: "edit-clear" > +visible: root.text != "" > +onTriggered: clearText() `visible: root.text.length !== 0` REPOSITORY R134 Discover Software Store REVISION DETAIL

D19301: Use Kirigami.ActionTextField for the SearchField

ognarb created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REVISION SUMMARY Need Kirigami latest version (master) TEST PLAN A regression found (need D19300 ) REPOSITORY

D19300: Improve ToolTip in the ActionTextField component

ognarb created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ognarb requested review of this revision. REVISION SUMMARY - Add standard duration (Kirigami.Units) - Don't display when text is not empty (same behaviour as in Discover) TEST PLAN

D18245: Create QApplication in a scope to work around possible deadlock

croick added a comment. In D18245#418708 , @thiago wrote: > I repeat: there's no indication in the backtrace that it is stuck. What's your evidence that it is? You wrote an application that shows nothing and never exits. Now it showed nothing

D19293: i18n: Add context to "Cannot fetch sources"

This revision was automatically updated to reflect the committed changes. Closed by commit R134:43f8d067aa10: i18n: Add context to Cannot fetch sources (authored by aspotashev). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D19293: i18n: Add context to "Cannot fetch sources"

aspotashev added a comment. This one is special because it's very unclear without context: one may think "sources" stands for source code, at least Ukrainian translation proves this theory. Other error messages are probably not ambiguous. REPOSITORY R134 Discover Software Store BRANCH

D18245: Create QApplication in a scope to work around possible deadlock

croick updated this revision to Diff 52524. croick retitled this revision from "[DrKonqi] Create QApplication in a scope to fix possible deadlock" to "Create QApplication in a scope to work around possible deadlock". croick edited the summary of this revision. croick added a comment. - add

D19029: Guard virtualDesktopManagement being accessed before fetched

davidedmundson added a comment. It would need to be guarded if it was used. However, from what I can tell it's not an issue there. All API calls are to objects inside QList and if that list is empty it does nothing. REPOSITORY R120 Plasma Workspace BRANCH master REVISION

Monday meeting notes for 25/2/2019

Bhushan: * prograss with Plasma Mobile on librem5 * https://bshah.in/plasma-librem5.mp4 here is video of Plasma Mobile running on Librem 5 Kai Uwe: - PowerDevil now sets KAboutData (got lost in kde4→kf5 port) so it shows up properly in DrKonqi -- sitter found a race when using KCrash

D19029: Guard virtualDesktopManagement being accessed before fetched

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Does the PlasmaWindowManagement object need to be guarded in the same way? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19029 To:

D18716: Add an ActionTextField component

This revision was automatically updated to reflect the committed changes. Closed by commit R169:d92bd4fe02c3: Add an ActionTextField component (authored by ognarb). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18716?vs=52411=52519 REVISION DETAIL

D19280: [TaskManager] Modernize and reorganize configuration settings

filipf updated this revision to Diff 52518. filipf added a comment. try a better solution for the indentation (now works consistently with scaling) REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19280?vs=52514=52518 BRANCH master REVISION

D19289: [DeviceNotifier] Port settings to QQC2 and Kirigami

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6be6a8c003c6: [DeviceNotifier] Port settings to QQC2 and Kirigami (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19280: [TaskManager] Modernize and reorganize configuration settings

filipf updated this revision to Diff 52514. filipf added a comment. fix typo in comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19280?vs=52513=52514 BRANCH master REVISION DETAIL https://phabricator.kde.org/D19280 AFFECTED FILES

D19280: [TaskManager] Modernize and reorganize configuration settings

filipf updated this revision to Diff 52513. filipf added a comment. revert grouping settings order and indent the onlyGroupWhenFull option REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19280?vs=52491=52513 BRANCH master REVISION DETAIL