D17211: Port applet/containment configs to qqc2

This revision was automatically updated to reflect the committed changes. Closed by commit R119:c2640f83f107: Port applet/containment configs to qqc2 (authored by mart). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17211?vs=46481=46483 REVISION

D17211: Port applet/containment configs to qqc2

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. +1 shipit! REPOSITORY R119 Plasma Desktop BRANCH phab/qqc2 REVISION DETAIL https://phabricator.kde.org/D17211 To: mart, #plasma, #vdg, broulik, ngraham Cc: abetts, ngraham, apol,

D17211: Port applet/containment configs to qqc2

mart updated this revision to Diff 46481. mart added a comment. - show the label again, but shorter REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17211?vs=46398=46481 BRANCH phab/qqc2 REVISION DETAIL https://phabricator.kde.org/D17211

D17211: Port applet/containment configs to qqc2

abetts added a comment. In D17211#368161 , @ngraham wrote: > Thanks, the combobox open-on-click feature works perfectly! > > I still don't agree with making the wallpaper plugin GHNS button icons-only. That makes it inconsistent with all

D17211: Port applet/containment configs to qqc2

ngraham added a comment. Thanks, the combobox open-on-click feature works perfectly! I still don't agree with making the wallpaper plugin GHNS button icons-only. That makes it inconsistent with all others in every other KCM and I took great pain recently to make them all consistent. Can

D17211: Port applet/containment configs to qqc2

abetts added a comment. +1 on visuals REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17211 To: mart, #plasma, #vdg, broulik, ngraham Cc: abetts, ngraham, apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, mart

D17211: Port applet/containment configs to qqc2

mart added a comment. the shrinking of the wallpaper combobox will be done in a separate commit REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17211 To: mart, #plasma, #vdg, broulik, ngraham Cc: ngraham, apol, plasma-devel, ragreen, Pitel, ZrenBot,

D17211: Port applet/containment configs to qqc2

mart added a comment. In D17211#367974 , @mart wrote: > ah, that needs a fix in qqc2-desktop-style.. i can hack the open on down, tough for combox and menus in particular, is not possible at all the pattern press, open the subpopup, move the

D17211: Port applet/containment configs to qqc2

mart added a comment. In D17211#367573 , @ngraham wrote: > The Layout and Wallpaper Type comboboxes should open on press, not on click-and-release. ah, that needs a fix in qqc2-desktop-style.. i can hack the open on down, tough for

D17211: Port applet/containment configs to qqc2

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. The Layout and Wallpaper Type comboboxes should open on press, not on click-and-release. The Positioning combobox shouldn't be so much much wider than the other

D17211: Port applet/containment configs to qqc2

broulik added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17211 To: mart, #plasma, #vdg, broulik Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D17211: Port applet/containment configs to qqc2

mart updated this revision to Diff 46398. mart added a comment. - initialize a proper size REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17211?vs=46397=46398 BRANCH phab/qqc2 REVISION DETAIL https://phabricator.kde.org/D17211 AFFECTED FILES

D17211: Port applet/containment configs to qqc2

mart added a comment. oddly seems not all the pages to not animate... i fear they are trying to set anchors? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17211 To: mart, #plasma, #vdg, broulik Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D17211: Port applet/containment configs to qqc2

mart added a comment. F6444604: Screenshot_20181128_130459.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17211 To: mart, #plasma, #vdg, broulik Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D17211: Port applet/containment configs to qqc2

mart updated this revision to Diff 46397. mart added a comment. move text in tooltip REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17211?vs=46394=46397 BRANCH phab/qqc2 REVISION DETAIL https://phabricator.kde.org/D17211 AFFECTED FILES

D17211: Port applet/containment configs to qqc2

broulik added a comment. Quirks I have found: - The "Filters" page in Folder View configuration doesn't get a size initially and only does when I resize the window - The transition animation is buggy, the "enterItem" isn't properly animated from what I can tell, just pops up right

D17211: Port applet/containment configs to qqc2

apol added a comment. +1 cool! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D17211 To: mart, #plasma, #vdg, broulik Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D17211: Port applet/containment configs to qqc2

mart added a comment. before: F6444531: Screenshot_20181128_113703.png after: F6444535: Screenshot_20181128_113712.png F6444538: Screenshot_20181128_113718.png

D17211: Port applet/containment configs to qqc2

mart created this revision. mart added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY port the applet config dialogs and containments to QtQuickControls2 and Kirigami modernizing it,