Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126466/#review89900 --- src/declarativeimports/core/iconitem.cpp (line 396)

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

> On Dec. 22, 2015, 11:59 a.m., David Edmundson wrote: > > src/declarativeimports/core/iconitem.cpp, line 406 > > > > > > One of the (albeit extremely flimsy) arguments to a timer is changing > > both the width

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

> On Dic. 22, 2015, 11:59 a.m., David Edmundson wrote: > > src/declarativeimports/core/iconitem.cpp, line 406 > > > > > > One of the (albeit extremely flimsy) arguments to a timer is changing > > both the width

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126466/ --- (Updated Dec. 22, 2015, 4:32 p.m.) Review request for Plasma and David

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

> On Dec. 22, 2015, 4:35 p.m., Aleix Pol Gonzalez wrote: > > src/declarativeimports/core/iconitem.cpp, line 254 > > > > > > Are you sure it is a good idea to load the pixmap as we're rendering? > > This will

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126466/ --- (Updated Dec. 22, 2015, 4:58 p.m.) Review request for Plasma and David

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

> On Dec. 22, 2015, 11:59 a.m., David Edmundson wrote: > > src/declarativeimports/core/iconitem.cpp, line 406 > > > > > > One of the (albeit extremely flimsy) arguments to a timer is changing > > both the width

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126466/ --- (Updated Dec. 22, 2015, 4:56 p.m.) Review request for Plasma and David

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

> On Dec. 22, 2015, 5:13 p.m., David Edmundson wrote: > > src/declarativeimports/core/iconitem.cpp, line 253 > > > > > > given you have an explicit call to polish() I don't think we need the > > guard? Agreed

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126466/ --- (Updated Dec. 22, 2015, 5:32 p.m.) Review request for Plasma and David

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126466/#review89941 --- Ship it! the diff has ended up a bit broken - revision 4

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126466/#review89942 --- +1 - Aleix Pol Gonzalez On Dec. 22, 2015, 5:58 p.m., Eike

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126466/#review89946 --- Ship it! Ship It! - David Edmundson On Dec. 22, 2015,

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126466/ --- (Updated Dec. 22, 2015, 6:29 p.m.) Status -- This change has been

Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126466/ --- Review request for Plasma and David Edmundson. Bugs: 345545