Re: Review Request 126944: LockScreen: Use layout display name in KeyboardLayoutButton

2016-02-01 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126944/ --- (Updated Feb. 1, 2016, 2:02 p.m.) Status -- This change has been

Review Request 126944: LockScreen: Use layout display name in KeyboardLayoutButton

2016-02-01 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126944/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 126944: LockScreen: Use layout display name in KeyboardLayoutButton

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126944/#review91849 --- +1 components/keyboardlayout/keyboardlayout.cpp (lines 85

Re: Review Request 126944: LockScreen: Use layout display name in KeyboardLayoutButton

2016-02-01 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126944/ --- (Updated Feb. 1, 2016, 1:16 p.m.) Review request for Plasma.

Re: Review Request 126944: LockScreen: Use layout display name in KeyboardLayoutButton

2016-02-01 Thread David Rosca
> On Feb. 1, 2016, 1:12 p.m., Kai Uwe Broulik wrote: > > components/keyboardlayout/keyboardlayout.cpp, line 92 > > > > > > You can use a lambda The rest of the file is using slots, so I went with slot too. -

Re: Review Request 126944: LockScreen: Use layout display name in KeyboardLayoutButton

2016-02-01 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126944/#review91852 --- Ship it! Ship It! - Kai Uwe Broulik On Feb. 1, 2016,