Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper

> On Dec. 22, 2015, 1:22 a.m., Aleix Pol Gonzalez wrote: > > I quite like it. +1 > > > > What's the sources? (i.e. if someone wanted to modify it, what should he > > base on?) We have it on the VDG share. Here's a link to the wallpaper folder: https://share.kde.org/index.php/s/Ao0pkmIziY0uCV2

Re: Noto fonts screw my system, please stop forcing fonts upon me!

i did that, but they saw no problem. (i linked to the arch bug report in my previous mail) as you can see in the two linked bug report, i think the two correct places in which is could be fixed is the repo and the packaging. i’ll get back to the packagers when i have an answer in the repo bug

Re: Review Request 126468: AppletQuickItem: Drop timer to create full representation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126468/ --- (Updated Dec. 22, 2015, 2:58 p.m.) Status -- This change has been

Re: Review Request 126475: Make sure PlasmaCore.WindowThumbnail doesn't redirect windows while disabled or invisible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126475/#review89947 --- Ship it! Ship It! - David Edmundson On Dec. 22, 2015,

Re: Review Request 124047: Improve clock's tooltip layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124047/ --- (Updated Dec. 22, 2015, 8:34 p.m.) Review request for Plasma. Changes

Review Request 126477: [breeze-gtk] Relax cmake version requirement to rest of plasma

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126477/ --- Review request for Plasma and David Edmundson. Repository: breeze-gtk

Re: Review Request 125993: Implemented lastfmimagefetcher as a Plugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125993/#review89948 --- Ship it! libs/mediacenter/lastfmimagefetcher.cpp (line 172)

Re: Review Request 124047: Improve clock's tooltip layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124047/#review89950 --- It still does not shrink if timezones are removed. Otherwise

Re: Review Request 122859: WIP: Don't animate from previous pixmap when IconItem has been invisible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/122859/#review89951 --- I suppose this is obsolete now. - Kai Uwe Broulik On März

Re: Review Request 124047: Improve clock's tooltip layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124047/#review89958 --- applets/digital-clock/package/contents/ui/Tooltip.qml (line

Re: Review Request 124047: Improve clock's tooltip layout

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124047/ --- (Updated Dec. 22, 2015, 8:38 p.m.) Review request for Plasma. Changes

Re: Review Request 122859: WIP: Don't animate from previous pixmap when IconItem has been invisible

> On Dec. 22, 2015, 9:58 p.m., Kai Uwe Broulik wrote: > > I suppose this is obsolete now. I don't think it is. The other patch was about removing a silly timer before loading a pixmap, however it still always has the fade when changing source. - David

Re: Noto fonts screw my system, please stop forcing fonts upon me!

Avoiding top-posting makes your emails a bit easier to read. I took the liberty to rearrange. > Sebastian Kügler schrieb am Di., 22. Dez. 2015 um 15:32 Uhr: > On Tuesday, December 22, 2015 14:03:19 Philipp A. wrote: > > all of those individually are perfectly resonable

Review Request 126468: AppletQuickItem: Drop timer to create full representation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126468/ --- Review request for Plasma. Repository: plasma-framework Description

Jenkins-kde-ci: plasma-workspace Plasma-5.5 stable-kf5-qt5 » Linux,gcc - Build # 21 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.5%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/21/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 22 Dec 2015 10:15:24 + Build duration: 4 min 16 sec CHANGE SET Revision

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126466/#review89900 --- src/declarativeimports/core/iconitem.cpp (line 396)

Re: Review Request 126464: [compactApplet] Read ToolTipArea.mainItem from plasmoid.toolTipItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126464/#review89910 --- Did you test all plasmoids with standard tooltip still work

Re: Review Request 126373: change the taskbar color from blue to gray

> On Dic. 20, 2015, 8:24 p.m., andreas kainz wrote: > > ok so please vote for > > 1. leave it as it is > > 2. as it is now but with white text for selected task > > 3. add blue boarder as all other tasks have (see first line in taskbar3.png) > > 4. better idea > > Martin Klapetek wrote: >

Re: Review Request 126460: Honor SkipGrouping hint from KNotification

> On Dic. 21, 2015, 8:38 p.m., David Edmundson wrote: > > dataengines/notifications/notificationsengine.cpp, line 191 > > > > > > const shipit, modulo this const - Marco

Re: Review Request 126468: AppletQuickItem: Drop timer to create full representation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126468/#review89902 --- you talk about popups, but have you tested applets on the

Re: Review Request 126463: Allow applets to set full ToolTip item

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126463/#review89909 --- Ship it! src/scriptengines/qml/plasmoid/appletinterface.h

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

> On Dec. 22, 2015, 11:59 a.m., David Edmundson wrote: > > src/declarativeimports/core/iconitem.cpp, line 406 > > > > > > One of the (albeit extremely flimsy) arguments to a timer is changing > > both the width

Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126319/#review89916 --- +1 from me too I quite like it. perhaps i'm not too sold as

Re: Review Request 126468: AppletQuickItem: Drop timer to create full representation

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126468/#review89904 --- Ship it! Ship It! - David Edmundson On Dec. 22, 2015,

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

> On Dic. 22, 2015, 11:59 a.m., David Edmundson wrote: > > src/declarativeimports/core/iconitem.cpp, line 406 > > > > > > One of the (albeit extremely flimsy) arguments to a timer is changing > > both the width

Re: Review Request 126463: Allow applets to set full ToolTip item

> On Dic. 21, 2015, 10:39 p.m., David Edmundson wrote: > > src/scriptengines/qml/plasmoid/appletinterface.h, line 407 > > > > > > what would happen if the tooltipItem object gets deleted by the > > plasmoid

Re: Noto fonts screw my system, please stop forcing fonts upon me!

Hello, concerning fonts - the choice of fonts is always a tricky call. Aside from an exact, and more feature complete version of Oxygen which sadly doesn't exist, Noto is the perfect choice for us. It's a very well made standardized font and the only other contender was the Firefox Fira IIRC

Re: Noto fonts screw my system, please stop forcing fonts upon me!

Hi, I feel like the same as Aleix. For me, as a part of CJK lang and fonts users, changing font settings is one of the highest priority work when I install fresh Plasma emvironment ( and when removing .config/* :P ) even though Noto is set to default. I think the Plasma dev and design team take

Re: Review Request 126319: Plasma 5.6 "Graphite" Wallpaper

Every time that you release a wallpaper I think: "oh, OK, this is the best wallpaper ever, even the next won't be better than this!" and every time you surprise me with a wallpaper better than the previous. This time you impress me again, this wallpaper goes exactly in the direction I wanted

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126466/ --- (Updated Dec. 22, 2015, 4:32 p.m.) Review request for Plasma and David

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

> On Dec. 22, 2015, 4:35 p.m., Aleix Pol Gonzalez wrote: > > src/declarativeimports/core/iconitem.cpp, line 254 > > > > > > Are you sure it is a good idea to load the pixmap as we're rendering? > > This will

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126466/ --- (Updated Dec. 22, 2015, 4:58 p.m.) Review request for Plasma and David

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

> On Dec. 22, 2015, 11:59 a.m., David Edmundson wrote: > > src/declarativeimports/core/iconitem.cpp, line 406 > > > > > > One of the (albeit extremely flimsy) arguments to a timer is changing > > both the width

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126466/ --- (Updated Dec. 22, 2015, 4:56 p.m.) Review request for Plasma and David

Review Request 126472: Don't always load the timetracker

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126472/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 126472: Don't always load the timetracker

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126472/#review89924 --- Ship it! Nice. I agree with Aleix that the env var would be

[Powerdevil] [Bug 357045] Remember brigthness level between logins

https://bugs.kde.org/show_bug.cgi?id=357045 Kai Uwe Broulik changed: What|Removed |Added CC|

Re: Review Request 126471: Don't emit statusChanged if it hasn't changed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126471/#review89920 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 22, 2015,

Re: Review Request 126472: Don't always load the timetracker

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126472/#review89921 --- I'm ok with this, although it wasn't guarded initially

[Powerdevil] [Bug 357045] New: Remember brigthness level between logins

https://bugs.kde.org/show_bug.cgi?id=357045 Bug ID: 357045 Summary: Remember brigthness level between logins Product: Powerdevil Version: unspecified Platform: Other OS: Linux Status: UNCONFIRMED

Re: Noto fonts screw my system, please stop forcing fonts upon me!

there is one part of this issue that bugs me as well, but it’s rather an unfortunate coincidence than anything else: - KDE requires Noto as a baseline default font. that’s fine as nobody forces me to use it. - the freetype project ships a metric-aliases config that defines a number of

Review Request 126471: Don't emit statusChanged if it hasn't changed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126471/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 126472: Don't always load the timetracker

> On Dec. 22, 2015, 3:21 p.m., Aleix Pol Gonzalez wrote: > > I'm ok with this, although it wasn't guarded initially because it was asked > > not to. IIRC. > > > > Anyway, +1. Some small documentation about the environment variable would be neat. - Aleix

Re: Noto fonts screw my system, please stop forcing fonts upon me!

On Tuesday, December 22, 2015 14:03:19 Philipp A. wrote: > all of those individually are perfectly resonable decisions, so without it > being anyone’s fault, i’m forced to fiddle with my fontconfig to blacklist > the three metric alias fonts if i don’t want to see it. That sounds like you want to

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

> On Dec. 22, 2015, 5:13 p.m., David Edmundson wrote: > > src/declarativeimports/core/iconitem.cpp, line 253 > > > > > > given you have an explicit call to polish() I don't think we need the > > guard? Agreed

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126466/ --- (Updated Dec. 22, 2015, 5:32 p.m.) Review request for Plasma and David

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126466/#review89941 --- Ship it! the diff has ended up a bit broken - revision 4

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126466/#review89942 --- +1 - Aleix Pol Gonzalez On Dec. 22, 2015, 5:58 p.m., Eike

Re: Review Request 126471: Don't emit statusChanged if it hasn't changed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126471/ --- (Updated Dec. 22, 2015, 5:32 p.m.) Status -- This change has been

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126466/#review89946 --- Ship it! Ship It! - David Edmundson On Dec. 22, 2015,

Review Request 126475: Make sure PlasmaCore.WindowThumbnail doesn't redirect windows while disabled or invisible

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126475/ --- Review request for Plasma, David Edmundson and Martin Gräßlin. Bugs:

Re: Review Request 126466: Drop unneeded timer from PlasmaCore.IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126466/ --- (Updated Dec. 22, 2015, 6:29 p.m.) Status -- This change has been