D29081: [QStyle] Make menu titles look less like menu items

ngraham created this revision. ngraham added reviewers: VDG, Breeze. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The look of Breeze menu titles has always slightly bothered me since they have the same

D28509: RFC: [libnotificationmanager] introduce the notification watcher

bshah added a comment. One last todo is fixing summary so it is not processed twice. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28509 To: bshah, #plasma, broulik, davidedmundson Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D28509: RFC: [libnotificationmanager] introduce the notification watcher

bshah updated this revision to Diff 80833. bshah added a comment. rebase to master REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28509?vs=80832=80833 BRANCH bshah/notification-watcher REVISION DETAIL https://phabricator.kde.org/D28509

D28509: RFC: [libnotificationmanager] introduce the notification watcher

bshah added inline comments. INLINE COMMENTS > broulik wrote in notification.h:128 > Maybe add a new `rawHints() const`? > > Not a fan of ref return I avoided using "raw" word in the function name, because when we process hints we don't actually modify it. We just process rest of

D28509: RFC: [libnotificationmanager] introduce the notification watcher

bshah updated this revision to Diff 80832. bshah marked 15 inline comments as done. bshah added a comment. address various comments - adhere to interface name when registering watcher - remove unused code - use qdbusservicewatcher - add valid property REPOSITORY R120 Plasma

D29064: [WIP] Support module commandline paramenter

ngraham added inline comments. INLINE COMMENTS > IconMode.cpp:143 > d->mainWidget->setCurrentWidget( d->moduleView ); > - > +qWarning()<<""< // avoid double titles by setting the right face type before loading the > module aahh! >

D27669: [kstyle] Tools area

ngraham added a comment. Affected apps: - Spectacle: crashes as soon as it launches - Telegram: crashes when I click on a chat in the sidebar Other unusual behavior noticed: - Opening open/save dialogs and settings windows in Dolphin and Kate causes the parent apps to hang

D27669: [kstyle] Tools area

ngraham added a comment. The crash is still happening for me. It's instantly reproducible with Spectacle. I open it and it immediately crashes. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27669 To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre, ngraham

D29080: [kcms/fonts] Guide users towards KScreen KCM for making things bigger on-screen

ngraham updated this revision to Diff 80831. ngraham added a comment. Add clarifying comment REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29080?vs=80830=80831 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29080 AFFECTED FILES

D29080: [kcms/fonts] Guide users towards KScreen KCM for making things bigger on-screen

ngraham added inline comments. INLINE COMMENTS > fonts.cpp:229 > - > -emit fontsHaveChanged(); > } Nothing was previously listening for this signal, so I believe it is safe to repurpose it for something else as I have done in this patch. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D29080: [kcms/fonts] Guide users towards KScreen KCM for making things bigger on-screen

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Many users seem to like using Force Fonts DPI or (less commonly) the font sizes to

D29060: Port placeholder message to Kirigami.PlaceholderMessage

ngraham updated this revision to Diff 80826. ngraham added a comment. Add margins so really long translations can't touch the edges of the view REPOSITORY R1044 Plasma Thunderbolt Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29060?vs=80780=80826 BRANCH

D28888: Fix navigation regressions

ngraham added a comment. Close. There's extra spacing on the right for some reason, and I think the sidebar's background used to be white. F8252517: Screenshot_20200421_191722.png REPOSITORY R1014 Kirigami Gallery REVISION DETAIL

D29057: Introduce PlaceholderMessage component

ngraham updated this revision to Diff 80825. ngraham added a comment. Add margins to examples REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29057?vs=80782=80825 BRANCH placeholder-message (branched from master) REVISION DETAIL

D29059: Port BrowsingPage to PlaceholderMessage

ngraham updated this revision to Diff 80824. ngraham added a comment. One last thing: add margins so it can't touch the edges of the view REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29059?vs=80783=80824 BRANCH

D28888: Fix navigation regressions

cblack updated this revision to Diff 80822. cblack added a comment. Switch between ListView and CardsLayout REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2?vs=80291=80822 BRANCH cblack/better-navigation (branched from master) REVISION

D27669: [kstyle] Tools area

cblack updated this revision to Diff 80819. cblack added a comment. Remove stray qDebug REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27669?vs=80603=80819 BRANCH arcpatch-D27669_1 REVISION DETAIL https://phabricator.kde.org/D27669 AFFECTED FILES

D28666: Refactor for loops

ngraham added a comment. That was fixed, thanks. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28666 To: cblack, #kirigami, mart Cc: broulik, ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson, mart

D29075: [wallpapers/image] Port to BasicListItem+subtitle

ngraham updated this revision to Diff 80817. ngraham added a comment. Forgot to bump the required versions REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29075?vs=80816=80817 BRANCH port-to-basiclistitem-with-subtitle (branched from master)

D29075: [wallpapers/image] Port to BasicListItem+subtitle

ngraham created this revision. ngraham added reviewers: Plasma, Kirigami. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This allows us to use the new consistent appearance introduced with D29074

D29074: Make BasicListItem more useful by giving it a subtitle property

ngraham created this revision. ngraham added reviewers: VDG, Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Right now `BasicListItem` is quite limited and therefore not very useful. We

D28666: Refactor for loops

ngraham added a comment. This appears to have broken `SwipeListItem`. Now the actions don't show up anymore and there's loads of console spam: file:///home/nate/kde/usr/lib64/qml/org/kde/kirigami.2/templates/SwipeListItem.qml:421: TypeError: Type error

D28625: Use ShadowedRectangle for Card backgrounds

cblack added a comment. This seems to be causing regressions to card behaviour for me. Cards are running together when they weren't previously: F8252161: ksnip_20200421-162339.png The images are: 1. having non-deterministic texture issues

D29071: FileChooser portal: add support for opening directories

broulik added inline comments. INLINE COMMENTS > filechooser.cpp:167 > > +if (options.contains(QStringLiteral("directory"))) { > +directory = options.value(QStringLiteral("directory")).toBool(); This check isn't needed, but is probably consistent with the rest and should be

D29071: FileChooser portal: add support for opening directories

jgrulich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jgrulich requested review of this revision. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop BRANCH filechooser-directory REVISION DETAIL https://phabricator.kde.org/D29071

D28873: Add SwipeNavigator component

cblack updated this revision to Diff 80804. cblack added a comment. Adjust tab stylings REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28873?vs=80281=80804 BRANCH cblack/lateral (branched from master) REVISION DETAIL

D28462: [KCM][WIP] Add KCModuleData

ngraham added a comment. +1 for a simple base class so we can avoid so much boilerplate REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28462 To: bport, #plasma, ervin, meven, crossi, hchain Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n,

D28461: In sidebar mode show if a module is in default state or not

ervin accepted this revision. ervin added a comment. LGTM REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D28461 To: bport, #plasma, ervin, meven, crossi, hchain, #vdg, mart Cc: GB_2, mart, ngraham, abetts, filipf, The-Feren-OS-Dev, ndavis, broulik,

D28462: [KCM][WIP] Add KCModuleData

ervin requested changes to this revision. ervin added a comment. This revision now requires changes to proceed. Only a small thing left I think INLINE COMMENTS > cursorthemedata.h:33 > +Q_OBJECT > +//Q_PROPERTY(CursorThemeSettings *cursorThemeSettings READ > cursorThemeSettings

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

apol updated this revision to Diff 80797. apol added a comment. Remember to run the event loop REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28884?vs=80795=80797 BRANCH master REVISION DETAIL

D28873: Add SwipeNavigator component

ngraham resigned from this revision. ngraham added a subscriber: squeakypancakes. ngraham added a comment. All right, you've convinced me. As for the appearance, we probably need for that to be defined using styles. IMO the material style should get this very google-looking appearance

D29019: Create a hotspot KCM for Plasma Mobile

This revision was automatically updated to reflect the committed changes. Closed by commit R116:1c9d021daf4e: Create a hotspot KCM for Plasma Mobile (authored by tfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29019?vs=80765=80796#toc REPOSITORY R116 Plasma Network Management

D29019: Create a hotspot KCM for Plasma Mobile

cblack accepted this revision. cblack added a comment. UI seems fine enough. REPOSITORY R116 Plasma Network Management Applet BRANCH mobileHotspotKcm REVISION DETAIL https://phabricator.kde.org/D29019 To: tfella, #vdg, jgrulich, nicolasfella, cblack Cc: cblack, nicolasfella,

D29019: Create a hotspot KCM for Plasma Mobile

tfella added a comment. F8251937: HotspotKcm.png REPOSITORY R116 Plasma Network Management Applet BRANCH mobileHotspotKcm REVISION DETAIL https://phabricator.kde.org/D29019 To: tfella, #vdg, jgrulich, nicolasfella Cc: nicolasfella, plasma-devel,

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

apol updated this revision to Diff 80795. apol added a comment. Remove conditional compilation to pipewire It's not in this module, we don't need to depend on it. Also removes code regarding EGL initialization that I think now is not necessary. REPOSITORY R838 Flatpak Support: KDE

D28744: Rewrite of the global shortcuts kcm

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Boom. REPOSITORY R119 Plasma Desktop BRANCH kcmkeys2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D28744 To: davidre, #vdg, #plasma, ngraham Cc: GB_2,

D29040: Use colorful icon instead of monochrome icon for touchpad kcm

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5cb382282de3: Use colorful icon instead of monochrome icon for touchpad kcm (authored by Guo Yunhe i...@guoyunhe.me). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D29064: support module commandline paramenter

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY in prevision of more or less replacing kcmshell with systemsettings itself, suppo loading a module as a

D29057: Introduce PlaceholderMessage component

abetts added a comment. Look cool! REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D29057 To: ngraham, #vdg, #kirigami, mart Cc: abetts, broulik, cblack, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart

D29059: Port BrowsingPage to PlaceholderMessage

ngraham updated this revision to Diff 80783. ngraham added a comment. Adjusted to changed icon API (now accepts grouped properties, so use `icon.name`) REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29059?vs=80779=80783 BRANCH

D29057: Introduce PlaceholderMessage component

ngraham updated this revision to Diff 80782. ngraham marked 13 inline comments as done. ngraham added a comment. Address review comments REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29057?vs=80777=80782 BRANCH placeholder-message (branched from

D29057: Introduce PlaceholderMessage component

broulik added inline comments. INLINE COMMENTS > PlaceholderMessage.qml:118 > + */ > +property QQC2.Action helperAction > + You can probably just make an `alias` to the button's `action` property. It got added in Qt 5.10, then it should take on the icon, text, visibility, trigger, etc

D29057: Introduce PlaceholderMessage component

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > PlaceholderMessage.qml:10 > +import QtQuick.Layouts 1.13 > +import org.kde.kirigami 2.12 > + as convention (sadly not used everywhere in the sources but at least

D29057: Introduce PlaceholderMessage component

cblack added inline comments. INLINE COMMENTS > PlaceholderMessage.qml:20 > + * > + * @code > + * import org.kde.kirigami 2.11 as Kirigami `@code{.qml}` > PlaceholderMessage.qml:40 > + * > + ** Used as a "here's how to proceed" message > + * ListView { Split into own codeblock >

D29056: [libtaskmanager] add stacking order data for wayland

davidedmundson added a comment. assuming others are merged of course REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29056 To: bport, broulik, davidedmundson, zzag, meven Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D29060: Port placeholder message to Kirigami.PlaceholderMessage

ngraham created this revision. ngraham added reviewers: VDG, Plasma, dvratil. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This makes the appearance more standardized by using the new Kirigmai library

D29059: Port BrowsingPage to PlaceholderMessage

ngraham created this revision. ngraham added reviewers: VDG, Discover Software Store, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY While I'm stuck with https://bugs.kde.org/show_bug.cgi?id=420324, I

D29058: Set a component display name for the action collection of ksmserver

davidre created this revision. davidre added reviewers: ngraham, Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY "ksmserver" is not a good user visible string. TEST PLAN check in global

D29057: Introduce PlaceholderMessage component

ngraham created this revision. ngraham added reviewers: VDG, Kirigami, mart. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY This patch creates the `PlaceholderMessage`, a re-usable component that can be

D29056: [libtaskmanager] add stacking order data for wayland

bport created this revision. bport added reviewers: broulik, davidedmundson, zzag, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bport requested review of this revision. REVISION SUMMARY Depends on D29055 and D29054

D29052: Set component display name for touchboard and keyboard kcm action collections

davidre created this revision. davidre added reviewers: ngraham, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Otherwise they get assigned a generic "KDE Daemon" name because of kded TEST PLAN

D28744: Rewrite of the global shortcuts kcm

davidre updated this revision to Diff 80767. davidre added a comment. - Fix defaults - Add pending deletion thing REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28744?vs=80675=80767 BRANCH kcmkeys2 (branched from master) REVISION DETAIL

D29019: Create a hotspot KCM for Plasma Mobile

tfella updated this revision to Diff 80765. tfella added a comment. Use network-wireless-hotspot as icon REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29019?vs=80714=80765 BRANCH mobileHotspotKcm REVISION DETAIL

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 80762. ngraham added a comment. Don't include merge conflict bits lol REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=80760=80762 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL

D29033: Remove duplicated code

apol abandoned this revision. apol added a comment. My bad, thanks! REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D29033 To: apol, #frameworks, zzag Cc: zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham added a comment. I think we may need a kconf update script to migrate people to the new colors, since the colors in the current color scheme get cached in their config files. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D28317 To: ngraham, #vdg, #breeze

D29033: Remove duplicated code

zzag requested changes to this revision. zzag added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > waylandintegration.cpp:191 > [this] (PlasmaWindow *w) { > -emit KWindowSystem::self()->windowAdded(w->internalId()); > -

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 80760. ngraham added a comment. Rebase REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28317?vs=80759=80760 BRANCH tools-area-color-changes (branched from master) REVISION DETAIL https://phabricator.kde.org/D28317

D28317: Adjust default color scheme and titlebar appearance for Tools Area

ngraham updated this revision to Diff 80759. ngraham added a comment. Remove Breeze Light color scheme, per @ndavis's suggestion (I came to agree that it doesn't make sense to keep it around here; we can put it on GHNS along with "Breeze Classic" REPOSITORY R31 Breeze CHANGES SINCE LAST

D28141: Add KSysGuard::Sensors library

ahiemstra updated this revision to Diff 80758. ahiemstra added a comment. - clang-format sensors lib - Capture this rather than = REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28141?vs=79072=80758 BRANCH sensors_lib REVISION DETAIL

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

jgrulich added inline comments. INLINE COMMENTS > waylandintegration.cpp:310 > > -// HACK wait for stream to be ready > -QTimer::singleShot(3000, , ::quit); This has been removed, but I think it will still be needed. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop

D28000: [kde-cli-tools] Port QRegExp to QRegularExpression

ahmadsamir added a comment. Ping. REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D28000 To: ahmadsamir, #plasma, apol, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham,

D28135: Port away from deprecated QSet/QList methods in some places

ahmadsamir added a comment. Ping. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28135 To: ahmadsamir, #plasma, davidedmundson, apol Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen,

D29046: ColorUtils: Use const ref for QColor/QJSValue, fix code style

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY Use const ref for QColor and QJSValue values. Clean up code style, lots of missing

D28884: screencasting: Adoption of the org_kde_plasma_video_streaming protocol

jgrulich added a comment. With all code relevant to PipeWire removed, you can remove all needed CMake find modules in cmake subdir and you can also remove the ENABLE_PIPEWIRE option as it shouldn't be needed anymore (including all ifdefs). REPOSITORY R838 Flatpak Support: KDE Portal for

D28141: Add KSysGuard::Sensors library

ahiemstra added inline comments. INLINE COMMENTS > mart wrote in SensorsPlugin.cpp:2 > also here Same issue as above. > mart wrote in SensorsPlugin.h:2 > shouldn't remove existing copyrights? It's a new file, but for some reason Phab thinks it's copied from formatter.h (which it has nothing

D28873: Add SwipeNavigator component

niccolove added a comment. In D28873#652724 , @mart wrote: > for those that are a sidebar, there is already a standard, agreed upon look, that is being slowly and painfully moved to be adopted, which is: > F8249505:

D28141: Add KSysGuard::Sensors library

mart added inline comments. INLINE COMMENTS > Sensor.cpp:207 > + > +if(parent() && parent()->metaObject()->indexOfSignal("enabledChanged()") > != -1) { > +connect(parent(), SIGNAL(enabledChanged()), this, > SIGNAL(enabledChanged())); if ( > SensorDaemonInterface.cpp:87 > +

D28625: Use ShadowedRectangle for Card backgrounds

This revision was automatically updated to reflect the committed changes. Closed by commit R169:e770b0ddd2af: Use ShadowedRectangle for Card backgrounds (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28625?vs=80735=80736 REVISION

D28625: Use ShadowedRectangle for Card backgrounds

ahiemstra updated this revision to Diff 80735. ahiemstra added a comment. - Rebase on most recent master - Use ShadowedRectangleNode for ShadowedTexture if source is not set - Use transparent color for BannerImage's ShadowedImage - Hide BannerImage scrim if source or title is not set -

D28333: Add a new daemon for stats monitoring

ivan added inline comments. INLINE COMMENTS > client.cpp:65-66 > +m_connections.insertMulti(sensor, connect(sensor, > ::sensorInfoChanged, this, [this, sensor]() { > +auto newInfo = sensor->info(); > +m_pendingMetaDataChanges[sensor->path()] =

D28333: Add a new daemon for stats monitoring

ivan added inline comments. INLINE COMMENTS > main.cpp:45 > +m_property1->setMin(0); > +m_property1->setMin(100); > +m_property1->setShortName("Some Sensor 1"); `setMax`? > client.cpp:38 > +{ > +connect(m_daemon, ::sensorRemoved, this, [=](const > QString ) { > +

D28333: Add a new daemon for stats monitoring

mart added inline comments. INLINE COMMENTS > ksysguard_iface.xml:23 > + > + > + since this is array in/array out, could consistence of naming be improved? either sensorsIds/sensorsInfos or sensorIds/sensorInfos > ksysguarddaemon.cpp:58 > +auto timer = new QTimer(this); > +

D29040: Use colorful icon instead of monochrome icon for touchpad kcm

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Use icons from preferences folder instead of devices folder. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D28509: RFC: [libnotificationmanager] introduce the notification watcher

broulik added inline comments. INLINE COMMENTS > CMakeLists.txt:25 > + > +#notificationwatcher.cpp > +#watcher_p.cpp Remove > abstractnotificationsmodel.h:41 > public: > -~NotificationsModel() override; > - > -using Ptr = QSharedPointer; > -static Ptr

[plasmashell] [Bug 350365] Battery monitor in tray randomly shows there is no battery

https://bugs.kde.org/show_bug.cgi?id=350365 --- Comment #50 from Alexander Fieroch --- This but is fixed for me! It was not a bug in software - it was a bug in notebook firmware. To all others who still see this problem with no battery detected: do you have a lenovo notebook? maybe you have a

D28744: Rewrite of the global shortcuts kcm

davidre added a comment. In D28744#652925 , @ngraham wrote: > Here's how it looks with the old KCM: F8249724: Screenshot_20200420_125405.png > > So my KDE Daemon category has one entry in French for