[Differential] [Commented On] D3815: [Task Manager] Add "Places" for entries belonging to a file manager

2016-12-27 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Yes, that is certainly a downside. One idea could be to move it into a submenu if there are more than X entries (though I'm not sure yet which number to choose). The downside of that would be that people who often add and remove places might get confused by the

[Differential] [Commented On] D3815: [Task Manager] Add "Places" for entries belonging to a file manager

2016-12-26 Thread colomar (Thomas Pfeiffer)
colomar added a comment. To solve the problem of the context menu getting very long: How about putting the places in a submenu? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3815 EMAIL PREFERENCES

[Differential] [Commented On] D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

2016-12-22 Thread colomar (Thomas Pfeiffer)
colomar added a comment. We always have to keep in mind that usind multiple layouts is an advanced feature used by a minority of users. Therefore, as long as a feature only becomes active when there are multiple layouts (and in this case only when multiple layouts are used _and_ the login

[Differential] [Commented On] D3756: [Folder View] Add "Restore" from trash option

2016-12-20 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Yup, makes sense! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3756 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design, hein Cc: colomar, plasma-devel,

[Differential] [Commented On] D3738: [Task Manager] Tooltips redesign

2016-12-19 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Great improvements! Is the desktop / Activity only shown if - there are multiple ones and - the task manager shows tasks from different ones? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3738 EMAIL PREFERENCES

[Differential] [Commented On] D3616: [Lock Screen / Login] Add "reveal password button"

2016-12-10 Thread colomar (Thomas Pfeiffer)
colomar added a comment. +1 for the patch (I don't think the icon is close enough to the login button to be problematic) Also +1 for disabling "show password" buttons in general via Kiosk REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3616 EMAIL

[Differential] [Commented On] D3538: Drop resize animation when adding pages

2016-11-29 Thread colomar (Thomas Pfeiffer)
colomar added a comment. +1, definitely looks better to me (and Jens will love any killed animation, anyway ;) ) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D3538 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol,

[Differential] [Commented On] D3539: [Notifications] Show interactive thumbnails on notifications

2016-11-29 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Really nice! The single thumbnail might be a bit too large, as having large notification windows pop up could be irritating. Maybe half the size would be big enough? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3539 EMAIL

[Differential] [Commented On] D3210: make scrollbar size configurable

2016-11-15 Thread colomar (Thomas Pfeiffer)
colomar added a comment. I haven't had the chance to play with it and I think we should still have a plan B if we get negative feedback on it during beta tests, but the concept as it is described in the latest comments makes sense to me. REPOSITORY rBREEZE Breeze REVISION DETAIL

[Differential] [Commented On] D3210: make scrollbar size configurable

2016-11-10 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D3210#62062, @mart wrote: > > sorry for the late reply > ok, so if i understood correctly: > I'll remove those 2 options, and have instead both showing the scrollbar on hover *and* the scrollbar size depend

[Differential] [Commented On] D3210: make scrollbar size configurable

2016-11-07 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Whoa okay, that is complex... Given that I failed to understand what the proposed checkboxes were supposed to mean, I fear it will be the same for users. Therefore maybe not gibing the option at all is indeed the better solution, and your suggestion to turn the

[Differential] [Commented On] D3268: Applet: Show device icons and active port name

2016-11-07 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Great feature! I just fear that the naming scheme might make it look like the device name is the name for the port, like "A microphone called Audio Adapter". Maybe naming Port (device name) would make it more clear? REPOSITORY rPLASMAPA Plasma Audio Volume

[Differential] [Commented On] D3302: RFC: [Task Manager] Indicate applications playing audio

2016-11-07 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Very useful patch! The only thing I'm unsure of is the three-second delay. It might be a bit too long if some annoying applicaiton suddenly starts blaring sound and the option to mute it easily only becomes available after three seconds of torture. I think two

[Differential] [Commented On] D3210: make scrollbar size configurable

2016-11-07 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D3210#60963, @hpereiradacosta wrote: > >> Why do we need both? What happens if one checks the first but not the second? > > You get a large scrollbar, visible only on mouse-over So that means it would be

[Differential] [Commented On] D3210: make scrollbar size configurable

2016-11-06 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D3210#60602, @mart wrote: > in this latest version there are 2 checkboxes: "show scrollbar only on mouse over" and "small scrollbar" which both defautls to true Why do we need both? What happens if one checks the first

[Differential] [Commented On] D3210: make scrollbar size configurable

2016-11-03 Thread colomar (Thomas Pfeiffer)
colomar added a comment. If I understood it correctly (that there is only a checkbox "Only show full scrollbar on mouse over" added to the config) then that is exactly what I had in mind. REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3210 EMAIL PREFERENCES

[Differential] [Commented On] D3210: make scrollbar size configurable

2016-11-02 Thread colomar (Thomas Pfeiffer)
colomar added a comment. It does make sense to me to give the option to turn the slim scroll bar as such on and off. I can imagine some people being uncomfortable with the animation on mouseover. Being able to configure individual parameters is probably overkill, however. REPOSITORY

[Differential] [Commented On] D3156: WIP: Application Menu applet

2016-10-29 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Our users will be very happy about this being back! I agree that there needs to be some way to access it via keyboard. Pressing alt to shift keyboard focus to the menu bar sounds like a good idea, if pressing alt again shifts it back to the window content again.

[Differential] [Commented On] D2314: Context Menu to Mute, Set Default Sink/Source, Active Port

2016-10-29 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Sorry for not replying earlier. There is nothing that speaks against offering this context menu. However, all the actions in the context menu must be available in the main UI as well. Due to discoverability reasons, context menus must never be the only way to

[Differential] [Commented On] D3011: [SDDM Theme] Show caps lock warning

2016-10-10 Thread colomar (Thomas Pfeiffer)
colomar added a comment. +1 for the change! I think the string for failed unlock while capslock is on should be "Login failed (Caps lock is on)" though, as the "login failed" part is the more important one. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

[Differential] [Changed Subscribers] D2957: [SDDM Theme] Offer switching to the user's session if there is one

2016-10-06 Thread colomar (Thomas Pfeiffer)
colomar added a subscriber: graesslin. colomar added a comment. > Also it really needs to be a config option somewhere. People do multiple login. We made LightDM reuse sessions and got tonnes of comments. @graesslin said he'd prefer to block multiple login with the same user due to all

[Differential] [Commented On] D2957: [SDDM Theme] Offer switching to the user's session if there is one

2016-10-06 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Definitely a good change! Suggestion as for when to release: One way we could go about it is see whether we get bug reports about the current behavior. If users perceive it as a bug, we release this as a bugfix, otherwise it goes into 5.9. REPOSITORY

[Differential] [Commented On] D2944: [TabBox] Switch between windows with mouse wheel

2016-10-05 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Behavior sounds sensible, wrapping around would make sense, though. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2944 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Commented On] D2741: [Window Switcher] Cleanup

2016-09-13 Thread colomar (Thomas Pfeiffer)
colomar added a comment. I've just asked the other VDG members for their take on the font size. Since this is not a big issue either way, the patch is fine to go in anyway. If the VDG decides we'd like the font to be smaller, it would be nice if it could be changed in another patch.

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

2016-09-12 Thread colomar (Thomas Pfeiffer)
colomar added inline comments. INLINE COMMENTS > compositing.ui:291 > + This brings performance improvement for e.g. games. > + The setting can be overruled by window specific rules. > + window-specific REPOSITORY rKWIN KWin REVISION DETAIL https://phabricator.kde.org/D2584 EMAIL

[Differential] [Commented On] D2753: [Screen Locker KCM] Put Wallpaper in a separate tab

2016-09-12 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D2753#51248, @broulik wrote: > Because that's an idea Martin and I had a while ago iirc. And also I don't see how we could make this one scrolling page, since it's a QML thing with a ScrollView embedded in a widget environment.

[Differential] [Commented On] D2753: [Screen Locker KCM] Put Wallpaper in a separate tab

2016-09-12 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D2753#51234, @mart wrote: > as far i know the guidelines for new kcms are no tabs? Indeed the idea was to use a longer, scrolling page instead of tabs, combined with expanding sections for advanced settings. What made

[Differential] [Commented On] D2580: possible to use OverlaySheet with ListView

2016-09-12 Thread colomar (Thomas Pfeiffer)
colomar added a comment. There is always still the possibility to use one of the Action Buttons as a close button (as shown in the Gallery) if it gets too long to easily swipe away. REPOSITORY rKIRIGAMI Kirigami BRANCH phab/listviewsheet REVISION DETAIL

[Differential] [Commented On] D2580: possible to use OverlaySheet with ListView

2016-09-12 Thread colomar (Thomas Pfeiffer)
colomar added a comment. There is always still the possibility to use one of the Action Buttons as a close button (as shown in the Gallery) if it gets too long to easily swipe away. REPOSITORY rKIRIGAMI Kirigami BRANCH phab/listviewsheet REVISION DETAIL

[Differential] [Commented On] D2383: [Notifications] Add "Clear Notifications" context menu entry

2016-09-11 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D2383#50991, @andreaska wrote: > ordinary I had more often the problem that the notification stuff is empty but I'd like to know what happend in the past. > > most of the time I see no new notification but I'd like to see the

[Differential] [Commented On] D1771: [Workspace Options] Add option to disable OSD

2016-09-11 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D1771#50973, @broulik wrote: > Can we have something more concise than "Visual feedback (On-Screen Display) for status changes not triggered via a graphical user interface". Perhaps just "Visual feedback for status changes"?

[Differential] [Commented On] D2383: [Notifications] Add "Clear Notifications" context menu entry

2016-09-11 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Okay, let's stick with the context menu for now and see if we can find a good place in the popup at some point. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2383 EMAIL PREFERENCES

[Differential] [Commented On] D2741: [Window Switcher] Cleanup

2016-09-11 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Why is the font for the window titles so large? I don't really see much benefit from that... REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2741 EMAIL PREFERENCES

[Differential] [Commented On] D2610: Make icon follow styleHints

2016-08-30 Thread colomar (Thomas Pfeiffer)
colomar added a comment. > What you say does make sense, but I'd like to note that in KDE4 they did respect the single-/double-click settings (when on the desktop, not in the panel), so this can be seen as "regression" in Plasma5. I'd call it an improvement, actually, because now it

[Differential] [Commented On] D2610: Make icon follow styleHints

2016-08-30 Thread colomar (Thomas Pfeiffer)
colomar added a comment. The only raison d'ĂȘtre for "double-click to open" is to be able to select on single click. If selecting is not possible (as is the case both in the panel and in a desktop containment), there is no reason for opening only on double-click (other than consistency with

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

2016-08-26 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D2584#48381, @broulik wrote: > Plasma is the only major desktop environment that still supports a non-composited uscase. Unity and Gnome cannot disable it in the first place. Oh, so they just ignore that request from

[Differential] [Commented On] D2584: Introduce a config option whether applications are allowed to block compositing

2016-08-26 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Actually, I'm not really convinced of this. Blocking compositing is done via an official, cross-desktop API, isn't it? It's not a KWin-specific feature, right? If so, then KWin should not go alone in offering this config option. If I'm an application developer and

[Differential] [Updated] D2524: New User Switcher

2016-08-23 Thread colomar (Thomas Pfeiffer)
colomar added a project: VDG. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2524 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart Cc: mart, plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Commented On] D2523: New lockscreen

2016-08-23 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Please tag all diffs with UI changes with VDG to make sure we learn about them. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2523 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Updated] D2523: New lockscreen

2016-08-23 Thread colomar (Thomas Pfeiffer)
colomar added a project: VDG. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2523 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma, mart Cc: mart, plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Commented On] D2525: RFC: Make Switch User option invoke the switch user UI in the lockscreen

2016-08-22 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Big +1, yay for consistency! REPOSITORY rKSCREENLOCKER KScreenLocker REVISION DETAIL https://phabricator.kde.org/D2525 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: colomar, mart, graesslin,

[Differential] [Commented On] D2449: small utility to create L packages

2016-08-19 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D2449#46736, @mart wrote: > > it's instant save, some pieces couldn't be done differently at the moment Hm, I think that's a problem. 1. Instant apply is not a common pattern in KDE software at all and

[Differential] [Commented On] D2449: small utility to create L packages

2016-08-19 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Thanks! Feedback: - The lineedits should be made long enough to actually hold the whole content (for the comment, maybe a textbox would be better?), because editing in a field which is too small for the content is really annoying. - How does one save

[Differential] [Commented On] D2449: small utility to create L packages

2016-08-19 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Can you please provide screenshots of the tool? Yes, even developer-centric tools should get a UI review ;) REPOSITORY rPLASMASDK Plasma SDK REVISION DETAIL https://phabricator.kde.org/D2449 EMAIL PREFERENCES

[Differential] [Commented On] D2448: use dbus interface to switch shell l

2016-08-18 Thread colomar (Thomas Pfeiffer)
colomar added a comment. UI-wise, I'd do it differently. Currently, the description of what the checkbox affects and the checkbox itself are too far separated, plus it makes it sound like the layout is going to be changed even if the checkbox is not checked. Instead what I'd do is, below

[Differential] [Commented On] D2409: Update Color KCM

2016-08-11 Thread colomar (Thomas Pfeiffer)
colomar added a comment. The KCM looks okay for a first iteration, although for the future, it would make more sense to design it like the Look And Feel or Desktop Theme KCMs, with a grid of bigger previews instead of list + one big preview. What I'd change right now is Config Scheme ->

[Differential] [Commented On] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

2016-08-11 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Looks great now, thank you for digging into the focus stuff! REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2398 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Commented On] D2398: [Applet Configuration] Match category sidebar style with Breeze widget default style

2016-08-11 Thread colomar (Thomas Pfeiffer)
colomar added a comment. I'm glad that you're fixing this inconsistency! Just for clarification since it can't be seen from the screenshots: In System Settings, the full highlight color is only used on the sidebar when it is currently focused. When the main window area is focused

[Differential] [Commented On] D2383: [Notifications] Add "Clear Notifications" context menu entry

2016-08-09 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Shouldn't that button rather be in the popup itself? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2383 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Commented On] D2219: Add option to enable volume feedback

2016-07-28 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Is the feedback only played when there is no other source playing? If not, it should be done like that. If you already have something playing, it's just annoying to play an additional sound, and does not provide any additional info because you notice how loud

[Differential] [Commented On] D2212: Reduce Calendar size in Digital clock

2016-07-20 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D2212#41489, @drosca wrote: > > But it takes more than half of my screen !!! > > Yes, because gridUnit sizing is broken. Here is how it looks on my system with patched plasma-framework: > F189452: PDCLXFY.png

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

2016-07-19 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D2223#41238, @mart wrote: > if they would auto clear, but still stay for some minutes, i would be fine Even in some minutes, quite a few notifications can pile up in the queue if you do lots of operations. This would only

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

2016-07-19 Thread colomar (Thomas Pfeiffer)
colomar added a comment. @mart If you started a file transfer job at some point and now you neither have a progress indicator anymore, nor see an error message, what is supposed to have happened other than that it succeeded? Of all the file transfer job, the vast majority will complete

[Differential] [Commented On] D2223: [Notifications] Only keep job finished notification in case of an error

2016-07-19 Thread colomar (Thomas Pfeiffer)
colomar added a comment. +1 from me (of course, since it was my request ;) ) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2223 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Commented On] D2217: Add option to disable OSD on volume change

2016-07-19 Thread colomar (Thomas Pfeiffer)
colomar added a comment. How about we keep it as one option and only add more fine-grained controls of users demand it? If we want to do fine-grained options right away, it should be hidden behind an "Advanced" expander (see https://techbase.kde.org/Projects/Usability/HIG/Settings ),

[Differential] [Commented On] D2217: Add option to disable OSD on volume change

2016-07-19 Thread colomar (Thomas Pfeiffer)
colomar added a comment. I agree with Martin: Either people want to see an OSD when changing a parameter using the keyboard, or they don't. Like Martin, I don't see why someone would want an OSD when changing screen brightness with the keyboard, but not when changing volume. Would it

[Differential] [Commented On] D2204: [Service Runner] Search through "Comment" as well

2016-07-18 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Big +1, both showing and being able to search in the description is crucial especially for newer users who have not memorized the often entirely arbitrary application names. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

[Differential] [Commented On] D2173: WIP: New System Settings delegate design

2016-07-18 Thread colomar (Thomas Pfeiffer)
colomar added a comment. > There is one strange thing regarding the behaviour - the sub-item links. > > The first problem is that it is not obvious what is clickable and what is not - the only hint is a slight change in the background (at least with my colour scheme) on hover. Is

[Differential] [Commented On] D2110: Create a Colors page in the Gallery

2016-07-07 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Ok. Not spectacularly pretty, of course, but it does the job. Good to go from my side! REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2110 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol,

[Differential] [Commented On] D2110: Create a Colors page in the Gallery

2016-07-07 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Screenshot, please? REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2110 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: colomar, plasma-devel

[Differential] [Commented On] D2090: [Kickoff] Sort Favorites in-view

2016-07-04 Thread colomar (Thomas Pfeiffer)
colomar added a comment. +1, good improvement! I fear that many users won't discover it, but we need a more global solution for that problem anyway. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2090 EMAIL PREFERENCES

[Differential] [Commented On] D2019: [Task Manager] Add media controls in context menu

2016-06-27 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Hm ok, good point. How do we prevent duplicate play controls, then? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2019 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Commented On] D2019: [Task Manager] Add media controls in context menu

2016-06-27 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Ah damn you're right, Plasma once again does more than I know ;) Back to this review request, though: Shouldn't the application itself handle media controls as jump lists? Cantata, for example, already does just that. Would it then show playback controls twice

[Differential] [Commented On] D2019: [Task Manager] Add media controls in context menu

2016-06-27 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Nice addition! However, what I'd like even more to see (in addition) is having a tooltip with player controls also on a launcher. Would that be possible as well? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2019 EMAIL

[Differential] [Commented On] D1771: [Workspace Options] Add option to disable OSD

2016-06-22 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Martin is right, OSDs are not only about keyboard shortcuts. They are quite difficult to describe clearly without relying on technical terms, however. Maybe "Visual feedback (On-Screen Display) for status changes not triggered via a graphical user

[Differential] [Commented On] D1940: [Recent Documents Runner] Add drag and drop, "show in folder" action and subtext

2016-06-18 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D1940#35859, @broulik wrote: > If you drag it to an existing sticky note you'll paste the path to the file. I decided against pasting the file contents in this case back when I implemented this. This is in the notes applet and

[Differential] [Commented On] D1940: [Recent Documents Runner] Add drag and drop, "show in folder" action and subtext

2016-06-18 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Great change, +1 to all the features! Just a question: What does dragging to a sticky note do? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1940 EMAIL PREFERENCES

[Differential] [Commented On] D1901: [PolicyAgent] Ignore "Keep screen on" request while screen is locked

2016-06-15 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Makes sense! REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL https://phabricator.kde.org/D1901 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design Cc: colomar, plasma-devel, jensreuterberg,

[Differential] [Commented On] D1867: [Calendar Applet] Show day or week number in icon

2016-06-14 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Where did you take that icon from? We have apps/office-calendar and org.kde.plasma.calendar, both of which look quite different from this one. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1867 EMAIL PREFERENCES

[Differential] [Commented On] D1735: Notify about low peripheral batteries (mouse, keyboard)

2016-06-02 Thread colomar (Thomas Pfeiffer)
colomar added a comment. +1 from the usability side, the second wording iteration is indeed an improvement! REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL https://phabricator.kde.org/D1735 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Commented On] D1592: [Device Notifier] Add option to disable popup on new device

2016-05-11 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Ah sorry, I overlooked the bug you mentioned. Alright, go ahead, then! REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1592 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Commented On] D1592: [Device Notifier] Add option to disable popup on new device

2016-05-11 Thread colomar (Thomas Pfeiffer)
colomar added a comment. What's the reason for this feature? Have users complained about the popup? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1592 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D1591: [Shell Runner] Add "Run in Terminal" option

2016-05-11 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Yup, makes sense! REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1591 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma, Plasma: Design Cc: colomar, plasma-devel,

[Differential] [Commented On] D1366: Add Event Sounds stream to Applications list

2016-05-10 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Makes sense, and I agree that "notification sounds" is better. REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D1366 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma,

[Differential] [Commented On] D1504: [Service Runner] Search for Jump List Actions

2016-04-27 Thread colomar (Thomas Pfeiffer)
colomar added a comment. +1 from the usability side REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1504 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma, Plasma: Design Cc: colomar,

[Differential] [Commented On] D1478: [Notifications] Don't group job finished notifications

2016-04-25 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D1478#27450, @mck182 wrote: > So that users may leave long-taking jobs unattended and then click "Open folder" on the notification or something once they're back and/or the job is done. Ah, right, that makes sense. Not

[Differential] [Commented On] D1479: [Notifications] Limit notification size and scroll to the bottom if needed

2016-04-24 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Why can we not make it scroll? REVISION DETAIL https://phabricator.kde.org/D1479 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma, Plasma: Design, mck182 Cc: colomar, plasma-devel, sebas

[Differential] [Commented On] D1478: [Notifications] Don't group job finished notifications

2016-04-24 Thread colomar (Thomas Pfeiffer)
colomar added a comment. Why are those notification even persistent in the first place? If a user misses the notification, they should notice that the job was finished by the fact that it's not running anymore. Only errors should be persistent. REPOSITORY rPLASMAWORKSPACE Plasma

[Differential] [Commented On] D1452: Implement volume overdrive

2016-04-20 Thread colomar (Thomas Pfeiffer)
colomar added a comment. I know Pavucontrol does the same, but I think this makes it too easy to go into overdrive. There is a reason why "100%" is not the actual maximum volume you can get out of a device. I don't want us to be liable for either burst speakers or burst eardrums...

[Differential] [Commented On] D1443: Applet: Move Application streams with drag and drop

2016-04-18 Thread colomar (Thomas Pfeiffer)
colomar added a comment. All thumbs up from the usability side! REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D1443 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: drosca, Plasma, Plasma: Design Cc:

[Differential] [Commented On] D1366: Add Event Sounds stream to Applications list

2016-04-10 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D1366#25480, @drosca wrote: > F106811: event-sounds.png > > Looks like this (always first in the list). It will need different icon, ideas? Event sounds are usually notifications,

[Differential] [Commented On] D1350: [Digital Clock] Allow copying current date to clipboard

2016-04-07 Thread colomar (Thomas Pfeiffer)
colomar added a comment. I'd change the label to "Copy date/time to clipboard", otherwise it looks good! REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1350 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Closed] D1326: Fix search keywords pointing to the Desktop Effects KCM which should point to the Compositing KCM

2016-04-06 Thread colomar (Thomas Pfeiffer)
This revision was automatically updated to reflect the committed changes. Closed by commit rKWINd847ddf84189: Fix search keywords between Desktop Effects KCM and Compositing KCM (authored by colomar). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

[Differential] [Updated, 4 lines] D1326: Fix search keywords pointing to the Desktop Effects KCM which should point to the Compositing KCM

2016-04-06 Thread colomar (Thomas Pfeiffer)
colomar retitled this revision from "Fix search keyword "animation speed" pointing to the wrong KCM" to "Fix search keywords pointing to the Desktop Effects KCM which should point to the Compositing KCM". colomar updated the summary for this revision. colomar updated this revision to Diff 3163.

[Differential] [Commented On] D1326: Fix search keyword "animation speed" pointing to the wrong KCM

2016-04-05 Thread colomar (Thomas Pfeiffer)
colomar added a comment. In https://phabricator.kde.org/D1326#24768, @bshah wrote: > +1, but OpenGL,XRender,video settings keywords also should move away? Good point! And while we're at it, "compositing" as well. I'll do that tomorrow. REPOSITORY rKWIN KWin REVISION DETAIL

[Differential] [Request, 4 lines] D1326: Fix search keyword "animation speed" pointing to the wrong KCM

2016-04-05 Thread colomar (Thomas Pfeiffer)
colomar created this revision. colomar added a reviewer: Plasma. colomar set the repository for this revision to rKWIN KWin. colomar added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Searching for "animation speed" now points to the Compositing

[Differential] [Commented On] D1291: Add microphone volume OSD

2016-04-02 Thread colomar (Thomas Pfeiffer)
colomar added a comment. I've asked Andreas to create the needed icons, please wait for them to arrive. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1291 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: