Remove old /proc/acpi/events and /dev/cpu/microcode interfaces

2013-07-03 Thread Thomas Renninger
Please consider to apply for vanilla kernel submission. Thanks, Thomas -- To unsubscribe from this list: send the line unsubscribe platform-driver-x86 in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/3] ACPI: Remove old /proc/acpi/event interface

2013-07-03 Thread Thomas Renninger
: Rafael J. Wysocki r...@sisk.pl CC: Matthew Garrett matthew.garr...@nebula.com CC: Henrique de Moraes Holschuh h...@hmh.eng.br Signed-off-by: Thomas Renninger tr...@suse.de --- Documentation/laptops/asus-laptop.txt |8 +- Documentation/laptops/sony-laptop.txt |8 +- Documentation/power

[PATCH 3/3] platform thinkpad: Remove deprecated hotkey_report_mode parameter

2013-07-03 Thread Thomas Renninger
Moraes Holschuh h...@hmh.eng.br Signed-off-by: Thomas Renninger tr...@suse.de --- Documentation/laptops/thinkpad-acpi.txt | 73 +++ drivers/platform/x86/thinkpad_acpi.c| 29 2 files changed, 6 insertions(+), 96 deletions(-) diff --git a/Documentation

[PATCH 1/3] x86 microcode: Remove old MICROCODE_OLD_INTERFACE

2013-07-03 Thread Thomas Renninger
SLE11 nowadays makes use of the new interface without doing any modifications to the kernel in this area. That means the old interface is not needed at least since 3.0 or longer. Time to get rid of it. CC: Arjan van de Ven ar...@linux.intel.com CC: h...@zytor.com Signed-off-by: Thomas Renninger

Re: [PATCH v3 11/12] msi-wmi: Introduced quirk_last_pressed

2012-12-14 Thread Thomas Renninger
On Friday, December 14, 2012 11:37:00 AM joeyli wrote: ... Hi Thomas, do you have good suggestion if we filter out all events within 50ms? Puhh, I do not know the details anymore. I never had this machine, but worked on it remotely while someone else hit the key. Iirc this was a BIOS bug and

Re: [PATCH 2/4] toshiba_acpi: Support alternate hotkey interfaces

2011-12-18 Thread Thomas Renninger
On Saturday 17 December 2011 16:07:42 Seth Forshee wrote: On Sat, Dec 17, 2011 at 04:32:14AM -0700, Azael Avalos wrote: 2011/12/17 Thomas Renninger tr...@suse.de: On Thursday 15 December 2011 19:06:09 Seth Forshee wrote: ... +static bool toshiba_acpi_i8042_filter(unsigned char data

Re: [PATCH 2/4] toshiba_acpi: Support alternate hotkey interfaces

2011-12-17 Thread Thomas Renninger
On Thursday 15 December 2011 19:06:09 Seth Forshee wrote: ... +static bool toshiba_acpi_i8042_filter(unsigned char data, unsigned char str, + struct serio *port) +{ + if (str 0x20) + return false; + + if (unlikely(data == 0xe0)) +

Re: [PATCH 1/4] ACPI: EC: Add ec_get_handle()

2011-12-16 Thread Thomas Renninger
On Friday, December 16, 2011 01:33:33 AM Matthew Garrett wrote: On Fri, Dec 16, 2011 at 01:22:35AM +0100, Thomas Renninger wrote: I think best is to move the thinkpad implementation of getting ACPI handles based on HIDs to osl.c and make it global. I'll send patches. Please review them

Re: [PATCH 1/4] ACPI: EC: Add ec_get_handle()

2011-12-15 Thread Thomas Renninger
On Thursday 15 December 2011 19:06:08 Seth Forshee wrote: toshiba_acpi needs to execute an AML method within the EC namespace to make hotkeys work on some platforms. Provide an interface to allow it to easily get a handle to the EC namespace for this purpose. I first liked the idea of making

Re: [PATCH 1/4] ACPI: EC: Add ec_get_handle()

2011-12-15 Thread Thomas Renninger
On Friday 16 December 2011 01:33:33 Matthew Garrett wrote: On Fri, Dec 16, 2011 at 01:22:35AM +0100, Thomas Renninger wrote: I think best is to move the thinkpad implementation of getting ACPI handles based on HIDs to osl.c and make it global. I'll send patches. Please review them

Re: [PATCH] acer-wmi: schedule threeg and interface sysfs for feature removal

2011-05-30 Thread Thomas Renninger
On Monday, May 30, 2011 02:21:40 AM Lee, Chun-Yi wrote: we can now autodetect internal 3G device and already have the threeg rfkill device. So, we plan to remove threeg sysfs support for it's no longer necessary. We also plan to remove interface sysfs file that exposed which ACPI-WMI

Re: [PATCH V2] platform-driver-x86: ACPI EC Extra driver for Oaktrail

2011-01-10 Thread Thomas Renninger
... Is any hardware actually going to ship with this identifier, or will vendors change the string? I think vendors and OEMs will change this string. But we can add the DMI_BOARD_NAME, DMI_BOARD_VERSION, etc. back later, can we? I could imagine vendors will also build a higher level

Re: Bug#587014: screen brightness can't be modified on some Panasonic laptops

2011-01-03 Thread Thomas Renninger
On Wednesday 29 December 2010 16:24:28 Nicolas Limare wrote: I also received a message reportin for this bug on a Panasonic CF-52. Can I in any way help this bug get more attention? What is Bug#587014? Do you have a link? Panasonic is the only driver which will always try to use native

[PATCH] acpi ec_sys: Export fields of all regions from the EC to debugfs readable (v2)

2010-08-04 Thread Thomas Renninger
driver hacks. - Fix write_support file creation: mode and .write callback function, both must be set (or removed) appropriately. Signed-off-by: Thomas Renninger tr...@suse.de CC: mj...@srcf.ucam.org CC: platform-driver-x86@vger.kernel.org CC: linux-a...@vger.kernel.org CC: astarikovs...@suse.de CC

[PATCH] acpi ec_sys: Export fields of all regions from the EC to debugfs readable (v3)

2010-08-04 Thread Thomas Renninger
driver hacks. - Fix write_support file creation: mode and .write callback function, both must be set (or removed) appropriately. (v3) - Fix: ‘acpi_ec_open’ warning: control reaches end of non-void function compiler warning Signed-off-by: Thomas Renninger tr...@suse.de CC: mj

Re: [PATCH] acpi ec_sys: Be more cautious about ec write access

2010-07-31 Thread Thomas Renninger
On Friday 30 July 2010 06:37:17 pm Henrique de Moraes Holschuh wrote: On Thu, 29 Jul 2010, Thomas Renninger wrote: - Only allow root to read/write io file (sever bug!) I'd go further, and only allow CAP_SYS_RAWIO. I'll have a look and eventually come up with something on-top

Re: [PATCH] acpi ec_sys: Export fields of all regions from the EC to debugfs readable

2010-07-31 Thread Thomas Renninger
On Saturday 31 July 2010 01:30:53 am Andrew Morton wrote: On Fri, 30 Jul 2010 17:47:04 +0200 Thomas Renninger tr...@suse.de wrote: -static int acpi_ec_open_io(struct inode *i, struct file *f) +static int acpi_ec_open(struct inode *i, struct file *f) { f-private_data = i-i_private

[PATCH 3/3] hp-wmi: acpi_drivers.h is already included through acpi.h two lines below

2010-07-29 Thread Thomas Renninger
Signed-off-by: Thomas Renninger tr...@suse.de CC: linux-a...@vger.kernel.or CC: platform-driver-x86@vger.kernel.org CC: m...@redhat.com --- drivers/platform/x86/hp-wmi.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86

[PATCH 2/3] hp-wmi: Fix mixing up of and/or directive

2010-07-29 Thread Thomas Renninger
This should have been an and. Additionally checking for !obj is even better. Signed-off-by: Thomas Renninger tr...@suse.de CC: linux-a...@vger.kernel.or CC: platform-driver-x86@vger.kernel.org CC: m...@redhat.com --- drivers/platform/x86/hp-wmi.c |4 +++- 1 files changed, 3 insertions(+), 1

[PATCH 1/3] hp-wmi: Fix input buffer size of perform_query

2010-07-29 Thread Thomas Renninger
-by: Thomas Renninger tr...@suse.de CC: linux-a...@vger.kernel.or CC: platform-driver-x86@vger.kernel.org CC: m...@redhat.com --- drivers/platform/x86/hp-wmi.c | 40 +++- 1 files changed, 23 insertions(+), 17 deletions(-) diff --git a/drivers/platform/x86/hp-wmi.c b

[PATCH 2/2] acpi ec_sys: Be more cautious about ec write access

2010-07-29 Thread Thomas Renninger
- Set Kconfig option default n - Only allow root to read/write io file (sever bug!) - Introduce write support module param - default off - Properly clean up if any debugfs files cannot be created Signed-off-by: Thomas Renninger tr...@suse.de CC: mj...@srcf.ucam.org CC: platform-driver-x86

Re: [PATCH 2/2] acpi ec_sys: Be more cautious about ec write access

2010-07-29 Thread Thomas Renninger
On Thursday 29 July 2010 10:08:45 pm Thomas Renninger wrote: + + if (!write_support) + acpi_ec_io_ops.write = NULL; + if (!debugfs_create_file(io, 0600, dev_dir, ec, acpi_ec_io_ops)) Wait, this is wrong. I send an updated patch in a second... Thomas

[PATCH] acpi ec_sys: Be more cautious about ec write access

2010-07-29 Thread Thomas Renninger
- Set Kconfig option default n - Only allow root to read/write io file (sever bug!) - Introduce write support module param - default off - Properly clean up if any debugfs files cannot be created Signed-off-by: Thomas Renninger tr...@suse.de CC: mj...@srcf.ucam.org CC: platform-driver-x86

[PATCH 6/7] X86 platform driver: Fix section mismatch in wmi.c

2010-07-16 Thread Thomas Renninger
The .add function must not be declared __init. Signed-off-by: Thomas Renninger tr...@suse.de CC: Alexey Starikovskiy astarikovs...@suse.de CC: Len Brown l...@kernel.org CC: linux-ker...@vger.kernel.org CC: linux-a...@vger.kernel.org CC: platform-driver-x86@vger.kernel.org --- drivers/platform

[PATCH 2/7] ACPI: Provide /sys/kernel/debug//ec/ec0/io for binary access to the EC

2010-07-16 Thread Thomas Renninger
A userspace app to easily read/write the EC can be found here: ftp://ftp.suse.com/pub/people/trenn/sources/ec/ec_access.c Multiple ECs are not supported, but shouldn't be hard to add as soon as the ec driver itself will support them. Signed-off-by: Thomas Renninger tr...@suse.de CC: Alexey

[PATCH 4/7] ACPI: Remove /proc/acpi/embedded_controller/..

2010-07-16 Thread Thomas Renninger
Other patches in this series add the same info to /sys/... and /proc/ioports. The info removed should never have been used in an application, eventually someone read it manually. /proc/acpi is deprecated for more than a year anyway... Signed-off-by: Thomas Renninger tr...@suse.de CC: Alexey

Re: How to read time stamp from HPET timer from device driver?

2010-07-15 Thread Thomas Renninger
On Tuesday 13 July 2010 03:34:50 pm Samuel Xu wrote: Hi, Cascardo: Thanks for reply! I just want to get the guide on some sample code of HPET usage invoked from kernel mode driver. You must not use hpet directly to keep track of the time. There is HW which does not have an hpet, or the kernel

Re: [PATCH 5/6] X86 platform drivers: Remove EC dump from thinkpad_acpi

2010-07-02 Thread Thomas Renninger
On Thursday 01 July 2010 21:31:18 Thomas Renninger wrote: On Thursday 01 July 2010 06:27:41 pm Henrique de Moraes Holschuh wrote: On Thu, 01 Jul 2010, Thomas Renninger wrote: ... I'd prefer if the above text gets replaced by something that adds a pointer to the new facility, instead

[PATCH 4/6] ACPI: Remove /proc/acpi/embedded_controller/..

2010-07-01 Thread Thomas Renninger
Other patches in this series add the same info to /sys/... and /proc/ioports. The info removed should never have been used in an application, eventually someone read it manually. /proc/acpi is deprecated for more than a year anyway... Signed-off-by: Thomas Renninger tr...@suse.de CC: Alexey

[PATCH 5/6] X86 platform drivers: Remove EC dump from thinkpad_acpi

2010-07-01 Thread Thomas Renninger
There is a general interface for that now (provided by other patches in this patch series): /sys/devices/system/ec/*/io Signed-off-by: Thomas Renninger tr...@suse.de CC: Alexey Starikovskiy astarikovs...@suse.de CC: Len Brown l...@kernel.org CC: linux-ker...@vger.kernel.org CC: linux

[PATCH 3/6] ACPI: Register EC io ports in /proc/ioports

2010-07-01 Thread Thomas Renninger
: keyboard 0066-0066 : EC command 0070-0071 : rtc0 ... Signed-off-by: Thomas Renninger tr...@suse.de CC: Alexey Starikovskiy astarikovs...@suse.de CC: Len Brown l...@kernel.org CC: linux-ker...@vger.kernel.org CC: linux-a...@vger.kernel.org CC: Bjorn Helgaas bjorn.helg...@hp.com CC: platform-driver

Provide /sys/../ec with read/write access and some cleanups

2010-07-01 Thread Thomas Renninger
These patches are diffed against the test branch of the ACPI tree, but also patch fine with 2.6.35-rc3. I thought about tainting the kernel if someone writes to the EC, but as userspace can also write to graphics IO, PCI config or MSRs, it shouldn't matter that much. Eventually this should still

Re: [PATCH] wmi: fix a memory leak in wmi_notify_debug

2010-06-28 Thread Thomas Renninger
is loaded with debug_event=1). Signed-off-by: Thomas Renninger tr...@suse.de Thomas -- To unsubscribe from this list: send the line unsubscribe platform-driver-x86 in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 3/7] x86 platform drivers: hp-wmi Use consistent prefix string for messages.

2010-05-21 Thread Thomas Renninger
Signed-off-by: Thomas Renninger tr...@suse.de CC: m...@redhat.com CC: linux-a...@vger.kernel.org CC: platform-driver-x86@vger.kernel.org --- drivers/platform/x86/hp-wmi.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/hp-wmi.c b/drivers

Cleanup and update hp-wmi to match the latest API

2010-05-21 Thread Thomas Renninger
The first 6 patches are not that intrusive and it would be great to see them pushed soon. The last one needs discussing. Thanks, Thomas -- To unsubscribe from this list: send the line unsubscribe platform-driver-x86 in the body of a message to majord...@vger.kernel.org More majordomo

[PATCH 7/7] X86 platform: hp-wmi Better match the HP WMI query interface

2010-05-21 Thread Thomas Renninger
) - more Signed-off-by: Thomas Renninger tr...@suse.de CC: m...@redhat.com CC: linux-a...@vger.kernel.org CC: platform-driver-x86@vger.kernel.org --- drivers/platform/x86/hp-wmi.c | 135 - 1 files changed, 105 insertions(+), 30 deletions(-) diff --git a/drivers

Re: [PATCH 3/3] X86 platfrom wmi: Add debug facility to dump WMI data in a readable way

2010-05-05 Thread Thomas Renninger
On Tuesday 04 May 2010 07:40:09 pm Carlos Corbacho wrote: On Monday 03 May 2010 14:30:17 Thomas Renninger wrote: Signed-off-by: Thomas Renninger tr...@suse.de CC: platform-driver-x86@vger.kernel.org CC: mj...@srcf.ucam.org CC: corentin.ch...@gmail.com I don't really see the point

Re: [PATCH 1/3] X86 platform wmi: Introduce debug param to log all WMI events

2010-05-04 Thread Thomas Renninger
On Tuesday 04 May 2010 01:54:44 pm Corentin Chary wrote: On Mon, May 3, 2010 at 3:30 PM, Thomas Renninger tr...@suse.de wrote: To give people easily an idea what could be WMI driven on their system. ... CCing wmi.c maintainer. Oh dear, I mixed you up. Both starting with C.. C.. :) Corentin: Do

Re: [PATCH 1/2] X86 platform wmi: Introduce debug param to log all WMI events

2010-05-03 Thread Thomas Renninger
On Monday 03 May 2010 14:07:56 Corentin Chary wrote: On Mon, May 3, 2010 at 11:10 AM, Thomas Renninger tr...@suse.de wrote: To give people easily an idea what could be WMI driven on their system. Introduces: wmi.debug=[01] ... +MODULE_PARM_DESC(debug, +Debug facility

[PATCH 1/3] X86 platform wmi: Introduce debug param to log all WMI events

2010-05-03 Thread Thomas Renninger
unloaded again is untested, but should work. Signed-off-by: Thomas Renninger tr...@suse.de CC: platform-driver-x86@vger.kernel.org CC: mj...@srcf.ucam.org CC: corentin.ch...@gmail.com --- drivers/platform/x86/wmi.c | 58 +-- 1 files changed, 50 insertions

[PATCH 3/3] X86 platfrom wmi: Add debug facility to dump WMI data in a readable way

2010-05-03 Thread Thomas Renninger
Signed-off-by: Thomas Renninger tr...@suse.de CC: platform-driver-x86@vger.kernel.org CC: mj...@srcf.ucam.org CC: corentin.ch...@gmail.com --- drivers/platform/x86/wmi.c | 35 +++ 1 files changed, 35 insertions(+), 0 deletions(-) diff --git a/drivers/platform