Re: [ptxdist] [PATCH] libmodbus3: add patch for fixing alignment problem on arm

2013-03-28 Thread Alexander Dahl
Hei hei, Am 2013-03-27 18:57, schrieb Michael Olbrich: When does this issue happen anyways? I've never seen it. The problem is in one of the test programs, code was like this before: uint16_t *tab_rp_registers; /* load some data to this poiner */ *((uint32_t *)tab_rp_registers) =

Re: [ptxdist] [PATCH] libmodbus3: add patch for fixing alignment problem on arm

2013-03-28 Thread Michael Olbrich
Hi, On Thu, Mar 28, 2013 at 08:46:59AM +0100, Alexander Dahl wrote: Am 2013-03-27 18:57, schrieb Michael Olbrich: When does this issue happen anyways? I've never seen it. The problem is in one of the test programs, code was like this before: uint16_t *tab_rp_registers; /* load some

Re: [ptxdist] [PATCH] libmodbus3: add patch for fixing alignment problem on arm

2013-03-27 Thread Michael Olbrich
On Tue, Mar 26, 2013 at 10:04:30AM +0100, Alexander Dahl wrote: Am 2013-03-19 17:27, schrieb Michael Olbrich: LIBMODBUS3_MAKE_OPT := -C src LIBMODBUS3_INSTALL_OPT := -C src install My colleague removed 'tests' from Makefile.am, I don't know which one would be the best choice.

Re: [ptxdist] [PATCH] libmodbus3: add patch for fixing alignment problem on arm

2013-03-26 Thread Alexander Dahl
Hei hei, Am 2013-03-19 17:27, schrieb Michael Olbrich: LIBMODBUS3_MAKE_OPT:= -C src LIBMODBUS3_INSTALL_OPT := -C src install My colleague removed 'tests' from Makefile.am, I don't know which one would be the best choice. I prefer to avoid patches when possible. Meanwhile

Re: [ptxdist] [PATCH] libmodbus3: add patch for fixing alignment problem on arm

2013-03-19 Thread Michael Olbrich
On Thu, Mar 14, 2013 at 01:16:36PM +0100, Alexander Dahl wrote: We use -Wcast-align on ARMv5 platform and libmodbus3 sets -Werror which leads to a failing build in one case. This patch fixes the alignment problem. Upstream pull requested. Hmm, this is just unit test stuff, right? We don't

Re: [ptxdist] [PATCH] libmodbus3: add patch for fixing alignment problem on arm

2013-03-19 Thread Alexander Dahl
Hei Michael, Am 2013-03-19 16:32, schrieb Michael Olbrich: On Thu, Mar 14, 2013 at 01:16:36PM +0100, Alexander Dahl wrote: We use -Wcast-align on ARMv5 platform and libmodbus3 sets -Werror which leads to a failing build in one case. This patch fixes the alignment problem. Upstream pull

Re: [ptxdist] [PATCH] libmodbus3: add patch for fixing alignment problem on arm

2013-03-19 Thread Michael Olbrich
On Tue, Mar 19, 2013 at 04:55:37PM +0100, Alexander Dahl wrote: Hei Michael, Am 2013-03-19 16:32, schrieb Michael Olbrich: On Thu, Mar 14, 2013 at 01:16:36PM +0100, Alexander Dahl wrote: We use -Wcast-align on ARMv5 platform and libmodbus3 sets -Werror which leads to a failing build in