Re: [pulseaudio-discuss] [PATCH] module-jack-sink/source: Set fixed latency correctly on creation

2012-03-26 Thread David Henningsson
On 03/25/2012 12:59 PM, Maarten Lankhorst wrote: 250 ms default fixed latency won't work well for some applications like wine. Thanks for the patch. It seems reasonable to set the sink's latency to match jack's latency, but jack_port_get_total_latency is deprecated and therefore causes a

Re: [pulseaudio-discuss] Trying to update translations

2012-03-26 Thread David Henningsson
On 03/23/2012 05:02 PM, Rémi Denis-Courmont wrote: ...and this brokenness is the rule, not the exception. (And in the example above one can wonder why a translation was made in the first place.) In some cases these do not even fit their format strings. Btw, I have seen some crashes in

Re: [pulseaudio-discuss] [PATCH] module-jack-sink/source: Set fixed latency correctly on creation

2012-03-26 Thread Maarten Lankhorst
Hey David, Op 26-03-12 11:30, David Henningsson schreef: On 03/25/2012 12:59 PM, Maarten Lankhorst wrote: 250 ms default fixed latency won't work well for some applications like wine. Thanks for the patch. It seems reasonable to set the sink's latency to match jack's latency, but

[pulseaudio-discuss] [PATCH] sink: Prevent filter sink cycles

2012-03-26 Thread David Henningsson
While looking at bug 44397, https://bugs.freedesktop.org/show_bug.cgi?id=44397 Gnome's volume control somehow wanted to create a filter sink cycle. I'm attaching a patch to prevent this, which seems to have worked (at least there is no crash!), but before I push it: Is there any reason,

Re: [pulseaudio-discuss] [PATCH] module-jack-sink/source: Set fixed latency correctly on creation

2012-03-26 Thread David Henningsson
On 03/26/2012 11:54 AM, Maarten Lankhorst wrote: Hey David, Op 26-03-12 11:30, David Henningsson schreef: On 03/25/2012 12:59 PM, Maarten Lankhorst wrote: 250 ms default fixed latency won't work well for some applications like wine. Thanks for the patch. It seems reasonable to set the

[pulseaudio-discuss] [PATCH] alsa-mixer: Fix element channel masks array size.

2012-03-26 Thread Tanu Kaskinen
Valid channel id range is from 0 to SND_MIXER_SCHN_LAST, inclusive, so the array size has to be SND_MIXER_SCHN_LAST + 1. --- src/modules/alsa/alsa-mixer.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/modules/alsa/alsa-mixer.h b/src/modules/alsa/alsa-mixer.h index

Re: [pulseaudio-discuss] Release planning

2012-03-26 Thread Roman Beslik
So, how can I get a release candidate from Git? What URL should I probe? There is no branch named 2.0 or like. Sorry, I am not familiar with your terminology *happen off* the master branch. On 19.02.12 18:59, Arun Raghavan wrote: Hey folks, In order to make things a bit more regular, we've

Re: [pulseaudio-discuss] [PATCH] alsa-mixer: Fix element channel masks array size.

2012-03-26 Thread David Henningsson
On 03/26/2012 01:35 PM, Tanu Kaskinen wrote: Valid channel id range is from 0 to SND_MIXER_SCHN_LAST, inclusive, so the array size has to be SND_MIXER_SCHN_LAST + 1. This looks correct. A quick grep for SND_MIXER_SCHN_LAST shows similar arrays in alsa-sink and alsa-source, and also, that my

[pulseaudio-discuss] [PATCH] dbus: Add an assertion to get rid of a warning from Coverity.

2012-03-26 Thread Tanu Kaskinen
Coverity thinks that sample can be NULL when it's dereferenced after this line. Adding an assertion doesn't hurt here (in my opinion), and that should get rid of the warning. --- src/modules/dbus/iface-core.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [pulseaudio-discuss] [PATCH] alsa-mixer: Fix element channel masks array size.

2012-03-26 Thread Tanu Kaskinen
On Mon, 2012-03-26 at 13:44 +0200, David Henningsson wrote: On 03/26/2012 01:35 PM, Tanu Kaskinen wrote: Valid channel id range is from 0 to SND_MIXER_SCHN_LAST, inclusive, so the array size has to be SND_MIXER_SCHN_LAST + 1. This looks correct. A quick grep for SND_MIXER_SCHN_LAST shows

Re: [pulseaudio-discuss] Release planning

2012-03-26 Thread Arun Raghavan
On Mon, 2012-03-26 at 14:42 +0300, Roman Beslik wrote: So, how can I get a release candidate from Git? What URL should I probe? We've uploaded one RC already. Details at: http://lists.freedesktop.org/archives/pulseaudio-discuss/2012-March/012986.html There is no branch named 2.0 or like.

Re: [pulseaudio-discuss] Release planning

2012-03-26 Thread Tanu Kaskinen
On Mon, 2012-03-26 at 14:42 +0300, Roman Beslik wrote: So, how can I get a release candidate from Git? What URL should I probe? There is no branch named 2.0 or like. Sorry, I am not familiar with your terminology *happen off* the master branch. The phrase means that there won't be a separate

Re: [pulseaudio-discuss] Release planning

2012-03-26 Thread Colin Guthrie
'Twas brillig, and Tanu Kaskinen at 26/03/12 13:32 did gyre and gimble: On Mon, 2012-03-26 at 14:42 +0300, Roman Beslik wrote: So, how can I get a release candidate from Git? What URL should I probe? There is no branch named 2.0 or like. Sorry, I am not familiar with your terminology *happen

[pulseaudio-discuss] Missing channels on Terratec 6Fire USB

2012-03-26 Thread Robert M. Albrecht
Hi, I'm trying to install the Terratec 6Fire USB audio device. It's an external audio device with several analog in output channels. The alsa-driver is running and I can play analog stereo music or movies on pulseaudio based players. I can output digital sound (ac3 or dts) on spdif via

Re: [pulseaudio-discuss] GSoC Proposal: Configurable maximum volume for sinks and sources

2012-03-26 Thread Tanu Kaskinen
On Sun, 2012-03-25 at 16:45 +0200, Matěj Laitl wrote: Hi Tanu and pulseaudio-discuss, I'd like to participate as a student in GSoC 2012 working on PulseAudio. Among suggested ideas I've chosen Configurable maximum volume for sinks and sources, below is a very draft of my proposal.

[pulseaudio-discuss] [PATCH v2] module-jack-sink/source: Set fixed latency correctly on creation

2012-03-26 Thread Maarten Lankhorst
Changes since v1: Use max value of jack_port_get_latency_range to calculate the latency and squash compiler warnings cased by using jack_port_get_total_latency Modifying latency only works inside a callback, and for hardware the latency is generally fixed on jack, so just take the max value.

[pulseaudio-discuss] My attempt to reduce latency with pacat and tvtime

2012-03-26 Thread Steven Elliott
I use tvtime (an open source TV application) to watch TV on my Fedora 16 system. As some of you may know forwarding audio from the sound card built into the TV tuner card to the primary sound card is not done by tvtime. There are various ways of forwarding the audio including SoX,