sent a v4 of this
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
in directory storages, we don't need the 'import/' part of the volumes,
as that is implied in dir based storages
Signed-off-by: Dominik Csapak
---
www/manager6/Utils.js | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index
importable formats are currently ova/ovf/vmx
Signed-off-by: Dominik Csapak
---
www/manager6/storage/Browser.js | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/www/manager6/storage/Browser.js b/www/manager6/storage/Browser.js
index 934ce706..822257e7 100644
--- a/www
copies the OVF.pm and relevant ovf tests from qemu-server.
We need it here, and it uses PVE::Storage already, and since there is no
intermediary package/repository we could put it, it seems fitting in
here.
Put it in a new GuestImport module
Signed-off-by: Dominik Csapak
---
debian/control
but only for non esxi ones, since that does not allow
uploading/downloading there
Signed-off-by: Dominik Csapak
---
www/manager6/storage/Browser.js| 9 +++--
www/manager6/window/UploadToStorage.js | 1 +
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/www/manager6
and delete it here (incl tests; they live in pve-storage now).
Signed-off-by: Dominik Csapak
---
PVE/CLI/qm.pm | 4 +-
PVE/QemuServer/Makefile | 1 -
PVE/QemuServer/OVF.pm | 242 --
debian/control
but only when we detect the 'ova-needs-extraction' warning.
This can be used to select the storage where the disks contained in an
OVA will be extracted to temporarily.
Signed-off-by: Dominik Csapak
---
www/manager6/window/GuestImport.js | 23 +++
1 file changed, 23
use the standards info about the ostypes to map to our own
(see comment for link to the relevant part of the dmtf schema)
every type that is not listed we map to 'other', so no need to have it
in a list.
Signed-off-by: Dominik Csapak
---
src/PVE/GuestImport/OVF.pm | 69
and reuse the DirPlugin implementation
Signed-off-by: Dominik Csapak
---
src/PVE/Storage/BTRFSPlugin.pm | 5 +
src/PVE/Storage/CIFSPlugin.pm | 6 +-
src/PVE/Storage/CephFSPlugin.pm| 6 +-
src/PVE/Storage/GlusterfsPlugin.pm | 6 +-
src/PVE/Storage/NFSPlugin.pm
since 'virtual guests' only make sense for a hypervisor, not e.g. a
directory for OVAs
also change the icon from 'desktop' to 'cloud-download' in the
non-esxi case
Signed-off-by: Dominik Csapak
---
www/manager6/storage/Browser.js | 6 --
1 file changed, 4 insertions(+), 2 deletions
we only want to show that icon in the tree when the storage is solely
used for importing, not when it's just one of several content types.
Signed-off-by: Dominik Csapak
---
www/manager6/Utils.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/Utils.js b/www
Signed-off-by: Dominik Csapak
---
www/manager6/window/GuestImport.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/window/GuestImport.js
b/www/manager6/window/GuestImport.js
index 4bedc211..76ba6dc8 100644
--- a/www/manager6/window/GuestImport.js
+++ b/www/manager6/window
in the same branch as 'vztmpl' and 'iso'
Signed-off-by: Dominik Csapak
---
src/PVE/Storage.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Storage.pm b/src/PVE/Storage.pm
index 7c43701..8b9d21b 100755
--- a/src/PVE/Storage.pm
+++ b/src/PVE/Storage.pm
@@ -542,7
* typo fixes
* and probably more, see the individual patches for details
pve-storage:
Dominik Csapak (12):
copy OVF.pm from qemu-server
plugin: dir: implement import content type
plugin: dir: handle ova files for import
ovf: improve and simplify path checking code
ovf: implement parsing
()`)
As a fallback i used e1000, since that is our default too, and should
work for most guest operating systems.
Signed-off-by: Dominik Csapak
---
src/PVE/GuestImport/OVF.pm | 23 ++-
src/PVE/Storage/DirPlugin.pm | 2 +-
src/test/run_ovf_tests.pl| 5 +
3 files changed, 28
this is to override the target extraction storage for the option disk
extraction for 'import-from'. This way if the storage does not
supports the content type 'images', one can give an alternative one.
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu.pm | 46
or in an
error case).
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu.pm | 55 +++
PVE/QemuServer.pm | 12 +
PVE/QemuServer/Helpers.pm | 5
3 files changed, 61 insertions(+), 11 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2
, it should be no problem if we cannot parse it sometimes)
Signed-off-by: Dominik Csapak
---
src/PVE/API2/Storage/Status.pm | 1 +
src/PVE/GuestImport.pm | 77 ++
src/PVE/GuestImport/OVF.pm | 52 +---
src/PVE/Makefile
Signed-off-by: Dominik Csapak
---
www/manager6/Utils.js| 1 +
www/manager6/form/ContentTypeSelector.js | 2 +-
www/manager6/storage/CephFSEdit.js | 2 +-
www/manager6/storage/GlusterFsEdit.js| 2 +-
4 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/www
since there we already have the size information
Signed-off-by: Dominik Csapak
---
www/manager6/storage/Browser.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/storage/Browser.js b/www/manager6/storage/Browser.js
index 763abc70..c0b66acc 100644
--- a/www
the api part was never in use by anything
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu/Makefile | 2 +-
PVE/API2/Qemu/OVF.pm | 53 --
2 files changed, 1 insertion(+), 54 deletions(-)
delete mode 100644 PVE/API2/Qemu/OVF.pm
diff --git a/PVE/API2
introducing a separate regex that only contains ova, since
upload/downloading ovfs does not make sense (since the disks are then
missing).
Signed-off-by: Dominik Csapak
---
src/PVE/API2/Storage/Status.pm | 18 ++
src/PVE/Storage.pm | 11 +++
2 files changed
if the base image (parent) of an image contains whitespace in it's path
(e.g. a space), the current untainting would not match and it would seem
there was no parent.
Fix that by adapting the untaint regex
Signed-off-by: Dominik Csapak
---
src/PVE/Storage/Plugin.pm | 2 +-
1 file changed, 1
simply add all parsed disks to the boot order in the order we encounter
them (similar to the esxi plugin).
Signed-off-by: Dominik Csapak
---
src/PVE/GuestImport/OVF.pm | 6 +-
src/test/run_ovf_tests.pl | 3 +++
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/src/PVE
it seems there is no part of the ovf standard that handles which type of
bios there is (at least i could not find it). Every ovf/ova i tested
either has no info about it, or has it in a vmware specific property
which we parse here.
Signed-off-by: Dominik Csapak
---
src/PVE/GuestImport/OVF.pm
/raw/vmdk files.
ovf because it can be imported, and the rest because they can be used
in the 'import-from' part of qemu-server.
Signed-off-by: Dominik Csapak
---
src/PVE/GuestImport/OVF.pm | 5 -
src/PVE/Storage.pm | 8 +++
src/PVE/Storage/DirPlugin.pm
in this directory
by checking for '.' and '..' (slashes are not allowed in SAFE_CHAR_CLASS_RE)
Signed-off-by: Dominik Csapak
---
src/PVE/GuestImport/OVF.pm | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/src/PVE/GuestImport/OVF.pm b/src/PVE
On 5/23/24 14:25, Fabian Grünbichler wrote:
On May 23, 2024 12:40 pm, Dominik Csapak wrote:
On 5/22/24 12:08, Fabian Grünbichler wrote:
On April 29, 2024 1:21 pm, Dominik Csapak wrote:
[snip]
+ $target_volname = "$vmid/" . $target_diskname;
this encodes a fact about volname
On 5/22/24 12:08, Fabian Grünbichler wrote:
On April 29, 2024 1:21 pm, Dominik Csapak wrote:
since we want to handle ova files (which are only ovf+images bundled in
a tar file) for import, add code that handles that.
we introduce a valid volname for files contained in ovas like
On 5/17/24 10:31, Fiona Ebner wrote:
Reported in the community forum:
https://forum.proxmox.com/threads/145723/post-664612
Signed-off-by: Fiona Ebner
---
PVE/CLI/pve7to8.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/CLI/pve7to8.pm b/PVE/CLI/pve7to8.pm
index
one small nit inline:
On 5/10/24 13:47, Markus Frank wrote:
diff --git a/query-machine-capabilities/Makefile
b/query-machine-capabilities/Makefile
new file mode 100644
index 000..c5f6348
--- /dev/null
+++ b/query-machine-capabilities/Makefile
@@ -0,0 +1,21 @@
+DESTDIR=
+PREFIX=/usr
comments inline
On 5/10/24 13:47, Markus Frank wrote:
By adding a new input panel with an AMD SEV technology selection combo
box and checkboxes for the optional parameters in an advanced section,
the user can configure the amd_sev option via the WebUI's Options tab.
Signed-off-by: Markus Frank
comments inline:
On 5/10/24 13:47, Markus Frank wrote:
This patch is for enabling AMD SEV (Secure Encrypted Virtualization)
support in QEMU.
VM-Config-Examples:
amd_sev: type=std,no-debug=1,no-key-sharing=1
amd_sev: es,no-debug=1,kernel-hashes=1
kernel-hashes, reduced-phys-bios & cbitpos
all in all the series looks mostly good to me with some minor comments
(see comments on the individual patches)
i could not test it since i don't have an amd epyc system here ;)
one high level thing though (but no hard feelings)
is the systemd service really necessary ?
we could simply call
(de)reference operator
* removed unnecessary comment
* removed unnecessary context adds (inside the functions is enough context)
pve-esxi-import-tools:
Dominik Csapak (1):
improve error handling before mounting
src/esxi.rs | 7 ++-
src/main.rs | 15 +++
2 files changed, 17
This can help debug issues where we failed early and could not see any
error output otherwise, e.g. this thread in the forum:
https://forum.proxmox.com/threads/146248/
Signed-off-by: Dominik Csapak
---
src/esxi.rs | 7 ++-
src/main.rs | 15 +++
2 files changed, 17 insertions(+), 5
an erroneous return code.
Signed-off-by: Dominik Csapak
---
src/PVE/Storage/ESXiPlugin.pm | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm
index b8bce0e..4bcd7ff 100644
--- a/src/PVE/Storage/ESXiPlugin.pm
+++ b/src
On 5/8/24 16:43, Thomas Lamprecht wrote:
On 08/05/2024 14:41, Dominik Csapak wrote:
if the fuse tool encounters an error early, it prints it like:
Error: some error message
on stderr.
We can capture that here by redirecting STDERR to $wr and die'ing with
using just a variable name like
On 5/8/24 16:26, Thomas Lamprecht wrote:
On 08/05/2024 14:41, Dominik Csapak wrote:
when we fail early in the mount process, we did not log any error to the
syslog, but only the top most one to stderr.
sadly we were not able to see them anywhere, so improve the log by
* log the complete error
'MDev' could be interpreted as either 'Mediated Device' or 'Mapped
Device', which can confuse users.
At least one user was confused:
https://forum.proxmox.com/threads/146586/#post-662091
Fix that by writing out 'Mediated Device'.
Signed-off-by: Dominik Csapak
---
sending as RFC because
in main_do
This can help debug issues where we failed early and could not see any
error output otherwise, e.g. this thread in the forum:
https://forum.proxmox.com/threads/146248/
Signed-off-by: Dominik Csapak
---
src/main.rs | 36 +++-
1 file changed, 27 insertions
the user nothing and does not
help us debug.
Signed-off-by: Dominik Csapak
---
src/PVE/Storage/ESXiPlugin.pm | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Storage/ESXiPlugin.pm b/src/PVE/Storage/ESXiPlugin.pm
index b8bce0e..8dc33fc 100644
--- a/src/PVE/Storage
two smaller patches that improve which error gets shown to the user and
logged to syslog in case of an early error when trying to fuse mount
pve-esxi-import-tools:
Dominik Csapak (1):
improve error handling before mounting
src/main.rs | 36 +++-
1 file changed
On 4/30/24 11:13, Fiona Ebner wrote:
Am 30.04.24 um 10:38 schrieb Wolfgang Bumiller:
- technically users could add a disk with a "bad" parent to a storage
*manually*, but given the list_images mentioned above, I'd argue the
situation isn't really getting worse, as values that *do* match
since there we already have the size information
Signed-off-by: Dominik Csapak
---
www/manager6/storage/Browser.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/storage/Browser.js b/www/manager6/storage/Browser.js
index 763abc70..c0b66acc 100644
--- a/www
in directory storages, we don't need the 'import/' part of the volumes,
as that is implied in dir based storages
Signed-off-by: Dominik Csapak
---
www/manager6/Utils.js | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js
index
copies the OVF.pm and relevant ovf tests from qemu-server.
We need it here, and it uses PVE::Storage already, and since there is no
intermediary package/repository we could put it, it seems fitting in
here.
Put it in a new GuestImport module
Signed-off-by: Dominik Csapak
---
src/PVE
this is to override the target extraction storage for the option disk
extraction for 'import-from'. This way if the storage does not
supports the content type 'images', one can give an alternative one.
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu.pm | 56
or in an
error case).
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu.pm | 44 ++-
PVE/QemuServer.pm | 5 -
PVE/QemuServer/Helpers.pm | 10 +
3 files changed, 48 insertions(+), 11 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2
since 'virtual guests' only make sense for a hypervisor, not e.g. a
directory for OVAs
also change the icon from 'desktop' to 'cloud-download' in the
non-esxi case
Signed-off-by: Dominik Csapak
---
www/manager6/storage/Browser.js | 6 --
1 file changed, 4 insertions(+), 2 deletions
importable formats are currently ova/ovf/vmx
Signed-off-by: Dominik Csapak
---
www/manager6/storage/Browser.js | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/www/manager6/storage/Browser.js b/www/manager6/storage/Browser.js
index 934ce706..822257e7 100644
--- a/www
the api part was never in use by anything
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu/Makefile | 2 +-
PVE/API2/Qemu/OVF.pm | 53 --
2 files changed, 1 insertion(+), 54 deletions(-)
delete mode 100644 PVE/API2/Qemu/OVF.pm
diff --git a/PVE/API2
introducing a separate regex that only contains ova, since
upload/downloading ovfs does not make sense (since the disks are then
missing).
Signed-off-by: Dominik Csapak
---
src/PVE/API2/Storage/Status.pm | 18 ++
src/PVE/Storage.pm | 11 +++
2 files changed
it seems there is no part of the ovf standard that handles which type of
bios there is (at least i could not find it). Every ovf/ova i tested
either has no info about it, or has it in a vmware specific property
which we parse here.
Signed-off-by: Dominik Csapak
---
src/PVE/GuestImport/OVF.pm
, it should be no problem if we cannot parse it sometimes)
Signed-off-by: Dominik Csapak
---
src/PVE/API2/Storage/Status.pm | 1 +
src/PVE/GuestImport.pm | 100 +
src/PVE/GuestImport/OVF.pm | 53 ++---
src/PVE/Makefile | 1 +
src
) after extraction
* add new 'import-extraction-storage' for import
* rename panel in gui for directory storages
* typo fixes
* and probably more, see the individual patches for details
pve-storage:
Dominik Csapak (10):
copy OVF.pm from qemu-server
plugin: dir: implement import content type
and delete it here (incl tests; they live in pve-storage now).
Signed-off-by: Dominik Csapak
---
PVE/CLI/qm.pm | 4 +-
PVE/QemuServer/Makefile | 1 -
PVE/QemuServer/OVF.pm | 242 --
test/Makefile
but only when we detect the 'ova-needs-extraction' warning.
This can be used to select the storage where the disks contained in an
OVA will be extracted to temporarily.
Signed-off-by: Dominik Csapak
---
www/manager6/window/GuestImport.js | 23 +++
1 file changed, 23
Signed-off-by: Dominik Csapak
---
www/manager6/Utils.js| 1 +
www/manager6/form/ContentTypeSelector.js | 2 +-
www/manager6/storage/CephFSEdit.js | 2 +-
www/manager6/storage/GlusterFsEdit.js| 2 +-
4 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/www
Signed-off-by: Dominik Csapak
---
www/manager6/window/GuestImport.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/window/GuestImport.js
b/www/manager6/window/GuestImport.js
index 4bedc211..76ba6dc8 100644
--- a/www/manager6/window/GuestImport.js
+++ b/www/manager6/window
we only want to show that icon in the tree when the storage is solely
used for importing, not when it's just one of several content types.
Signed-off-by: Dominik Csapak
---
www/manager6/Utils.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/Utils.js b/www
but only for non esxi ones, since that does not allow
uploading/downloading there
Signed-off-by: Dominik Csapak
---
www/manager6/storage/Browser.js| 9 +++--
www/manager6/window/UploadToStorage.js | 1 +
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/www/manager6
in the same branch as 'vztmpl' and 'iso'
Signed-off-by: Dominik Csapak
---
src/PVE/Storage.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/Storage.pm b/src/PVE/Storage.pm
index 31b2ad5..fe29842 100755
--- a/src/PVE/Storage.pm
+++ b/src/PVE/Storage.pm
@@ -540,7
and reuse the DirPlugin implementation
Signed-off-by: Dominik Csapak
---
src/PVE/Storage/BTRFSPlugin.pm | 5 +
src/PVE/Storage/CIFSPlugin.pm | 6 +-
src/PVE/Storage/CephFSPlugin.pm| 6 +-
src/PVE/Storage/GlusterfsPlugin.pm | 6 +-
src/PVE/Storage/NFSPlugin.pm
()`)
As a fallback i used e1000, since that is our default too, and should
work for most guest operating systems.
Signed-off-by: Dominik Csapak
---
src/PVE/GuestImport/OVF.pm | 23 ++-
src/PVE/Storage/DirPlugin.pm | 2 +-
src/test/run_ovf_tests.pl| 5 +
3 files changed, 28
simply add all parsed disks to the boot order in the order we encounter
them (similar to the esxi plugin).
Signed-off-by: Dominik Csapak
---
src/PVE/GuestImport/OVF.pm | 6 +-
src/test/run_ovf_tests.pl | 3 +++
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/src/PVE
/raw/vmdk files.
ovf because it can be imported, and the rest because they can be used
in the 'import-from' part of qemu-server.
Signed-off-by: Dominik Csapak
---
src/PVE/GuestImport/OVF.pm | 3 +++
src/PVE/Storage.pm | 8 +++
src/PVE/Storage/DirPlugin.pm
use the standards info about the ostypes to map to our own
(see comment for link to the relevant part of the dmtf schema)
every type that is not listed we map to 'other', so no need to have it
in a list.
Signed-off-by: Dominik Csapak
---
src/PVE/GuestImport/OVF.pm | 69
this is wrong and does nothing, see previous commit:
0c54d61 (remove 'amd_iommu=on' from the passthrough docs)
and
https://www.kernel.org/doc/html/latest/admin-guide/kernel-parameters.html?highlight=amd_iommu
Signed-off-by: Dominik Csapak
---
qm-pci-passthrough.adoc | 3 +--
1 file changed, 1
the node of the pciselector
too, we need to check here if the field is disabled.
Signed-off-by: Dominik Csapak
---
www/manager6/window/PCIMapEdit.js | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/www/manager6/window/PCIMapEdit.js
b/www/manager6/window/PCIMapEdit.js
index
-off-by: Dominik Csapak
---
noticed that the 'zstd thread' field was strechted in the backup
advanced panel when using the german language...
www/manager6/container/TwoColumnContainer.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/container/TwoColumnContainer.js
of the radiofield was decided
only from 'isCreate' (via the 'checked' cbind), but should have been
decided by whether there was an encryption key or not.
both are fixed by setting the values in the 'setValue' method
explicitly
Signed-off-by: Dominik Csapak
---
www/manager6/storage/PBSEdit.js | 6
this belongs after the ':' otherwise the output looks weird:
[..] can be
: * integrated into [..]
* needs to be [..]
Signed-off-by: Dominik Csapak
---
proxmox-auto-install-assistant/src/main.rs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/proxmox-auto-install
that the 'bind' here only gets triggered once the panel is
rendered, but we actually need it before that.
To work around the issue for now, manually enable/disable the field when
toggling the fleecing checkbox. (Though this warrants a bit of deeper
investigation into this bind behavior)
Signed-off-by: Dominik
we have to 'printPropertyString' the fleecing parameters, otherwise
we'll get api parameter errors for that
Signed-off-by: Dominik Csapak
---
www/manager6/dc/Backup.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index
this is not a valid
value anyway, skip that.
Signed-off-by: Dominik Csapak
---
www/manager6/dc/Backup.js | 1 +
www/manager6/form/BandwidthSelector.js | 2 +-
www/manager6/panel/BackupAdvancedOptions.js | 1 +
3 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/www/manager6/dc
On 4/22/24 15:21, Thomas Lamprecht wrote:
Am 22/04/2024 um 15:18 schrieb Dominik Csapak:
On 4/22/24 15:13, Fiona Ebner wrote:
Why not the more accurate 'qm_machine_type' (was introduced in pve-docs =
8.1.0)?
you're right, would be even better (did not realize that existed), i/you can
send
On 4/22/24 15:13, Fiona Ebner wrote:
Am 15.04.24 um 10:50 schrieb Markus Frank:
---
www/manager6/qemu/MachineEdit.js | 1 +
1 file changed, 1 insertion(+)
diff --git a/www/manager6/qemu/MachineEdit.js b/www/manager6/qemu/MachineEdit.js
index 48c72c1d..ee2b2dac 100644
---
On 4/22/24 15:11, Fiona Ebner wrote:
Am 15.04.24 um 10:50 schrieb Markus Frank:
Added a proxmoxKVComboBox for selecting a vIOMMU implementation for a VM.
If i440fx is selected, another ComboBox will be enabled/visible that does not
have the Intel option, as Intel-vIOMMU is not compatible with
applied both patches, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
applied both patches, thanks!
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
On 4/22/24 13:34, Fiona Ebner wrote:
Am 22.04.24 um 13:09 schrieb Dominik Csapak:
On 4/22/24 13:00, Fiona Ebner wrote:
Am 19.04.24 um 11:45 schrieb Dominik Csapak:
diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
index 22a9729..39a8354 100644
--- a/src/PVE/Storage/Plugin.pm
On 4/22/24 13:00, Fiona Ebner wrote:
Am 19.04.24 um 11:45 schrieb Dominik Csapak:
diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
index 22a9729..39a8354 100644
--- a/src/PVE/Storage/Plugin.pm
+++ b/src/PVE/Storage/Plugin.pm
@@ -654,6 +654,10 @@ sub parse_volname
a few comments inline
On 4/8/24 12:33, Markus Frank wrote:
For SPICE and VNC, a different message is displayed.
The backend code for the clipboard option can be found in the
'config: enable vnc clipboard parameter in vga_fmt'-commit in qemu-server.
Signed-off-by: Markus Frank
---
one minor nit inline, otherwise
Reviewed-by: Dominik Csapak
Tested-by: Dominik Csapak
On 4/8/24 12:33, Markus Frank wrote:
Signed-off-by: Markus Frank
---
www/manager6/qemu/DisplayEdit.js | 57 ++--
1 file changed, 33 insertions(+), 24 deletions(-)
diff --git
where we generally want to show a field on the left, but a description
on the right.
merges the column1/2/B into just items.
Signed-off-by: Dominik Csapak
---
changes from v1:
* adapt to changes in 1/2
better viewed with -w, since most of the patch is just adding a level of
indent
www
this is a container, showing a widget on the left column and another one
on the right one, with a (default) flex ratio of 1:2
this is helpful when wanting fields to align vertically in an input
panel that have different height (e.g. because of text wrapping)
Signed-off-by: Dominik Csapak
this is a field container, showing a field on the left column and a
description on the right one, with a (default) flex ratio of 1:2
this is helpful when wanting a longer description on the right column
but still have the fields aligned.
Signed-off-by: Dominik Csapak
---
alternatively, we could
where we generally want to show a field on the left, but a description
on the right.
merges the column1/2/B into just items.
Signed-off-by: Dominik Csapak
---
www/manager6/panel/BackupAdvancedOptions.js | 45 ++---
1 file changed, 13 insertions(+), 32 deletions(-)
diff --git
Signed-off-by: Dominik Csapak
---
qm.adoc | 6 ++
1 file changed, 6 insertions(+)
diff --git a/qm.adoc b/qm.adoc
index 3f4e59a..3ab5270 100644
--- a/qm.adoc
+++ b/qm.adoc
@@ -1814,6 +1814,12 @@ Currently there are the following options:
the mapping, the mediated device will be create
call simpler
* return better structured values
Signed-off-by: Dominik Csapak
---
PVE/API2/Qemu.pm | 39 ++-
1 file changed, 22 insertions(+), 17 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index f95d8d95..94aa9942 100644
--- a/PVE/API2
properties.
Signed-off-by: Dominik Csapak
---
changes from v2:
* now correctly check the mdev property
expected is from 'device' and configured one is from the record
PVE/API2/Cluster/Mapping/PCI.pm | 2 +-
www/manager6/dc/PCIMapView.js | 6 ++
2 files changed, 7 insertions(+), 1 deletion(-)
diff
and set it on all current users
Signed-off-by: Dominik Csapak
---
PVE/CLI/qm.pm | 2 +-
PVE/QemuServer.pm | 13 -
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm
index b105830f..fbc590f5 100755
--- a/PVE/CLI/qm.pm
+++ b/PVE/CLI/qm.pm
those should be able to migrate even for online vms. If the mapping does
not exist on the target node, that will be caught further down anyway.
Signed-off-by: Dominik Csapak
---
PVE/API2/Nodes.pm | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/PVE/API2
tpmstate0 is already included in `get_vm_volumes`, and our only storage
plugin that has unmap_volume implemented is the RBDPlugin, where we call
unmap in `deactivate_volume`. So it's already ummapped by the
`deactivate_volumes` calls above.
Signed-off-by: Dominik Csapak
---
PVE/QemuServer.pm
by giving the mapping config to assert_valid, not only the specific mapping
Signed-off-by: Dominik Csapak
---
PVE/QemuServer/PCI.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/QemuServer/PCI.pm b/PVE/QemuServer/PCI.pm
index 7ff9cad7..6ba43ee8 100644
--- a/PVE
they only have one user each (where we can inline the implementation).
It's easy enough to recreate should we need to.
Signed-off-by: Dominik Csapak
---
src/PVE/Mapping/PCI.pm | 10 --
src/PVE/Mapping/USB.pm | 9 -
2 files changed, 19 deletions(-)
diff --git a/src/PVE/Mapping
but that lives int he 'global' part of the mapping config, not in a
specific mapping. To check that, add it to the $configured_props from
there.
this requires all call sites to be adapted otherwise the check will
always fail for devices that are capable of mediated devices
Signed-off-by: Dominik
if the hardware/driver is capable, the admin can now mark a pci device
as 'live-migration-capable', which then tries enabling live migration
for such devices.
mark it as experimental when configuring and in the migrate window
Signed-off-by: Dominik Csapak
---
www/manager6/window/Migrate.js
so that we can decide in qemu-server to allow live-migration.
The driver and QEMU must be capable of that, and it's the
admin's responsibility to know and configure that
Mark the option as experimental in the description.
Signed-off-by: Dominik Csapak
---
src/PVE/Mapping/PCI.pm | 8
1
1 - 100 of 1981 matches
Mail list logo
