Ah, sorry, only just noticed that there is a v10 already. But maybe my
comments still apply there.
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Am 26.04.24 um 11:58 schrieb Markus Frank:
> This patch is for enabling AMD SEV (Secure Encrypted Virtualization)
> support in QEMU.
>
> VM-Config-Examples:
> amd_sev: type=std,no-debug=1,no-key-sharing=1
> amd_sev: es,no-debug=1,kernel-hashes=1
>
> kernel-hashes, reduced-phys-bios & cbitpos
Am 17.05.24 um 13:39 schrieb Fiona Ebner:
> Same rationale as with upstream QEMU commit 5aaac46793 ("migration:
> savevm: consult migration blockers"), migration and (async) snapshot
> are essentially the same operation and thus snapshot also needs to
> check for migration
Am 26.04.24 um 11:58 schrieb Markus Frank:
> Implement a systemd service that runs a C program that extracts AMD
> SEV hardware information such as reduced-phys-bios and cbitpos from
> CPUID at boot time, looks if SEV, SEV-ES & SEV-SNP are enabled, and
> outputs these details as JSON to
per that filters blockers with the
prefix used by the VMDK migration blocker.
The function qemu_savevm_state_blocked() is called as part of
migration_is_blocked_allow_prefix() so no check is lost with this
patch.
Signed-off-by: Fiona Ebner
---
An alternative would be to mark the VMDK blocker as a
&quo
tc.") which is present since
tag 20190717.
[0]: https://forum.proxmox.com/threads/135758/post-664862
[1]: https://packages.debian.org/bookworm/all/firmware-ath9k-htc/filelist
Signed-off-by: Fiona Ebner
---
debian/control | 2 ++
1 file changed, 2 insertions(+)
diff --git a/debian/control
...@mail.gmail.com/T/#u
[1]:
https://lore.kernel.org/qemu-devel/20240517075336.104091-1-f.eb...@proxmox.com/T/#u
Signed-off-by: Fiona Ebner
---
.../0006-virtio-gpu-fix-v2-migration.patch| 98 +++
...0007-hw-pflash-fix-block-write-start.patch | 59 +++
...operand-size-for-DATA16
Reported in the community forum:
https://forum.proxmox.com/threads/145723/post-664612
Signed-off-by: Fiona Ebner
---
PVE/CLI/pve7to8.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/CLI/pve7to8.pm b/PVE/CLI/pve7to8.pm
index b34c8362..8443f1fb 100644
--- a/PVE/CLI
instead.
Signed-off-by: Fiona Ebner
---
PVE/QemuServer.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 9032d294..5df0c96d 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -6406,7 +6406,8 @@ sub vm_suspend
Am 14.05.24 um 15:03 schrieb Fiona Ebner:
> That said, looking into this and wondering why QEMU doesn't check it,
> there's an issue in that our savevm-async code does not properly check
> for all migration blockers (only some of them)! I'll work out a patch
> for that.
Well...yo
Am 12.04.24 um 11:32 schrieb Fabian Grünbichler:
> On March 19, 2024 4:08 pm, Hannes Duerr wrote:
>> When a snapshot is created with RAM, qemu attempts to save not only the
>> RAM content, but also the internal state of the PCI devices.
>>
>> However, as not all drivers support this, this can lead
threads/101810/
https://forum.proxmox.com/threads/101560/
https://forum.proxmox.com/threads/79572/post-352377
Fixes: 5582b0c ("vzdump: rsync: make less verbose")
Signed-off-by: Fiona Ebner
---
src/PVE/VZDump/LXC.pm | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff -
Am 03.05.24 um 19:36 schrieb Thomas Lamprecht:
> On 03/05/2024 14:01, Fiona Ebner wrote:
>> Since commit 865ef132 ("implement dynamic migration_downtime") the
>> migration downtime will be automatically increased when migration
>> cannot converge at the very end. Up
Since commit 865ef132 ("implement dynamic migration_downtime") the
migration downtime will be automatically increased when migration
cannot converge at the very end. Update the description to reflect
reality.
Signed-off-by: Fiona Ebner
---
PVE/QemuServer.pm | 5 -
1 file
The default timeout for HMP commands is 5 seconds and while it should
be rather fast to attach a new drive to QEMU, a system can be very
busy during backup, so future-proof and increase to 60 seconds.
Signed-off-by: Fiona Ebner
---
PVE/VZDump/QemuServer.pm | 4 ++--
1 file changed, 2 insertions
Signed-off-by: Fiona Ebner
---
www/manager6/qemu/HardwareView.js | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/www/manager6/qemu/HardwareView.js
b/www/manager6/qemu/HardwareView.js
index 6dcba071..e1902695 100644
--- a/www/manager6/qemu/HardwareView.js
+++ b/www/man
of 5 seconds is already used.
Signed-off-by: Fiona Ebner
---
www/manager6/qemu/HardwareView.js | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/www/manager6/qemu/HardwareView.js
b/www/manager6/qemu/HardwareView.js
index 672a7e1a..6dcba071 100644
--- a/www/manager6
The default timeout is 5 seconds, but some HMP commands (e.g.
disk-related ones) might take longer than that. It's still an
interactive session, so use 30 seconds for now. Should there be any
user-complains about frequent timeouts, it could still be increased
further.
Signed-off-by: Fiona Ebner
timeout that's used for
drive-related QMP commands.
Signed-off-by: Fiona Ebner
---
PVE/QemuServer.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 82e7d6a6..ba3d9f26 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
The default timeout is 5 seconds, but some HMP commands (e.g.
disk-related ones) might take longer than that. The API call is
synchronous, so has to complete within 30 seconds, and since there is
no other costly operation, use 25 seconds.
Signed-off-by: Fiona Ebner
---
PVE/API2/Qemu.pm | 2
ted to use the asynchronous API call when
hot-unplugging a drive, to be more in-line with the backend.
qemu-server:
Fiona Ebner (5):
monitor: allow passing timeout for a HMP command
api: human monitor: increase timeout to 25 seconds
vzdump: increase timeout for attaching drives to 60 seconds
cli: qm
-by: Fiona Ebner
---
PVE/QemuServer/Monitor.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/PVE/QemuServer/Monitor.pm b/PVE/QemuServer/Monitor.pm
index a7567518..937006ae 100644
--- a/PVE/QemuServer/Monitor.pm
+++ b/PVE/QemuServer/Monitor.pm
@@ -50,11 +50,11 @@ sub
0/post-431660
https://forum.proxmox.com/threads/111831/post-482425
https://forum.proxmox.com/threads/111831/post-499807
https://forum.proxmox.com/threads/137849/
Signed-off-by: Fiona Ebner
---
PVE/QemuMigrate.pm| 9 ++
PVE/QemuServer.pm
There's functions from all of those being used, but without importing
first.
Signed-off-by: Fiona Ebner
---
PVE/QemuMigrate.pm | 3 +++
1 file changed, 3 insertions(+)
diff --git a/PVE/QemuMigrate.pm b/PVE/QemuMigrate.pm
index 649cfec4..312ddaf8 100644
--- a/PVE/QemuMigrate.pm
+++ b/PVE
This makes it clear(er) that fleecing can be configured as a node-wide
default too.
Signed-off-by: Fiona Ebner
---
configs/vzdump.conf | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/vzdump.conf b/configs/vzdump.conf
index 33893e69..9aec4aea 100644
--- a/configs/vzdump.conf
+++ b
on created by Proxmox VE is not ordered before the one
generated by netplan and thus not applied by systemd-networkd.
Reported in the community forum:
https://forum.proxmox.com/threads/145848/post-658058
Fixes: 02d9462 ("setup: enable systemd-networkd via preset for ubuntu 23.04+")
Signed
Minimally tested, that an upgrade from an existing 23.04 container
works, there still is network and no obviously bad messages in the
container's journal.
Reported in the community forum:
https://forum.proxmox.com/threads/145848/
Signed-off-by: Fiona Ebner
---
No changes in v2.
src/PVE/LXC
Am 30.04.24 um 10:59 schrieb Thomas Lamprecht:
> On 30/04/2024 10:43, Fiona Ebner wrote:
>> So this is not new (already present for Ubuntu 23.10) and stems from the
>> fact that these images from linuxcontainers.org contain:
>>
>>> root@CT113:~# cat /etc/ne
Am 30.04.24 um 10:38 schrieb Wolfgang Bumiller:
> On Tue, Apr 30, 2024 at 10:14:13AM +0200, Fiona Ebner wrote:
>>
>> So the returned $parent will now just be undef if it contains
>> whitespaces, even though there is a parent. Can't that cause issues
>> further
Am 29.04.24 um 13:11 schrieb Thomas Lamprecht:
> Am 29/04/2024 um 11:56 schrieb Fiona Ebner:
>> Am 29.04.24 um 11:36 schrieb Fiona Ebner:
>>> Am 29.04.24 um 11:23 schrieb Fiona Ebner:
>>>> Reported in the community forum:
>>>> https://forum.proxmox.com/th
Hi,
Am 24.04.24 um 22:44 schrieb Ben Dailey:
> I would like to keep extracted backups on an NFS server backed with ZFS and
> retain the benefits of differential snapshots and it would be helpful to
> have the vma extract replace the previous backups directly.
why not just remove the previously
Am 30.04.24 um 09:53 schrieb Wolfgang Bumiller:
> This prevents importing from vmdks with whitespaces in file names.
> Further, some operations that include file sizes (like listing disks)
> would potentially fail entirely if a custom disk with a badly name
> backing device exists in a VM images
-write operations.
Reported-by: Friedrich Weber
Signed-off-by: Fiona Ebner
---
Changes in v3:
* rebase on master
Upstream submission of this patch:
https://lore.kernel.org/qemu-devel/20240429141934.442154-1-f.eb...@proxmox.com/T/#u
...e-write-use-uint64_t-for-timeout-in-.patch | 35
of why the backup failed, so bubble up the
original snapshot error instead.
Reported-by: Friedrich Weber
Signed-off-by: Fiona Ebner
---
Changes in v3:
* rebase on master
...ve-error-when-copy-before-write-fail.patch | 117 ++
debian/patches/series
Reported in the community forum:
https://forum.proxmox.com/threads/145955/post-658380
Signed-off-by: Fiona Ebner
---
vzdump.adoc | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/vzdump.adoc b/vzdump.adoc
index 79d4bbc..9b1cb61 100644
--- a/vzdump.adoc
+++ b/vzdump.adoc
-write operations.
Reported-by: Friedrich Weber
Signed-off-by: Fiona Ebner
---
New in v2.
Upstream submission of this patch:
https://lore.kernel.org/qemu-devel/20240429141934.442154-1-f.eb...@proxmox.com/T/#u
...e-write-use-uint64_t-for-timeout-in-.patch | 35 +++
...ock-copy
of why the backup failed, so bubble up the
original snapshot error instead.
Reported-by: Friedrich Weber
Signed-off-by: Fiona Ebner
---
No changes in v2, but sent as a patch for the parent git module.
...ve-error-when-copy-before-write-fail.patch | 117 ++
debian/patches
Am 29.04.24 um 14:53 schrieb Fiona Ebner:
> With fleecing, failure for copy-before-write does not fail the guest
> write, but only sets the snapshot error that is associated to the
> copy-before-write filter, making further requests to the snapshot
> access fail with EACCES, which the
of why the backup failed, so bubble up the
original snapshot error instead.
Reported-by: Friedrich Weber
Signed-off-by: Fiona Ebner
Tested-by: Friedrich Weber
---
Should have a "fixes #5409:" prefix when applied in the parent git
module. Please consider applying this after the upda
Am 29.04.24 um 11:36 schrieb Fiona Ebner:
> Am 29.04.24 um 11:23 schrieb Fiona Ebner:
>> Reported in the community forum:
>> https://forum.proxmox.com/threads/145848/#post-658694
>>
>> Signed-off-by: Fiona Ebner
>> ---
>>
>> Minimally tested, tha
Am 29.04.24 um 11:23 schrieb Fiona Ebner:
> Reported in the community forum:
> https://forum.proxmox.com/threads/145848/#post-658694
>
> Signed-off-by: Fiona Ebner
> ---
>
> Minimally tested, that an upgrade from an existing 23.04 container
> works, there still is netw
Reported in the community forum:
https://forum.proxmox.com/threads/145848/#post-658694
Signed-off-by: Fiona Ebner
---
Minimally tested, that an upgrade from an existing 23.04 container
works, there still is network and no obviously bad messages in the
container's journal.
src/PVE/LXC/Setup
listing
a file name and removing that line would break the script. Be more
precise and require an alphanumeric character before the suffix.
Signed-off-by: Fiona Ebner
---
Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index c05c641..a719e43 100644
the calls to acquire and
release the lock. See the patch for details.
Did not see any outstanding important fixes on the qemu-stable mailing
list currently, so none picked up.
[0]: https://lists.proxmox.com/pipermail/pve-devel/2024-March/062422.html
Fiona Ebner (4):
makefile: adapt firmware blob
Same rationale as 6facdf3 ("also exclude hppa-firmware.img ROM from
build"), not used by Proxmox VE and would cause a failure during
build.
Signed-off-by: Fiona Ebner
---
Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/Makefile b/Makefile
index a719e43..f23b
Am 24.04.24 um 11:14 schrieb Filip Schauer:
> This fixes the broken prevention of starting a VM with a 32-bit CPU
> using a 64-bit OVMF (UEFI) BIOS.
>
> Signed-off-by: Filip Schauer
applied, thanks! Added a "Fixes" trailer and a prefix to the commit title.
Am 22.04.24 um 15:16 schrieb Dominik Csapak:
> On 4/22/24 15:11, Fiona Ebner wrote:
>
>>
>> Should we display some hint that Intel can/should also be used even if
>> you have an AMD? Maybe even just in the text we display, like "Intel
>> (also used for
Am 22.04.24 um 15:18 schrieb Dominik Csapak:
> On 4/22/24 15:13, Fiona Ebner wrote:
>> Am 15.04.24 um 10:50 schrieb Markus Frank:
>>> ---
>>> www/manager6/qemu/MachineEdit.js | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/ww
Am 15.04.24 um 10:50 schrieb Markus Frank:
> ---
> www/manager6/qemu/MachineEdit.js | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/www/manager6/qemu/MachineEdit.js
> b/www/manager6/qemu/MachineEdit.js
> index 48c72c1d..ee2b2dac 100644
> --- a/www/manager6/qemu/MachineEdit.js
> +++
Am 15.04.24 um 10:50 schrieb Markus Frank:
> Added a proxmoxKVComboBox for selecting a vIOMMU implementation for a VM.
> If i440fx is selected, another ComboBox will be enabled/visible that does not
> have the Intel option, as Intel-vIOMMU is not compatible with i440fx.
>
Just wondering, is it
Am 22.04.24 um 13:56 schrieb Dominik Csapak:
> i have to apologize, it seems my previous message was wrong.
> after re-checking and re-testing a variant i had before changing it
> to not returning any format for ova/ovfs it seems to work fine.
>
> not sure where the error i got came from (maybe i
Am 19.04.24 um 18:33 schrieb Alexander Zeidler:
> diff --git a/bin/Makefile b/bin/Makefile
> index 180a91b5..6c5f9b14 100644
> --- a/bin/Makefile
> +++ b/bin/Makefile
> @@ -66,10 +66,10 @@ pve6to7.1:
>
> pve7to8.1:
> printf ".TH PVE7TO8 1\n.SH NAME\npve7to8 \- Proxmox VE upgrade checker
Am 22.04.24 um 13:09 schrieb Dominik Csapak:
> On 4/22/24 13:00, Fiona Ebner wrote:
>> Am 19.04.24 um 11:45 schrieb Dominik Csapak:
>>> diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
>>> index 22a9729..39a8354 100644
>>> --- a/src/PVE/Storage
Am 19.04.24 um 11:45 schrieb Dominik Csapak:
> diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
> index 22a9729..39a8354 100644
> --- a/src/PVE/Storage/Plugin.pm
> +++ b/src/PVE/Storage/Plugin.pm
> @@ -654,6 +654,10 @@ sub parse_volname {
> return ('backup', $fn);
> }
Am 22.04.24 um 11:15 schrieb Lukas Wagner:
>
>
> On 2024-04-22 11:10, Fiona Ebner wrote:
>>> +| Cluster node fenced |`fencing` | `error` |
>>> `hostname`
>>> +| Storage replication job failed |`replication` | `error` |
&g
Am 22.04.24 um 10:31 schrieb Lukas Wagner:
> Signed-off-by: Lukas Wagner
> ---
> notifications.adoc | 20 +++-
> 1 file changed, 11 insertions(+), 9 deletions(-)
>
> diff --git a/notifications.adoc b/notifications.adoc
> index 57053c8..dec878a 100644
> --- a/notifications.adoc
>
Am 22.04.24 um 10:31 schrieb Lukas Wagner:
> @@ -416,10 +416,22 @@ Ext.define('Proxmox.panel.NotificationRulesEditPanel', {
> let me = this;
> let record = me.get('selectedRecord');
> let currentData = record.get('data');
> +
> +
Am 22.04.24 um 10:22 schrieb Fiona Ebner:
> Am 22.04.24 um 10:16 schrieb Dominik Csapak:
>> where we generally want to show a field on the left, but a description
>> on the right.
>>
>> merges the column1/2/B into just items.
>>
>> Signed-off-by: Dom
Am 22.04.24 um 10:16 schrieb Dominik Csapak:
> where we generally want to show a field on the left, but a description
> on the right.
>
> merges the column1/2/B into just items.
>
> Signed-off-by: Dominik Csapak
Getting eslint errors:
> [./panel/BackupAdvancedOptions.js]:
> WARN: line 158 col
Am 11.04.24 um 11:29 schrieb Fiona Ebner:
> @@ -282,6 +293,7 @@ sub read_vzdump_defaults {
> } keys %$confdesc_for_defaults
> };
> $parse_prune_backups_maxfiles->($defaults, "defaults in VZDump schema");
> +parse_fleecing($defaults);
>
As discussed off-list with Thomas, applied the remaining non-RFC patches
and bumped the packages with the necessary dependency bumps. For the RFC
ones we'll have more time to decide upon the improved cleanup mechanism
(should it even go to the config or rather some file in /var) and minus
sign in
Am 19.04.24 um 12:09 schrieb Fiona Ebner:
>>
>
> Versioned breaks required:
> - new pve-cluster will break old pve-manager and old pve-ha-manager
> - new libproxmox-rs-perl/libpve-rs-perl will break old pve-cluster
>
Since I got myself confused for a moment when re-installi
Am 15.04.24 um 10:26 schrieb Lukas Wagner:
> +
> +__PACKAGE__->register_method ({
> +name => 'get_field_values',
> +path => 'values',
> +method => 'GET',
> +description => 'Returns known notification metadata fields and their
> known values',
> +permissions => {
> + check
Am 19.04.24 um 14:22 schrieb Lukas Wagner:
>
>
> On 2024-04-19 14:02, Fiona Ebner wrote:
>> Am 15.04.24 um 10:26 schrieb Lukas Wagner:
>>> This allows users to create notification match rules for specific
>>> replication jobs, if they so desire.
&g
Am 15.04.24 um 10:26 schrieb Lukas Wagner:
> This new API route returns known notification metadata fields and
> a list of known possible values. This will be used by the UI to
> provide suggestions when adding/modifying match rules.
>
> Signed-off-by: Lukas Wagner
> ---
>
Am 15.04.24 um 10:26 schrieb Lukas Wagner:
> This allows users to create notification match rules for specific
> replication jobs, if they so desire.
>
> Signed-off-by: Lukas Wagner
> ---
> PVE/API2/Replication.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
Am 15.04.24 um 10:26 schrieb Lukas Wagner:
> This allows us to access us the backup job id in the send_notification
> function, where we can set it as metadata for the notification.
>
> Signed-off-by: Lukas Wagner
> ---
> PVE/API2/VZDump.pm | 8
> PVE/Jobs/VZDump.pm | 4 +++-
>
Am 15.04.24 um 10:25 schrieb Lukas Wagner:
> Signed-off-by: Lukas Wagner
> ---
> PVE/API2/Cluster/Notifications.pm | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/PVE/API2/Cluster/Notifications.pm
> b/PVE/API2/Cluster/Notifications.pm
> index 7047f0b1..68fdda2a
Am 15.04.24 um 10:26 schrieb Lukas Wagner:
> This might be useful if somebody wants to match on the new
> 'backup-job' field in a notification match rule.
>
> Signed-off-by: Lukas Wagner
> ---
> www/manager6/Utils.js | 4
> www/manager6/dc/Backup.js | 11 +++
> 2 files
Am 15.04.24 um 10:26 schrieb Lukas Wagner:
> This might be useful if somebody wants to match on the new
> 'backup-job' field in a notification match rule.
>
> Signed-off-by: Lukas Wagner
Needs a rebase, because the advanced settings were moved to a new
"Advanced" tab.
bpve-rs-perl will break old pve-cluster
Still not too sure about putting the templates in
/usr/share/proxmox-ve/, but maybe @Thomas or @Fabian can chime in on that.
While I'm rather unfamiliar with the code and not much into Rust,
everything looked good to me (just a few nits). So, with a grain of s
Am 09.04.24 um 15:25 schrieb Lukas Wagner:
> diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
> index 152eb3e5..2ea626f0 100644
> --- a/PVE/VZDump.pm
> +++ b/PVE/VZDump.pm
The existing $subject_template and $body_template could be removed now
like for the others
> diff --git a/templates/Makefile
Am 09.04.24 um 15:25 schrieb Lukas Wagner:
> Signed-off-by: Lukas Wagner
> ---
> .gitignore | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index e8d1eb27..48975d55 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -9,3 +9,5 @@ dest/
>
Am 09.04.24 um 15:25 schrieb Lukas Wagner:
> The notification system will now load template files from a defined
> location. The template to use is now passed to proxmox_notify, instead
> of separate template strings for subject/body.
>
> Signed-off-by: Lukas Wagner
> Tested-by: Folke Gleumes
>
Am 19.04.24 um 10:45 schrieb Lukas Wagner:
>> Who adds the template files? I don't see a patch for proxmox-ve in this
>> series. Does this series require some versioned breaks to some package?
>
> The pve-manager and pve-ha-manager (for fencing notifications) patches add
> the templates.
> I
Nit: I always like a quick sentence for who needs it for such changes.
Am 09.04.24 um 15:25 schrieb Lukas Wagner:
> Signed-off-by: Lukas Wagner
> ---
> proxmox-notify/src/lib.rs | 10 +++---
> 1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/proxmox-notify/src/lib.rs
Am 09.04.24 um 15:25 schrieb Lukas Wagner:
> +#[api]
> +#[derive(Clone, Debug, Serialize, Deserialize, PartialEq, Eq, PartialOrd)]
> +#[serde(rename_all = "kebab-case")]
> +/// Target information
> +pub struct Target {
> +/// Name of the endpoint
> +name: String,
> +/// Origin of the
Am 09.04.24 um 15:25 schrieb Lukas Wagner:
> +/// Get a list of all notification targets.
> +pub fn get_targets(config: ) -> Result, HttpError> {
> +let mut targets = Vec::new();
> +
> +#[cfg(feature = "gotify")]
> +for endpoint in gotify::get_endpoints(config)? {
> +
Am 09.04.24 um 15:25 schrieb Lukas Wagner:
> It uses proxmox_sys::nodename - the dep is needed, otherwise the code
> does not compile in some feature flag permutations.
>
> Signed-off-by: Lukas Wagner
> Tested-by: Folke Gleumes
> ---
> proxmox-notify/Cargo.toml | 6 +++---
> 1 file changed, 3
Am 09.04.24 um 15:25 schrieb Lukas Wagner:
> Instead of passing the template strings for subject and body when
> constructing a notification, we pass only the name of a template.
> When rendering the template, the name of the template is used to find
> corresponding template files. For PVE, they
Am 18.04.24 um 13:23 schrieb Dominik Csapak:
> On 4/18/24 13:20, Fiona Ebner wrote:
>> Am 16.04.24 um 15:19 schrieb Dominik Csapak:
>>> diff --git a/www/manager6/window/UploadToStorage.js
>>> b/www/manager6/window/UploadToStorage.js
>>> index 3c5bba88..79a6e8a6
> },
>
> cbindData: function(initialConfig) {
Apart from that, all pve-manager patches:
Reviewed-by: Fiona Ebner
___
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
Am 18.04.24 um 13:10 schrieb Dominik Csapak:
> On 4/18/24 12:35, Fiona Ebner wrote:
>> Am 18.04.24 um 11:27 schrieb Dominik Csapak:
>>> ok after a bit of thinking and discussing off-list
>>> the plan to go forward from my side is this:
>>>
>>> (plea
Am 18.04.24 um 11:27 schrieb Dominik Csapak:
> ok after a bit of thinking and discussing off-list
> the plan to go forward from my side is this:
>
> (please tell if there is something obviously wrong with it or you'd
> strongly prefer something differently)
>
> extract on demand vs on upload:
>
Am 18.04.24 um 11:58 schrieb Dominik Csapak:
> On 4/18/24 11:55, Fiona Ebner wrote:
>>
>>
>> Am 18.04.24 um 11:48 schrieb Dominik Csapak:
>>> On 4/18/24 11:41, Fiona Ebner wrote:
>>>> Am 16.04.24 um 15:19 schrieb Dominik Csapak:
>>>>
Am 18.04.24 um 11:48 schrieb Dominik Csapak:
> On 4/18/24 11:41, Fiona Ebner wrote:
>> Am 16.04.24 um 15:19 schrieb Dominik Csapak:
>>> @@ -391,6 +392,13 @@ my sub create_disks : prototype($$) {
>>> $needs_creation = $live_import;
>
Am 16.04.24 um 15:19 schrieb Dominik Csapak:
> @@ -391,6 +392,13 @@ my sub create_disks : prototype($$) {
>
> $needs_creation = $live_import;
>
> + if (PVE::Storage::copy_needs_extraction($source)) { # needs
> extraction beforehand
> + print
Am 16.04.24 um 15:19 schrieb Dominik Csapak:
> and delete it here (incl tests; they live in pve-storage now).
>
> Signed-off-by: Dominik Csapak
Reviewed-by: Fiona Ebner
> diff --git a/PVE/CLI/qm.pm b/PVE/CLI/qm.pm
> index b105830f..d1d35800 100755
> --- a/PVE/CLI/qm.pm
>
Am 18.04.24 um 10:57 schrieb Dominik Csapak:
> On 4/18/24 10:52, Fiona Ebner wrote:
>> Am 16.04.24 um 15:19 schrieb Dominik Csapak:
>>> the api part was never in use by anything
>>>
>>
>> We don't know for sure if there is not some external client that make
Am 16.04.24 um 15:19 schrieb Dominik Csapak:
> the api part was never in use by anything
>
We don't know for sure if there is not some external client that makes
use of it. But I also think we can drop it and wait for somebody to
complain.
> Signed-off-by: Dominik Csapak
Reviewed-
s/btfs/btrfs/
What about GlusterFS? Or is more required to add it there?
Am 16.04.24 um 15:19 schrieb Dominik Csapak:
> and reuse the DirPlugin implementation
>
> Signed-off-by: Dominik Csapak
Reviewed-by: Fiona Ebner
___
pve-devel mai
e required always.
Clarify that the option is not used by NFS and CIFS.
Signed-off-by: Fiona Ebner
---
Changes in v2:
* do not use a definite list of plugins that use the option
* clarify that NFS and CIFS do not use the option
src/PVE/Storage/PBSPlugin.pm | 6 --
src/PVE/Storage/Plugin
Am 16.04.24 um 15:19 schrieb Dominik Csapak:
> @@ -355,9 +361,21 @@ ovf:Item[rasd:InstanceID='%s']/rasd:ResourceType",
> $controller_id);
>
> $qm->{boot} = "order=" . join(';', @$boot);
>
> +my $nic_id = dtmf_name_to_id('Ethernet Adapter');
> +my $xpath_find_nics =
>
below addressed:
Reviewed-by: Fiona Ebner
> ---
> src/PVE/API2/Storage/Status.pm | 14 --
> src/PVE/Storage.pm | 11 +++
> 2 files changed, 23 insertions(+), 2 deletions(-)
>
> diff --git a/src/PVE/API2/Storage/Status.pm b/src/PVE/API2/Storage/Status.p
Am 17.04.24 um 16:55 schrieb Thomas Lamprecht:
> Am 15/04/2024 um 14:48 schrieb Fiona Ebner:
>> diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm
>> index 22a9729..5f49830 100644
>> --- a/src/PVE/Storage/Plugin.pm
>> +++ b/src/PVE/Storage/Plugin.pm
Am 17.04.24 um 15:14 schrieb Dominik Csapak:
> On 4/17/24 13:32, Fiona Ebner wrote:
>> Am 16.04.24 um 15:18 schrieb Dominik Csapak:
>>> use the standards info about the ostypes to map to our own
>>> (see comment for link to the relevant part of the dmtf
Am 18.04.24 um 09:22 schrieb Fiona Ebner:
>>>> diff --git a/src/PVE/Storage.pm b/src/PVE/Storage.pm
>>>> index f8ea93d..bc073ef 100755
>>>> --- a/src/PVE/Storage.pm
>>>> +++ b/src/PVE/Storage.pm
>>>> @@ -2189,4 +2189,63 @@ sub get_impo
Am 17.04.24 um 15:07 schrieb Dominik Csapak:
> On 4/17/24 12:52, Fiona Ebner wrote:
>> Am 16.04.24 um 15:18 schrieb Dominik Csapak:
>>>
>>> we currently extract into the import storage in a directory named:
>>> `.tmp__` which should not clash with concur
-guest-common commit "replication:
snapshot cleanup: only attempt to remove snapshots that exist".
Signed-off-by: Fiona Ebner
---
Build-depends on new pve-guest-common.
test/replication_test5.log | 2 --
1 file changed, 2 deletions(-)
diff --git a/test/replication_test5.
s: a6f5b35 ("replication: prepare: include volumes without snapshots in the
result")
Reported-by: Thomas Lamprecht
Signed-off-by: Fiona Ebner
---
src/PVE/Replication.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/PVE/Replication.pm b/src/PVE/Replication.pm
in
1 - 100 of 1245 matches
Mail list logo
