Re: [PATCH] target/riscv: fix the issue of guest reboot then no response or crash in kvm-mode

Hi Alistair: Thanks for your reply. I'll modify the change follow your suggestion, and push the new change, pls help to review again. Replied Message FromAlistair Francis Date6/23/2023 10:15 To liguang.zhang<18622748...@163.com>

Re: [PATCH] STM32F100: support different density lines

On Thu, Jun 22, 2023 at 10:30 PM Alistair Francis wrote: > > + > > +object_class_property_add_str(oc, "density", stm32f100_get_density, > > +stm32f100_set_density); > > +object_class_property_set_description(oc, "density", > > +"Set the STM32F100 density line device. " >

Re: [PATCH] STM32F100: add support for external memory via FSMC

On Thu, Jun 22, 2023 at 10:37 PM Alistair Francis wrote: > On Wed, Jun 21, 2023 at 5:44 AM Lucas Villa Real wrote: > > > > Add support for FSMC on high-density STM32F100 devices and enable > > mapping of additional memory via the `-m SIZE` command-line option. > > FSMC Bank1 can address up to

[PATCH] target/riscv: fix the issue of guest reboot then no response or crash in kvm-mode

From: "liguang.zhang" There are two issues when rebooting a guest using KVM 1. When the guest initiates a reboot the host is unable to stop the vcpu 2. When running a SMP guest the qemu monitor system_reset causes a vcpu crash This can be fixed by clearing the CSR values at reset and syncing

[PATCH] target/riscv: fix the issue of guest reboot then no response or crash in kvm-mode

From: "liguang.zhang" There have a issue of guest reboot bug in kvm-mode: 1. in guest shell just run the reboot, guest can't reboot success, and host kvm stop the vcpu schedual. 2. for smp guest, ctrl+a+c switch to qemu command, use system_reset command to reset the guest, then vcpu crash

[PATCH] target/riscv: fix the issue of guest reboot then no response or crash in kvm-mode

From: "liguang.zhang" There have a issue of guest reboot bug in kvm-mode: 1. in guest shell just run the reboot, guest can't reboot success, and host kvm stop the vcpu schedual. 2. for smp guest, ctrl+a+c switch to qemu command, use system_reset command to reset the guest, then vcpu crash

[PATCH v7 1/9] hw/net: e1000: Remove the logic of padding short frames in the receive path

Now that we have implemented unified short frames padding in the QEMU networking codes, remove the same logic in the NIC codes. This actually reverts commit 78aeb23eded2d0b765bf9145c71f80025b568acd. Signed-off-by: Bin Meng --- (no changes since v1) hw/net/e1000.c | 11 +-- 1 file

[PATCH v7 2/9] hw/net: vmxnet3: Remove the logic of padding short frames in the receive path

Now that we have implemented unified short frames padding in the QEMU networking codes, remove the same logic in the NIC codes. This actually reverts commit 40a87c6c9b11ef9c14e0301f76abf0eb2582f08e. Signed-off-by: Bin Meng --- (no changes since v1) hw/net/vmxnet3.c | 10 -- 1 file

[PATCH v7 8/9] hw/net: sunhme: Remove the logic of padding short frames in the receive path

Now that we have implemented unified short frames padding in the QEMU networking codes, remove the same logic in the NIC codes. Signed-off-by: Bin Meng --- (no changes since v1) hw/net/sunhme.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/hw/net/sunhme.c b/hw/net/sunhme.c

[PATCH v7 6/9] hw/net: rtl8139: Remove the logic of padding short frames in the receive path

Now that we have implemented unified short frames padding in the QEMU networking codes, remove the same logic in the NIC codes. Signed-off-by: Bin Meng --- (no changes since v1) hw/net/rtl8139.c | 12 1 file changed, 12 deletions(-) diff --git a/hw/net/rtl8139.c

[PATCH v7 9/9] hw/net: ftgmac100: Drop the small packet check in the receive path

Now that we have implemented unified short frames padding in the QEMU networking codes, the small packet check logic in the receive path is no longer needed. Suggested-by: Cédric Le Goater Signed-off-by: Bin Meng --- Changes in v7: - new patch: "hw/net: ftgmac100: Drop the small packet check

[PATCH v7 4/9] hw/net: ne2000: Remove the logic of padding short frames in the receive path

Now that we have implemented unified short frames padding in the QEMU networking codes, remove the same logic in the NIC codes. Signed-off-by: Bin Meng --- (no changes since v1) hw/net/ne2000.c | 12 1 file changed, 12 deletions(-) diff --git a/hw/net/ne2000.c b/hw/net/ne2000.c

[PATCH v7 5/9] hw/net: pcnet: Remove the logic of padding short frames in the receive path

Now that we have implemented unified short frames padding in the QEMU networking codes, remove the same logic in the NIC codes. Signed-off-by: Bin Meng --- (no changes since v1) hw/net/pcnet.c | 9 - 1 file changed, 9 deletions(-) diff --git a/hw/net/pcnet.c b/hw/net/pcnet.c index

[PATCH v7 0/9] net: Pad short frames for network backends

The minimum Ethernet frame length is 60 bytes. For short frames with smaller length like ARP packets (only 42 bytes), on a real world NIC it can choose either padding its length to the minimum required 60 bytes, or sending it out directly to the wire. Such behavior can be hardcoded or controled by

[PATCH v7 3/9] hw/net: i82596: Remove the logic of padding short frames in the receive path

Now that we have implemented unified short frames padding in the QEMU networking codes, remove the same logic in the NIC codes. Signed-off-by: Bin Meng --- (no changes since v1) hw/net/i82596.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/hw/net/i82596.c

[PATCH v7 7/9] hw/net: sungem: Remove the logic of padding short frames in the receive path

Now that we have implemented unified short frames padding in the QEMU networking codes, remove the same logic in the NIC codes. Signed-off-by: Bin Meng --- (no changes since v1) hw/net/sungem.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/hw/net/sungem.c

Re: [PATCH] cryptodev: Handle unexpected request to avoid crash

Hi Michael Could you please apply this patch? On 5/26/23 11:38, Lei He wrote: On Apr 27, 2023, at 16:05, zhenwei pi wrote: Generally guest side should discover which services the device is able to offer, then do requests on device. However it's also possible to break this rule in a guest.

QEMU RISC-V

hello, I built RISC-V toolchain and QEMU as follows: # Install prerequisites: https://github.com/riscv-collab/riscv-gnu-toolchain#prerequisites # Install additional prerequisites: https://github.com/riscv-collab/riscv-gnu-toolchain/issues/1251 git clone

[PATCH v2] hw/s390x: Move KVM specific PV from hw/ to target/s390x/kvm/

Protected Virtualization (PV) is not a real hardware device: it is a feature of the firmware on s390x that is exposed to userspace via the KVM interface. Move the pv.c/pv.h files to target/s390x/kvm/ to make this clearer. Suggested-by: Thomas Huth Signed-off-by: Philippe Mathieu-Daudé --- v1:

[PATCH v2] target/riscv: Restrict KVM-specific fields from ArchCPU

These fields shouldn't be accessed when KVM is not available. Restrict the KVM timer migration state. Rename the KVM timer post_load() handler accordingly, because cpu_post_load() is too generic. Signed-off-by: Philippe Mathieu-Daudé --- Since v1

[PATCH v2] target/ppc: Restrict KVM-specific fields from ArchCPU

The 'kvm_sw_tlb' and 'tlb_dirty' fields introduced in commit 93dd5e852c ("kvm: ppc: booke206: use MMU API") are specific to KVM and shouldn't be accessed when it is not available. Signed-off-by: Philippe Mathieu-Daudé --- Since v1

[PATCH v3 13/16] accel: Rename WHPX 'struct whpx_vcpu' -> AccelCPUState

We want all accelerators to share the same opaque pointer in CPUState. Rename WHPX 'whpx_vcpu' as 'AccelCPUState'; use the typedef. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/i386/whpx/whpx-all.c | 30 +++--- 1 file changed, 15

[PATCH v3 12/16] accel: Remove WHPX unreachable error path

g_new0() can not fail. Remove the unreachable error path. https://developer-old.gnome.org/glib/stable/glib-Memory-Allocation.html#glib-Memory-Allocation.description Reported-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson ---

[PATCH v3 16/16] accel: Rename HVF 'struct hvf_vcpu_state' -> AccelCPUState

We want all accelerators to share the same opaque pointer in CPUState. Rename the 'hvf_vcpu_state' structure as 'AccelCPUState'. Use the generic 'accel' field of CPUState instead of 'hvf'. Replace g_malloc0() by g_new0() for readability. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by:

[PATCH v3 09/16] accel: Remove NVMM unreachable error path

g_malloc0() can not fail. Remove the unreachable error path. https://developer-old.gnome.org/glib/stable/glib-Memory-Allocation.html#glib-Memory-Allocation.description Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/i386/nvmm/nvmm-all.c | 4 1 file

[PATCH v3 10/16] accel: Rename NVMM 'struct qemu_vcpu' -> AccelCPUState

We want all accelerators to share the same opaque pointer in CPUState. Rename NVMM 'qemu_vcpu' as 'AccelCPUState'; directly use the typedef, remove unnecessary casts. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/i386/nvmm/nvmm-all.c | 32

[PATCH v3 01/16] MAINTAINERS: Update Roman Bolshakov email address

r.bolsha...@yadro.com is bouncing: Update Roman's email address using one found somewhere on the Internet; this way he can Ack-by. (Reorder Taylor's line to keep the section sorted alphabetically). Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 4 ++-- .mailmap| 3 ++- 2 files

[PATCH v3 15/16] accel: Rename 'cpu_state' -> 'cs'

Most of the codebase uses 'CPUState *cpu' or 'CPUState *cs'. While 'cpu_state' is kind of explicit, it makes the code harder to review. Simply rename as 'cs'. Acked-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/i386/hvf/x86hvf.h | 18 +- target/i386/hvf/x86hvf.c | 372

[PATCH v3 04/16] accel: Fix a leak on Windows HAX

hThread is only used on the error path in hax_kick_vcpu_thread(). Fixes: b0cb0a66d6 ("Plumb the HAXM-based hardware acceleration support") Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/i386/hax/hax-all.c | 3 +++ 1 file changed, 3 insertions(+) diff --git

[PATCH v3 03/16] accel: Remove unused hThread variable on TCG/WHPX

On Windows hosts, cpu->hThread is assigned but never accessed: remove it. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- accel/tcg/tcg-accel-ops-mttcg.c | 4 accel/tcg/tcg-accel-ops-rr.c | 3 --- target/i386/whpx/whpx-accel-ops.c | 3 --- 3 files changed,

[PATCH v3 14/16] accel: Inline WHPX get_whpx_vcpu()

No need for this helper to access the CPUState::accel field. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/i386/whpx/whpx-all.c | 29 ++--- 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/target/i386/whpx/whpx-all.c

[PATCH v3 11/16] accel: Inline NVMM get_qemu_vcpu()

No need for this helper to access the CPUState::accel field. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- target/i386/nvmm/nvmm-all.c | 28 +++- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a/target/i386/nvmm/nvmm-all.c

[PATCH v3 08/16] accel: Move HAX hThread to accelerator context

hThread variable is only used by the HAX accelerator, so move it to the accelerator specific context. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- include/hw/core/cpu.h | 1 - target/i386/hax/hax-i386.h | 3 +++ target/i386/hax/hax-accel-ops.c | 2 +-

[PATCH v3 00/16] accel: Share CPUState accel context (HAX/NVMM/WHPX/HVF)

This series is part of the single binary effort. All accelerator will share their per-vCPU context in an opaque 'accel' pointer within the CPUState. First handle HAX/NVMM/WHPX/HVF. KVM and TCG will follow as two different (bigger) follow-up series. Except HVF/intel, all has been (cross-)build

[PATCH v3 06/16] accel: Rename 'hax_vcpu' as 'accel' in CPUState

All accelerators will share a single opaque context in CPUState. Start by renaming 'hax_vcpu' as 'accel'. Reviewed-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- include/hw/core/cpu.h | 2 +- target/i386/hax/hax-accel-ops.c | 2 +- target/i386/hax/hax-all.c |

[PATCH v3 07/16] accel: Rename HAX 'struct hax_vcpu_state' -> AccelCPUState

We want all accelerators to share the same opaque pointer in CPUState. Start with the HAX context, renaming its forward declarated structure 'hax_vcpu_state' as 'AccelCPUState'. Document the CPUState field. Directly use the typedef. Remove the amusing but now unnecessary casts in NVMM / WHPX.

[PATCH v3 05/16] accel: Destroy HAX vCPU threads once done

When the vCPU thread finished its processing, destroy it and signal its destruction to generic vCPU management layer. Add a sanity check for the vCPU accelerator context. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- target/i386/hax/hax-accel-ops.c | 3 +++

[PATCH v3 02/16] accel: Document generic accelerator headers

These headers are meant to be include by any file to check the availability of accelerators, thus are not accelerator specific. Signed-off-by: Philippe Mathieu-Daudé Acked-by: Richard Henderson --- include/sysemu/hax.h | 2 ++ include/sysemu/kvm.h | 2 ++ include/sysemu/nvmm.h | 2 ++

Re: [PATCH v2 07/16] accel: Rename HAX 'struct hax_vcpu_state' -> AccelCPUState

On 22/6/23 19:46, Richard Henderson wrote: On 6/22/23 18:08, Philippe Mathieu-Daudé wrote: |+ struct AccelvCPUState *accel;| ... +typedef struct AccelCPUState { hax_fd fd; int vcpu_id; struct hax_tunnel *tunnel; unsigned char *iobuf; -}; +} hax_vcpu_state; Discussed

Re: [PATCH v3 1/5] target/microblaze: Define TCG_GUEST_DEFAULT_MO

On Mon, Jun 19, 2023 at 4:23 PM Richard Henderson < richard.hender...@linaro.org> wrote: > The microblaze architecture does not reorder instructions. > While there is an MBAR wait-for-data-access instruction, > this concerns synchronizing with DMA. > > This should have been defined when enabling

Re: [PATCH v5 01/11] hw: arm: Add bananapi M2-Ultra and allwinner-r40 support

On 6/24/23 07:23, Guenter Roeck wrote: On 6/24/23 03:40, Peter Maydell wrote: On Fri, 23 Jun 2023 at 20:33, Guenter Roeck wrote: On 6/23/23 10:44, Peter Maydell wrote: On Sat, 17 Jun 2023 at 17:29, Guenter Roeck wrote: Hi, On Tue, May 23, 2023 at 06:04:58PM +0800, qianfangui...@163.com

Facing difficulties in building QEMU for windows

I am currently following these resources to build QEMU - Hosts/W32 - QEMU However, when starting qemu-system-aarch64.exe in a console, nothing happens. I expected a window showing up. Shortly after starting the exe, I'm getting back the

Re: qemu-system-ppc64 option -smp 2 broken with commit 20b6643324a79860dcdfe811ffe4a79942bca21e

23.06.2023 14:09, Anushree Mathur wrote: Hi everyone, I was trying to boot rhel9.3 image with upstream qemu-system-ppc64 -smp 2 option and observed a segfault (qemu crash). qemu command line used: qemu-system-ppc64 -name Rhel9.3.ppc64le -smp 2 -m 16G -vga none -nographic -machine pseries

Re: [PATCH v5 01/11] hw: arm: Add bananapi M2-Ultra and allwinner-r40 support

On 6/24/23 03:40, Peter Maydell wrote: On Fri, 23 Jun 2023 at 20:33, Guenter Roeck wrote: On 6/23/23 10:44, Peter Maydell wrote: On Sat, 17 Jun 2023 at 17:29, Guenter Roeck wrote: Hi, On Tue, May 23, 2023 at 06:04:58PM +0800, qianfangui...@163.com wrote: From: qianfan Zhao Allwinner

[PATCH 2/2] accel: Re-enable WHPX cross-build on case sensitive filesystems

Since MinGW commit 395dcfdea ("rename hyper-v headers and def files to lower case") [*], WinHvPlatform.h and WinHvEmulation.h got respectively renamed as winhvplatform.h / winhvemulation.h. The mingw64-headers package included in the Fedora version we use for CI does include this commit; and

[PATCH 1/2] docs/devel/testing: Update the 'Docker Debugging' section

Since commit 93cc0506f6 ("tests/docker: Use Fedora containers for MinGW cross-builds in the gitlab-CI") the MinGW toolchain is packaged inside the fedora-win[32/64]-cross images. Signed-off-by: Philippe Mathieu-Daudé --- docs/devel/testing.rst | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 0/2] accel: Re-enable WHPX cross-build on case sensitive filesystems

Re-enable cross-building of WHPX (via Docker images; also on CI). Only cross-built. Philippe Mathieu-Daudé (2): docs/devel/testing: Update the 'Docker Debugging' section accel: Re-enable WHPX cross-build on case sensitive filesystems docs/devel/testing.rst | 2 +- meson.build

Re: [PULL 10/14] tests/docker: Remove old Debian 9 containers

On 24/6/23 00:29, Philippe Mathieu-Daudé wrote: On 2/10/20 13:36, Alex Bennée wrote: From: Thomas Huth We do not support Debian 9 in QEMU anymore, and the Debian 9 containers are now no longer used in the gitlab-CI. Time to remove them. Signed-off-by: Thomas Huth Signed-off-by: Alex Bennée

[PULL v2 1/3] target/hppa: Fix OS reboot issues

When the OS triggers a reboot, the reset helper function sends a qemu_system_reset_request(SHUTDOWN_CAUSE_GUEST_RESET) together with an EXCP_HLT exception to halt the CPUs. So, at reboot when initializing the CPUs again, make sure to set all instruction pointers to the firmware entry point,

[PULL v2 2/3] target/hppa: Provide qemu version via fw_cfg to firmware

Give current QEMU version string to SeaBIOS-hppa via fw_cfg interface so that the firmware can show the QEMU version in the boot menu info. Signed-off-by: Helge Deller --- hw/hppa/machine.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c index

[PULL v2 0/3] Hppa boot reboot fixes patches

The following changes since commit b455ce4c2f300c8ba47cba7232dd03261368a4cb: Merge tag 'q800-for-8.1-pull-request' of https://github.com/vivier/qemu-m68k into staging (2023-06-22 10:18:32 +0200) are available in the Git repository at: https://github.com/hdeller/qemu-hppa.git

Re: [PULL 0/3] Hppa reboot fix patches

On 6/24/23 13:29, Helge Deller wrote: The following changes since commit c5ffd16ba4c8fd3601742cc9d2b3cff03995dd5d: Revert "cputlb: Restrict SavedIOTLB to system emulation" (2023-06-21 07:19:46 +0200) are available in the Git repository at: https://github.com/hdeller/qemu-hppa.git

[PULL 2/3] target/hppa: Provide qemu version via fw_cfg to firmware

Give current QEMU version string to SeaBIOS-hppa via fw_cfg interface so that the firmware can show the QEMU version in the boot menu info. Signed-off-by: Helge Deller --- hw/hppa/machine.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c index

[PULL 0/3] Hppa reboot fix patches

The following changes since commit c5ffd16ba4c8fd3601742cc9d2b3cff03995dd5d: Revert "cputlb: Restrict SavedIOTLB to system emulation" (2023-06-21 07:19:46 +0200) are available in the Git repository at: https://github.com/hdeller/qemu-hppa.git tags/hppa-reboot-fix-pull-request for you to

[PULL 1/3] target/hppa: Fix OS reboot issues

When the OS triggers a reboot, the reset helper function sends a qemu_system_reset_request(SHUTDOWN_CAUSE_GUEST_RESET) together with an EXCP_HLT exception to halt the CPUs. So, at reboot when initializing the CPUs again, make sure to set all instruction pointers to the firmware entry point,

Re: [PATCH v5 01/11] hw: arm: Add bananapi M2-Ultra and allwinner-r40 support

On Fri, 23 Jun 2023 at 20:33, Guenter Roeck wrote: > > On 6/23/23 10:44, Peter Maydell wrote: > > On Sat, 17 Jun 2023 at 17:29, Guenter Roeck wrote: > >> > >> Hi, > >> > >> On Tue, May 23, 2023 at 06:04:58PM +0800, qianfangui...@163.com wrote: > >>> From: qianfan Zhao > >>> > >>> Allwinner R40

Re: [PATCH 0/4] target/ppc: Catch invalid real address accesses

On Sat, 24 Jun 2023, Philippe Mathieu-Daudé wrote: On 23/6/23 14:37, Cédric Le Goater wrote: On 6/23/23 11:10, Peter Maydell wrote: On Fri, 23 Jun 2023 at 09:21, Nicholas Piggin wrote: ppc has always silently ignored access to real (physical) addresses with nothing behind it, which can make

Re: [PATCH v3 16/19] target/riscv/cpu.c: create KVM mock properties

On Fri, Jun 23, 2023 at 11:28:03AM -0300, Daniel Henrique Barboza wrote: ... > > I think we should actually fail with an error when the user tries to > > enable an extension KVM doesn't support. Otherwise a user may be > > confused as to why their Zawrs=on didn't provide them a machine with > >

Re: [PATCH v3 12/19] target/riscv: add KVM specific MISA properties

On Fri, Jun 23, 2023 at 11:14:45AM -0300, Daniel Henrique Barboza wrote: > > > On 6/23/23 06:38, Andrew Jones wrote: > > On Thu, Jun 22, 2023 at 10:56:53AM -0300, Daniel Henrique Barboza wrote: > > ... > > > +#define KVM_MISA_CFG(_bit, _reg_id) \ > > > +{.offset = _bit, .kvm_reg_id =

RFC: bsd-user broken a while ago, is this the right fix?

This change: commit f00506aeca2f6d92318967693f8da8c713c163f3 Merge: d37158bb242 87e303de70f Author: Peter Maydell Date: Wed Mar 29 11:19:19 2023 +0100 Merge tag 'pull-tcg-20230328' of https://gitlab.com/rth7680/qemu into staging Use a local version of GTree [#285] Fix