Re: [Qemu-devel] [PATCH for-3.2 05/41] slirp: use a callback structure to interface with qemu

2018-11-19 Thread Samuel Thibault
Philippe Mathieu-Daudé, le mer. 14 nov. 2018 14:10:15 +0100, a ecrit: > With the const qualifier: > Reviewed-by: Philippe Mathieu-Daudé Stefan Hajnoczi, le mer. 14 nov. 2018 14:30:14 +, a ecrit: > On Wed, Nov 14, 2018 at 04:36:07PM +0400, Marc-André Lureau wrote: > > -typedef void

Re: [Qemu-devel] [PATCH for-3.2 05/41] slirp: use a callback structure to interface with qemu

2018-11-14 Thread Stefan Hajnoczi
On Wed, Nov 14, 2018 at 04:36:07PM +0400, Marc-André Lureau wrote: > -typedef void (*slirp_output)(void *opaque, const uint8_t *pkt, int pkt_len); > +typedef struct SlirpCb { > +void (*output)(void *opaque, const uint8_t *pkt, int pkt_len); > +} SlirpCb; Please include doc comments for each

Re: [Qemu-devel] [PATCH for-3.2 05/41] slirp: use a callback structure to interface with qemu

2018-11-14 Thread Philippe Mathieu-Daudé
On 14/11/18 13:36, Marc-André Lureau wrote: This will bring slirp a bit forward to the state of an independent project. This could be squashed with earlier submitted "slirp: associate slirp_output". Signed-off-by: Marc-André Lureau --- slirp/libslirp.h | 7 +-- slirp/slirp.h| 2