[PATCH 3/3] tcg/cputlb: remove other-cpu capability from TLB flushing

2024-03-27 Thread Nicholas Piggin
Some TLB flush operations can flush other CPUs. The problem with this is they used non-synced variants of flushes (i.e., that return before the destination has completed theflush). Since all TLB flush users need the synced variants and the last user of the non-synced flush was buggy, this is a

[PATCH 2/3] tcg/cputlb: Remove non-synced variants of global TLB flushes

2024-03-27 Thread Nicholas Piggin
These are no longer used. Signed-off-by: Nicholas Piggin --- docs/devel/multi-thread-tcg.rst | 13 ++-- include/exec/exec-all.h | 97 +- accel/tcg/cputlb.c | 103 3 files changed, 19 insertions(+), 194

[PATCH 0/3] target/ppc: fix tlb flushing race

2024-03-27 Thread Nicholas Piggin
ppc broadcast tlb flushes should be synchronised with other vCPUs, like all other architectures that support such operations seem to be doing. Fixing ppc removes the last caller of the non-synced TLB flush variants, we can remove some dead code. I'd like to merge patch 1 for 9.0, and hold patches

[PATCH 1/3] target/ppc: Fix broadcast tlbie synchronisation

2024-03-27 Thread Nicholas Piggin
With mttcg, broadcast tlbie instructions do not wait until other vCPUs have been kicked out of TCG execution before they complete (including necessary subsequent tlbsync, etc., instructions). This is contrary to the ISA, and it permits other vCPUs to use translations after the TLB flush. For

Re: [PATCH v2] hw/net/net_tx_pkt: Fix virtio header without checksum offloading

2024-03-27 Thread Jason Wang
On Wed, Mar 27, 2024 at 4:43 PM Akihiko Odaki wrote: > > It is incorrect to have the VIRTIO_NET_HDR_F_NEEDS_CSUM set when > checksum offloading is disabled so clear the bit. > > TCP/UDP checksum is usually offloaded when the peer requires virtio > headers because they can instruct the peer to

[PATCH 1/4] tests/avocado: Fix ppc_hv_tests.py xorriso dependency guard

2024-03-27 Thread Nicholas Piggin
For some reason the skipIf missing_deps() check fails to skip the test if it comes after the skipUnless lines, causing an error running on systems without xorriso. Avocado implements skipUnless is just an inverted skipIf, so it's not clear what the bug is or why this fixes it. For now it's enough

[PATCH 2/4] tests/avocado: ppc_hv_tests.py set alpine time before setup-alpine

2024-03-27 Thread Nicholas Piggin
If the time is wrong, setup-alpine SSL certificate checks can fail. setup-alpine is used to bring up the network, but it doesn't seem to to set NTP time before the failing SSL checks. This test has recently started failing presumably because the default time has now fallen too far behind. Fix

[PATCH 3/4] tests/avocado: exec_command should not consume console output

2024-03-27 Thread Nicholas Piggin
_console_interaction reads data from the console even when there is only an input string to send, and no output data to wait on. This can cause lines to be missed by wait_for_console_pattern calls that follows an exec_command. Fix this by not reading the console if there is no pattern to wait for.

[PATCH 0/4] tests/avocado: Fixes for ppc_hv_tests.py

2024-03-27 Thread Nicholas Piggin
This series is a bunch of fixes for ppc_hv_tests.py. It includes a generic avocado patch that I've posted before, but that seems to only really affect ppc_hv_tests.py (I haven't seen other tests wait for console after executing a command like this). If people feel patch 3 is too late for 9.0,

[PATCH 4/4] tests/avocado: Mark ppc_hv_tests.py as non-flaky after fixed console interaction

2024-03-27 Thread Nicholas Piggin
Now that exec_command doesn't incorrectly consume console output, and guest time is set correctly, ppc_hv_tests.py is working more reliably. Try marking it non-flaky. Signed-off-by: Nicholas Piggin --- tests/avocado/ppc_hv_tests.py | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [RFC 0/2] disable the configuration interrupt for the unsupported device

2024-03-27 Thread Jason Wang
On Wed, Mar 27, 2024 at 5:44 PM Cindy Lu wrote: > > On Wed, Mar 27, 2024 at 5:13 PM Jason Wang wrote: > > > > On Wed, Mar 27, 2024 at 5:12 PM Jason Wang wrote: > > > > > > On Wed, Mar 27, 2024 at 4:28 PM Cindy Lu wrote: > > > > > > > > On Wed, Mar 27, 2024 at 3:54 PM Jason Wang wrote: > > > >

Re: [RFC 0/2] disable the configuration interrupt for the unsupported device

2024-03-27 Thread Jason Wang
On Wed, Mar 27, 2024 at 5:33 PM Cindy Lu wrote: > > On Wed, Mar 27, 2024 at 5:12 PM Jason Wang wrote: > > > > On Wed, Mar 27, 2024 at 4:28 PM Cindy Lu wrote: > > > > > > On Wed, Mar 27, 2024 at 3:54 PM Jason Wang wrote: > > > > > > > > On Wed, Mar 27, 2024 at 2:03 PM Cindy Lu wrote: > > > > >

Re: [PATCH-for-9.1 v2 06/21] hw/acpi/ich9: Remove dead code related to 'acpi_memory_hotplug'

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:08AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:08 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 06/21] hw/acpi/ich9: Remove dead code related to > 'acpi_memory_hotplug' > X-Mailer: git-send-email 2.41.0 > >

Re: [PATCH-for-9.1 v2 05/21] hw/acpi/ich9: Remove 'memory-hotplug-support' property

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:07AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:07 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 05/21] hw/acpi/ich9: Remove > 'memory-hotplug-support' property > X-Mailer: git-send-email 2.41.0 > > No external code sets

Re: [PATCH-for-9.1 v2 21/21] hw/i386/pc: Replace PCMachineClass::acpi_data_size by PC_ACPI_DATA_SIZE

2024-03-27 Thread Zhao Liu
Hi Philippe, On Wed, Mar 27, 2024 at 10:51:23AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:23 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 21/21] hw/i386/pc: Replace > PCMachineClass::acpi_data_size by PC_ACPI_DATA_SIZE > X-Mailer: git-send-email

Re: [PATCH-for-9.1 v2 20/21] target/i386: Remove X86CPU::kvm_no_smi_migration field

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:22AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:22 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 20/21] target/i386: Remove > X86CPU::kvm_no_smi_migration field > X-Mailer: git-send-email 2.41.0 > >

[PATCH for-9.0?] accel/tcg: Use CPUState.get_pc in cpu_io_recompile

2024-03-27 Thread Richard Henderson
Using log_pc produces the pc at the beginning of TB, not the actual pc installed by cpu_restore_state_from_tb, which could be any of the guest instructions within TB. Signed-off-by: Richard Henderson --- accel/tcg/translate-all.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH-for-9.1 v2 19/21] hw/i386/pc: Remove 2.3 and deprecate 2.4 to 2.7 pc-i440fx machines

2024-03-27 Thread Zhao Liu
Hi Philippe, On Wed, Mar 27, 2024 at 10:51:21AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:21 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 19/21] hw/i386/pc: Remove 2.3 and deprecate 2.4 > to 2.7 pc-i440fx machines > X-Mailer: git-send-email 2.41.0

Re: [PATCH-for-9.1 v2 18/21] hw/i386/acpi: Remove AcpiBuildState::rsdp field

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:20AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:20 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 18/21] hw/i386/acpi: Remove AcpiBuildState::rsdp > field > X-Mailer: git-send-email 2.41.0 > > AcpiBuildState::rsdp is

RE: [PATCH v1 01/11] Introduce a common abstract struct HostIOMMUDevice

2024-03-27 Thread Duan, Zhenzhong
Hi Cédric, >-Original Message- >From: Cédric Le Goater >Subject: Re: [PATCH v1 01/11] Introduce a common abstract struct >HostIOMMUDevice > >Hello Zhenzhong, > >On 3/19/24 12:58, Duan, Zhenzhong wrote: >> Hi Cédric, >> >>> -Original Message- >>> From: Cédric Le Goater >>> Sent:

RE: [PATCH v5 4/7] migration/multifd: add qpl compression method

2024-03-27 Thread Liu, Yuan1
> -Original Message- > From: Peter Xu > Sent: Thursday, March 28, 2024 3:49 AM > To: Liu, Yuan1 > Cc: faro...@suse.de; qemu-devel@nongnu.org; hao.xi...@bytedance.com; > bryan.zh...@bytedance.com; Zou, Nanhai > Subject: Re: [PATCH v5 4/7] migration/multifd: add qpl compression method >

Re: [PATCH-for-9.1 v2 17/21] hw/i386/pc: Remove PCMachineClass::rsdp_in_ram

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:19AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:19 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 17/21] hw/i386/pc: Remove > PCMachineClass::rsdp_in_ram > X-Mailer: git-send-email 2.41.0 > > PCMachineClass::rsdp_in_ram

Re: [PATCH-for-9.1 v2 16/21] hw/i386/pc: Remove PCMachineClass::resizable_acpi_blob

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:18AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:18 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 16/21] hw/i386/pc: Remove > PCMachineClass::resizable_acpi_blob > X-Mailer: git-send-email 2.41.0 > >

Re: [PATCH-for-9.1 v2 15/21] hw/i386/pc: Remove deprecated pc-i440fx-2.2 machine

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:17AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:17 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 15/21] hw/i386/pc: Remove deprecated > pc-i440fx-2.2 machine > X-Mailer: git-send-email 2.41.0 > > The pc-i440fx-2.2

Re: [PATCH-for-9.1 v2 14/21] hw/mem/memory-device: Remove legacy_align from memory_device_pre_plug()

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:16AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:16 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 14/21] hw/mem/memory-device: Remove legacy_align > from memory_device_pre_plug() > X-Mailer: git-send-email 2.41.0 > >

Re: [PATCH-for-9.1 v2 13/21] hw/mem/pc-dimm: Remove legacy_align argument from pc_dimm_pre_plug()

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:15AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:15 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 13/21] hw/mem/pc-dimm: Remove legacy_align > argument from pc_dimm_pre_plug() > X-Mailer: git-send-email 2.41.0 > >

Re: [PATCH-for-9.1 v2 12/21] hw/i386/pc: Remove PCMachineClass::enforce_aligned_dimm

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:14AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:14 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 12/21] hw/i386/pc: Remove > PCMachineClass::enforce_aligned_dimm > X-Mailer: git-send-email 2.41.0 > >

RE: [PATCH v5 5/7] migration/multifd: implement initialization of qpl compression

2024-03-27 Thread Liu, Yuan1
> -Original Message- > From: Peter Xu > Sent: Thursday, March 28, 2024 3:26 AM > To: Liu, Yuan1 > Cc: Daniel P. Berrangé ; faro...@suse.de; qemu- > de...@nongnu.org; hao.xi...@bytedance.com; bryan.zh...@bytedance.com; Zou, > Nanhai > Subject: Re: [PATCH v5 5/7] migration/multifd:

[PATCH v3 1/3] target/riscv: Add support for Zve32x extension

2024-03-27 Thread Jason Chien
Add support for Zve32x extension and replace some checks for Zve32f with Zve32x, since Zve32f depends on Zve32x. Signed-off-by: Jason Chien Reviewed-by: Frank Chang Reviewed-by: Max Chou Reviewed-by: Daniel Henrique Barboza --- target/riscv/cpu.c | 2 ++

[PATCH v3 2/3] target/riscv: Add support for Zve64x extension

2024-03-27 Thread Jason Chien
Add support for Zve64x extension. Enabling Zve64f enables Zve64x and enabling Zve64x enables Zve32x according to their dependency. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2107 Signed-off-by: Jason Chien Reviewed-by: Frank Chang Reviewed-by: Max Chou Reviewed-by: Daniel Henrique

[PATCH v3 3/3] target/riscv: Relax vector register check in RISCV gdbstub

2024-03-27 Thread Jason Chien
In current implementation, the gdbstub allows reading vector registers only if V extension is supported. However, all vector extensions and vector crypto extensions have the vector registers and they all depend on Zve32x. The gdbstub should check for Zve32x instead. Signed-off-by: Jason Chien

[PATCH v3 0/3] target/riscv: Support Zve32x and Zve64x extensions

2024-03-27 Thread Jason Chien
This patch series adds the support for Zve32x and Zvx64x and makes vector registers visible in GDB if any of the V/Zve*/Zvk* extensions is enabled. v2: Rebase onto riscv-to-apply.next (commit 385e575). v3: Spuash patch 2 into patch 1. Spuash patch 4 into patch 3. Jason Chien (3):

Re: [PATCH v6 2/2] memory tier: create CPUless memory tiers after obtaining HMAT info

2024-03-27 Thread Huang, Ying
"Ho-Ren (Jack) Chuang" writes: [snip] > @@ -655,6 +672,34 @@ void mt_put_memory_types(struct list_head *memory_types) > } > EXPORT_SYMBOL_GPL(mt_put_memory_types); > > +/* > + * This is invoked via `late_initcall()` to initialize memory tiers for > + * CPU-less memory nodes after driver

Re: [PATCH v2 2/2] target/riscv: Support xtheadmaee for thead-c906

2024-03-27 Thread Alistair Francis
On Wed, Mar 27, 2024 at 9:19 PM Conor Dooley wrote: > > Christoph linked here on his submission to Linux of a fix for this, so I > am reviving this to leave a couple comments :) > > On Thu, Feb 15, 2024 at 02:24:02PM +1000, Alistair Francis wrote: > > On Mon, Feb 5, 2024 at 6:37 PM Christoph

Re: [PATCH v3 48/49] hw/i386/sev: Use guest_memfd for legacy ROMs

2024-03-27 Thread Xiaoyao Li
On 3/21/2024 2:12 AM, Isaku Yamahata wrote: On Wed, Mar 20, 2024 at 03:39:44AM -0500, Michael Roth wrote: TODO: make this SNP-specific if TDX disables legacy ROMs in general TDX disables pc.rom, not disable isa-bios. IIRC, TDX doesn't need pc pflash. Not TDX doesn't need pc pflash, but

qemu process consumes 100% host CPU after reverting snapshot

2024-03-27 Thread Chun Feng Wu
Hi, I am testing throttle filter chain(multiple throttle-groups on disk) with the following steps: 1. start guest vm(chained throttle filters applied on disk per https://github.com/qemu/qemu/blob/master/docs/throttle.txt) 2. take snapshot 3. revert snapshot after step3, I noticed qemu

Re: [PATCH v1] coroutine: avoid inserting duplicate coroutine to co_queue_wakeup

2024-03-27 Thread Eric Blake
On Mon, Mar 25, 2024 at 11:50:41AM -0400, Stefan Hajnoczi wrote: > On Mon, Mar 25, 2024 at 05:18:50PM +0800, zhuyangyang wrote: > > If g_main_loop_run()/aio_poll() is called in the coroutine context, > > the pending coroutine may be woken up repeatedly, and the co_queue_wakeup > > may be

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-27 Thread Bernhard Beschow
Am 26. März 2024 13:29:58 UTC schrieb "Philippe Mathieu-Daudé" : >Hi Igor, > >On 26/3/24 14:08, Thomas Huth wrote: >> >> s/iaspc/isapc/ in the subject >> >> On 26/03/2024 13.51, Igor Mammedov wrote: >>> ISAPC machine was introduced 25 years ago and it's a lot of time since >>> such machine

Re: [PATCH v3] vfio/pci: migration: Skip config space check for Vendor Specific Information in VSC during restore/load

2024-03-27 Thread Alex Williamson
On Wed, 27 Mar 2024 16:11:37 -0400 "Michael S. Tsirkin" wrote: > On Wed, Mar 27, 2024 at 11:39:15AM -0600, Alex Williamson wrote: > > On Fri, 22 Mar 2024 12:12:10 +0530 > > Vinayak Kale wrote: > > > > > In case of migration, during restore operation, qemu checks config space > > > of the >

[PATCH 1/3] vvfat: Fix bug in writing to middle of file

2024-03-27 Thread Amjad Alsharafi
Before this commit, the behavior when calling `commit_one_file` for example with `offset=0x2000` (second cluster), what will happen is that we won't fetch the next cluster from the fat, and instead use the first cluster for the read operation. This is due to off-by-one error here, where `i=0x2000

[PATCH 3/3] ffvat: Fix reading files with non-continuous clusters

2024-03-27 Thread Amjad Alsharafi
When reading with `read_cluster` we get the `mapping` with `find_mapping_for_cluster` and then we call `open_file` for this mapping. The issue appear when its the same file, but a second cluster that is not immediately after it, imagine clusters `500 -> 503`, this will give us 2 mappings one has

[PATCH 0/3] vvfat: Fix bugs in writing and reading files

2024-03-27 Thread Amjad Alsharafi
These patches fix some bugs found when modifying files in vvfat. First, there was a bug when writing to the second+ cluster of a file, it will copy the cluster before it instead. Another issue was modifying the clusters of a file and adding new clusters, this showed 2 issues: - If the new

[PATCH 2/3] vvfat: Fix usage of `info.file.offset`

2024-03-27 Thread Amjad Alsharafi
The field is marked as "the offset in the file (in clusters)", but it was being used like this `cluster_size*(nums)+mapping->info.file.offset`, which is incorrect. Additionally, removed the `abort` when `first_mapping_index` does not match, as this matches the case when adding new clusters for

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-27 Thread Paolo Bonzini
Il mer 27 mar 2024, 14:09 Igor Mammedov ha scritto: > It's question of whether we are willing to do unthinkable, > i.e. to break QEMU <-> guest ABI for isapc case by removing > corresponding fwcfg entries. > It's not unthinkable since it's unversioned. we are loosing a chance to cleanup > QEMU

Re: [PATCH-for-9.1 v2 3/3] hw/timer: Remove the ALTERA_TIMER model

2024-03-27 Thread Richard Henderson
On 3/27/24 04:48, Philippe Mathieu-Daudé wrote: The ALTERA_TIMER was only used by Nios II machines, which have been removed. Since it has no direct user, remove it. Signed-off-by: Philippe Mathieu-Daudé --- hw/timer/altera_timer.c | 244

Re: [PATCH-for-9.1 v2 2/3] target/nios2: Remove the deprecated Nios II target

2024-03-27 Thread Richard Henderson
On 3/27/24 04:48, Philippe Mathieu-Daudé wrote: The Nios II target is deprecated since v8.2 in commit 9997771bc1 ("target/nios2: Deprecate the Nios II architecture"). Remove: - Buildsys / CI infra - User emulation - System emulation (10m50-ghrd & nios2-generic-nommu machines) - Tests Cc: Marek

Re: [PATCH v3] vfio/pci: migration: Skip config space check for Vendor Specific Information in VSC during restore/load

2024-03-27 Thread Michael S. Tsirkin
On Wed, Mar 27, 2024 at 11:39:15AM -0600, Alex Williamson wrote: > On Fri, 22 Mar 2024 12:12:10 +0530 > Vinayak Kale wrote: > > > In case of migration, during restore operation, qemu checks config space of > > the > > pci device with the config space in the migration stream captured during > >

Re: [PATCH v5 4/7] migration/multifd: add qpl compression method

2024-03-27 Thread Peter Xu
On Wed, Mar 20, 2024 at 12:45:24AM +0800, Yuan Liu wrote: > add the Query Processing Library (QPL) compression method > > Although both qpl and zlib support deflate compression, qpl will > only use the In-Memory Analytics Accelerator(IAA) for compression > and decompression, and IAA is not

Re: [PATCH-for-9.0? v2 1/3] fpu/softfloat: Remove mention of TILE-Gx target

2024-03-27 Thread Richard Henderson
On 3/27/24 04:48, Philippe Mathieu-Daudé wrote: TILE-Gx has been removed during the v6.0 release (see commit 2cc1a90166 "Remove deprecated target tilegx"), no need to mention it in the list of "supported targets". Signed-off-by: Philippe Mathieu-Daudé --- fpu/softfloat-specialize.c.inc | 2 +-

Re: [PATCH for-9.0 v3 0/2] qtest/virtio-9p-test.c: fix slow tests

2024-03-27 Thread Daniel Henrique Barboza
On 3/27/24 15:53, Christian Schoenebeck wrote: On Wednesday, March 27, 2024 3:20:09 PM CET Daniel Henrique Barboza wrote: Hi, In this new version we took a different approach after the discussions we had in [1]. The tests are now untouched, and we're addressing the root cause directly: the

[PATCH] block: Remove unnecessary NULL check in bdrv_pad_request()

2024-03-27 Thread Kevin Wolf
Coverity complains that the check introduced in commit 3f934817 suggests that qiov could be NULL and we dereference it before reaching the check. In fact, all of the callers pass a non-NULL pointer, so just remove the misleading check. Resolves: Coverity CID 1542668 Signed-off-by: Kevin Wolf ---

Re: [PATCH v5 5/7] migration/multifd: implement initialization of qpl compression

2024-03-27 Thread Peter Xu
On Fri, Mar 22, 2024 at 12:40:32PM -0400, Peter Xu wrote: > > > void multifd_recv_zero_page_process(MultiFDRecvParams *p) > > > { > > > for (int i = 0; i < p->zero_num; i++) { > > > void *page = p->host + p->zero[i]; > > > if (!buffer_is_zero(page, p->page_size)) { > > >

bdrv_pad_request() Coverity report

2024-03-27 Thread Stefan Hajnoczi
Hi Fiona, The Coverity static checker sent a report about commit 3f934817c82c ("block/io: accept NULL qiov in bdrv_pad_request"). Please take a look and send a follow-up patch, if necessary: *** CID 1542668: Null pointer dereferences (REVERSE_INULL) /builds/qemu-project/qemu/bloc k/io.c: 1733

Re: [PATCH for-9.0 v3 0/2] qtest/virtio-9p-test.c: fix slow tests

2024-03-27 Thread Christian Schoenebeck
On Wednesday, March 27, 2024 3:20:09 PM CET Daniel Henrique Barboza wrote: > Hi, > > In this new version we took a different approach after the discussions > we had in [1]. The tests are now untouched, and we're addressing the root > cause directly: the fact that we have a single temp dir for all

Re: [PATCH-for-9.0 v2] hw/i386/pc: Deprecate 64-bit CPUs on ISA-only PC machine

2024-03-27 Thread Philippe Mathieu-Daudé
On 27/3/24 18:29, Marcin Juszkiewicz wrote: W dniu 27.03.2024 o 17:54, Philippe Mathieu-Daudé pisze: diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 7b548519b5..345c35507f 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -208,6 +208,13 @@ is no

Re: [PATCH v2 3/5] target/riscv: Add support for Zve64x extension

2024-03-27 Thread Daniel Henrique Barboza
On 3/25/24 05:33, Jason Chien wrote: Add support for Zve64x extension. Enabling Zve64f enables Zve64x and enabling Zve64x enables Zve32x according to their dependency. Signed-off-by: Jason Chien Reviewed-by: Frank Chang Reviewed-by: Max Chou --- Reviewed-by: Daniel Henrique Barboza

Re: [PATCH v3] vfio/pci: migration: Skip config space check for Vendor Specific Information in VSC during restore/load

2024-03-27 Thread Alex Williamson
On Fri, 22 Mar 2024 12:12:10 +0530 Vinayak Kale wrote: > In case of migration, during restore operation, qemu checks config space of > the > pci device with the config space in the migration stream captured during save > operation. In case of config space data mismatch, restore operation is

Re: [PATCH v2 2/5] target/riscv: Expose Zve32x extension to users

2024-03-27 Thread Daniel Henrique Barboza
I think this patch should be squashed into patch 1. Patch 1 as is does nothing since there's no way of enabling the flag without this patch. Same thing with patch 4: I think it should be squashed into patch 3. Thanks, Daniel On 3/25/24 05:33, Jason Chien wrote: Signed-off-by: Jason Chien

Re: [PATCH v2 1/5] target/riscv: Add support for Zve32x extension

2024-03-27 Thread Daniel Henrique Barboza
On 3/25/24 05:33, Jason Chien wrote: Add support for Zve32x extension and replace some checks for Zve32f with Zve32x, since Zve32f depends on Zve32x. Signed-off-by: Jason Chien Reviewed-by: Frank Chang Reviewed-by: Max Chou --- Reviewed-by: Daniel Henrique Barboza

Re: [PATCH-for-9.0 v2] hw/i386/pc: Deprecate 64-bit CPUs on ISA-only PC machine

2024-03-27 Thread Marcin Juszkiewicz
W dniu 27.03.2024 o 17:54, Philippe Mathieu-Daudé pisze: diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst index 7b548519b5..345c35507f 100644 --- a/docs/about/deprecated.rst +++ b/docs/about/deprecated.rst @@ -208,6 +208,13 @@ is no longer packaged in any distro making it

Re: [PATCH-for-9.0 v2 16/19] hw/xen/xen_pt: Add missing license

2024-03-27 Thread Anthony PERARD
On Tue, Nov 14, 2023 at 03:38:12PM +0100, Philippe Mathieu-Daudé wrote: > Commit eaab4d60d3 ("Introduce Xen PCI Passthrough, qdevice") > introduced both xen_pt.[ch], but only added the license to > xen_pt.c. Use the same license for xen_pt.h. > > Suggested-by: David Woodhouse > Signed-off-by:

Re: [PATCH-for-9.0 v2 15/19] hw/xen: Reduce inclusion of 'cpu.h' to target-specific sources

2024-03-27 Thread Anthony PERARD
On Tue, Nov 14, 2023 at 03:38:11PM +0100, Philippe Mathieu-Daudé wrote: > We rarely need to include "cpu.h" in headers. Including it > 'taint' headers to be target-specific. Here only the i386/arm > implementations requires "cpu.h", so include it there and > remove from the

Re: [PATCH-for-9.1] target/nios2: Remove machines and system emulation

2024-03-27 Thread Philippe Mathieu-Daudé
On 27/3/24 16:39, Thomas Huth wrote: On 27/03/2024 15.15, Philippe Mathieu-Daudé wrote: On 27/3/24 14:19, Thomas Huth wrote: On 27/03/2024 13.45, Philippe Mathieu-Daudé wrote: On 27/3/24 13:35, Philippe Mathieu-Daudé wrote: Remove the Nios II machines and the system emulation code

Re: [PATCH v4 1/2] Refactor common functions between POSIX and Windows implementation

2024-03-27 Thread Philippe Mathieu-Daudé
On 27/3/24 17:24, aidan_le...@selinc.com wrote: From: aidaleuc Signed-off-by: aidaleuc --- qga/commands-common-ssh.c | 49 + qga/commands-common-ssh.h | 12 + qga/commands-posix-ssh.c | 51 +++

[PATCH-for-9.0 v2] hw/i386/pc: Deprecate 64-bit CPUs on ISA-only PC machine

2024-03-27 Thread Philippe Mathieu-Daudé
Per Daniel suggestion [*]: > isapc could arguably be restricted to just 32-bit CPU models, > because we should not need it to support any feature that didn't > exist prior to circa 1995. eg refuse to start with isapc, if 'lm' > is present in the CPU model for example. Display a warning when

Re: [RFC PATCH-for-9.0 v2 13/19] hw/xen: Remove use of 'target_ulong' in handle_ioreq()

2024-03-27 Thread Anthony PERARD
On Tue, Nov 14, 2023 at 03:38:09PM +0100, Philippe Mathieu-Daudé wrote: > Per commit f17068c1c7 ("xen-hvm: reorganize xen-hvm and move common > function to xen-hvm-common"), handle_ioreq() is expected to be > target-agnostic. However it uses 'target_ulong', which is a target > specific definition.

[PATCH v4 1/2] Refactor common functions between POSIX and Windows implementation

2024-03-27 Thread aidan_leuck
From: aidaleuc Signed-off-by: aidaleuc --- qga/commands-common-ssh.c | 49 + qga/commands-common-ssh.h | 12 + qga/commands-posix-ssh.c | 51 +++ qga/meson.build | 1 + 4 files changed, 65

[PATCH v4 0/2] Implement SSH commands in QEMU GA for Windows

2024-03-27 Thread aidan_leuck
From: aidaleuc This patch aims to implement guest-ssh-add-authorized-keys, guest-ssh-remove-authorized-keys, and guest-ssh-get-authorized-keys for Windows. This PR is based on Microsoft's OpenSSH implementation https://github.com/PowerShell/Win32-OpenSSH. The guest agents will support

[PATCH v4 2/2] Implement SSH commands in QEMU GA for Windows

2024-03-27 Thread aidan_leuck
From: aidaleuc Signed-off-by: aidaleuc --- qga/commands-windows-ssh.c | 789 + qga/commands-windows-ssh.h | 26 ++ qga/meson.build| 7 +- qga/qapi-schema.json | 17 +- 4 files changed, 827 insertions(+), 12 deletions(-) create mode

Re: [PATCH v3 2/2] Implement SSH commands in QEMU GA for Windows

2024-03-27 Thread Philippe Mathieu-Daudé
On 27/3/24 16:54, Aidan Leuck wrote: On 22/3/24 18:46, aidan_le...@selinc.com wrote: From: Aidan Leuck Signed-off-by: Aidan Leuck --- qga/commands-windows-ssh.c | 791 + Huge file, I'm skipping it. qga/commands-windows-ssh.h | 26 ++

Re: [PATCH 10/10] pnv/phb4: Mask off LSI Source-ID based on number of interrupts

2024-03-27 Thread Cédric Le Goater
On 3/27/24 10:59, Saif Abrar wrote: Hello Cedric,   }   +static void pnv_phb4_fund_A_reset(PnvPHB4 *phb) What is fund_A ? I used 'fund_A' as an abbreviation to "Fundamental Register Set A". Please let know if you suggest another abbreviation to name this method. pnv_phb4_reset_xsrc may

[PATCH-for-9.0] hw/i386/pc: Restrict CXL to PCI-based machines

2024-03-27 Thread Philippe Mathieu-Daudé
CXL is based on PCIe. In is pointless to initialize its context on non-PCI machines. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index e80f02bef4..5c21b0c4db 100644 --- a/hw/i386/pc.c

Re: [PATCH-for-9.0] hw/i386/pc: Deprecate 64-bit CPUs on ISA-only PC machine

2024-03-27 Thread Daniel P . Berrangé
On Wed, Mar 27, 2024 at 04:35:17PM +0100, Philippe Mathieu-Daudé wrote: > Per Daniel suggestion [*]: > > > isapc could arguably be restricted to just 32-bit CPU models, > > because we should not need it to support any feature that didn't > > exist prior to circa 1995. eg refuse to start with

RE: [PATCH v3 2/2] Implement SSH commands in QEMU GA for Windows

2024-03-27 Thread Aidan Leuck
-Original Message- From: Philippe Mathieu-Daudé Sent: Wednesday, March 27, 2024 9:38 AM To: Aidan Leuck ; qemu-devel@nongnu.org; Markus Armbruster Cc: kkost...@redhat.com; berra...@redhat.com Subject: Re: [PATCH v3 2/2] Implement SSH commands in QEMU GA for Windows [Caution -

Re: [PATCH for-9.1 v2 09/11] hostmem: add a new memory backend based on POSIX shm_open()

2024-03-27 Thread David Hildenbrand
So I thought that for now we only support the "anonymous" mode, and if in the future we have a use case where the user wants to specify the name, we can add it later. Okay, so for now you really only want an anonymous fd that behaves like a memfd, got it. Likely we should somehow fail if the

Re: [PATCH-for-9.0? v2 1/3] fpu/softfloat: Remove mention of TILE-Gx target

2024-03-27 Thread Thomas Huth
On 27/03/2024 15.48, Philippe Mathieu-Daudé wrote: TILE-Gx has been removed during the v6.0 release (see commit 2cc1a90166 "Remove deprecated target tilegx"), no need to mention it in the list of "supported targets". Signed-off-by: Philippe Mathieu-Daudé --- fpu/softfloat-specialize.c.inc |

Re: [PATCH for-9.1 v2 09/11] hostmem: add a new memory backend based on POSIX shm_open()

2024-03-27 Thread Stefano Garzarella
On Wed, Mar 27, 2024 at 12:51:51PM +0100, David Hildenbrand wrote: On 27.03.24 11:23, Stefano Garzarella wrote: On Tue, Mar 26, 2024 at 03:45:52PM +0100, David Hildenbrand wrote: +mode = 0; +oflag = O_RDWR | O_CREAT | O_EXCL; +backend_name = host_memory_backend_get_name(backend); +

Re: [PATCH-for-9.1] target/nios2: Remove machines and system emulation

2024-03-27 Thread Thomas Huth
On 27/03/2024 15.15, Philippe Mathieu-Daudé wrote: On 27/3/24 14:19, Thomas Huth wrote: On 27/03/2024 13.45, Philippe Mathieu-Daudé wrote: On 27/3/24 13:35, Philippe Mathieu-Daudé wrote: Remove the Nios II machines and the system emulation code (deprecated since v8.2 in commit 9997771bc1

Re: [PATCH v3 2/2] Implement SSH commands in QEMU GA for Windows

2024-03-27 Thread Philippe Mathieu-Daudé
On 27/3/24 15:38, Aidan Leuck wrote: Hi Philippe, Thank you for your feedback I will get these issues addressed. I left one small comment on the QAPI schema JSON. Aidan Leuck -Original Message- From: Philippe Mathieu-Daudé Sent: Monday, March 25, 2024 11:51 AM To: Aidan Leuck ;

[PATCH-for-9.0] hw/i386/pc: Deprecate 64-bit CPUs on ISA-only PC machine

2024-03-27 Thread Philippe Mathieu-Daudé
Per Daniel suggestion [*]: > isapc could arguably be restricted to just 32-bit CPU models, > because we should not need it to support any feature that didn't > exist prior to circa 1995. eg refuse to start with isapc, if 'lm' > is present in the CPU model for example. [*]

Re: [PATCH v3 21/49] i386/sev: Introduce "sev-common" type to encapsulate common SEV state

2024-03-27 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Mar 20, 2024 at 03:39:17AM -0500, Michael Roth wrote: >> Currently all SEV/SEV-ES functionality is managed through a single >> 'sev-guest' QOM type. With upcoming support for SEV-SNP, taking this >> same approach won't work well since some of the

Re: [PATCH for-9.0 v3 0/2] qtest/virtio-9p-test.c: fix slow tests

2024-03-27 Thread Greg Kurz
On Wed, 27 Mar 2024 11:20:09 -0300 Daniel Henrique Barboza wrote: > Hi, > > In this new version we took a different approach after the discussions > we had in [1]. The tests are now untouched, and we're addressing the root > cause directly: the fact that we have a single temp dir for all the

[PATCH-for-9.1 v2 0/3] target/nios2: Remove the deprecated Nios II target

2024-03-27 Thread Philippe Mathieu-Daudé
Since v1: - Remove user emulation too - Remove ALTERA_TIMER Philippe Mathieu-Daudé (3): fpu/softfloat: Remove mention of TILE-Gx target target/nios2: Remove the deprecated Nios II target hw/timer: Remove the ALTERA_TIMER model MAINTAINERS | 13 -

[PATCH-for-9.0? v2 1/3] fpu/softfloat: Remove mention of TILE-Gx target

2024-03-27 Thread Philippe Mathieu-Daudé
TILE-Gx has been removed during the v6.0 release (see commit 2cc1a90166 "Remove deprecated target tilegx"), no need to mention it in the list of "supported targets". Signed-off-by: Philippe Mathieu-Daudé --- fpu/softfloat-specialize.c.inc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH-for-9.1 v2 3/3] hw/timer: Remove the ALTERA_TIMER model

2024-03-27 Thread Philippe Mathieu-Daudé
The ALTERA_TIMER was only used by Nios II machines, which have been removed. Since it has no direct user, remove it. Signed-off-by: Philippe Mathieu-Daudé --- hw/timer/altera_timer.c | 244 hw/timer/Kconfig| 4 - hw/timer/meson.build| 1 -

RE: [PATCH v3 2/2] Implement SSH commands in QEMU GA for Windows

2024-03-27 Thread Aidan Leuck
Hi Philippe, Thank you for your feedback I will get these issues addressed. I left one small comment on the QAPI schema JSON. Aidan Leuck -Original Message- From: Philippe Mathieu-Daudé Sent: Monday, March 25, 2024 11:51 AM To: Aidan Leuck ; qemu-devel@nongnu.org Cc:

Re: [PATCH-for-9.1] rdma: Remove RDMA subsystem and pvrdma device

2024-03-27 Thread Fabiano Rosas
Philippe Mathieu-Daudé writes: > The whole RDMA subsystem was deprecated in commit e9a54265f5 > ("hw/rdma: Deprecate the pvrdma device and the rdma subsystem") > released in v8.2. Time to remove it. > > Keep the RAM_SAVE_FLAG_HOOK definition since it might appears > in old migration streams. > >

Re: [PATCH-for-9.0 v2 12/19] hw/xen: Merge 'hw/xen/arch_hvm.h' in 'hw/xen/xen-hvm-common.h'

2024-03-27 Thread Anthony PERARD
On Tue, Nov 14, 2023 at 03:38:08PM +0100, Philippe Mathieu-Daudé wrote: > We don't need a target-specific header for common target-specific > prototypes. Declare xen_arch_handle_ioreq() and xen_arch_set_memory() > in "hw/xen/xen-hvm-common.h". > > Signed-off-by: Philippe Mathieu-Daudé >

[PATCH for-9.0 v3 0/2] qtest/virtio-9p-test.c: fix slow tests

2024-03-27 Thread Daniel Henrique Barboza
Hi, In this new version we took a different approach after the discussions we had in [1]. The tests are now untouched, and we're addressing the root cause directly: the fact that we have a single temp dir for all the test execution in qos-test. We're now creating and cleaning temp dirs for each

[PATCH for-9.0 v3 1/2] qtest/virtio-9p-test.c: create/remove temp dirs after each test

2024-03-27 Thread Daniel Henrique Barboza
The local 9p driver in virtio-9p-test.c its temporary dir right at the start of qos-test (via virtio_9p_create_local_test_dir()) and only deletes it after qos-test is finished (via virtio_9p_remove_local_test_dir()). This means that any qos-test machine that ends up running virtio-9p-test local

[PATCH for-9.0 v3 2/2] qtest/virtio-9p-test.c: remove g_test_slow() gate

2024-03-27 Thread Daniel Henrique Barboza
Commit 558f5c42ef gated the local tests with g_test_slow() to skip them in 'make check'. The reported issue back then was this following CI problem: https://lists.nongnu.org/archive/html/qemu-devel/2020-11/msg05510.html This problem ended up being fixed after it was detected with the recently

Re: [PATCH-for-9.1 v2 10/21] hw/smbios: Remove 'uuid_encoded' argument from smbios_set_defaults()

2024-03-27 Thread Philippe Mathieu-Daudé
On 27/3/24 15:08, Zhao Liu wrote: On Wed, Mar 27, 2024 at 10:51:12AM +0100, Philippe Mathieu-Daudé wrote: Date: Wed, 27 Mar 2024 10:51:12 +0100 From: Philippe Mathieu-Daudé Subject: [PATCH-for-9.1 v2 10/21] hw/smbios: Remove 'uuid_encoded' argument from smbios_set_defaults() X-Mailer:

Re: [PATCH-for-9.1] target/nios2: Remove machines and system emulation

2024-03-27 Thread Philippe Mathieu-Daudé
On 27/3/24 14:19, Thomas Huth wrote: On 27/03/2024 13.45, Philippe Mathieu-Daudé wrote: On 27/3/24 13:35, Philippe Mathieu-Daudé wrote: Remove the Nios II machines and the system emulation code (deprecated since v8.2 in commit 9997771bc1 "target/nios2: Deprecate the Nios II architecture").

Re: [PATCH 6/9] i386/pc: Skip initialization of system FW when using IGVM

2024-03-27 Thread Roy Hopkins
On Wed, 2024-03-27 at 18:58 +0530, Ani Sinha wrote: > > > > On 27 Feb 2024, at 20:20, Roy Hopkins wrote: > > > > When using an IGVM file the configuration of the system firmware is > > defined by IGVM directives contained in the file. Therefore the default > > system firmware should not be

Re: [PATCH-for-9.0? v2 4/4] meson: Enable -Wstatic-in-inline

2024-03-27 Thread Paolo Bonzini
Il mer 27 mar 2024, 13:42 Philippe Mathieu-Daudé ha scritto: > IIUC your comment, you are worried about system headers declaring > non-static inline functions? > No, it's just that the flag (and thus the patch) is not doing what the commit message says. Perhaps you could instead add a

Re: [PATCH-for-9.1 v2 11/21] hw/smbios: Remove 'smbios_uuid_encoded', simplify smbios_encode_uuid()

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:13AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:13 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 11/21] hw/smbios: Remove 'smbios_uuid_encoded', > simplify smbios_encode_uuid() > X-Mailer: git-send-email 2.41.0 > >

Re: [PATCH-for-9.1 v2 10/21] hw/smbios: Remove 'uuid_encoded' argument from smbios_set_defaults()

2024-03-27 Thread Zhao Liu
On Wed, Mar 27, 2024 at 10:51:12AM +0100, Philippe Mathieu-Daudé wrote: > Date: Wed, 27 Mar 2024 10:51:12 +0100 > From: Philippe Mathieu-Daudé > Subject: [PATCH-for-9.1 v2 10/21] hw/smbios: Remove 'uuid_encoded' argument > from smbios_set_defaults() > X-Mailer: git-send-email 2.41.0 > >

Re: [PATCH for-9.0] docs/about: Mark the iaspc machine type as deprecated

2024-03-27 Thread Daniel P . Berrangé
On Tue, Mar 26, 2024 at 02:29:58PM +0100, Philippe Mathieu-Daudé wrote: > Hi Igor, > > On 26/3/24 14:08, Thomas Huth wrote: > > > > s/iaspc/isapc/ in the subject > > > > On 26/03/2024 13.51, Igor Mammedov wrote: > > > ISAPC machine was introduced 25 years ago and it's a lot of time since > > >

Re: [PATCH-for-9.1 v2 09/21] hw/i386/pc: Remove PCMachineClass::smbios_uuid_encoded

2024-03-27 Thread Zhao Liu
> Since this parameter is always ture, then we can drop it and further > clean up the static flag "smbios_uuid_encoded" in hw/smbios/smbios.c. Oops, my email didn't sync up well, the next two patches were doing just that. Thanks, Zhao

Re: [PATCH net v2 2/2] virtio_net: Do not send RSS key if it is not supported

2024-03-27 Thread Breno Leitao
On Wed, Mar 27, 2024 at 10:27:58AM +0800, Heng Qi wrote: > > > 在 2024/3/26 下午11:19, Breno Leitao 写道: > > There is a bug when setting the RSS options in virtio_net that can break > > the whole machine, getting the kernel into an infinite loop. > > > > Running the following command in any QEMU

  1   2   3   >