Re: [Qemu-devel] [PATCH qom-cpu v3 4/9] cpu: Turn cpu_paging_enabled() into a CPUState hook

2013-06-05 Thread Andreas Färber
Am 31.05.2013 15:33, schrieb Luiz Capitulino: On Thu, 30 May 2013 17:07:56 +0200 Andreas Färber afaer...@suse.de wrote: Signed-off-by: Andreas Färber afaer...@suse.de Nitpick alarm on. Very welcome :) --- include/qom/cpu.h | 10 ++ include/sysemu

Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize

2013-06-05 Thread Andreas Färber
Am 05.06.2013 14:36, schrieb Michael S. Tsirkin: Anyway, my point was, when moving stuff out of exit, we should also change the signature to the new one - DeviceState* and (unused) Error**. Then we're getting closer to removing the old exit field, and at that point renaming individual hooks -

Re: [Qemu-devel] [PATCH 1/2] tcg-arm: Implement tcg_register_jit

2013-06-05 Thread Andreas Färber
Am 05.06.2013 14:49, schrieb Richard Henderson: On 06/04/2013 06:56 PM, li guang wrote: +typedef struct { +uint32_t len __attribute__((aligned((sizeof(void *); +uint32_t cie_offset; +tcg_target_long func_start __attribute__((packed)); +tcg_target_long func_len

Re: [Qemu-devel] [PATCH qom-cpu v3 6/9] cpu: Turn cpu_get_memory_mapping() into a CPUState hook

2013-06-05 Thread Andreas Färber
Am 31.05.2013 15:48, schrieb Luiz Capitulino: On Thu, 30 May 2013 17:07:58 +0200 Andreas Färber afaer...@suse.de wrote: Signed-off-by: Andreas Färber afaer...@suse.de --- include/qom/cpu.h | 11 +++ include/sysemu/memory_mapping.h | 2 -- memory_mapping-stub.c

Re: [Qemu-devel] [PATCH qom-cpu 00/15 v8] target-i386: convert CPU features into properties, part 1

2013-06-05 Thread Andreas Färber
Am 05.06.2013 15:18, schrieb Igor Mammedov: It's a rebase of v7 on current qom-cpu tree, since then some patches from it were applied to master. Convertion of feature bits is left for part 2 since it's not ready yet. v7-v8: * split out dynamic properties convertion patch into per property

Re: [Qemu-devel] [PATCH qom-cpu v3 9/9] memory_mapping: Change qemu_get_guest_memory_mapping() semantics

2013-06-05 Thread Andreas Färber
Am 31.05.2013 16:14, schrieb Luiz Capitulino: On Thu, 30 May 2013 17:08:01 +0200 Andreas Färber afaer...@suse.de wrote: Previously it would search for the first CPU with paging enabled and retrieve memory mappings from this and any following CPUs or return an error if that fails. Instead

Re: [Qemu-devel] [PATCH qom-cpu 00/15 v8] target-i386: convert CPU features into properties, part 1

2013-06-05 Thread Andreas Färber
Am 05.06.2013 16:39, schrieb Igor Mammedov: On Wed, 05 Jun 2013 15:29:08 +0200 Andreas Färber afaer...@suse.de wrote: Am 05.06.2013 15:18, schrieb Igor Mammedov: It's a rebase of v7 on current qom-cpu tree, since then some patches from it were applied to master. Convertion of feature bits

Re: [Qemu-devel] [PATCH qom-cpu 00/15 v8] target-i386: convert CPU features into properties, part 1

2013-06-05 Thread Andreas Färber
Am 05.06.2013 19:17, schrieb Eduardo Habkost: On Wed, Jun 05, 2013 at 07:04:59PM +0200, Andreas Färber wrote: Am 05.06.2013 16:39, schrieb Igor Mammedov: On Wed, 05 Jun 2013 15:29:08 +0200 Andreas Färber afaer...@suse.de wrote: Why is conversion of dynamic properties to static properties

Re: [Qemu-devel] kFreeBSD and USB support

2013-06-05 Thread Andreas Färber
Am 05.06.2013 22:17, schrieb Michael Tokarev: Hello. On debian we, for a long time, used the following hack in a build script of qemu: # Hack alert. qemu-1.3 still needs this. # On recent kFreebsd, old USB host API has been removed, # but qemu did not learn to use new USB API. # Just

Re: [Qemu-devel] [PATCH v2 1/2] audio/intel-hda: Fix Inheritance hierachy

2013-06-06 Thread Andreas Färber
implementation functions. Went for option B, with a common base class. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Looks fine, Reviewed-by: Andreas Färber afaer...@suse.de Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer

Re: [Qemu-devel] [PATCH v2 2/2] audio/intel-hda: QOM casting sweep

2013-06-06 Thread Andreas Färber
Am 06.06.2013 07:34, schrieb peter.crosthwa...@xilinx.com: From: Peter Crosthwaite peter.crosthwa...@xilinx.com Define and use standard QOM cast macro. Remove usages of DO_UPCAST and direct - style casting. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Reviewed-by: Andreas

Re: [Qemu-devel] [PATCH v2] e600 core for MPC86xx processors

2013-06-06 Thread Andreas Färber
Am 26.05.2013 19:41, schrieb Julio Guerra: MPC86xx processors are based on the e600 core, which is not the case in qemu where it is based on the 7400 processor. This patch creates the e600 core and instantiates the MPC86xx processors based on it. Therefore, adding the high BATs and the SPRG

[Qemu-devel] [PATCH v5 1/5] usb/hcd-ehci-sysbus: Convert to QOM realize

2013-06-06 Thread Andreas Färber
initialization code as well. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/usb/hcd-ehci-pci.c| 2 +- hw/usb/hcd-ehci-sysbus.c | 13 ++--- hw/usb/hcd-ehci.c| 2 +- hw/usb/hcd-ehci.h| 2 +- 4 files changed, 9 insertions(+), 10 deletions(-) diff --git a/hw/usb

[Qemu-devel] [PATCH v5 4/5] usb/hcd-ehci: Replace PORTSC macros with variables

2013-06-06 Thread Andreas Färber
From: Kuo-Jung Su dant...@faraday-tech.com Replace PORTSC macros with variables which could then be configured in ehci__class_init(...) Signed-off-by: Kuo-Jung Su dant...@faraday-tech.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/usb/hcd-ehci-pci.c| 2 ++ hw/usb/hcd-ehci

[Qemu-devel] [PATCH v5 2/5] usb/hcd-ehci: Split off instance_init from realize

2013-06-06 Thread Andreas Färber
This makes the mem MemoryRegion available to derived instance_inits. Keep the bus in realize for now since naming breaks in instance_init. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/usb/hcd-ehci-pci.c| 19 ++- hw/usb/hcd-ehci-sysbus.c | 16 +--- hw/usb

[Qemu-devel] [PATCH v5 3/5] usb/hcd-ehci: Add Tegra2 SysBus EHCI device

2013-06-06 Thread Andreas Färber
From: Andreas Färber andreas.faer...@web.de This prepares an EHCI device for the Nvidia Tegra2 SoC family. Values based on patch by Vincent Palatin and verified against TRM v01p. Cc: Vincent Palatin vpala...@chromium.org Signed-off-by: Andreas Färber andreas.faer...@web.de --- hw/usb/hcd-ehci

[Qemu-devel] [PATCH v5 0/5] usb: QOM realize support for SysBus EHCI and FUSBH200

2013-06-06 Thread Andreas Färber
-tech.com Cc: Peter Crosthwaite peter.crosthwa...@xilinx.com Cc: Igor Mitsyanko i.mitsya...@samsung.com Cc: Liming Wang walimis...@gmail.com Andreas Färber (3): usb/hcd-ehci-sysbus: Convert to QOM realize usb/hcd-ehci: Split off instance_init from realize usb/hcd-ehci: Add Tegra2 SysBus EHCI

[Qemu-devel] [PATCH v5 5/5] usb/hcd-ehci: Add Faraday FUSBH200 support

2013-06-06 Thread Andreas Färber
From: Kuo-Jung Su dant...@faraday-tech.com Add Faraday FUSBH200 support, which is slightly different from EHCI spec. (Or maybe simply a bad/wrong implementation...) Signed-off-by: Kuo-Jung Su dant...@faraday-tech.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/usb/hcd-ehci-sysbus.c

Re: [Qemu-devel] [PATCH] fix Coverity scan SIGN_EXTENSION error

2013-06-06 Thread Andreas Färber
Am 06.06.2013 17:12, schrieb Gerd Hoffmann: Cc: Markus Armbruster arm...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com Please indicate in the subject that this is about qxl when queuing. :) Cheers, Andreas --- hw/display/qxl-render.c |2 +- 1 file changed, 1 insertion(+),

Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize

2013-06-07 Thread Andreas Färber
Am 07.06.2013 03:03, schrieb Paolo Bonzini: Il 05/06/2013 05:50, Andreas Färber ha scritto: Also I notice some patches are accessing parent fields directly - please use BUS(), PCI_DEVICE() etc. to hide this. I'm always using them. For example: +static void intel_hda_instance_finalize

Re: [Qemu-devel] [PATCH 01/39] scsi: keep device alive while it has requests

2013-06-07 Thread Andreas Färber
Am 04.06.2013 20:51, schrieb Paolo Bonzini: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi/scsi-bus.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c index 53ea906..e443193 100644 --- a/hw/scsi/scsi-bus.c +++

Re: [Qemu-devel] [PATCH 02/39] dma: keep a device alive while it has SGLists

2013-06-07 Thread Andreas Färber
Am 04.06.2013 20:51, schrieb Paolo Bonzini: A QEMUSGList has a reference to a device's address space. Keep the device alive while the QEMUSGList exists. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- dma-helpers.c | 6 +- hw/ide/ahci.c | 3 ++- hw/ide/macio.c

Re: [Qemu-devel] [PATCH 39/39] tpm: move add/del_subregion to realize/unrealize

2013-06-07 Thread Andreas Färber
Am 04.06.2013 20:52, schrieb Paolo Bonzini: Only do init/destroy in instance_init/finalize. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/tpm/tpm_tis.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c index

[Qemu-devel] [PATCH v2 07/12] i8259: QOM'ify some more

2013-06-07 Thread Andreas Färber
Introduce type constant. Prepares for PIC realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/intc/i8259.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/hw/intc/i8259.c b/hw/intc/i8259.c index fef00fc..1b513ff 100644 --- a/hw/intc

[Qemu-devel] [PATCH v2 09/12] i8259: Convert PICCommonState to use QOM realizefn

2013-06-07 Thread Andreas Färber
Instead of having the parent provide PICCommonClass::init, let the children override DeviceClass::realize themselves. This pushes the responsibility of saving and calling the parent's realizefn to the children. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i386/kvm/i8259.c

[Qemu-devel] [PATCH v2 04/12] i8254: QOM'ify some more

2013-06-07 Thread Andreas Färber
Introduce type constant and avoid DO_UPCAST(). Prepares for PIT realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/timer/i8254.c | 4 ++-- include/hw/timer/i8254.h | 18 +++--- 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/hw/timer/i8254.c b

[Qemu-devel] [PATCH v2 11/12] isa: QOM'ify ISADevice

2013-06-07 Thread Andreas Färber
Rename its parent field and use DEVICE() where necessary. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/block/fdc.c | 16 +--- hw/char/serial-isa.c | 14 -- hw/i386/pc.c | 9 + hw/i386/pc_piix.c| 2 +- hw/intc

[Qemu-devel] [PATCH v2 08/12] kvm/i8259: QOM'ify some more

2013-06-07 Thread Andreas Färber
Introduce type constant. Prepares for PIC realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i386/kvm/i8259.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/hw/i386/kvm/i8259.c b/hw/i386/kvm/i8259.c index d961eca..0bfbe34 100644 --- a/hw/i386/kvm/i8259

[Qemu-devel] [PATCH v2 01/12] gus: QOM'ify some more

2013-06-07 Thread Andreas Färber
Add type constant and cast macro. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/audio/gus.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/audio/gus.c b/hw/audio/gus.c index a91921c..e0aea26 100644 --- a/hw/audio/gus.c +++ b/hw/audio/gus.c @@ -46,6 +46,9

[Qemu-devel] [PATCH v2 12/12] qdev: Drop FROM_QBUS() macro

2013-06-07 Thread Andreas Färber
Use QOM cast macros I2C_BUS(), SSI_BUS(), PCI_BUS() instead. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i2c/core.c | 4 ++-- hw/pci/pci.c | 2 +- hw/ssi/ssi.c | 2 +- include/hw/qdev-core.h | 2 -- 4 files changed, 4 insertions(+), 6 deletions(-) diff

[Qemu-devel] [PATCH v2 02/12] cs4231a: QOM'ify some more

2013-06-07 Thread Andreas Färber
Introduce type constant and cast macro. Replace reset hook with DeviceClass::reset callback. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/audio/cs4231a.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/hw/audio/cs4231a.c b/hw/audio/cs4231a.c index

[Qemu-devel] [PATCH v2 10/12] isa: QOM'ify ISABus

2013-06-07 Thread Andreas Färber
Rename its parent field and use ISA_BUS() where necessary. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/isa/i82378.c | 2 +- hw/isa/isa-bus.c | 8 hw/isa/piix4.c | 2 +- hw/isa/vt82c686.c| 2 +- hw/ppc/prep.c| 2 +- hw/sparc64/sun4u.c | 3

[Qemu-devel] [PATCH v2 05/12] kvm/i8254: QOM'ify some more

2013-06-07 Thread Andreas Färber
Introduce type constant and cast macro to obsolete DO_UPCAST(). Prepares for PIT realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i386/kvm/i8254.c | 19 +++ include/hw/timer/i8254.h | 13 - 2 files changed, 19 insertions(+), 13 deletions(-) diff

[Qemu-devel] [PATCH v2 03/12] isa: Use realizefn for ISADevice

2013-06-07 Thread Andreas Färber
Drop ISADeviceClass::init and the resulting no-op initfn and let children implement their own realizefn. Adapt error handling. Split off an instance_init where sensible. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/audio/adlib.c | 23 +++ hw/audio/cs4231a.c

[Qemu-devel] [PATCH v2 06/12] i8254: Convert PITCommonState to QOM realizefn

2013-06-07 Thread Andreas Färber
Instead of having the parent provide PITCommonClass::init, let the children override DeviceClass::realize themselves. This pushes the responsibility for saving and calling the parent's realizefn to the children. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i386/kvm/i8254.c

Re: [Qemu-devel] [PATCH v2 00/12] QOM realize for ISA, part 2

2013-06-07 Thread Andreas Färber
Am 07.06.2013 14:58, schrieb Andreas Färber: Cc: malc av1...@comtv.ru FWIW should be av1474, but either one bounces. ;) Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

[Qemu-devel] [PATCH v2 00/12] QOM realize for ISA, part 2

2013-06-07 Thread Andreas Färber
: malc av1...@comtv.ru Cc: Hu Tao hu...@cn.fujitsu.com Cc: Michael S. Tsirkin m...@redhat.com Cc: Peter C. Crosthwaite peter.crosthwa...@xilinx.com Andreas Färber (12): gus: QOM'ify some more cs4231a: QOM'ify some more isa: Use realizefn for ISADevice i8254: QOM'ify some more kvm/i8254

Re: [Qemu-devel] [PATCH 00/39] Delay destruction of memory regions to instance_finalize

2013-06-07 Thread Andreas Färber
Hi Peter, Am 07.06.2013 10:41, schrieb Peter Crosthwaite: I have a series that fixes all qom cast macros for all PCI devices tree wide. Can post. Qom cast macros added as needed. Sounds promising! I just CC'ed you on my ISA series v2, which touches on PCI_BUS() in the final patch, dropping

Re: [Qemu-devel] [PATCH 5/5] trace-events: Fix up source file comments

2013-06-07 Thread Andreas Färber
Am 07.06.2013 12:59, schrieb Markus Armbruster: They're all wrong since (at least) Paolo's big source tree reorganization. Need to shuffle some event declarations around to keep them under the correct source file comment. Signed-off-by: Markus Armbruster arm...@redhat.com ---

[Qemu-devel] [PATCH RFT 4/5] virtio-console: Use exitfn for virtserialport, too

2013-06-07 Thread Andreas Färber
virtconsole and virtserialport are identical in every other aspect except for the distinguishing VirtIOSerialPortClass::is_console field. Cc: qemu-sta...@nongnu.org Signed-off-by: Andreas Färber afaer...@suse.de --- hw/char/virtio-console.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw

[Qemu-devel] [PATCH RFT 1/5] virtio-blk-dataplane: Improve error reporting

2013-06-07 Thread Andreas Färber
Return an Error so that it can be propagated later. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/block/dataplane/virtio-blk.c | 25 + hw/block/dataplane/virtio-blk.h | 5 +++-- hw/block/virtio-blk.c | 8 +++- 3 files changed, 23 insertions(+), 15

[Qemu-devel] [PATCH RFT 2/5] virtio: Convert VirtioDevice to QOM realize/unrealize

2013-06-07 Thread Andreas Färber
the SCSIBus and initializing /dev/vhost-scsi respectively. While at it, drop duplicate VIRTIO_DEVICE() casts and avoid qdev. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/9pfs/virtio-9p-device.c | 67 -- hw/9pfs/virtio-9p.h| 13 ++ hw/block

[Qemu-devel] [PATCH RFT 0/5] QOM realize for virtio

2013-06-07 Thread Andreas Färber
Konrad fred.kon...@greensocs.com Andreas Färber (5): virtio-blk-dataplane: Improve error reporting virtio: Convert VirtioDevice to QOM realize/unrealize virtio-console: QOM'ify VirtConsole virtio-console: Use exitfn for virtserialport, too virtio-serial-port: Convert to QOM realize

[Qemu-devel] [PATCH RFT 3/5] virtio-console: QOM'ify VirtConsole

2013-06-07 Thread Andreas Färber
Introduce type constant, cast macro and rename parent field. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/char/virtio-console.c | 33 - 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/hw/char/virtio-console.c b/hw/char/virtio-console.c

[Qemu-devel] [PATCH RFT 5/5] virtio-serial-port: Convert to QOM realize/unrealize

2013-06-07 Thread Andreas Färber
Note: virtconsole's/virtserialport's realizefn now registers its handlers before VirtIOSerialPort's realizefn. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/char/virtio-console.c | 71 --- hw/char/virtio-serial-bus.c | 45

Re: [Qemu-devel] [PATCH 0/2] gdbstub runstate check follow-ups

2013-06-07 Thread Andreas Färber
resume from guest panicked state Tested-by: Andreas Färber afaer...@suse.de Andreas gdbstub.c | 5 - vl.c | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB

Re: [Qemu-devel] [PATCH RFT 2/5] virtio: Convert VirtioDevice to QOM realize/unrealize

2013-06-08 Thread Andreas Färber
Hi, Am 08.06.2013 04:22, schrieb Peter Crosthwaite: On Sat, Jun 8, 2013 at 4:18 AM, Andreas Färber afaer...@suse.de wrote: diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.c index dc6f4e4..409d315 100644 --- a/hw/9pfs/virtio-9p-device.c +++ b/hw/9pfs/virtio-9p-device.c

Re: [Qemu-devel] [PATCH] pseries: Support for in-kernel XICS interrupt controller

2013-06-08 Thread Andreas Färber
Am 05.06.2013 09:39, schrieb Alexey Kardashevskiy: From: David Gibson da...@gibson.dropbear.id.au Recent (host) kernels support emulating the PAPR defined XICS interrupt controller system within KVM. This patch allows qemu to initialize and configure the in-kernel XICS, and keep its state

Re: [Qemu-devel] [PATCH 03/13] target-ppc: Convert ppc cpu savevm to VMStateDescription

2013-06-08 Thread Andreas Färber
Am 04.06.2013 14:20, schrieb Alexey Kardashevskiy: Author: David Gibson da...@gibson.dropbear.id.au From: The savevm code for the powerpc cpu emulation is currently based around the old register_savevm() rather than register_vmstate() method. It's also rather broken, missing some

Re: [Qemu-devel] [PATCH] pseries: Support for in-kernel XICS interrupt controller

2013-06-08 Thread Andreas Färber
Am 08.06.2013 16:11, schrieb Alexey Kardashevskiy: On 06/08/2013 08:20 PM, Andreas Färber wrote: Am 05.06.2013 09:39, schrieb Alexey Kardashevskiy: From: David Gibson da...@gibson.dropbear.id.au Recent (host) kernels support emulating the PAPR defined XICS interrupt controller system within

Re: [Qemu-devel] [PATCH 5/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Introduce post-cpu-init function

2013-06-08 Thread Andreas Färber
Am 07.06.2013 19:28, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com In preparation for treating cpus as devices CPUs *are* devices since multiple releases now, so this is badly put. we need to separate machine initialization into two stages: 1. Initialization that needs

Re: [Qemu-devel] [PATCH 7/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Infrastructure for Cpu Devices

2013-06-08 Thread Andreas Färber
Hi, Am 07.06.2013 19:28, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com Add infrastructure for treating cpus as devices. This patch allows cpus to be specified using a combination of '-smp' and '-device cpu'. This approach forces a change in the way cpus are counted via

Re: [Qemu-devel] [PATCH 8/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Treat S390 cpus as devices

2013-06-08 Thread Andreas Färber
Am 07.06.2013 19:28, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com Modify cpu initialization and QOM routines associated with s390-cpu such that all cpus on S390 are now created via the QOM device creation code path. Signed-off-by: Jason J. Herne jjhe...@us.ibm.com ---

[Qemu-devel] [PATCH qom-cpu v4 02/18] pc: Fix crash when attempting to hotplug CPU with negative ID

2013-06-09 Thread Andreas Färber
) and maxcpus is already checked, add check for lower bound and error out on incorrect value. Signed-off-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i386/pc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 4844a6b

[Qemu-devel] [PATCH qom-cpu v4 06/18] target-i386: cpu: Fix potential buffer overrun in get_register_name_32()

2013-06-09 Thread Andreas Färber
by: Jesse Larrew jlar...@linux.vnet.ibm.com Signed-off-by: Andreas Färber afaer...@suse.de --- target-i386/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index 762baad..4b2da0d 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -221,7

[Qemu-devel] [PATCH qom-cpu v4 08/18] memory_mapping: Move MemoryMappingList typedef to qemu/typedefs.h

2013-06-09 Thread Andreas Färber
This will avoid issues with hwaddr and ram_addr_t when including sysemu/memory_mapping.h for CONFIG_USER_ONLY. Signed-off-by: Andreas Färber afaer...@suse.de --- include/qemu/typedefs.h | 2 ++ include/sysemu/memory_mapping.h | 5 +++-- 2 files changed, 5 insertions(+), 2 deletions

[Qemu-devel] [PATCH qom-cpu v4 03/18] pc: Create pc-*-1.6 machine-types

2013-06-09 Thread Andreas Färber
From: Eduardo Habkost ehabk...@redhat.com Some CPU model fixes are going to be included and they will require compatibility properties in the pc-*-1.5 machine-types. Signed-off-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Andreas Färber

[Qemu-devel] [PATCH qom-cpu v4 01/18] dump: Move stubs into libqemustub.a

2013-06-09 Thread Andreas Färber
This allows us to drop CONFIG_NO_CORE_DUMP with its indirect dependency on CONFIG_HAVE_CORE_DUMP. Acked-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de --- Makefile.target | 2 -- stubs/Makefile.objs | 1 + dump-stub.c = stubs/dump.c | 0

[Qemu-devel] [PATCH qom-cpu v4 14/18] dump: Abstract dump_init() with cpu_synchronize_all_states()

2013-06-09 Thread Andreas Färber
Instead of calling cpu_synchronize_state() for each CPU, call the existing cpu_synchronize_all_states() helper. Signed-off-by: Andreas Färber afaer...@suse.de --- dump.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/dump.c b/dump.c index b44dafc..44a1339 100644

[Qemu-devel] [PATCH qom-cpu v4 12/18] cpu: Change default for CPUClass::get_paging_enabled()

2013-06-09 Thread Andreas Färber
map by default. Signed-off-by: Andreas Färber afaer...@suse.de --- qom/cpu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qom/cpu.c b/qom/cpu.c index b25fbc9..dba4a11 100644 --- a/qom/cpu.c +++ b/qom/cpu.c @@ -59,7 +59,7 @@ bool cpu_paging_enabled(const CPUState *cpu

[Qemu-devel] [PATCH qom-cpu v4 04/18] target-i386: Update model values on Conroe/Penryn/Nehalem CPU models

2013-06-09 Thread Andreas Färber
imamm...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/i386/pc_piix.c| 4 hw/i386/pc_q35.c | 4 include/hw/i386/pc.h | 16 target-i386/cpu.c| 6 +++--- 4 files changed, 27 insertions(+), 3 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw

[Qemu-devel] [PATCH qom-cpu v4 09/18] cpu: Turn cpu_get_memory_mapping() into a CPUState hook

2013-06-09 Thread Andreas Färber
Change error reporting from return value to Error argument. Signed-off-by: Andreas Färber afaer...@suse.de --- include/qom/cpu.h | 14 ++ include/sysemu/memory_mapping.h | 2 -- memory_mapping-stub.c | 6 -- memory_mapping.c | 7

[Qemu-devel] [PATCH qom-cpu v4 05/18] target-i386: Set level=4 on Conroe/Penryn/Nehalem

2013-06-09 Thread Andreas Färber
Signed-off-by: Eduardo Habkost ehabk...@redhat.com Reviewed-by: Igor Mammedov imamm...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de --- include/hw/i386/pc.h | 12 target-i386/cpu.c| 6 +++--- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/include/hw

[Qemu-devel] [PATCH qom-cpu v4 13/18] memory_mapping: Cleanup qemu_get_guest_memory_mapping()

2013-06-09 Thread Andreas Färber
() and have it actually stop on errors. Whether it is unsupported on a certain CPU can be checked by looking for a NULL CPUClass::get_memory_mapping field. Signed-off-by: Andreas Färber afaer...@suse.de --- dump.c | 7 +- include/sysemu/memory_mapping.h | 8

[Qemu-devel] [PATCH qom-cpu v4 07/18] cpu: Turn cpu_paging_enabled() into a CPUState hook

2013-06-09 Thread Andreas Färber
Relocate assignment of x86 get_arch_id to have all hooks in one place. Signed-off-by: Andreas Färber afaer...@suse.de --- include/qom/cpu.h | 10 ++ include/sysemu/memory_mapping.h | 1 - memory_mapping-stub.c | 6 -- memory_mapping.c

[Qemu-devel] [PATCH qom-cpu v4 18/18] memory_mapping: Build only once

2013-06-09 Thread Andreas Färber
Move RAMBlock, RAMList and ram_list to exec/cpu-common.h since they do not depend on CPUArchState. We can then use it together with qom/cpu.h to replace cpu.h and exec/cpu-all.h includes, making it fully target-independent. Signed-off-by: Andreas Färber afaer...@suse.de --- Makefile.objs

[Qemu-devel] [PATCH qom-cpu v4 15/18] dump: Abstract dump_init() further with qemu_for_each_cpu()

2013-06-09 Thread Andreas Färber
Allows to drop CPUArchState variable. Signed-off-by: Andreas Färber afaer...@suse.de --- dump.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/dump.c b/dump.c index 44a1339..4e6b855 100644 --- a/dump.c +++ b/dump.c @@ -702,10 +702,16 @@ static ram_addr_t

[Qemu-devel] [PATCH qom-cpu v4 16/18] dump: Abstract write_elf{64, 32}_notes() with qemu_for_each_cpu()

2013-06-09 Thread Andreas Färber
Removes the last use of CPUArchState. Signed-off-by: Andreas Färber afaer...@suse.de --- dump.c | 133 +++-- 1 file changed, 97 insertions(+), 36 deletions(-) diff --git a/dump.c b/dump.c index 4e6b855..d3cb8e2 100644 --- a/dump.c

Re: [Qemu-devel] [PATCH qom-cpu v4 00/18] dump: Build cleanups, redone

2013-06-09 Thread Andreas Färber
Am 09.06.2013 18:10, schrieb Andreas Färber: Andreas Färber (13): dump: Move stubs into libqemustub.a [...] Eduardo Habkost (3): pc: Create pc-*-1.6 machine-types target-i386: Update model values on Conroe/Penryn/Nehalem CPU models target-i386: Set level=4 on Conroe/Penryn/Nehalem

[Qemu-devel] [PATCH qom-cpu v4 17/18] memory_mapping: Use hwaddr type for MemoryMapping virt_addr field

2013-06-09 Thread Andreas Färber
The memory mapping API uses hwaddr, so use it in the struct, too. This avoids a header dependency on target_ulong type. Cc: Wen Congyang we...@cn.fujitsu.com Signed-off-by: Andreas Färber afaer...@suse.de --- include/sysemu/memory_mapping.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[Qemu-devel] [PATCH qom-cpu v4 00/18] dump: Build cleanups, redone

2013-06-09 Thread Andreas Färber
Capitulino lcapitul...@redhat.com Andreas Färber (13): dump: Move stubs into libqemustub.a cpu: Turn cpu_paging_enabled() into a CPUState hook memory_mapping: Move MemoryMappingList typedef to qemu/typedefs.h cpu: Turn cpu_get_memory_mapping() into a CPUState hook memory_mapping: Drop

[Qemu-devel] [PATCH qom-cpu v4 11/18] dump: Drop qmp_dump_guest_memory() stub and build for all targets

2013-06-09 Thread Andreas Färber
CONFIG_HAVE_CORE_DUMP and leave configure completely out of the picture for target CPU features. Signed-off-by: Andreas Färber afaer...@suse.de --- Makefile.target | 2 +- configure | 4 hmp-commands.hx | 2 -- stubs/dump.c| 8 4 files changed, 1 insertion(+), 15 deletions(-) diff

[Qemu-devel] [PATCH qom-cpu v4 10/18] memory_mapping: Drop qemu_get_memory_mapping() stub

2013-06-09 Thread Andreas Färber
mapping also don't implement dump support, we will not reach this code today and can worry about changing cpu_paging_enabled() default when the need arises. This allows us to drop CONFIG_HAVE_GET_MEMORY_SUPPORT. Signed-off-by: Andreas Färber afaer...@suse.de --- Makefile.target | 4

Re: [Qemu-devel] [PATCH qom-cpu v4 17/18] memory_mapping: Use hwaddr type for MemoryMapping virt_addr field

2013-06-09 Thread Andreas Färber
Am 09.06.2013 19:17, schrieb Peter Maydell: On 9 June 2013 17:10, Andreas Färber afaer...@suse.de wrote: The memory mapping API uses hwaddr, so use it in the struct, too. This avoids a header dependency on target_ulong type. --- a/include/sysemu/memory_mapping.h +++ b/include/sysemu

Re: [Qemu-devel] [PATCH] audio: Replace macro GCC_ATTR by GCC_FMT_ATTR and use inline functions

2013-06-09 Thread Andreas Färber
Am 09.06.2013 14:22, schrieb Stefan Weil: GCC_ATTR was only used in audio_int.h, so it is now unused and the definition can be removed from compiler.h. Signed-off-by: Stefan Weil s...@weilnetz.de Reviewed-by: Andreas Färber afaer...@suse.de Andreas -- SUSE LINUX Products GmbH, Maxfeldstr

Re: [Qemu-devel] [PATCH qom-cpu v4 18/18] memory_mapping: Build only once

2013-06-09 Thread Andreas Färber
Am 09.06.2013 19:29, schrieb Peter Maydell: On 9 June 2013 17:10, Andreas Färber afaer...@suse.de wrote: Move RAMBlock, RAMList and ram_list to exec/cpu-common.h since they do not depend on CPUArchState. We can then use it together with qom/cpu.h to replace cpu.h and exec/cpu-all.h includes

[Qemu-devel] [PATCH qom-cpu 00/59] QOM CPUState, part 10: CPU loops

2013-06-09 Thread Andreas Färber
...@eu.citrix.com (dummy CPU thread changes) Cc: Peter Maydell peter.mayd...@linaro.org (hwaddr) Andreas Färber (59): kvm: Change kvm_cpu_synchronize_state() argument to CPUState kvm: Change cpu_synchronize_state() argument to CPUState cpus: Simplify cpu_synchronize_all_post_reset() cpus

[Qemu-devel] [PATCH qom-cpu 04/59] cpus: Simplify cpu_synchronize_all_post_init()

2013-06-09 Thread Andreas Färber
Use new qemu_for_each_cpu(). Signed-off-by: Andreas Färber afaer...@suse.de --- cpus.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/cpus.c b/cpus.c index 1186ad3..85b35f6 100644 --- a/cpus.c +++ b/cpus.c @@ -425,13 +425,14 @@ void cpu_synchronize_all_post_reset

[Qemu-devel] [PATCH qom-cpu 05/59] cpus: Simplify pause_all_vcpus()

2013-06-09 Thread Andreas Färber
Use new qemu_for_each_cpu() to pause, stop and kick CPUs. Signed-off-by: Andreas Färber afaer...@suse.de --- cpus.c | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/cpus.c b/cpus.c index 85b35f6..ad5edfe 100644 --- a/cpus.c +++ b

[Qemu-devel] [PATCH qom-cpu 01/59] kvm: Change kvm_cpu_synchronize_state() argument to CPUState

2013-06-09 Thread Andreas Färber
It no longer relies on CPUArchState. Signed-off-by: Andreas Färber afaer...@suse.de --- hw/ppc/spapr_rtas.c | 2 +- include/sysemu/kvm.h | 4 ++-- kvm-all.c| 4 +--- kvm-stub.c | 2 +- target-i386/kvm.c| 10 +- 5 files changed, 10 insertions(+), 12

[Qemu-devel] [PATCH qom-cpu 03/59] cpus: Simplify cpu_synchronize_all_post_reset()

2013-06-09 Thread Andreas Färber
Use new qemu_for_each_cpu(). Signed-off-by: Andreas Färber afaer...@suse.de --- cpus.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/cpus.c b/cpus.c index 8ff66c3..1186ad3 100644 --- a/cpus.c +++ b/cpus.c @@ -415,13 +415,14 @@ void cpu_synchronize_all_states

[Qemu-devel] [PATCH qom-cpu 10/59] cpus: Simplify qemu_tcg_wait_io_event() and qemu_tcg_cpu_thread_fn()

2013-06-09 Thread Andreas Färber
Use new qemu_for_each_cpu(). Signed-off-by: Andreas Färber afaer...@suse.de --- cpus.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/cpus.c b/cpus.c index 9195bc3..a8572a9 100644 --- a/cpus.c +++ b/cpus.c @@ -703,10 +703,13 @@ static void

[Qemu-devel] [PATCH qom-cpu 07/59] cpus: Simplify set_numa_modes()

2013-06-09 Thread Andreas Färber
Use new qemu_for_each_cpu(). Signed-off-by: Andreas Färber afaer...@suse.de --- cpus.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/cpus.c b/cpus.c index 1babecf..24ee974 100644 --- a/cpus.c +++ b/cpus.c @@ -1188,22 +1188,22 @@ static void tcg_exec_all

[Qemu-devel] [PATCH qom-cpu 15/59] cpus: Change qemu_kvm_wait_io_event() argument to CPUState

2013-06-09 Thread Andreas Färber
It no longer uses CPUArchState. Signed-off-by: Andreas Färber afaer...@suse.de --- cpus.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/cpus.c b/cpus.c index fcef422..2545e15 100644 --- a/cpus.c +++ b/cpus.c @@ -722,10 +722,8 @@ static void qemu_tcg_wait_io_event(void

[Qemu-devel] [PATCH qom-cpu 13/59] cpu: Change cpu_exit() argument to CPUState

2013-06-09 Thread Andreas Färber
It no longer depends on CPUArchState, so move it to qom/cpu.c. Signed-off-by: Andreas Färber afaer...@suse.de --- cpus.c | 4 ++-- exec.c | 8 gdbstub.c | 2 +- hw/i386/pc.c| 2 +- hw/mips/mips_fulong2e.c | 2 +- hw/mips

[Qemu-devel] [PATCH qom-cpu 02/59] kvm: Change cpu_synchronize_state() argument to CPUState

2013-06-09 Thread Andreas Färber
Change Monitor::mon_cpu to CPUState as well. In cpu_sychronize_all_states() use qemu_for_each_cpu() now. In dump_init() use cpu_synchronize_all_states(). Signed-off-by: Andreas Färber afaer...@suse.de --- cpus.c | 13 +++-- gdbstub.c | 8 hw/i386

[Qemu-devel] [PATCH qom-cpu 12/59] gdbstub: Simplify find_cpu()

2013-06-09 Thread Andreas Färber
Use qemu_get_cpu() and CPUState::env_ptr. Signed-off-by: Andreas Färber afaer...@suse.de --- gdbstub.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/gdbstub.c b/gdbstub.c index fb6c6a5..92ecdcb 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -2068,17 +2068,13

[Qemu-devel] [PATCH qom-cpu 09/59] cpus: Simplify hw_error()

2013-06-09 Thread Andreas Färber
Use new qemu_for_each_cpu(). Signed-off-by: Andreas Färber afaer...@suse.de --- cpus.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/cpus.c b/cpus.c index 1975c5c..9195bc3 100644 --- a/cpus.c +++ b/cpus.c @@ -386,21 +386,22 @@ void configure_icount(const

[Qemu-devel] [PATCH qom-cpu 16/59] kvm: Change kvm_set_signal_mask() argument to CPUState

2013-06-09 Thread Andreas Färber
CPUArchState is no longer needed. Signed-off-by: Andreas Färber afaer...@suse.de --- cpus.c | 3 ++- include/sysemu/kvm.h | 2 +- kvm-all.c| 3 +-- kvm-stub.c | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/cpus.c b/cpus.c index 2545e15

[Qemu-devel] [PATCH qom-cpu 19/59] kvm: Change kvm_handle_internal_error() argument to CPUState

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de --- kvm-all.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/kvm-all.c b/kvm-all.c index 1cd4573..1675311 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -1520,10 +1520,8 @@ static void kvm_handle_io(uint16_t port, void *data

[Qemu-devel] [PATCH qom-cpu 06/59] cpus: Simplify resume_all_vcpus()

2013-06-09 Thread Andreas Färber
Use new qemu_for_each_cpu(). Signed-off-by: Andreas Färber afaer...@suse.de --- cpus.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/cpus.c b/cpus.c index ad5edfe..1babecf 100644 --- a/cpus.c +++ b/cpus.c @@ -1005,16 +1005,15 @@ void cpu_resume(CPUState *cpu

[Qemu-devel] [PATCH qom-cpu 17/59] cpus: Change qemu_kvm_init_cpu_signals() argument to CPUState

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de --- cpus.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/cpus.c b/cpus.c index aa8aa36..080f308 100644 --- a/cpus.c +++ b/cpus.c @@ -572,9 +572,8 @@ static void dummy_signal(int sig) { } -static void

[Qemu-devel] [PATCH qom-cpu 08/59] cpus: Simplify qmp_inject_nmi()

2013-06-09 Thread Andreas Färber
Use new qemu_for_each_cpu(). Signed-off-by: Andreas Färber afaer...@suse.de --- cpus.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/cpus.c b/cpus.c index 24ee974..1975c5c 100644 --- a/cpus.c +++ b/cpus.c @@ -1331,18 +1331,24 @@ exit: fclose(f

[Qemu-devel] [PATCH qom-cpu 20/59] kvm: Change kvm_cpu_exec() argument to CPUState

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de --- cpus.c | 2 +- include/sysemu/kvm.h | 2 +- kvm-all.c| 3 +-- kvm-stub.c | 4 ++-- 4 files changed, 5 insertions(+), 6 deletions(-) diff --git a/cpus.c b/cpus.c index 636d4d8..f07618f 100644 --- a/cpus.c +++ b

[Qemu-devel] [PATCH qom-cpu 22/59] cpus: Change cpu_handle_guest_debug() argument to CPUState

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de --- cpus.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/cpus.c b/cpus.c index dba69bc..f629a15 100644 --- a/cpus.c +++ b/cpus.c @@ -463,10 +463,8 @@ static bool cpu_can_run(CPUState *cpu) return true; } -static

[Qemu-devel] [PATCH qom-cpu 35/59] linux-user: Simplify start_exclusive()

2013-06-09 Thread Andreas Färber
Use new qemu_for_each_cpu(). Signed-off-by: Andreas Färber afaer...@suse.de --- linux-user/main.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/linux-user/main.c b/linux-user/main.c index 95e17cf..5ced658 100644 --- a/linux-user/main.c +++ b/linux-user

[Qemu-devel] [PATCH qom-cpu 21/59] gdbstub: Set gdb_set_stop_cpu() argument to CPUState

2013-06-09 Thread Andreas Färber
Use CPUState::env_ptr for now. Signed-off-by: Andreas Färber afaer...@suse.de --- cpus.c | 2 +- gdbstub.c | 4 +++- include/exec/gdbstub.h | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/cpus.c b/cpus.c index f07618f..dba69bc 100644

[Qemu-devel] [PATCH qom-cpu 23/59] cpus: Change qemu_kvm_start_vcpu() argument to CPUState

2013-06-09 Thread Andreas Färber
Pass it on to qemu_kvm_cpu_thread_fn(). Signed-off-by: Andreas Färber afaer...@suse.de --- cpus.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/cpus.c b/cpus.c index f629a15..18dba18 100644 --- a/cpus.c +++ b/cpus.c @@ -732,14 +732,13 @@ static void

[Qemu-devel] [PATCH qom-cpu 39/59] translate-all: Abstract tb_phys_invalidate() with qemu_for_each_cpu()

2013-06-09 Thread Andreas Färber
Signed-off-by: Andreas Färber afaer...@suse.de --- translate-all.c | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/translate-all.c b/translate-all.c index 78a6f4d..8e98a13 100644 --- a/translate-all.c +++ b/translate-all.c @@ -819,14 +819,31

[Qemu-devel] [PATCH qom-cpu 11/59] monitor: Simplify do_inject_mce()

2013-06-09 Thread Andreas Färber
Use qemu_get_cpu() to avoid open-coded CPU loop. Signed-off-by: Andreas Färber afaer...@suse.de --- monitor.c | 14 +- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/monitor.c b/monitor.c index 6e22d15..19c297d 100644 --- a/monitor.c +++ b/monitor.c @@ -2013,7 +2013,6

<    1   2   3   4   5   6   7   8   9   10   >