Alexander Graf ag...@suse.de writes:
On 22.07.2013, at 21:38, Anthony Liguori wrote:
Alexander Graf ag...@suse.de writes:
tl;dr, this is a PV bus for the e500 described as something more
generic. I don't buy it. I don't think there are many platforms or
devices out there where you can
as it
is a PCIEPort.
That said, for consistency, I think having everything be relatively to
*one* type for a Property list is pretty helpful.
Expecting someone to know the type hierarchy by heart such that this
doesn't look like a bug is too much IMHO.
Regards,
Anthony Liguori
What are the advantages
Peter Maydell peter.mayd...@linaro.org writes:
On 22 July 2013 20:52, Anthony Liguori anth...@codemonkey.ws wrote:
Alexander Graf ag...@suse.de writes:
On 22.07.2013, at 21:38, Anthony Liguori wrote:
This could be used just the same for ARM's mach-virt, so I'd rather
not make it e500
of the endianness flag
entirely but this is a good step.
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Regards,
Anthony Liguori
Alexey Kardashevskiy (1):
spapr_pci: remove indirection for I/O port access
Paolo Bonzini (27):
sh4: do not use isa_mmio
ppc_oldworld: do not use isa_mmio
,threads=2,sockets=2
By today's standards.
I think this applies equally well to other architecture. Model hardware
more closely.
Regards,
Anthony Liguori
For VMSD we decided to deviate for new migratable targets from legacy
CPUs in favor of consistency with devices, for instance.
Stripping
Peter Maydell peter.mayd...@linaro.org writes:
On 22 July 2013 16:25, Anthony Liguori anth...@codemonkey.ws wrote:
Andreas Färber afaer...@suse.de writes:
Am 22.07.2013 13:34, schrieb Peter Maydell:
Looking at all of the '-cpu help' output, alpha seems to be
the odd one out here: none
Peter Maydell peter.mayd...@linaro.org writes:
On 15 July 2013 16:15, Anthony Liguori aligu...@us.ibm.com wrote:
Hard freeze is two weeks away.
http://wiki.qemu.org/Planning/1.6
I've just noticed that this is still inconsistent. That
page says:
Soft feature freeze. Major features should
-function device.
The current way of creating each function will always be supported though.
Regards,
Anthony Liguori
Ian.
types of
functionality.
Regards,
Anthony Liguori
typedef int (*qdev_initfn)(DeviceState *dev);
typedef int (*qdev_event)(DeviceState *dev);
typedef void (*qdev_resetfn)(DeviceState *dev);
@@ -81,6 +87,7 @@ typedef struct DeviceClass {
/* public */
const char *fw_name
Paolo Bonzini pbonz...@redhat.com writes:
Il 18/07/2013 16:42, Marcel Apfelbaum ha scritto:
On Thu, 2013-07-18 at 09:28 -0500, Anthony Liguori wrote:
Marcel Apfelbaum marce...@redhat.com writes:
Categorize devices that appear as output to -device ? command
by logical functionality. Sort
Eduardo Otubo ot...@linux.vnet.ibm.com writes:
Hello all,
In this small patch series I basically:
Cover letter should be marked [PATCH 0/2]. Otherwise it defeats
filtering.
Would like to see a Reviewed-by from someone before applying this.
Regards,
Anthony Liguori
v2 update:
- set
Markus Armbruster arm...@redhat.com writes:
Ping?
This needs a rebase.
Regards,
Anthony Liguori
Markus Armbruster arm...@redhat.com writes:
This is on top of [PATCH v4 00/12] Boot order tests, so it's
protected by these tests.
The first five patches are admittedly related
needed by the pseries
machine.
Signed-off-by: David Gibson da...@gibson.dropbear.id.au
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
---
Changes:
2013/09/07:
* added a comment about HPT size and migration style choice
---
hw/ppc/spapr.c | 269
From: David Gibson da...@gibson.dropbear.id.au
This patch adds helpers to allow PAPR VIO devices to save state common
to all VIO devices during savevm.
Signed-off-by: David Gibson da...@gibson.dropbear.id.au
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
---
hw/ppc/spapr_vio.c | 20
From: Alexey Kardashevskiy a...@ozlabs.ru
The patch reimplements handling of indirect requests in order to
simplify upcoming live migration support.
- all pointers (except SCSIRequest*) were replaces with integer
indexes and offsets;
- DMA'ed srp_direct_buf kept untouched (ie. BE format);
-
From: David Gibson da...@gibson.dropbear.id.au
This patch adds the necessary VMStateDescription information to support
savevm/loadvm for the spapr_llan (PAPR logical lan) device.
Signed-off-by: David Gibson da...@gibson.dropbear.id.au
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
---
hw/net
Pulled. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
) Fix endianness problem with TCE table translation
a) Drop the VMSTATE_DIVIDE thing in the process
I've tested this with a TCG pseries guest on an x86_64 host.
Since v1, I've incorporated some fixes that Alexey posted
upon testing with KVM.
Regards,
Anthony Liguori
such that if we
change the window_size, we can use globals to keep migration
working.
Signed-off-by: David Gibson da...@gibson.dropbear.id.au
[dwg: pseries: savevm support for PAPR TCE tables]
Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru
[alexey: ppc kvm: fix to compile]
Signed-off-by: Anthony
Applied. Thanks.
Regards,
Anthony Liguori
From: David Gibson da...@gibson.dropbear.id.au
This patch adds the necessary support for saving the state of the PAPR VIO
virtual SCSI device. This also saves and restores active SCSI requests.
[aik: implemented vscsi_req save/restore]
Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru
Cc: David
From: Alexey Kardashevskiy a...@ozlabs.ru
The savevm code for the powerpc cpu emulation is currently based around
the old register_savevm() rather than register_vmstate() method. It's also
rather broken, missing some important state on some CPU models.
This patch completely rewrites the savevm
From: Alexey Kardashevskiy a...@ozlabs.ru
At present, the savevm / migration support for the pseries machine will not
work when KVM is enabled. That's because KVM manages the guest's hash page
table in the host kernel, so qemu has no visibility of it. This patch
fixes this by using new kernel
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
hw/intc/xics.c | 345 +
hw/ppc/spapr.c | 28
include/hw/ppc/spapr.h | 3 +-
include/hw/ppc/xics.h | 74 ++-
4 files changed, 330 insertions(+), 120 deletions(-)
diff
From: David Gibson da...@gibson.dropbear.id.au
This patch adds the necessary VMStateDescription information to support
savevm/loadvm for the spapr_tty (PAPR logical serial) device.
Signed-off-by: David Gibson da...@gibson.dropbear.id.au
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
---
hw
From: David Gibson da...@gibson.dropbear.id.au
This adds the necessary support for saving the state of the PAPR virtual
PCI host bridge (or host bridges).
Signed-off-by: David Gibson da...@gibson.dropbear.id.au
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
---
hw/ppc/spapr_pci.c
a day or so) as virtio maintainer,
or should I put it in via arm-devs?
I would be happy for it to go through arm-devs and for any future
changes to virtio-mmio to go through that tree.
Regards,
Anthony Liguori
thanks
-- PMM
Alexey Kardashevskiy a...@ozlabs.ru writes:
On 07/16/2013 01:11 AM, Anthony Liguori wrote:
Model TCE tables as a device that's hooked up as a child object to
the owner. Besides the code cleanup, we get a few nice benefits:
1) free actually works now (it was dead code before)
2) the TCE
remapping. I guess that's better than nothing so
please rebase. I'll try to fix it properly on top of your patch.
Regards,
Anthony Liguori
Jan
you try the minimal patch above? Or this one that also
does the consequent simplifications.
FYI, the reproducer is very simple:
qemu-system-x86_64 -usb
Regards,
Anthony Liguori
diff --git a/exec.c b/exec.c
index c99a883..0904283 100644
--- a/exec.c
+++ b/exec.c
@@ -1898,14 +1898,8
Paolo Bonzini pbonz...@redhat.com writes:
Il 17/07/2013 17:50, Anthony Liguori ha scritto:
Paolo Bonzini pbonz...@redhat.com writes:
Il 17/07/2013 11:50, Markus Armbruster ha scritto:
Richard Henderson r...@twiddle.net writes:
Honor the implementation maximum access size, and at least
);
+len = (window_size / SPAPR_TCE_PAGE_SIZE)*sizeof(uint64_t);
if ((munmap(table, len) 0) ||
(close(fd) 0)) {
fprintf(stderr, KVM: Unexpected error removing TCE table:
%s,
Thanks, I'm running on x86 so this code didn't get built for me.
Regards,
Anthony Liguori
Alexey Kardashevskiy a...@ozlabs.ru writes:
On 07/16/2013 01:11 AM, Anthony Liguori wrote:
This series is based on Alexey's series:
spapr: migration, pci, msi, power8
Which in turn was based on work by David Gibson.
I've removed the bits not related to migration and made
...@redhat.com
Thank you.
Any further guidelines on when to ask for acks from you guys?
Three days between a post and pull request is a bit short especially
with no feedback. That was my primary concern here.
Regards,
Anthony Liguori
The mode
I've been operating in is mostly if virtio-pci provides
Alexey Kardashevskiy a...@ozlabs.ru writes:
On 07/16/2013 10:48 PM, Alexey Kardashevskiy wrote:
On 07/16/2013 10:35 PM, Alexey Kardashevskiy wrote:
On 07/16/2013 10:33 PM, Anthony Liguori wrote:
Alexey Kardashevskiy a...@ozlabs.ru writes:
On 07/16/2013 01:11 AM, Anthony Liguori wrote
/show_bug.cgi?id=970047
Signed-off-by: Laszlo Ersek ler...@redhat.com
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Regards,
Anthony Liguori
---
monitor.c | 11 +--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/monitor.c b/monitor.c
index 2ba7876..de24b2c 100644
.
Just for my own benefit, I always assume G_IO_STATUS_EOF cannot happen
if bytes_written 0. I see what you mean by the comment but do you
have any reason to believe this happens in practice?
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Regards,
Anthony Liguori
Signed-off-by: Laszlo Ersek ler
Laszlo Ersek ler...@redhat.com writes:
On 07/16/13 20:57, Anthony Liguori wrote:
Laszlo Ersek ler...@redhat.com writes:
The g_io_channel_write_chars() documentation states,
bytes_written: The number of bytes written. This can be nonzero even if
the return value
, le_mode only really affects load/stores and instruction
decoding. Any shared data structures between the CPU and OS remain big
endian.
So TARGET_WORDS_BIGENDIAN is still accurate even when le_mode=1. It's
not the semantic equivalent of changing TARGET_WORDS.
Regards,
Anthony Liguori
Is it at all
.
Hm. Good point, thanks! It seems memory_region_init_io is not necessary any
more. Will make a patch for it.
You should try the latest qemu.git commit. There shouldn't be a problem
anymore.
Regards,
Anthony Liguori
--
Alexey
Paolo Bonzini pbonz...@redhat.com writes:
Il 08/07/2013 20:39, Anthony Liguori ha scritto:
Alexey Kardashevskiy a...@ozlabs.ru writes:
From: David Gibson da...@gibson.dropbear.id.au
This patch adds the necessary VMStateDescription information to save the
state of PAPR TCE tables
such that if we
change the window_size, we can use globals to keep migration
working.
Signed-off-by: David Gibson da...@gibson.dropbear.id.au
[dwg: pseries: savevm support for PAPR TCE tables]
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
hw/ppc/spapr.c | 3 -
hw/ppc
From: David Gibson da...@gibson.dropbear.id.au
This patch adds the necessary VMStateDescription information to support
savevm/loadvm for the spapr_tty (PAPR logical serial) device.
Signed-off-by: David Gibson da...@gibson.dropbear.id.au
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
---
hw
From: Alexey Kardashevskiy a...@ozlabs.ru
The patch reimplements handling of indirect requests in order to
simplify upcoming live migration support.
- all pointers (except SCSIRequest*) were replaces with integer
indexes and offsets;
- DMA'ed srp_direct_buf kept untouched (ie. BE format);
-
From: David Gibson da...@gibson.dropbear.id.au
This patch adds the necessary support for saving the state of the PAPR VIO
virtual SCSI device. This also saves and restores active SCSI requests.
[aik: implemented vscsi_req save/restore]
Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru
Cc: David
From: Alexey Kardashevskiy a...@ozlabs.ru
The savevm code for the powerpc cpu emulation is currently based around
the old register_savevm() rather than register_vmstate() method. It's also
rather broken, missing some important state on some CPU models.
This patch completely rewrites the savevm
From: David Gibson da...@gibson.dropbear.id.au
This patch adds helpers to allow PAPR VIO devices to save state common
to all VIO devices during savevm.
Signed-off-by: David Gibson da...@gibson.dropbear.id.au
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
---
hw/ppc/spapr_vio.c | 20
Hard freeze is two weeks away.
http://wiki.qemu.org/Planning/1.6
Regards,
Anthony Liguori
From: David Gibson da...@gibson.dropbear.id.au
This patch adds the necessary VMStateDescription information to support
savevm/loadvm for the spapr_llan (PAPR logical lan) device.
Signed-off-by: David Gibson da...@gibson.dropbear.id.au
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
---
hw/net
) Fix endianness problem with TCE table translation
a) Drop the VMSTATE_DIVIDE thing in the process
I've tested this with a TCG pseries guest on an x86_64 host.
Regards,
Anthony Liguori
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
hw/intc/xics.c | 345 +
hw/ppc/spapr.c | 28
include/hw/ppc/spapr.h | 3 +-
include/hw/ppc/xics.h | 74 ++-
4 files changed, 330 insertions(+), 120 deletions(-)
diff
From: David Gibson da...@gibson.dropbear.id.au
This adds the necessary support for saving the state of the PAPR virtual
PCI host bridge (or host bridges).
Signed-off-by: David Gibson da...@gibson.dropbear.id.au
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
---
hw/ppc/spapr_pci.c
needed by the pseries
machine.
Signed-off-by: David Gibson da...@gibson.dropbear.id.au
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
---
Changes:
2013/09/07:
* added a comment about HPT size and migration style choice
---
hw/ppc/spapr.c | 269
From: Alexey Kardashevskiy a...@ozlabs.ru
At present, the savevm / migration support for the pseries machine will not
work when KVM is enabled. That's because KVM manages the guest's hash page
table in the host kernel, so qemu has no visibility of it. This patch
fixes this by using new kernel
would think that given
the work that's been done already, it would be counterproductive to
enable x-data-plane for another backend.
Paolo/Stefan, what do you guys think?
Regards,
Anthony Liguori
Dominik Dingel (1):
virtio-ccw
Pulled, thanks.
Regards,
Anthony Liguori
From MAILER-DAEMON Mon Jul 15 20:39:18 2013
From: Anthony Liguori aligu...@us.ibm.com
To: Anthony Liguori aligu...@us.ibm.com
Cc: Anthony Liguori aligu...@us.ibm.com, qemu-devel@nongnu.org
Subject: Re: [APPLIED] Merge remote-tracking branch 'cohuck
Peter Maydell peter.mayd...@linaro.org writes:
On 15 July 2013 21:39, Anthony Liguori aligu...@us.ibm.com wrote:
Pulled, thanks.
Regards,
Anthony Liguori
[etc]
New notification style or script hiccup? :-)
Blek, sorry for the noise. New script hiccup.
Regards,
Anthony Liguori
Alexey Kardashevskiy a...@ozlabs.ru writes:
On 07/16/2013 01:02 AM, Anthony Liguori wrote:
Alexey Kardashevskiy a...@ozlabs.ru writes:
On 07/13/2013 06:03 PM, David Gibson wrote:
On Fri, Jul 12, 2013 at 05:37:19PM +1000, Alexey Kardashevskiy wrote:
sPAPR PHB emulates IO ports on PCI via
On Mon, Jul 15, 2013 at 7:39 PM, Alexey Kardashevskiy a...@ozlabs.ru wrote:
On 07/16/2013 10:28 AM, Anthony Liguori wrote:
Alexey Kardashevskiy a...@ozlabs.ru writes:
The right solution is to drop the additional IO region on sPAPR and
remove the ISA devices marking themselves as little endian
Paolo Bonzini pbonz...@redhat.com writes:
Il 13/07/2013 17:22, Anthony Liguori ha scritto:
1) MMIO request goes to sPAPR PIO area, the vCPU was in BE mode but by
the time the handler is called, the value is in host byte order.
2) sPAPR (incorrectly) byte swaps by marking the region
On Sun, Jul 14, 2013 at 9:58 AM, Peter Maydell peter.mayd...@linaro.org wrote:
On 14 July 2013 14:05, Anthony Liguori anth...@codemonkey.ws wrote:
Also, what devices exactly would have a non-native byte order?!? I'm
confused...
MMIO/PIO requests don't have a byte order. It's literally 64
the regression but that's just because two wrongs make a right
in this situation.
We should remove *all* of the LE markings from ISA devices, remove the
portio mark, and the sPAPR mark. That's the right fix.
Regards,
Anthony Liguori
Paolo
the CPU stores bytes in
memory is orthogonal to what is happening on the bus.
Regards,
Anthony Liguori
Alex
wrong.
Regards,
Anthony Liguori
Cheers,
Ben.
Pulled, thanks.
Regards,
Anthony Liguori
endianness.
I/O doesn't propagate so there's no way to say something like this.
That's the fundamental problem IMHO.
Regards,
Anthony Liguori
Regards,
Hervé
[1] ftp://ftp.software.ibm.com/rs6000/technology/spec/endian.ps)
.
In portio_write above, you clearly assume that data is in LE format.
This fixes PPC PReP emulation, which would otherwise be broken with this
patchset.
Did you actually test that as this is how the code behaved previously?
Regards,
Anthony Liguori
Hervé
in the first
place...
Cc: Hervé Poussineau hpous...@reactos.org
Cc: Alex Graf ag...@suse.de
Cc: Benjamin Herrenschmidt b...@kernel.crashing.org
Signed-off-by: Anthony Liguori aligu...@us.ibm.com
---
ioport.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/ioport.c b/ioport.c
index 79b7f1a
Benjamin Herrenschmidt b...@kernel.crashing.org writes:
On Tue, 2013-07-09 at 08:58 -0500, Anthony Liguori wrote:
There's nothing gross about making the things that are devices
devices.
But there is no such thing as the XICS ...
The XICS is just the combination of ICP's and ICS... so XICS
Applied. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Pulled. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
Applied. Thanks.
Regards,
Anthony Liguori
. This
should work just fine with the GTK UI. I have no idea about Cocoa if
that's what you're using.
ASCII has nothing to do with keyboards. It's a character encoding.
Regards,
Anthony Liguori
codes.
Regards,
Anthony Liguori
Alex
Alexey Kardashevskiy a...@ozlabs.ru writes:
On 07/09/2013 04:29 AM, Anthony Liguori wrote:
Alexey Kardashevskiy a...@ozlabs.ru writes:
From: David Gibson da...@gibson.dropbear.id.au
The savevm code for the powerpc cpu emulation is currently based around
the old register_savevm() rather
, the migration will often fail
until the migration: do not sent zero pages in bulk stage patch is reverted
or fixed somehow.
Can you publish this in a branch please somewhere that I can pull from?
Regards,
Anthony Liguori
Alexey Kardashevskiy (4):
pseries: move interrupt controllers to hw
device, that would just be gross, and each VCPU has an
associated ICP.
There's nothing gross about making the things that are devices devices.
Regards,
Anthony Liguori
Cheers,
Ben.
Alexey Kardashevskiy a...@ozlabs.ru writes:
On 07/09/2013 04:01 AM, Anthony Liguori wrote:
Alexey Kardashevskiy a...@ozlabs.ru writes:
This series spent quite a lot of time waiting when David's PCI series
reaches the upstream but it does not seem to happen soon so I rebased
those on top
David Gibson da...@gibson.dropbear.id.au writes:
On Mon, Jul 08, 2013 at 01:39:26PM -0500, Anthony Liguori wrote:
Alexey Kardashevskiy a...@ozlabs.ru writes:
From: David Gibson da...@gibson.dropbear.id.au
This patch adds the necessary VMStateDescription information to save the
state
David Gibson da...@gibson.dropbear.id.au writes:
On Mon, Jul 08, 2013 at 01:39:26PM -0500, Anthony Liguori wrote:
Alexey Kardashevskiy a...@ozlabs.ru writes:
From: David Gibson da...@gibson.dropbear.id.au
This patch adds the necessary VMStateDescription information to save the
state
David Gibson da...@gibson.dropbear.id.au writes:
On Mon, Jul 08, 2013 at 01:27:05PM -0500, Anthony Liguori wrote:
Alexey Kardashevskiy a...@ozlabs.ru writes:
From: David Gibson da...@gibson.dropbear.id.au
The vmstate infrastructure includes a VMS_MULTIPY flag, and associated
)
GTester: last random seed: R02S25031265f05e4d41efcf758c9ef6043b
Regards,
Anthony Liguori
Cc: Todd T. Fries t...@fries.net
Signed-off-by: Michael Tokarev m...@tls.msk.ru
---
hw/lm32/milkymist-hw.h |2 +-
hw/nvram/fw_cfg.c |2 +-
hw/sparc/sun4m.c|2 +-
include
Michael Tokarev m...@tls.msk.ru writes:
09.07.2013 22:37, Anthony Liguori wrote:
Michael Tokarev m...@tls.msk.ru writes:
It looks like initially there was -nographic option to turn
off display, now there's another option of the same sort,
-display none. But code in other places of qemu
Peter Maydell peter.mayd...@linaro.org writes:
On 9 July 2013 21:45, Anthony Liguori aligu...@us.ibm.com wrote:
Michael Tokarev m...@tls.msk.ru writes:
09.07.2013 22:37, Anthony Liguori wrote:
ERROR:/home/aliguori/git/qemu/tests/fw_cfg-test.c:63:test_fw_cfg_nographic:
assertion failed
Marcelo Tosatti mtosa...@redhat.com writes:
On Sat, Mar 09, 2013 at 06:44:36AM +0100, Paolo Bonzini wrote:
Il 08/03/2013 18:53, Anthony Liguori ha scritto:
Anthony mentioned that this
http://article.gmane.org/gmane.comp.emulators.qemu/160699
Is the proper way to do
Peter Maydell peter.mayd...@linaro.org writes:
On 9 July 2013 22:24, Anthony Liguori aligu...@us.ibm.com wrote:
Peter Maydell peter.mayd...@linaro.org writes:
Why the heck are we telling the guest that the user
specified -nographic anyhow? It's a dumb guest ABI...
I believe OpenBIOS uses
301 - 400 of 9887 matches
Mail list logo
